i can PR it in if that's a thing you care about

LLyris the Kitori you copy what jackcs does and ittl probably work

P

Perksey•10/7/23, 2:26 AM

you didn’t commit anything but a generator.json and we don’t have a dotnet tool afaik

MMaxine i can PR it in if that's a thing you care about

P

Perksey•10/7/23, 2:27 AM

Given it’s Win32 I’d say that’d be fine

L

Lyris the Kitori•10/7/23, 2:27 AM

oh i just build it from source

M

MaxineOP•10/7/23, 2:27 AM

same

M

MaxineOP•10/7/23, 2:27 AM

apparently changing one msbuild flag is a breaking change for you guys

P

Perksey•10/7/23, 2:27 AM

which one

M

MaxineOP•10/7/23, 2:28 AM

the one that makes buildtools a dotnet tool

P

Perksey•10/7/23, 2:28 AM

just make a new package

M

MaxineOP•10/7/23, 2:28 AM

yeah i might do that

L

Lyris the Kitori•10/7/23, 2:28 AM

i just never bothered making it into a proper tool

L

Lyris the Kitori•10/7/23, 2:28 AM

since i had a local build anyway

L

Lyris the Kitori•10/7/23, 2:29 AM

it's on my list of "things to look into" at some point if no one else does

LLyris the Kitori how do you think we do d3d11

M

MaxineOP•10/7/23, 2:41 AM

something like https://github.com/microsoft/win32metadata specifically

GitHub

GitHub - microsoft/win32metadata: Tooling to generate metadata for ...

Tooling to generate metadata for Win32 APIs in the Windows SDK. - GitHub - microsoft/win32metadata: Tooling to generate metadata for Win32 APIs in the Windows SDK.

M

MaxineOP•10/7/23, 2:41 AM

that was my initial thought

L

Lyris the Kitori•10/7/23, 10:00 PM

is casting from nullable enum to nullable int a safe cast?

L

Lyris the Kitori•10/7/23, 10:00 PM

that just feels wrong

L

Lyris the Kitori•10/7/23, 10:01 PM

L

Lyris the Kitori•10/7/23, 10:01 PM

this just seems bad

P

Perksey•10/7/23, 10:03 PM

pretty sure it's safe

P

Perksey•10/7/23, 10:03 PM

nullable is pretty much magic, has special cases pretty much everywhere in both roslyn and the runtime

L

Lyris the Kitori•10/7/23, 10:04 PM

yeah, it just feels gross to do

M

MaxineOP•10/7/23, 10:04 PM

you're casting Nullable<int> to Nullable<TokenGame>

M

MaxineOP•10/7/23, 10:04 PM

which i think gets handled by an overload

P

Perksey•10/7/23, 10:04 PM

desugared

public enum Hello
{
    Hello
}

public class C
{
    public Nullable<int> M(Nullable<Hello> hello)
    {
        Nullable<Hello> hello2 = hello;
        if (!hello2.HasValue)
        {
            return null;
        }
        return (int)hello2.GetValueOrDefault();
    }
}

public enum Hello
{
    Hello
}

public class C
{
    public Nullable<int> M(Nullable<Hello> hello)
    {
        Nullable<Hello> hello2 = hello;
        if (!hello2.HasValue)
        {
            return null;
        }
        return (int)hello2.GetValueOrDefault();
    }
}

public enum Hello
{
    Hello
}

public class C
{
    public Nullable<int> M(Nullable<Hello> hello)
    {
        Nullable<Hello> hello2 = hello;
        if (!hello2.HasValue)
        {
            return null;
        }
        return (int)hello2.GetValueOrDefault();
    }
}

public enum Hello
{
    Hello
}

public class C
{
    public Nullable<int> M(Nullable<Hello> hello)
    {
        Nullable<Hello> hello2 = hello;
        if (!hello2.HasValue)
        {
            return null;
        }
        return (int)hello2.GetValueOrDefault();
    }
}

M

MaxineOP•10/7/23, 10:05 PM

does the compiler do that?

P

Perksey•10/7/23, 10:05 PM

https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA+ABATARgLABQGAzAAQwB2ArgLakASMANkxKQN6GncPOuEBfQiVLZSAYQ5ceIgJYUALgH5SAWQAUjFhBUALPhACUUgjzOiA7KXXzlh/doDc07kIICgA=

SharpLab

C#/VB/F# compiler playground.

M

MaxineOP•10/7/23, 10:05 PM

the ways roslyn devs work around having to make c# generics actually useful

L

Lyris the Kitori•10/7/23, 10:05 PM

damn C# is fucking cursed

M

MaxineOP•10/7/23, 10:05 PM

we can't have higher kinded generics, that'd be too much FUN

L

Lyris the Kitori•10/7/23, 10:06 PM

honestly

valueType?

valueType?

valueType?

valueType? being shorthand for

Nullable<valueType>

Nullable<valueType>

Nullable<valueType>

Nullable<valueType> was a mistake imo

M

MaxineOP•10/7/23, 10:06 PM

eh

M

MaxineOP•10/7/23, 10:06 PM

what's your better idea

L

Lyris the Kitori•10/7/23, 10:06 PM

make people type

Nullable<T>

Nullable<T>

Nullable<T>

Nullable<T>

M

MaxineOP•10/7/23, 10:06 PM

i would never use c# again

T

TechPizza•10/7/23, 10:06 PM

Option<T>

L

Lyris the Kitori•10/7/23, 10:07 PM

real

P

Perksey•10/7/23, 10:07 PM

[assembly: CompilationRelaxations(8)]

[assembly: CompilationRelaxations(8)]

[assembly: CompilationRelaxations(8)]

[assembly: CompilationRelaxations(8)]

mood

M

MaxineOP•10/7/23, 10:07 PM

this is the same logic people use against

var

var

var

var

A

Aqua•10/7/23, 10:07 PM

there is no logic to using

var

var

var

var

M

MaxineOP•10/7/23, 10:07 PM

you can't tell what it is unless you look at it with your eyes!

L

Lyris the Kitori•10/7/23, 10:07 PM

im currently committing code warcrimes because of a lack of language level discriminated unions in C#

M

MaxineOP•10/7/23, 10:07 PM

oh the humanity

A

Aqua•10/7/23, 10:07 PM

var variable = new()

var variable = new()

var variable = new()

var variable = new()
perfect

LLyris the Kitori im currently committing code warcrimes because of a lack of language level discr...

M

MaxineOP•10/7/23, 10:08 PM

Remora.Discord uses a very silly OneOf type

P

Perksey•10/7/23, 10:08 PM

you know

P

Perksey•10/7/23, 10:08 PM

it's scary

AAqua `var variable = new()` perfect

M

MaxineOP•10/7/23, 10:08 PM

it's almost like that isn't allowed

A

Aqua•10/7/23, 10:08 PM

it should be

A

Aqua•10/7/23, 10:08 PM

the compiler just guesses what you want

L

Lyris the Kitori•10/7/23, 10:08 PM

constructs a new

object

object

object

object :^)

i can PR it in if that's a thing you care about

Similar Threads