this is a bad suggestion, we can't have silk contributors looking at this due to the license. they'd

this is a bad suggestion, we can't have silk contributors looking at this due to the license. they'd become radioactive and we won't be able to take any of their contributions for legal reasons.

Aqua•10/17/23, 5:37 PM

it only works for some integers

PPerksey this is a bad suggestion, we can't have silk contributors looking at this due to...

Aqua•10/17/23, 5:38 PM

while this code is technically gpl license its so generic (haha im unfunny) that i don't care if it gets copied verbatim

Aqua•10/17/23, 5:38 PM

given that i just copied stuff from other people anyway

khitiara•10/17/23, 5:38 PM

and choosing a floating type to coerce to for sqrt-ing ints is always a choice being made

Aqua•10/17/23, 5:38 PM

(system.numerics mainly)

PerkseyOP•10/17/23, 5:38 PM

that's irrelevant, we have to respect the license. DNF can't accept that liability.

Kai•10/17/23, 5:38 PM

sqrt(2) won't be precise on floating point either

Kai•10/17/23, 5:39 PM

just like sqrt(2) won't be precise* on integers. Sure one is more precise, but either one will be inaccurate

Kai•10/17/23, 5:39 PM

^ this has essentially been the stance on 2.X. I still stand by that a lot, as I think without this VectorN<int> is just utterly useless

PerkseyOP•10/17/23, 5:39 PM

see that's the thing, Scalar.Sqrt<byte>(64)Scalar.Sqrt<byte>(64) would do the correct thing

PerkseyOP•10/17/23, 5:39 PM

(i think)

Kai•10/17/23, 5:40 PM

yes, it will. Otherwise that's a big bug but ye

khitiara•10/17/23, 5:40 PM

either way the issue is implementation here; cant use generic maths with supporting that

PerkseyOP•10/17/23, 5:41 PM

i think go with what generic maths is using, the BCL team (tanner) have made these decisions for a reason

khitiara•10/17/23, 5:41 PM

because eg IRootFunctions is only implemented by floats for this case

PerkseyOP•10/17/23, 5:41 PM

as much as you could do more whacky things with Maths 2.X, doesn't mean that you should in every use case (but mostly the respecting BCL team's decision, that's the most pertinent reason)

Kai•10/17/23, 5:41 PM

return (T) (object) (sbyte) (float) Math.Sqrt((float) (sbyte) (object) x);

return (T) (object) (sbyte) (float) Math.Sqrt((float) (sbyte) (object) x);

its not optimized - but should work fine

PPerksey i think go with what generic maths is using, the BCL team (tanner) have made the...

Aqua•10/17/23, 5:42 PM

i almost made mine support all these functions by all types by converting to double under the hood and then doing the calculations, before casting back to int etc
but i thought
there's a reason why it is like this
so best to do it how its been designed

Kai•10/17/23, 5:42 PM

It will even do this beauty

return (T)(object)(sbyte)(float)Sse.SqrtScalar(Vector128.CreateScalarUnsafe((float)(sbyte)(object)x)).ToScalar();

return (T)(object)(sbyte)(float)Sse.SqrtScalar(Vector128.CreateScalarUnsafe((float)(sbyte)(object)x)).ToScalar();

PerkseyOP•10/17/23, 5:42 PM

yeah i've just seen this as well.

PerkseyOP•10/17/23, 5:42 PM

not every function is implemented to automatically upcast though, iirc Length is weird

Kai•10/17/23, 5:42 PM

(does this code predate Math.Sqrt having an intrinsic?)

khitiara•10/17/23, 5:43 PM

id believe that it predats math(f).sqrt having that yeah

Kai•10/17/23, 5:43 PM

https://i.kaij.tech/file/2023/10/1697564583_grim.png

KKai (does this code predate Math.Sqrt having an intrinsic?)

PerkseyOP•10/17/23, 5:43 PM

(i believe so, although there is the

MATHF

MATHF

preprocessor define that is used in some places)

Kai•10/17/23, 5:43 PM

Right this actually predates MathF in some cases

PerkseyOP•10/17/23, 5:43 PM

i'm so happy to be using .NET 8

Kai•10/17/23, 5:43 PM

god it's been a hot second

PerkseyOP•10/17/23, 5:43 PM

IKR

PerkseyOP•10/17/23, 5:43 PM

come work on SilkX

PerkseyOP•10/17/23, 5:43 PM

join the dark side

khitiara•10/17/23, 5:43 PM

lol

khitiara•10/17/23, 5:44 PM

dotnet 8 is real nice here yeah

Kai•10/17/23, 5:44 PM

I just had my second day of uni

PerkseyOP•10/17/23, 5:44 PM

oh nice how's it going

khitiara•10/17/23, 5:44 PM

gods i wish there was easier generic specialization in dotnet

khitiara•10/17/23, 5:44 PM

oh nice!

Kai•10/17/23, 5:44 PM

I don't know tbh

Kai•10/17/23, 5:44 PM

seems like I will have a horrendous amount of math shoved down my throat

PerkseyOP•10/17/23, 5:44 PM

that's just engineering

Kai•10/17/23, 5:44 PM

idk

Kai•10/17/23, 5:45 PM

"many bachelors that actually make it will end up doing a double w/ maths"

Kai•10/17/23, 5:45 PM

idk if that shit is normal xD

Curin•10/17/23, 5:45 PM

It wasn't uncommon at my college either or at least a minor in math

Aqua•10/17/23, 5:45 PM

what is the deal with .net 8 again?

Aqua•10/17/23, 5:45 PM

it's faster or something?

Kai•10/17/23, 5:46 PM

.NET is always faster xD

Aqua•10/17/23, 5:46 PM

idk i've kinda stopped using C# altogether now so i'm not keeping up

PerkseyOP•10/17/23, 5:46 PM

faster, and whatever is in .NET 7 is now LTS

Aqua•10/17/23, 5:46 PM

ah ok

this is a bad suggestion, we can't have silk contributors looking at this due to the license. they'd

Similar Threads

Similar Threads

Similar Threads