> then cast back to byte i did not initially gather that from what you said here
then cast back to bytei did not initially gather that from what you said here
Areturning a float would make more sense
Mthat was me being dumb
Mbut yeah you're right this wouldn't work in generic maths
Aalthough i still personally think that there is no point having trig functions on integer types
but yep returning a float/double value is literally the only way it would be remotely useful lol
but yep returning a float/double value is literally the only way it would be remotely useful lol
Mbecause you probably want sin on floats to return floats and sin on doubles to return doubles and you probably want those to work on rad not deg
Mwait
Ayep
Myou could implement the methods as extension methods
MSin(this Vector3<T>) where T : IFloatingPoint<T>M(ignore the method name i just mean the general idea)
Awhy not just
static T Vector3.Sin<T>() where T : INumber<T>, IFloatingPoint<T>?Aor is this not the point of what you are doing
Mthat does not look like valid C#
Ait isn't
Ai more meant
Ainstead of operating directly on the vector
Myeah that works
Meither or
Mthere are uses for both
Atrue, you could always do both
Mlike dot product you want a static method
Abut i'd recommend having the static method at a minimum, its what people using system.numerics, monogame math, opentk math, etc would expect there to be
Myea
Aanother question
Awould the extension method mutate the original vector or would it return a new one?
Mnever mutate
Malways return
Aalright cool
Ayeah
Ai am using JOML for reasons
Aand due to java being java
Ait mutates the original vector
Awhich is just
Adisgusting
Myeeeeeeah
Mit's to avoid allocations
Ayup
Ano stack innit
Mit's not just weird, it makes it harder to use
Ayep
Mi should mock this generic vector up
Mthis is easy enough to do
Aim happy to help with math if required
Asince i've implemented my own generic math stuff plenty of times now
M>unity doesn't support generic math
sadge
sadge
Ai get that you can't use it for license reasons, even though id be more than happy to license it directly to you, i don't personally consider it as part of my engine's license even though it technically is
Myou can license your own code however you want
Ayep, although legally speaking its under LGPL-3.0 license cause thats what the repo's license is
Aand it technically means that if i wanted to i could at some point go in and issue a strike on you guys for using it
which i wouldn't do
but i get why the risk does not want to be taken
which i wouldn't do
but i get why the risk does not want to be taken
Mnononononono