Silk.NET•3y ago

https://gist.github.com/uwx/ee881028f5068f5c0ff29485051a1209

Gist

Silk v3 Generic Math Proposal.md

GitHub Gist: instantly share code, notes, and snippets.

MaxineOP•10/21/23, 4:01 AM

@Perksey if you're still awake

Perksey•10/21/23, 4:39 AM

literally any @Maintainer that is online right now: https://github.com/dotnet/Silk.NET/pull/1680

GitHub

This is the October 2023 Update (v2.18.0) by Perksey · Pull Request...

The Use functions rely on reflection doing the right things, which isn't necessarily correct on AOT.

dfkeenan🍍🍕•10/21/23, 4:40 AM

MMaxine https://gist.github.com/uwx/ee881028f5068f5c0ff29485051a1209

Perksey•10/21/23, 4:40 AM

will look tomorrow, annoy me in about 12 hours

Perksey•10/21/23, 4:44 AM

okay i'm going to have a shower now

MaxineOP•10/21/23, 4:44 AM

cya!

Perksey•10/21/23, 4:44 AM

when i come back that PR better be green or someone else is doing the release haha

Perksey•10/21/23, 4:45 AM

(i've just checked and you need Nitro to post the release notes in #announcements, and I am NOT writing a blog again)

MaxineOP•10/21/23, 4:45 AM

if anyone has an idea for a better implementation for this, let me know

    public static bool TryConvertFromChecked<TOther>(TOther value, out Vector3<T> result) where TOther : INumberBase<TOther>
    {
        if (value is Vector3<T> v)
        {
            result = v;
            return true;
        }
        
        // TODO: An interface could be added here to make things work. But if it causes boxing even with JIT optimizations, it's probably not worth it.

        result = default;
        return false;
    }

    public static bool TryConvertFromChecked<TOther>(TOther value, out Vector3<T> result) where TOther : INumberBase<TOther>
    {
        if (value is Vector3<T> v)
        {
            result = v;
            return true;
        }
        
        // TODO: An interface could be added here to make things work. But if it causes boxing even with JIT optimizations, it's probably not worth it.

        result = default;
        return false;
    }

i wonder if the JIT can devirtualize something like this?

MaxineOP•10/21/23, 4:47 AM

perks, GO SHOWER

khitiara•10/21/23, 4:47 AM

id also include numerics vector3

MaxineOP•10/21/23, 4:47 AM

PLEASE

khitiara•10/21/23, 4:47 AM

oh wait numerics vector3 doesnt implement inumberbase does it

MaxineOP•10/21/23, 4:47 AM

exactly

Perksey•10/21/23, 4:47 AM

oh i thought you were going to make a comment about how you can't make it green to which i was going to point you to the most approved PR in GitHub history https://github.com/dotnet/sdk/pull/22262

MaxineOP•10/21/23, 4:47 AM

i'm not a maintainer

MMaxine if anyone has an idea for a better implementation for this, let me know ```cs ...

Perksey•10/21/23, 4:47 AM

but yes that'll be implied

MMaxine i'm not a maintainer

Perksey•10/21/23, 4:48 AM

have you seen that PR

MaxineOP•10/21/23, 4:48 AM

holy fuck

MaxineOP•10/21/23, 4:48 AM

oh i remember that

MMaxine PLEASE

Perksey•10/21/23, 4:48 AM

THERE THE WATER IS RUNNING

Perksey•10/21/23, 4:48 AM

ONCE IT IS HOT

Perksey•10/21/23, 4:48 AM

I WILL SHOWER

MaxineOP•10/21/23, 4:49 AM

right i forgot you guys have the gas showers

MaxineOP•10/21/23, 4:49 AM

i really should stop saying it like that

MaxineOP•10/21/23, 4:49 AM

gas heated?

Perksey•10/21/23, 4:49 AM

OH FUCK

Perksey•10/21/23, 4:49 AM

YOU DID NOT NEED TO TAKE IT THERE

Perksey•10/21/23, 4:49 AM

MaxineOP•10/21/23, 4:49 AM

what

Perksey•10/21/23, 4:49 AM

MaxineOP•10/21/23, 4:49 AM

THAT WASN'T A JOKE

Perksey•10/21/23, 4:49 AM

it appears you did not take it there

MaxineOP•10/21/23, 4:49 AM

we have electric showers in brazil

MaxineOP•10/21/23, 4:49 AM

you have gas heating

MaxineOP•10/21/23, 4:49 AM

with the like

MaxineOP•10/21/23, 4:50 AM

mains gas pipes

Perksey•10/21/23, 4:50 AM

mmmmmhmmm you knew exactly what you thought with that phrasing

MaxineOP•10/21/23, 4:50 AM

it's like the second time i've said this and been misunderstood

Perksey•10/21/23, 4:50 AM

but alright

Perksey•10/21/23, 4:50 AM

i'll continue the convo

MaxineOP•10/21/23, 4:50 AM

i swear it wasn't on purpose!!

Perksey•10/21/23, 4:50 AM

yes we have gas heated showers

Perksey•10/21/23, 4:50 AM

although back at our latest house in the UK we did have electric showers

MaxineOP•10/21/23, 4:50 AM

really?

Perksey•10/21/23, 4:50 AM

so the new houses are modernising

MaxineOP•10/21/23, 4:51 AM

are they like ours? or do they work differently

Perksey•10/21/23, 4:51 AM

they use electricity

Perksey•10/21/23, 4:51 AM

to make the water hot

public static bool TryConvertFromChecked<TOther>(TOther value, out Vector3<T> result) where TOther : INumberBase<TOther> { if (value is Vector3<T> v) { result = v; return true; } // TODO: An interface could be added here to make things work. But if it causes boxing even with JIT optimizations, it's probably not worth it. result = default; return false; }

https://gist.github.com/uwx/ee881028f5068f5c0ff29485051a1209

Similar Threads