fun fact: i have no idea what canonical type vs named type means: but it gets shaderc into a better

fun fact: i have no idea what canonical type vs named type means: but it gets shaderc into a better state changing what i did so therefor im on the right path

LLyris the Kitori fun fact: i have no idea what canonical type vs named type means: but it gets sh...

tannergooding•11/4/23, 12:02 AM

Canonical type is the most underlying type after all typedefs, attributes, elaborations, and other C/C++ modifiers have been stripped away

tannergooding•11/4/23, 12:04 AM

This is where modern ClangSharp often has a self recursive function that steps through each step of the typedef and manually accounts for certain kinds of abstractions(like typedefs) or makes observations based on others (attibutations, etc) and rarely goes straight for canonical

Lyris the KitoriOP•11/4/23, 12:04 AM

oh yeah thats what we used to do as well however thats Not Working

Lyris the KitoriOP•11/4/23, 12:04 AM

so im doing a mix of proper recursion and also just straight up canonicaltype

tannergooding•11/4/23, 12:05 AM

As otherwise you can miss important info, like something being intptr_t or size_t and therefore needing to be nint

Or you also miss stuff like function pointer calling conventions

LLyris the Kitori so im doing a mix of proper recursion and also just straight up canonicaltype

tannergooding•11/4/23, 12:05 AM

Why isn't that working? Are you missing a particular Type kind that needs handling as part of the recursion? Some were introduced in newer Clang due to how the language works

Lyris the KitoriOP•11/4/23, 12:07 AM

uhhhh i dont know honestly i just poked at it until i did what i wanted and when it didnt i just changed something random until it looked more correct
just something in the chain isnt finding the underlying type and so the name of the typedef instead of the underlying type is being used when generating for some reason now

tannergooding•11/4/23, 12:07 AM

this was when moving to Clang 16 from 15?

Lyris the KitoriOP•11/4/23, 12:07 AM

eg given
typedef struct shaderc_compiler* shaderc_compiler_t;typedef struct shaderc_compiler* shaderc_compiler_t; BuildTools thinks any usages of shaderc_compiler_tshaderc_compiler_t are shaderc_compiler_tshaderc_compiler_t instead of shaderc_compiler*shaderc_compiler* now

Lyris the KitoriOP•11/4/23, 12:08 AM

when moving from 15 to 16 yes

tannergooding•11/4/23, 12:09 AM

right, this was also when they changed from (anonymous enum at(anonymous enum at to (unnamed enum at(unnamed enum at, or vice versa

tannergooding•11/4/23, 12:09 AM

I'd recommend looking at all athe stuff I had to do in https://github.com/dotnet/ClangSharp/pull/456/files#diff-bac9b18ad93dc3cb267b2bd241193960d517fac455eb8b12e8e8e7aa8020108c

tannergooding•11/4/23, 12:11 AM

There was also: https://github.com/dotnet/ClangSharp/pull/438/files, where I improved type checking in general

tannergooding•11/4/23, 12:11 AM

and https://github.com/dotnet/ClangSharp/pull/437, which had some small fixes to type lookup

tannergooding•11/4/23, 12:11 AM

all were iterative towards making v16 happy, which wasn't fun

tannergooding•11/4/23, 12:12 AM

https://github.com/dotnet/ClangSharp/releases/tag/v16.0.0 has the full diff, most are irrelevant towards type lookup
but might be something else worth looking at in that list too

Curin•11/4/23, 7:36 PM

@SilkX Team Aside from the math, what do we have left to do for SilkX to be ready for review?

khitiara•11/4/23, 7:36 PM

generator

Maxine•11/4/23, 7:37 PM

the rest of the fucking owl

CCurin @SilkX Team Aside from the math, what do we have left to do for SilkX to be read...

Perksey•11/4/23, 7:40 PM

tbh, not a lot, we can go with just what we have now but I’d worry that it’d essentially be the same as the last coffee and code where we discussed it

Perksey•11/4/23, 7:40 PM

the proposal needs updating based on what we’ve decided

Perksey•11/4/23, 7:40 PM

I feel like the most ideal scenario would be getting a GL triangle working

Curin•11/4/23, 7:47 PM

So minimum:
- update proposal docs to match implementation
preferably:
- get OpenGL generated w/ example (hello triangle)
- Math library

I know there are a few cleanup tasks as well:
- add native versions of the functions
- fix the response file handling (searching and better logging when not found)

Maxine•11/4/23, 7:49 PM

i start work on monday so i hope you guys can do the other half of the maths library

Perksey•11/4/23, 7:49 PM

yeah so I’ll push up what I’ve done on VTs now if I haven’t already, I think there’s everything implemented except for the thread-local statics which realistically isn’t needed

Curin•11/4/23, 7:50 PM

Thread-local statics?

Curin•11/4/23, 7:51 PM

Also does silk have a trello/Jira/etc.?

Maxine•11/4/23, 7:51 PM

yes

Maxine•11/4/23, 7:51 PM

github issues

Lyris the KitoriOP•11/4/23, 7:52 PM

we also have a github project for more fine grained task tracking

Lyris the KitoriOP•11/4/23, 7:52 PM

(we forget it exists most of the time though)

Perksey•11/4/23, 7:52 PM

https://github.com/orgs/dotnet/projects/64

GitHub

Silk.NET Development Tracker • dotnet

Silk.NET Development Tracker

Curin•11/4/23, 7:57 PM

Yeah that is more what I was thinking of.
Github issues is difficult to at a glance tell what's open, in progress, or ready for review (though PRs are good for this).

CCurin Thread-local statics?

Perksey•11/4/23, 8:04 PM

this is the "calling a static function on GlfwGlfw and it forwarding to a ThreadLocalThreadLocal IGlfwIGlfw" thing needed to use OpenGL with static functions

Perksey•11/4/23, 11:07 PM

Should we organise a coffee and code?

Curin•11/5/23, 2:27 AM

I think a coffee and code would be productive once SilkX is in the minimum state to present (your VTable changes go in and we update the proposals).

CCurin I think a coffee and code would be productive once SilkX is in the minimum state...

Perksey•11/5/23, 2:41 AM

I think once we’ve done that we’re ready for a full fat working group meeting haha

Curin•11/5/23, 2:46 AM

yeah, but is there a reason to get everyone together before that? As long as we can update the proposals relatively quickly (was going to look at that maybe sometime this week). we should be good with minimal in the next week or two.

Curin•11/5/23, 2:47 AM

or maybe I'm misunderstanding coffee and code, since I've only caught bits and pieces. To me it seems like a periodic meeting to get all the major contributors/stakeholders in a call together and discuss state and any upcoming decisions.

Perksey•11/5/23, 2:56 AM

C&C is just an informal community call yeah. We tend not to get the whole audience though because they’re a lot more impromptu than the working group meetings, which usually have more than a week of notice.

Perksey•11/5/23, 2:56 AM

I mean we can do but I don’t think a lot has changed since the last C&C in which we discussed it

Perksey•11/5/23, 2:57 AM

we’ve flipped flopped to const correctness and back again, so really it’ll just be the name trimming and the vtable stuff

Perksey•11/5/23, 2:58 AM

which will probably be unobjectionable

Perksey•11/5/23, 2:58 AM

it may be worth it as a triage session though, though technically we should wait for WG go-ahead for that as SilkX is still separate

Perksey•11/5/23, 3:00 AM

we could have an ideas session though

Perksey•11/5/23, 3:00 AM

mainly around windowing and extension design I think

Perksey•11/5/23, 3:01 AM

as we haven’t even thought about the extension system yet and how that works with VTs

Curin•11/5/23, 3:02 AM

That's fair, especially since any meeting about the go-ahead for SilkX will probably be better separate

Lyris the KitoriOP•11/5/23, 3:05 AM

id be down for a C&C at some point soon, even if theres not too much to discuss

Perksey•11/5/23, 4:46 AM

Looking back at the rejected proposals, there’s one that looks suspiciously like SilkX haha: https://github.com/dotnet/Silk.NET/blob/main/documentation/proposals/(Rejected)%20Proposal%20-%20Better%20Strings.md

fun fact: i have no idea what canonical type vs named type means: but it gets shaderc into a better

Similar Threads

Similar Threads

Similar Threads