Wow, is this actually the problem? 😮 https://github.com/langchain-ai/langchainjs/issues/3187#issuec

Wow, is this actually the problem?

https://github.com/langchain-ai/langchainjs/issues/3187#issuecomment-1800851389

GitHub

Illegal invocation with `langchain/llms/bedrock/web` on Cloudflare ...

declare type Env = { ENVIRONMENT: "dev" | "production"; BEDROCK_AWS_ACCESS_KEY_ID: string; BEDROCK_AWS_SECRET_ACCESS_KEY: string; }; import { Bedrock } from "langchain/llms...

kian•11/8/23, 1:27 AM

nope, Workers supports signal

Unsmart•11/8/23, 1:27 AM

Yeah I was bouta say workers has supported signals for a long time

kian•11/8/23, 1:29 AM

checked-fetch is a wrangler dev shim that warns you about custom ports

kian•11/8/23, 1:30 AM

try deploying it and see if it still throws an error

Kkian try deploying it and see if it still throws an error

daveOP•11/8/23, 1:40 AM

wouldn't just

--remote

--remote

be the same?

Kkian checked-fetch is a wrangler dev shim that warns you about custom ports

daveOP•11/8/23, 1:41 AM

I don't get where the custom port is defined?

Kkian checked-fetch is a wrangler dev shim that warns you about custom ports

daveOP•11/8/23, 1:44 AM

No custom port defined

Kkian try deploying it and see if it still throws an error

daveOP•11/8/23, 1:52 AM

still throws an error

daveOP•11/8/23, 2:01 AM

wat, I am so confused.

daveOP•11/8/23, 2:01 AM

function myFetch(input: RequestInfo, init?: RequestInit<CfProperties<unknown>> | undefined): Promise<Response> {
  console.log("myFetch", input, init);
  return fetch(input, init);
}

function myFetch(input: RequestInfo, init?: RequestInit<CfProperties<unknown>> | undefined): Promise<Response> {
  console.log("myFetch", input, init);
  return fetch(input, init);
}

Making my own shim fixes it.

cross•11/8/23, 3:31 AM

I want to check images uploaded to my site for explicit/nsfw

cross•11/8/23, 3:31 AM

Something like
https://cloud.google.com/vision/docs/detecting-safe-search

Google Cloud

Detect explicit content (SafeSearch) | Cloud Vision API | Googl...

cross•11/8/23, 3:31 AM

Can I do it with workers AI

Ddave Wow, is this actually the problem? 😮 https://github.com/langchain-ai/langchainj...

sathoro•11/8/23, 3:34 AM

you use langchain?

Ssathoro you use langchain? 😦

daveOP•11/8/23, 3:35 AM

just started to use it this morning. What's your opinion on it?

sathoro•11/8/23, 3:35 AM

btw I got Bedrock working in Workers already

sathoro•11/8/23, 3:35 AM

real ez no langchain

Ssathoro btw I got Bedrock working in Workers already

daveOP•11/8/23, 3:35 AM

yeah, with aws4fetch it'd be pretty easy.

sathoro•11/8/23, 3:36 AM

it's for bad developers

Ddave yeah, with aws4fetch it'd be pretty easy.

sathoro•11/8/23, 3:36 AM

yeah but to support streaming had to do a little custom stuff

sathoro•11/8/23, 3:36 AM

can send if you need

Ssathoro it's for bad developers

daveOP•11/8/23, 3:36 AM

bad, or lazy developers?

Ddave bad, or lazy developers?

sathoro•11/8/23, 3:36 AM

bad

Ssathoro bad

daveOP•11/8/23, 3:37 AM

what's the worst dealbreakers for you in langchain?

Ddave what's the worst dealbreakers for you in langchain?

sathoro•11/8/23, 3:37 AM

the whole thing

Ssathoro the whole thing

daveOP•11/8/23, 3:39 AM

I feel like I'd end up reinventing a fair amount of it

daveOP•11/8/23, 3:40 AM

I agree the code quality is questionable, since like.. as a new user, I really shouldn't be able to find mistakes and give a PR to address obvious bugs on my first use

https://github.com/langchain-ai/langchainjs/pull/3189

Ddave I feel like I'd end up reinventing a fair amount of it

sathoro•11/8/23, 3:41 AM

like what exactly? nothing is too complicated and it's better to know what actually happening

Ssathoro like what exactly? nothing is too complicated and it's better to know what actua...

daveOP•11/8/23, 3:42 AM

I like how there's an LLM class

Ddave I like how there's an LLM class

sathoro•11/8/23, 3:44 AM

we used to be friends

Ssathoro we used to be friends

daveOP•11/8/23, 3:44 AM

this will probably be the postmark situation v2 in the end

Ssathoro yeah but to support streaming had to do a little custom stuff

daveOP•11/8/23, 3:59 AM

related question, if you don't actually "need" to stream your response back to the client, is there any real benefit to doing streaming instead of awaiting for the full response? (My guess is it's better to not stream if you don't need to, since that would cause more CPU usage on the Worker.)

sathoro•11/8/23, 4:08 AM

yeah probably better to not stream if you don't need it but with OpenAI we have seen weird issues and actually stream everything even if we just buffer in the worker

Ssathoro yeah probably better to not stream if you don't need it but with OpenAI we have ...

daveOP•11/8/23, 4:12 AM

You’ve seen weird issues if you stream, or if you don’t stream?

Ddave You’ve seen weird issues if you stream, or if you don’t stream?

sathoro•11/8/23, 4:13 AM

don't stream but it's possible it was happening with streaming too because by the time I added logging and pushed it the behavior went away but I was thinking there was some sort of network timeout happening between CF and Workers without streaming. it was strange

sathoro•11/8/23, 4:14 AM

also there's a major outage right now with OpenAI

Ssathoro also there's a major outage right now with OpenAI

daveOP•11/8/23, 4:21 AM

Perfect timing, I was just heading to bed.