Bi'm not quite sure how... i don't see PRs approved
EI don't recall doing that
EI'll fix that as well?
Band then some surface changes:
https://github.com/ublue-os/nvidia/commit/de17bdd54df22122adad18b414921ea0238f56de
https://github.com/ublue-os/nvidia/commit/de17bdd54df22122adad18b414921ea0238f56de
EGreat
EI feel like a dumbass
AIs main not protected?
Bi can revert that stuff no problem, i just wonder how it happened... if it's just an accident, no problem... but was it some automation?
EI don't understand how opening an MR into ASUS/Surface NVIDIA would impact main
EAt all.
AIt is protected
Bto me, it looks like the change was merged locally and pushed
EI didn't do that
Bit is protected... but... i think we allow bypassing of rules by those with perms
ENot dumb enough to merge BOTH repos into NVIDIA and force push
B
i'm not quite sure how it happened either, that's why I'm bringing it up 
EI did this via GitHub last night so maybe I overlooked something there?
EVery confused
AYeah but you still need to force push I believe
Bi agree, i think that's required
EThe PRs never even existed for NVIDIA which makes zero sense
Byep, exactly why i was extra confused
ELike how would both repos get changed from one PR?
Bhonestly, i'm a little nervous about the pull app
EShouldn't the pull app only work one way?
Byes, but i had weird behavior and ended up almost pushing stuff to the wrong repo after adding it
Bi would like to resolve this by force pushing
ublue-os/nvidia such that those last 3 commits never existedEI agree
EApologies for everyone. Really screwed up there
EI hadn't even noticed
BI only noticed due to build failures... and then i was surprised because it was obvious we didn't have PRs for those commits
EMaybe GitHub tried to merge both repositories when the PR was opened?
B@EyeCantCU @akdev
I'll do this now
I'll do this now
EThank you so much
ASounds good to me, thanks for fixing it
JThis sounds related to when I requested somebody with the right permissions to sync the asus-nvidia repo, which looks like a fork of the nvidia repo. I wonder what happened there. Did github try to be "smart" by automatically applying merges to the fork and the upstream?
EI honestly have no idea but that's definitely not smart behavior lol
Bis that request above?
JBok, i read it
BSEEMS simple...
Bthanks for calling out the correlation.
JThe changes seem reasonable in asus-nvidia
JI only detected the drivers being updated
Bhmm... it looks like
1) changes synced from nvidia > asus-nvidia
2) changes synced from asus-nvidia > nvidia
3) changes synced from nvidia > surface-nvidia
4) changes synced from surface-nvidia > nvidia
1) changes synced from nvidia > asus-nvidia
2) changes synced from asus-nvidia > nvidia
3) changes synced from nvidia > surface-nvidia
4) changes synced from surface-nvidia > nvidia
EWith 2 PRs though?
Bi thinik it's more likely the "sync" operations bypassed something
EShoot
Bclearly there was no PR to merge from asus/surface > nvidia
