i was looking into that but couldnt find a way to modify the page based on path

Fftqo i was looking into that but couldnt find a way to modify the page based on path

I

Isaac McFadyen•3/8/24, 3:17 PM

So you'd put a static HTML page up and then set up a Function for each path that modifies the <head> in different ways.

I

Isaac McFadyen•3/8/24, 3:17 PM

Or you can have a single, monolithic function that just does the path-matching code by itself rather than using the Pages router.

F

ftqoOP•3/8/24, 3:19 PM

export const onRequestGet: PagesFunction = async (context) => {
  const path = new URL(context.request.url).pathname;
  return context.env.ASSETS.fetch(context.request);
};

export const onRequestGet: PagesFunction = async (context) => {
  const path = new URL(context.request.url).pathname;
  return context.env.ASSETS.fetch(context.request);
};

export const onRequestGet: PagesFunction = async (context) => {
  const path = new URL(context.request.url).pathname;
  return context.env.ASSETS.fetch(context.request);
};

export const onRequestGet: PagesFunction = async (context) => {
  const path = new URL(context.request.url).pathname;
  return context.env.ASSETS.fetch(context.request);
};

F

ftqoOP•3/8/24, 3:20 PM

instead of returning, id modify that response?

F

ftqoOP•3/8/24, 3:24 PM

im not sure how else id do it

I

Isaac McFadyen•3/8/24, 3:26 PM

Yeah exactly. You'd want to do

const res = context.env.ASSETS.fetch

const res = context.env.ASSETS.fetch

const res = context.env.ASSETS.fetch

const res = context.env.ASSETS.fetch and then do a

const text = await res.text()

const text = await res.text()

const text = await res.text()

const text = await res.text() and then modify it and return it.

I

Isaac McFadyen•3/8/24, 3:26 PM

And then have a separate Function on each route for different modifications.

I

Isaac McFadyen•3/8/24, 3:27 PM

Or actually you could use HTMLRewriter, would be faster and more efficient: https://developers.cloudflare.com/workers/runtime-apis/html-rewriter/

Cloudflare Docs

HTMLRewriter · Cloudflare Workers docs

Build comprehensive and expressive HTML parsers inside of a Worker application.

IIsaac McFadyen Rate limiting = no, not really? Cache can be used to protect your origin, yes, b...

E

enkerrohah•3/8/24, 4:26 PM

Simple example: lets say that i have an api endpoint that makes many queries to my database. i want to limit the endpoint usage by ip to like 10 hits in 10 seconds. I want to limit this to minimize the reads/writes my database does. Would i be able to create a middleware in front of the endpoint that checks the remaining queries for the specific ip? I understand that my worker would still be invoked, but could this be used to prevent querying my database in such cases?

C

cora•3/8/24, 4:26 PM

am i accessing the env variable wrong here? when i log the env variable being passed by fetch this is what i get, the route path and other stuff

Screenshot_2024-03-08_at_11.26.44_AM.png

Eenkerrohah Simple example: lets say that i have an api endpoint that makes many queries to ...

I

Isaac McFadyen•3/8/24, 5:02 PM

You could yes.

I

Isaac McFadyen•3/8/24, 5:02 PM

Or you could use a Cloudflare Rate Limiting rule which I believe is applied before the Worker.

I

Isaac McFadyen•3/8/24, 5:02 PM

(and which is free)

Ccora am i accessing the env variable wrong here? when i log the env variable being pa...

C

cora•3/8/24, 5:43 PM

additional context

Screenshot_2024-03-08_at_12.42.55_PM.png

C

cora•3/8/24, 5:43 PM

Screenshot_2024-03-08_at_12.43.26_PM.png

Ccora am i accessing the env variable wrong here? when i log the env variable being pa...

I

Isaac McFadyen•3/8/24, 5:46 PM

Are you using Pages?

IIsaac McFadyen Are you using Pages?

C

cora•3/8/24, 5:57 PM

yes

Ccora yes

I

Isaac McFadyen•3/8/24, 6:27 PM

Pages doesn't take the same inputs as a Worker.

I

Isaac McFadyen•3/8/24, 6:28 PM

See here: https://developers.cloudflare.com/pages/functions/api-reference/#eventcontext

IIsaac McFadyen Pages doesn't take the same inputs as a Worker.

C

cora•3/8/24, 6:52 PM

so do i have to use a pages function instead? because that seems to give the same error

I

Isaac McFadyen•3/8/24, 6:56 PM

You can use a Worker or Pages, but if you're using Pages you should be using a Function. What error are you getting exactly?

C

cora•3/8/24, 7:17 PM

I might be missing something here, does npx wrangler pages dev .vercel/output/static automatically turn pages/api routes into pages functions for cloudflare? So I don't have to change them into edge functions?

Ccora I might be missing something here, does npx wrangler pages dev .vercel/output/st...

H

Hello, I’m Allie!•3/8/24, 7:18 PM

No, you need to use https://github.com/cloudflare/next-on-pages

GitHub

GitHub - cloudflare/next-on-pages: CLI to build and develop Next.js...

CLI to build and develop Next.js apps for Cloudflare Pages - cloudflare/next-on-pages

VVâjhâtz I don't understand worker to worker communication. Maybe someone can shed some l...

E

Erisa•3/8/24, 8:56 PM

How do I call the fetch on service A without having to manually specify the URL as it might change

When using the service binding the URL doesn't really "mean" anything in the normal fetch sense here, it just is passed verbatim to the other Worker in

request.url

request.url

. It will still hit that worker even if you put something silly like

http://dummy

http://dummy

.

how can I stop external requests from being able to hit project A directly?

Disable the workers.dev subdomain for the Worker (

workers_dev = false

workers_dev = false

in wrangler.toml) and don't define any

routes

routes

entries for it.

HHello, I’m Allie!No, you need to use https://github.com/cloudflare/next-on-pages

C

cora•3/8/24, 9:08 PM

Yeah, that's what I meant - after running that i run the wrangler dev build command. So I don't have to change my next js api routes into edge functions and i dont have to convert them to pages functions either by creating a functions folder at the root?

Ccora Yeah, that's what I meant - after running that i run the wrangler dev build comm...

H

Hello, I’m Allie!•3/8/24, 9:09 PM

IIRC you do have to mark them as edge functions, then they should be built into Pages Functions automatically

C

cora•3/8/24, 9:11 PM

Interesting - so this was my old route, it was fine as is?

C

cora•3/8/24, 9:13 PM

I changed it to this manually

Ccora Interesting - so this was my old route, it was fine as is?

C

cora•3/8/24, 9:18 PM

Also this doesn't make sense to me, how would you access the env if you kept the api route the same

HHello, I’m Allie!IIRC you do have to mark them as edge functions, then they should be built into ...

C

cora•3/8/24, 10:21 PM

Using the pages guide to create a route, ie: onRequest doesnt seem to work at all

L

lemonek•3/8/24, 11:57 PM

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at <ur>. (Reason: CORS preflight response did not succeed). Status code: 500. 2

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at <ur>. (Reason: CORS preflight response did not succeed). Status code: 500. 2

return new Response(JSON.stringify({ url: uploadUrl }), {
        status: 200,
        statusText: 'OK',
        headers: {
          "Access-Control-Allow-Origin": "*",
          "Access-Control-Allow-Methods": "GET,HEAD,POST,OPTIONS",
          "Access-Control-Max-Age": "86400",
          "Access-Control-Allow-Headers": "Content-Type"
        }
      });

return new Response(JSON.stringify({ url: uploadUrl }), {
        status: 200,
        statusText: 'OK',
        headers: {
          "Access-Control-Allow-Origin": "*",
          "Access-Control-Allow-Methods": "GET,HEAD,POST,OPTIONS",
          "Access-Control-Max-Age": "86400",
          "Access-Control-Allow-Headers": "Content-Type"
        }
      });

return new Response(JSON.stringify({ url: uploadUrl }), {
        status: 200,
        statusText: 'OK',
        headers: {
          "Access-Control-Allow-Origin": "*",
          "Access-Control-Allow-Methods": "GET,HEAD,POST,OPTIONS",
          "Access-Control-Max-Age": "86400",
          "Access-Control-Allow-Headers": "Content-Type"
        }
      });

return new Response(JSON.stringify({ url: uploadUrl }), {
        status: 200,
        statusText: 'OK',
        headers: {
          "Access-Control-Allow-Origin": "*",
          "Access-Control-Allow-Methods": "GET,HEAD,POST,OPTIONS",
          "Access-Control-Max-Age": "86400",
          "Access-Control-Allow-Headers": "Content-Type"
        }
      });

No idea why it isn't working

Llemonek ``` Cross-Origin Request Blocked: The Same Origin Policy disallows reading the r...

E

Erisa•3/9/24, 1:38 AM

(Reason: CORS preflight response did not succeed). Status code: 500.

This indicates the issue is not with the headers, but rather the fact that the request is returning 500 instead of 200. Most likely a 500 in this context means the Worker thew an exception, check the log for that error to see why: https://developers.cloudflare.com/workers/observability/logging/

E

Erisa•3/9/24, 1:39 AM

Note that CORS preflight requests are sent with a http method of OPTIONS

A

Anthony•3/9/24, 2:01 PM

is anyone else having issues with executing discord webhooks from workers

T

TrueBrain•3/9/24, 2:11 PM

You are not alone. Since a few hours, Discord Webhook calls via Cloudflare Workers return a 403 for me, with some internal error message. If I would guess, Discord added something to their block-list for one reason or another

K

Kai•3/9/24, 2:59 PM

Experiencing same issue with Discord Webhook calls

AAnthony is anyone else having issues with executing discord webhooks from workers

T

TrueBrain•3/9/24, 3:57 PM

and it is working for me again

TTrueBrain and it is working for me again 🙂

A

Anthony•3/9/24, 4:14 PM

Same, Great!

D

dave•3/9/24, 6:57 PM

when doing a subrequest fetch to a html file, why does the etag and content-length header disappear?

D

dave•3/9/24, 7:05 PM

ah, I see I needed to have no-transform on the asset's cache-control header

D

dave•3/9/24, 7:23 PM

that's annoying, even if I set

no-transform

no-transform

on the request, it still doesn't work..

P

phyx•3/10/24, 4:22 AM

Has anyone tried submitting custom metrics from your worker to datadog via api? Without an agent, it's pretty hard to batch send a bunch of metrics because all you can do is append an array of metrics and "sendAll" with ctx.waitUntil() after the request event is over. Was wondering if anyone have tried this and how did it affect your DD bill?

W

Walshy•3/10/24, 7:05 AM

So this is referring to cold start, it used to be slower for free plan on first request. These days, every worker regardless of plan will be fast on first and subsequent requests

W

Walshy•3/10/24, 7:51 AM

They aren't always running on every single metal (since we reserve memory for each one) but yes, they can run on every single one and starting an isolate is lightning fast

At CF, we believe on running every service in every colo on every metal. We have a few these days which aren't but it's more work to not do that than do it so we will always strive to do that

W

Walshy•3/10/24, 7:51 AM

It'd be slower to go to another Colo than just spin up on the initial one so we just spin up and serve!

i was looking into that but couldnt find a way to modify the page based on path

Similar Threads

Similar Threads

Similar Threads