Cloudflare Developers•2y ago

Thanks for putting this much efforts <@691072002806513684> 🫡❤️🙌✨ Really appreciate your efforts �

Thanks for putting this much efforts @Dario

Really appreciate your efforts

Could you please tell me what configuration you choose while deploying?

Also, for me, when I am running yarn install in local the changes aren't coming in yarn.lock file and in yours there are changes, so did you have done some other steps too?

SSatyam Bajpai Thanks for putting this much efforts <@691072002806513684> 🫡❤️🙌✨ Really appre...

Dario•3/10/24, 6:26 PM

all the changes I made are there in the commits I shared, besides those and yarn installyarn install, I didn't do anything else

Dario•3/10/24, 6:26 PM

this is my configuration

Dario•3/10/24, 6:26 PM

Dario•3/10/24, 6:26 PM

and I am using the v2 build image

Dario•3/10/24, 6:26 PM

Dario•3/10/24, 6:26 PM

(but I think you were using that too)

Bbun do you still need a reproduction ?

Dario•3/10/24, 11:19 PM

@bun no I've got it

Dario•3/10/24, 11:21 PM

(PS: I also think I've also got a fix for it

, ~~but that might not work for your particular case~~ )

bun•3/11/24, 1:43 PM

What was the cause?

bun•3/11/24, 1:43 PM

I believe that error occurs in some specific context of the Next.js app

Dario•3/11/24, 5:37 PM

yes, I think it only happens when the getRequestContextgetRequestContext is part of the top-level scope of a file, as you can see here: https://github.com/dario-piotrowicz/next-on-Pages-top-level-getRequestContext-bug-repro

GitHub

GitHub - dario-piotrowicz/next-on-Pages-top-level-getRequestContext...

Contribute to dario-piotrowicz/next-on-Pages-top-level-getRequestContext-bug-repro development by creating an account on GitHub.

Dario•3/11/24, 5:38 PM

basically I think that the Next.js build process, imports the files and that triggers such the getRequestContextgetRequestContext calls to happen, but since you're in nodejs the context is not present

Dario•3/11/24, 5:41 PM

the annoying bit is also that prerendering does not work with files using the edge runtime so those calls not working is not something that should really cause issues, but naturally Next.js does need to import those files in order to see if they are exporting the edgeedge runtimeruntime config

Dario•3/11/24, 5:42 PM

I could very very easily fix it by making getRequestContextgetRequestContext just return undefinedundefined during prerendering, but if there is other code that on the top level uses such bindings it could be problematic, so I'll have to experiment and think about it a bit...

Dario•3/11/24, 6:58 PM

Mh.... it is quite problematic... I'm thinking that likely the only viable solution is to forbid the use of getRequestContextgetRequestContext from the top level

(and implement a nice error message that makes that clear)

Dario•3/11/24, 7:01 PM

PS: trying to use it alongside bindings top-level does seem to also cause hydration problems, so maybe forbidding it altogether is indeed the right choice

Dario•3/11/24, 7:01 PM

do you have any opinion on this @bun?

bun•3/11/24, 7:14 PM

Why does getRequestContext require edge runtime specifically? Couldnt it just return undefined for cf and ctx, but provide bindings as they already somehow exist in process.env

Bbun Why does getRequestContext require edge runtime specifically? Couldnt it just re...

Dario•3/11/24, 9:22 PM

well, in production it needs to be in the edge runtime because everything is (the nodejsnodejs is not supported) technically it could work in the nodejsnodejs runtime during development but there are two major issues with that:

It wouldn't make too much sense, as it would allow people to use the utility when it's meaningless, I feel like that could add much more confusion than anything else
(e.g. why allow people to do something when that thing is not going to work in production anyways?)
the way in which both getRequestContextgetRequestContext and the process.envprocess.env bindings work in dev mode is via this hack I came up with in which we can basically monkey patch the edge runtime context so that it the require data is made available there, I don't think there is such hack for the nodejsnodejs runtime (as next devnext dev also actually runs your nodejsnodejs code in a separate child process, making hacks very difficult to do without actually modifying the next dev server itself)

Mongy•3/12/24, 4:55 AM

After reading the comments above, what would be the current setup to be able to retrieve the env variables with setupDevPlatformsetupDevPlatform? It seems im having difficulty configuring a D1 database to work both locally and in production.

luna•3/12/24, 8:02 AM

does this include next on pages?

MMongy After reading the comments above, what would be the current setup to be able to ...

Dario•3/12/24, 10:21 AM

basically the setupDevPlatformsetupDevPlatform call can stay as is, what you need to change is getRequestContextgetRequestContext and make sure that it is not being called as part of the route initialization (e.g. don't put getRequestContext()getRequestContext() to the top level of a route file, but have it part of a function that gets called when the route is actually run)

Lluna does this include next on pages?

Dario•3/12/24, 10:28 AM

yes, I do think so (but I could be wrong)

DDario yes, I do think so (but I could be wrong)

luna•3/12/24, 10:28 AM

if it does it doesn’t seem to be working.

Lluna if it does it doesn’t seem to be working. 😅

Dario•3/12/24, 10:35 AM

oh.... ok sorry, I'll have to check with the team and/or play a bit with it myself

DDario oh.... ok sorry, I'll have to check with the team and/or play a bit with it myse...

luna•3/12/24, 10:37 AM

cheers, so far i have a site using next on pages with git. i enabled it about a week ago and have done multiple deploys since. still nothing shows in the analytics ui and i don’t see anything being added to the page’s head.

i’ve disabled and re-enabled and no change.

Dario•3/12/24, 10:43 AM

I see, I'll have a look thanks for the info

DDario basically the `setupDevPlatform` call can stay as is, what you need to change is...

Mongy•3/12/24, 2:59 PM

Hmmmmm the getRequestContextgetRequestContext can't be called within an actions.ts due to edge runtime requirement. Gana have to find another way to populate data to a client component.

Dario•3/12/24, 5:49 PM

@luna I've tried and web analytics seems to be totally working with next-on-pages

Dario•3/12/24, 5:50 PM

do you get a bacon script in your page's body by any chance?

Dario•3/12/24, 5:50 PM

Dario•3/12/24, 5:51 PM

what about the rum http requests?

Dario•3/12/24, 5:51 PM

GetPsyched•3/13/24, 7:59 AM

Please make sure that all your non-static routes export the following edge runtime route segment config:

How do I know which route is this referring to?

GetPsyched•3/13/24, 7:59 AM

Got this error in the log after a successful build, but apparently I have non-static routes?

GGetPsyched > Please make sure that all your non-static routes export the following edge run...

Dario•3/13/24, 9:20 AM

@GetPsyched could you share a screenshot?

DDario <@534651911903772674> could you share a screenshot? 🙂

GetPsyched•3/13/24, 10:54 AM

here's a copy of the log

message.txt12.79KB

GetPsyched•3/13/24, 10:55 AM

Oh all of the routes were not able to be pushed

GetPsyched•3/13/24, 10:56 AM

My middleware already defines two possible values for localelocale

then why is it not static

GetPsyched•3/13/24, 10:56 AM

Okay I guess this is a problem in my project, so will keep the discussion off this server, sorry and thanks

Dario•3/13/24, 11:01 AM

I see

, cool hopefully you can fix the issue, otherwise please do feel free to post here and we can try to help

(opening a thread should also help not making this noisy for everyone)

seasie•3/13/24, 7:51 PM

the persistpersist option of setupDevPlatformsetupDevPlatform doesn't appear to be working as expected, unless I have it configured incorrectly

if (process.env.NODE_ENV === "development") {
    await setupDevPlatform({
        persist: "../../.wrangler/search/v3",
    })
}

if (process.env.NODE_ENV === "development") {
    await setupDevPlatform({
        persist: "../../.wrangler/search/v3",
    })
}

but it still creates and accesses data from .wrangler/state/v3.wrangler/state/v3, I've tried both with and without v3v3 at the end of the path

FFiru my form would POST to the same URL as the page, leading to a 405 tho

Dudu•3/13/24, 8:59 PM

Heyo o/

Did you manage to solve this and if so how?

Dudu•3/13/24, 8:59 PM

I'm also getting 405 Method Not Allowed with the NextJS actions

DDudu Heyo o/ Did you manage to solve this and if so how?

Firu•3/14/24, 12:59 AM

I haven't fixed it. I migrated away from Next.js on Cloudflare Pages ):

Firu•3/14/24, 12:59 AM

i'd gladly migrate back if that issue didn't exist tho

FFiru I haven't fixed it. I migrated away from Next.js on Cloudflare Pages ):

Dudu•3/14/24, 12:15 PM

I have found a work around but now I'm getting this every time I submit the form

DDudu I have found a work around but now I'm getting this every time I submit the form

Firu•3/14/24, 12:15 PM

what's the workaround?

FFiru i tried doing `export const runtime = 'edge'` on both files and it still wouldn'...

Dudu•3/14/24, 12:16 PM

I tried this in different files until it worked

Dudu•3/14/24, 12:17 PM

In my case I have it on page.tsx

Thanks for putting this much efforts <@691072002806513684> 🫡❤️🙌✨ Really appreciate your efforts �

Similar Threads