Universal Blue•2y ago•

68 replies

looking at the brew pr in config

bshermanOP•3/24/24, 8:29 PM

is this really all that's needed?

bshermanOP•3/24/24, 8:29 PM

seems like we are missing /usr/etc/profile.d/brew.sh /usr/etc/profile.d/brew.sh

Gerblesh•3/24/24, 8:31 PM

that's in etc-profile.detc-profile.d

Gerblesh•3/24/24, 8:33 PM

however M2 had some good suggestions: 💾ublue-dev

Bbsherman seems like we are missing ` /usr/etc/profile.d/brew.sh`

Gerblesh•3/24/24, 8:33 PM

I think we're missing this from the SPEC yeah

bshermanOP•3/24/24, 8:35 PM

i just commented on PR, but now I see it is there, just the path is funny in the config repo... makes sense now

Gerblesh•3/24/24, 8:45 PM

man this SPEC file is messy

bshermanOP•3/24/24, 8:45 PM

yes it is

bshermanOP•3/24/24, 8:45 PM

there's a missing "Source8:" if you want to slot in there

Gerblesh•3/24/24, 9:14 PM

whoops I made a Source23Source23

Gerblesh•3/24/24, 9:16 PM

yeah i'll just keep it as is

Gerblesh•3/24/24, 9:16 PM

source 8 is likely best reserved for another justfile

bshermanOP•3/24/24, 9:16 PM

no worries

bshermanOP•3/24/24, 9:21 PM

suggestion on doing these... just run a local container build from your ublue-os/configublue-os/config locally checked out branch

bshermanOP•3/24/24, 9:21 PM

podman build -f Containerfile -t config:39podman build -f Containerfile -t config:39

bshermanOP•3/24/24, 9:22 PM

you'll see that currently this RPM fails to build

Gerblesh•3/24/24, 9:24 PM

thanks

Gerblesh•3/24/24, 9:28 PM

looks like the rpm manages to the build

bshermanOP•3/24/24, 9:36 PM

yeah, i just approved, lookin' good! thank you!

Bbsherman yeah, i just approved, lookin' good! thank you!

Gerblesh•3/24/24, 9:39 PM

should we be careful because of the conflicting target in bluefin?

Gerblesh•3/24/24, 9:46 PM

yeah conflicting targets give just an error

Gerblesh•3/24/24, 9:46 PM

i'll make a PR to bluefin to fix this

bshermanOP•3/24/24, 9:58 PM

@j0rge just brought up another issue in #

ublue-dev

https://github.com/ublue-os/bluefin/pull/988/files#diff-5fcdf9b4580789697d834d1456a22bcfaa236d668fc180cad4775afc36ed5914

bshermanOP•3/24/24, 9:58 PM

i'm not sure if we want the config RPM manipulating the systemd/user.conf though

bshermanOP•3/24/24, 9:59 PM

that's fine for our opininated images to do, but i dunno about having the rpm do it

j0rge•3/24/24, 9:59 PM

oh sorry missed this thread

j0rge•3/24/24, 10:00 PM

https://github.com/ublue-os/bluefin/blob/main/just/bluefin-apps.just

bshermanOP•3/24/24, 10:00 PM

we could make it a responsibility of downstream to modify limits if you want blue?

Bbsherman that's fine for our opininated images to do, but i dunno about having the rpm do...

Gerblesh•3/24/24, 10:00 PM

do you have any suggestions how best to implement this?

bshermanOP•3/24/24, 10:00 PM

i dunno

j0rge•3/24/24, 10:00 PM

this has an alias so it's ujust brewujust brew, will the alias still work?

j0rge•3/24/24, 10:00 PM

or should I add the alias to config?

j0rge•3/24/24, 10:00 PM

(line 13)

Gerblesh•3/24/24, 10:00 PM

i'll add alias to the 00-default.just to match bluefin

j0rge•3/24/24, 10:01 PM

ack

Gerblesh•3/24/24, 10:01 PM

almost forgot about that

bshermanOP•3/24/24, 10:02 PM

my vote is probably that config repo and just RPM does it's part by providing the installer, but if an image really wants to use it, they need to set limits

j0rge•3/24/24, 10:02 PM

we could just say "if you're using a custom image you need this brew config" so we don't have to special case it?

bshermanOP•3/24/24, 10:02 PM

otherwise, i think we risk clobbering what other things bluefin/bazzite/etc may want to do

j0rge•3/24/24, 10:02 PM

agree 100%

bshermanOP•3/24/24, 10:03 PM

and if people with custom images are hitting this we just tell them how to fix

bshermanOP•3/24/24, 10:03 PM

i don't think ALL uses of brew install will hit the bug, only bigger packages ... i hope

j0rge•3/24/24, 10:03 PM

plus I bet bazzite already has stuff like this, this is just like when you install texlive it runs out of handles, you know, defaults that the distro should have fixed 10 years ago.

bshermanOP•3/24/24, 10:03 PM

ok, i really gotta go... family

j0rge•3/24/24, 10:03 PM

yeah it's like texlive, most people won't notice

Gerblesh•3/24/24, 10:04 PM

maybe the ulimit file is curlcurled down from github if it doesn't already exist?

Gerblesh•3/24/24, 10:04 PM

sounds a bit hacky though

fiftydinar•3/24/24, 10:05 PM

Status like this would be great: "No-file limit fix: Enabled"

fiftydinar•3/24/24, 10:06 PM

It would check if number is equal or greater then something

looking at the brew pr in config

Similar Threads

Similar Threads

Similar Threads