B@mulderje thanks for the PR
BB@j0rge i started to ask about where we will plan to ship the facetimehd kmod
Jyeah I'm down, plenty of intel macs out there
Band i want to revisit a few things that we don't have super solid, but I have opinons on
Jwe need the intel ipu ones too but that''s a fight for another day
BI think this obviously fits hardware enablement goal
Bhowever, we haven't generally built kmods unless we intend to ship them in our own images (eg, bluefin, bazzite) but if we want to that i'm all for it
Jyeah I'm not sure intel macs are useful with bazzite, but aurorafin seems like a good spot.
B@mulderje asked some good questions in the PR and I want to hash out some answers here before i make more formal responses on PR
Bi THINK we've discussed this with @Kyle Gospo before... but one question was about COPR and spec hosting.
I do think we've previously agreed that we're trying to not add 3rd party COPRs where we can avoid it... which would mean we'd likely want to build the package in our COPR even if the spec file is hosted elswhere
I do think we've previously agreed that we're trying to not add 3rd party COPRs where we can avoid it... which would mean we'd likely want to build the package in our COPR even if the spec file is hosted elswhere
MI’m totally fine moving the COPR build into the ublue one. My main motivations on making it were 1) just getting it working, 2) learning about spec files/COPR/fedora build system stuff
MNo problem coordinating on moving it over
MAnother question I had was around getting them into something like rpmfusion. But ideally would have a place for it to live until that happens
MI’ve been reading around the fedora docs and doesn’t seem like this would be taken into their rpm repo outside of maybe the firmware files themselves. Note I could be very wrong there. Still poking around on what’s possible
MPossible / best practice I should say
Bi very much appreciate the effort to get it going before trying to merge in here, so if I was writing a doc on "how to bring in a new kmod" i'd probably include "build it in own account and COPR and once it's verified working, then present it as a PR"
Bi don't have experience getting things into Fedora or RPMfusion themselves
Bi've contributed to Fedora CoreOS, but that's a subset of Fedora
MNo problem! Looks like there were some build errors from the v4l2 driver. Asked to re-kick the build in the PR
MI was looking around at rpmfusion and looks like the process is pretty well documented here: https://rpmfusion.org/Contributors & https://rpmfusion.org/Packaging/KernelModules/Kmods2
MI'll take a look at getting that side going since I think there is value in the spec file being a more general thing vs ublue-specific
MThat said, i dont think there are any issues adding it to your copr now. IMO there is nothing "bad" about it being build/hosted in multiple places temporarily
MAnd thank you for your patience with my git (and everything else...) skills 
MHey there, @bsherman . wanted to quickly check in to see next steps on the PR. let me know if anything i can do to help push that along
Malso fyi, been daily(ish) driving a version of this via a blue-build image https://github.com/mulderje/ublue-oldair
GitHub
This is my personal OS image. Contribute to mulderje/ublue-oldair development by creating an account on GitHub.
Brelated to chat in #
ublue-dev ... https://github.com/ublue-os/akmods/issues/176 covers the idea for splitting which i'd like to see before we add more kmods to
ublue-dev ... https://github.com/ublue-os/akmods/issues/176 covers the idea for splitting which i'd like to see before we add more kmods to akmodsthanks for writing that up! i'll take my PR and spin it off into adding the "extra" while making the facetimehd kmod its first consumer
Mwe could also do something a la packages.json to clean up build script calls, and in this world make a clean break between core and extra. i'll do that as a follow on PR unless you think that should come first?
Mre your idea to break out the containerfile into a separate one for extra. do you have any resources on pros/cons of that approach vs what bluefin is doing for their dx vs standard build (ie one containerfile and using the latter as a base layer)
Mwould like to be better educated there...
Meither way will get going on switching that up
Mdo you have any recommendations on running the build in the ublue akmod repo? i can't seem to figure out how to run the action in my fork because i dont have the key
Mone question for the "akmods-extra" package, would your vision there be that it would be inclusive of what is in core or like the "akmods-nvidia" package where it is just the one separate RPM?
Mif the latter, would that be a pain down the line for people who want to add in kmods? i.e. they would need to add in a second COPY line or something along those lines to bring in akmods and akmods-extra as an example
Mseparately do you have an ETA on when you hope to re land this PR? https://github.com/ublue-os/akmods/pull/172
GitHub
This reverts commit b64843b.
I found that this akmods+hwe change was disabling Wayland.
Needs more testing before merging again.
I found that this akmods+hwe change was disabling Wayland.
Needs more testing before merging again.
Mi was about to change around some of the same pieces in reusable_build.yml that you just reverted and dont want to step on any toes
Mthat also may be a lack of git knowledge... should i be doing something like merging in your working branch as a best practice or something along those lines?
Mplease do let me know if a better way to manage that bit in the future
Mbuild is running fine in that PR with an extra stream. will update the issue/PR shortly
Many feedback would be great
Bhey! saw your PR and just seeing these messages... I'm trying to be more focussed on my day job this week.
Byeah, i know there are a couple PRs in flight which will mess with what you are doing.
Mall good! totally understand. appreciate you taking a look when you're able
Bok, sorry it's been a while since feedback, but i think you see a lot has been happening.
Bi am quite eager to get to work on splitting the akmods common builds into common and extras now that all the F40 stuff is done and we've cleaned out some existing cruft
Mno worries at all! take your time to digest and let me know if you have any other changes in mind prior to getting this PR in
Mi also want to work on refactoring a bit to pull out some of the common bits - both across the containerfiles and in the kmod build files
Mover the next few days i am planning on pulling together a PR for a packages.json esqe thing that'll hopefully help pull out some of the repetative bits
