is it safe to leak the database id? i.e. to publish `wrangler.toml` which has database id bindings ?

Ddakom is it safe to leak the database id? i.e. to publish `wrangler.toml` which has da...

H

Yes. The entirety of

wrangler.toml

wrangler.toml

is safe to publish, as long as you aren't putting secrets in it

Ddakom is it safe to leak the database id? i.e. to publish `wrangler.toml` which has da...

A

Acе•4/11/24, 1:40 PM

The ID only works for workers in your account so it should be fine

M

mau•4/11/24, 3:55 PM

My where condition with an index on id is taking 2.0-2.2 seconds. If I get everything from the table it takes 2.3-2.8 seconds. Is it normal?

M

mau•4/11/24, 3:58 PM

M

mau•4/11/24, 3:59 PM

M

mau•4/11/24, 4:00 PM

any thoughts? thanks!

M

mau•4/11/24, 4:03 PM

M

mau•4/11/24, 4:03 PM

Oops

M

mau•4/11/24, 4:04 PM

okay, is it good? 500+ms...

M

mau•4/11/24, 4:06 PM

it ranges from 500+ms to 1.2 seconds

M

mau•4/11/24, 4:21 PM

import type { DrizzleD1Database } from 'drizzle-orm/d1';
import { drizzle } from 'drizzle-orm/d1';
import { eq } from 'drizzle-orm/expressions';
import type { Request as IttyRequest, Route } from 'itty-router';
import { Router } from 'itty-router';
import { json } from 'itty-router-extras';

import { users } from './schema';
import { sql } from 'drizzle-orm';

export interface Env {
    DB: D1Database;
}

interface Request extends IttyRequest {
    db: DrizzleD1Database;
}

interface Methods {
    get: Route;
    post: Route;
}

async function injectDB(request: Request, env: Env) {
    const db = drizzle(env.DB);
    request.db = db;
}

const router = Router<Request, Methods>({ base: '/' });

router.get("/favicon.ico",()=>{
    return json({});
})

router.get('/users', injectDB, async (req: Request, env: Env) => {
    const query = req.db.select().from(users);
    console.log(query.toSQL());
    const result = await query.all();
    return json(result);
});

router.get('/users/:id', injectDB, async (req: Request, env: Env) => {
    const result : any = await req.db
        .select().from(users)
        .where(eq(users.id, Number(req.params!['id'])))
        .get();
    return json(result);
});

router.post('/users', injectDB, async (req: Request, env: Env) => {
    const { name, email } = await req.json!();
    const res = await req.db.insert(users).values({ name, email }).returning().get();
    return json({ res });
});

router.get("/indexes",injectDB, async(req,env)=>{
    let data = await req.db.run(sql`SELECT name, type, sql FROM sqlite_schema WHERE type IN ('index');`);
    return json(data);
})

export default {
    fetch: router.handle,
};

import type { DrizzleD1Database } from 'drizzle-orm/d1';
import { drizzle } from 'drizzle-orm/d1';
import { eq } from 'drizzle-orm/expressions';
import type { Request as IttyRequest, Route } from 'itty-router';
import { Router } from 'itty-router';
import { json } from 'itty-router-extras';

import { users } from './schema';
import { sql } from 'drizzle-orm';

export interface Env {
    DB: D1Database;
}

interface Request extends IttyRequest {
    db: DrizzleD1Database;
}

interface Methods {
    get: Route;
    post: Route;
}

async function injectDB(request: Request, env: Env) {
    const db = drizzle(env.DB);
    request.db = db;
}

const router = Router<Request, Methods>({ base: '/' });

router.get("/favicon.ico",()=>{
    return json({});
})

router.get('/users', injectDB, async (req: Request, env: Env) => {
    const query = req.db.select().from(users);
    console.log(query.toSQL());
    const result = await query.all();
    return json(result);
});

router.get('/users/:id', injectDB, async (req: Request, env: Env) => {
    const result : any = await req.db
        .select().from(users)
        .where(eq(users.id, Number(req.params!['id'])))
        .get();
    return json(result);
});

router.post('/users', injectDB, async (req: Request, env: Env) => {
    const { name, email } = await req.json!();
    const res = await req.db.insert(users).values({ name, email }).returning().get();
    return json({ res });
});

router.get("/indexes",injectDB, async(req,env)=>{
    let data = await req.db.run(sql`SELECT name, type, sql FROM sqlite_schema WHERE type IN ('index');`);
    return json(data);
})

export default {
    fetch: router.handle,
};

import type { DrizzleD1Database } from 'drizzle-orm/d1';
import { drizzle } from 'drizzle-orm/d1';
import { eq } from 'drizzle-orm/expressions';
import type { Request as IttyRequest, Route } from 'itty-router';
import { Router } from 'itty-router';
import { json } from 'itty-router-extras';

import { users } from './schema';
import { sql } from 'drizzle-orm';

export interface Env {
    DB: D1Database;
}

interface Request extends IttyRequest {
    db: DrizzleD1Database;
}

interface Methods {
    get: Route;
    post: Route;
}

async function injectDB(request: Request, env: Env) {
    const db = drizzle(env.DB);
    request.db = db;
}

const router = Router<Request, Methods>({ base: '/' });

router.get("/favicon.ico",()=>{
    return json({});
})

router.get('/users', injectDB, async (req: Request, env: Env) => {
    const query = req.db.select().from(users);
    console.log(query.toSQL());
    const result = await query.all();
    return json(result);
});

router.get('/users/:id', injectDB, async (req: Request, env: Env) => {
    const result : any = await req.db
        .select().from(users)
        .where(eq(users.id, Number(req.params!['id'])))
        .get();
    return json(result);
});

router.post('/users', injectDB, async (req: Request, env: Env) => {
    const { name, email } = await req.json!();
    const res = await req.db.insert(users).values({ name, email }).returning().get();
    return json({ res });
});

router.get("/indexes",injectDB, async(req,env)=>{
    let data = await req.db.run(sql`SELECT name, type, sql FROM sqlite_schema WHERE type IN ('index');`);
    return json(data);
})

export default {
    fetch: router.handle,
};

import type { DrizzleD1Database } from 'drizzle-orm/d1';
import { drizzle } from 'drizzle-orm/d1';
import { eq } from 'drizzle-orm/expressions';
import type { Request as IttyRequest, Route } from 'itty-router';
import { Router } from 'itty-router';
import { json } from 'itty-router-extras';

import { users } from './schema';
import { sql } from 'drizzle-orm';

export interface Env {
    DB: D1Database;
}

interface Request extends IttyRequest {
    db: DrizzleD1Database;
}

interface Methods {
    get: Route;
    post: Route;
}

async function injectDB(request: Request, env: Env) {
    const db = drizzle(env.DB);
    request.db = db;
}

const router = Router<Request, Methods>({ base: '/' });

router.get("/favicon.ico",()=>{
    return json({});
})

router.get('/users', injectDB, async (req: Request, env: Env) => {
    const query = req.db.select().from(users);
    console.log(query.toSQL());
    const result = await query.all();
    return json(result);
});

router.get('/users/:id', injectDB, async (req: Request, env: Env) => {
    const result : any = await req.db
        .select().from(users)
        .where(eq(users.id, Number(req.params!['id'])))
        .get();
    return json(result);
});

router.post('/users', injectDB, async (req: Request, env: Env) => {
    const { name, email } = await req.json!();
    const res = await req.db.insert(users).values({ name, email }).returning().get();
    return json({ res });
});

router.get("/indexes",injectDB, async(req,env)=>{
    let data = await req.db.run(sql`SELECT name, type, sql FROM sqlite_schema WHERE type IN ('index');`);
    return json(data);
})

export default {
    fetch: router.handle,
};

https://github.com/drizzle-team/drizzle-orm/tree/main/examples/cloudflare-d1

GitHub

drizzle-orm/examples/cloudflare-d1 at main · drizzle-team/drizzle-orm

Headless TypeScript ORM with a head. Runs on Node, Bun and Deno. Lives on the Edge and yes, it's a JavaScript ORM too

drizzle-team/drizzle-orm

I

Iaci•4/11/24, 4:46 PM

hey guys, are there any tutorials out there that focus on explaining how to insert a row into a cloudflare d1 database with a cloudflare worker ?

IIaci hey guys, are there any tutorials out there that focus on explaining how to inse...

M

Max (@rozenmd)•4/11/24, 4:50 PM

sure are:

I

Iaci•4/11/24, 4:51 PM

ok i feel dumb now, i honestly did rtfm but i was looking at the examples rather than scrolling down "Write queries within your Worker" section

I

Iaci•4/11/24, 4:51 PM

there it is

I

Iaci•4/11/24, 4:51 PM

thanks

M

Max (@rozenmd)•4/11/24, 4:51 PM

no worries

I

Iaci•4/11/24, 4:52 PM

the example in that section should work out of the box ?

M

Max (@rozenmd)•4/11/24, 4:52 PM

yep

M

Max (@rozenmd)•4/11/24, 4:52 PM

there's also a reference doc here https://developers.cloudflare.com/d1/build-with-d1/d1-client-api/#query-statement-methods

MMax (@rozenmd)there's also a reference doc here https://developers.cloudflare.com/d1/build-wit...

I

Iaci•4/11/24, 5:00 PM

i am only able to upload code through the worker web editor, how am i able to set envs so that it know which db should it interact with ?

I

Iaci•4/11/24, 5:00 PM

by that i mean i have no access to a terminal rn

M

Max (@rozenmd)•4/11/24, 5:01 PM

you should be able to bind a DB to the Worker via the dashboard

M

Max (@rozenmd)•4/11/24, 5:01 PM

it'd be in Worker settings or something

MMax (@rozenmd)it'd be in Worker settings or something

I

Iaci•4/11/24, 5:17 PM

yep, got it, thanks !

Original message was deleted

M

mau•4/11/24, 6:50 PM

I deployed the database in Asia performance is still the same.

M

Max (@rozenmd)•4/11/24, 7:23 PM

not sure it makes sense to perf test D1 before it has read replication

M

Miloš•4/11/24, 8:38 PM

We'll be building our app on top of D1 and I was just wondering when dynamic bindings and read replicas are going to be released. Ofc not asking for exact date, but do you think it'll be within next two months?

V

Varna•4/12/24, 9:57 AM

What do you think of this improvement idea on migrations CLI?
https://gist.github.com/varna/07334fac76e4479a2fc950051131a34c

Gist

Idea on making Cloudflare wrangler CLI for D1 migrations better exp...

Idea on making Cloudflare wrangler CLI for D1 migrations better experience. - wrangler-d1-migrations.md

A

arsengoian•4/12/24, 11:00 AM

Hi everyone! Is this a bug? I'm trying to delete ca. 8 million rows.

VVarna What do you think of this improvement idea on migrations CLI? https://gist.githu...

A

arsengoian•4/12/24, 11:01 AM

Looks good to me, I especially agree with the "Scary defaults" part. But it's important that the non-interactive options remain (e.g. apply) for CI pipelines. It's also important that the behavior is uniform among other wrangler commands.

VVarna What do you think of this improvement idea on migrations CLI? https://gist.githu...

M

Max (@rozenmd)•4/12/24, 11:19 AM