does this make sense? like the main benefit would be that the discord bot wouldnt be using http call

Ooof2win2 does this make sense? like the main benefit would be that the discord bot wouldn...

B

Beny•4/13/24, 5:00 PM

Yes that would be good, no point having 2 copies of the same code

O

oof2win2OP•4/13/24, 5:01 PM

hmm ill think it over

O

oof2win2OP•4/13/24, 5:01 PM

might be weird with auth and file uploads

O

oof2win2OP•4/13/24, 5:01 PM

thanks though, at least im not going insane

O

onnimonni•4/13/24, 7:16 PM

Has someone created tests for scheduled workers with correct typing?

I'm trying to create a test for my scheduled worker and the default typing for a scheduled worker seems to work like this:

async scheduled(event: ScheduledEvent, env: Env, ctx: ExecutionContext): Promise<void> {
        console.log('This is a scheduled event');
    },

async scheduled(event: ScheduledEvent, env: Env, ctx: ExecutionContext): Promise<void> {
        console.log('This is a scheduled event');
    },

async scheduled(event: ScheduledEvent, env: Env, ctx: ExecutionContext): Promise<void> {
        console.log('This is a scheduled event');
    },

async scheduled(event: ScheduledEvent, env: Env, ctx: ExecutionContext): Promise<void> {
        console.log('This is a scheduled event');
    },

When I want to call this

scheluded

scheluded

scheluded

scheluded in my test I did this:

it("scheduled event logs 'This is a scheduled event'", async () => {
            const controller = createScheduledController({
                scheduledTime: new Date(1000),
                cron: "30 * * * *",
            });
            const ctx = createExecutionContext();
            await worker.scheduled(controller, env, ctx);
            await waitOnExecutionContext(ctx);
            expect(ctx.log).toMatchInlineSnapshot(`"This is a scheduled event"`);
        });

it("scheduled event logs 'This is a scheduled event'", async () => {
            const controller = createScheduledController({
                scheduledTime: new Date(1000),
                cron: "30 * * * *",
            });
            const ctx = createExecutionContext();
            await worker.scheduled(controller, env, ctx);
            await waitOnExecutionContext(ctx);
            expect(ctx.log).toMatchInlineSnapshot(`"This is a scheduled event"`);
        });

it("scheduled event logs 'This is a scheduled event'", async () => {
            const controller = createScheduledController({
                scheduledTime: new Date(1000),
                cron: "30 * * * *",
            });
            const ctx = createExecutionContext();
            await worker.scheduled(controller, env, ctx);
            await waitOnExecutionContext(ctx);
            expect(ctx.log).toMatchInlineSnapshot(`"This is a scheduled event"`);
        });

it("scheduled event logs 'This is a scheduled event'", async () => {
            const controller = createScheduledController({
                scheduledTime: new Date(1000),
                cron: "30 * * * *",
            });
            const ctx = createExecutionContext();
            await worker.scheduled(controller, env, ctx);
            await waitOnExecutionContext(ctx);
            expect(ctx.log).toMatchInlineSnapshot(`"This is a scheduled event"`);
        });

The typing seems to want an

ScheduledEvent

ScheduledEvent

ScheduledEvent

ScheduledEvent but I didn't find anyway to mock those. The only related mocking function seems to be

createScheduledController

createScheduledController

createScheduledController

createScheduledController but it's type is

 ScheduledController

ScheduledController

 ScheduledController

ScheduledController which is similiar but not the same.

O

onnimonni•4/13/24, 7:17 PM

Second question is that can I somehow test the side effects of the function like what it logs?

The scheduled functions don't return anything so testing the return values is impossible

O

onnimonni•4/13/24, 7:24 PM

Well I was able to fix this by allowing either

ScheduledController

ScheduledController

ScheduledController

ScheduledController or

ScheduledEvent

ScheduledEvent

ScheduledEvent

ScheduledEvent typing in the scheduled event and by following this stackoverflow answer on testing the logging: https://stackoverflow.com/questions/76042978/in-vitest-how-do-i-assert-that-a-console-log-happened

Stack Overflow

In Vitest, how do I assert that a console.log() happened?

The question's in the title. With Jest it was console.log = jest.fn(). How do I get and analyse the console output of the code I'm testing?

Kkian await scheduler.wait(ms)

S

Shravan•4/13/24, 11:21 PM

is there any difference between scheduler.wait and

export const sleep = (ms: number): Promise<void> => {
    return new Promise<void>((resolve) => setTimeout(resolve, ms));
};

export const sleep = (ms: number): Promise<void> => {
    return new Promise<void>((resolve) => setTimeout(resolve, ms));
};

export const sleep = (ms: number): Promise<void> => {
    return new Promise<void>((resolve) => setTimeout(resolve, ms));
};

export const sleep = (ms: number): Promise<void> => {
    return new Promise<void>((resolve) => setTimeout(resolve, ms));
};

and how they work in workers?

SShravan is there any difference between scheduler.wait and `export const sleep = (ms: n...

B

Beny•4/14/24, 12:23 AM

I think it fixes Date.now() if I remember correctly

BBeny I think it fixes Date.now() if I remember correctly

S

Shravan•4/14/24, 1:29 AM

you mean if we use date.now after scheduler.wait?

U

Unsmart•4/14/24, 1:34 AM

Its just an awaitable alternative of setTimeout. So its basically exactly the same.

A

Armaan from Armenia•4/14/24, 6:54 AM

how do I get rid of this for the dev to challenge?

A

Armaan from Armenia•4/14/24, 6:54 AM

deadline is 6 minutes away and I used it all

A

Armaan from Armenia•4/14/24, 6:54 AM

help

AArmaan from Armenia how do I get rid of this for the dev to challenge?

O

onnimonni•4/14/24, 9:01 AM

Read the error. You have already used your free quota. Sign up for the paid workers plan for 5$. You can stop using it when you don't need it anymore.

Oonnimonni Read the error. You have already used your free quota. Sign up for the paid work...

A

Armaan from Armenia•4/14/24, 9:20 AM

Thank you so much! Updated!:D

M

Migmac•4/14/24, 12:50 PM

Where can I submit a feature-request / extension / suggestion?

E

Erisa•4/14/24, 12:51 PM

#workers-feature-suggestions

M

Migmac•4/14/24, 12:51 PM

Thank yoU!

N

neoney•4/14/24, 8:28 PM

Worker supposed to run every minute on cron

all recent triggers have been erroring, trying to debug, does not seem to be running anymore

N

neoney•4/14/24, 8:29 PM

ive been tailing for 6 minutes

N

neoney•4/14/24, 8:29 PM

no logs

N

neoney•4/14/24, 8:30 PM

does tail not show logs from cron?

W

Walshy•4/14/24, 8:38 PM

tail does show

W

Walshy•4/14/24, 8:39 PM

Are you on a paid plan?

W

Walshy•4/14/24, 8:39 PM

you're averaging a lot of cpu time per execution

WWalshy Are you on a paid plan?

N

neoney•4/14/24, 8:47 PM

yes

WWalshy you're averaging a lot of cpu time per execution

N

neoney•4/14/24, 8:47 PM

yeah its a worker that goes through all database stuff that hasnt been processed and sends webhooks

N

neoney•4/14/24, 8:47 PM

ive added a try catch over the main functions

N

neoney•4/14/24, 8:47 PM

and deployed it

N

neoney•4/14/24, 8:47 PM

suddenly its green, and i have logs

N

neoney•4/14/24, 8:48 PM

and no logs errored

N

neoney•4/14/24, 8:48 PM

:thinkRoll:

W

Walshy•4/14/24, 8:48 PM

yeah tail should be fine, i can check one of my workers real quick

N

neoney•4/14/24, 8:48 PM

no clue what that was about.

N

neoney•4/14/24, 8:48 PM

tail working now

N

neoney•4/14/24, 8:48 PM

the worker wasnt working for like a day i think

N

neoney•4/14/24, 8:48 PM

ended up with

  (warn) Log size limit exceeded: More than 128KB of data (across console.log statements, exception, request metadata and headers) was logged during a single request. Subsequent data for this request will not be recorded in logs, appear when tailing this Worker's logs, or in Tail Workers.

  (warn) Log size limit exceeded: More than 128KB of data (across console.log statements, exception, request metadata and headers) was logged during a single request. Subsequent data for this request will not be recorded in logs, appear when tailing this Worker's logs, or in Tail Workers.

  (warn) Log size limit exceeded: More than 128KB of data (across console.log statements, exception, request metadata and headers) was logged during a single request. Subsequent data for this request will not be recorded in logs, appear when tailing this Worker's logs, or in Tail Workers.

  (warn) Log size limit exceeded: More than 128KB of data (across console.log statements, exception, request metadata and headers) was logged during a single request. Subsequent data for this request will not be recorded in logs, appear when tailing this Worker's logs, or in Tail Workers.

because it did so much at once lol

W

Walshy•4/14/24, 8:49 PM

haha

N

neoney•4/14/24, 8:52 PM

actually something's still wrong with it

N

neoney•4/14/24, 8:52 PM

but the code might be wrong

N

neoney•4/14/24, 8:52 PM

ill research whats goign on

N

neoney•4/14/24, 8:53 PM

N

neoney•4/14/24, 8:53 PM

this is mostly time waiting for fetch tho, so should be fine?

N

neoney•4/14/24, 8:53 PM

right?

W

Walshy•4/14/24, 8:53 PM

yep

N

neoney•4/14/24, 8:55 PM

lmao

N

neoney•4/14/24, 8:55 PM

coworker typed a var as any and db field names were outdated

N

neoney•4/14/24, 8:55 PM

hopefully works now

N

neoney•4/14/24, 9:48 PM

When I deploy a worker with wrangler, all variables will get reset to the ones in wrangler.toml, except for ones that have been encrypted?

does this make sense? like the main benefit would be that the discord bot wouldnt be using http call

Similar Threads

Similar Threads

Similar Threads