does it matter, if I don't check any part of it, only the hostname and query params?

Nneoney does it matter, if I don't check any part of it, only the hostname and query par...

H

Hello, I’m Allie!•4/17/24, 4:38 PM

It just needs to be a valid URL. Though, with the new RPC APIs, you don't have to pass in a URL at all

H

Hello, I’m Allie!•4/17/24, 4:38 PM

You can just call a function directly on the stub

N

neoneyOP•4/17/24, 4:38 PM

not using RPC yet

N

neoneyOP•4/17/24, 4:38 PM

soo

N

neoneyOP•4/17/24, 4:38 PM

I can do something like this?

N

neoneyOP•4/17/24, 4:38 PM

const lockId = env.LOCK.idFromString(`${storeId}-${data.userEmail}`);
    const lock = env.LOCK.get(lockId);

    const lockUrl = new URL("http://0.0.0.0/lock");
    lockUrl.searchParams.set("durationSecs", "30");
    const lockResponse = await lock.fetch(lockUrl.toString());

    if (lockResponse.status !== 204)
      return new Error("Request being processed.");

const lockId = env.LOCK.idFromString(`${storeId}-${data.userEmail}`);
    const lock = env.LOCK.get(lockId);

    const lockUrl = new URL("http://0.0.0.0/lock");
    lockUrl.searchParams.set("durationSecs", "30");
    const lockResponse = await lock.fetch(lockUrl.toString());

    if (lockResponse.status !== 204)
      return new Error("Request being processed.");

const lockId = env.LOCK.idFromString(`${storeId}-${data.userEmail}`);
    const lock = env.LOCK.get(lockId);

    const lockUrl = new URL("http://0.0.0.0/lock");
    lockUrl.searchParams.set("durationSecs", "30");
    const lockResponse = await lock.fetch(lockUrl.toString());

    if (lockResponse.status !== 204)
      return new Error("Request being processed.");

const lockId = env.LOCK.idFromString(`${storeId}-${data.userEmail}`);
    const lock = env.LOCK.get(lockId);

    const lockUrl = new URL("http://0.0.0.0/lock");
    lockUrl.searchParams.set("durationSecs", "30");
    const lockResponse = await lock.fetch(lockUrl.toString());

    if (lockResponse.status !== 204)
      return new Error("Request being processed.");

N

neoneyOP•4/17/24, 4:38 PM

where the fetch handler in the DO is

N

neoneyOP•4/17/24, 4:38 PM

async fetch(request: Request) {
    const url = new URL(request.url);

    switch (url.pathname) {
      case "/unlock": {
        await this.state.storage.delete("lock");
        return new Response(null, {
          status: 204,
        });
      }
      case "/lock": {
        const lockedUntil = await this.state.storage.get<number>("lock");
        if (lockedUntil && lockedUntil > Date.now())
          return new Response(null, {
            status: 409,
          });

        const durationSecsString = url.searchParams.get("durationSecs");
        if (!durationSecsString)
          return new Response(null, {
            status: 400,
          });
        const durationSecsNumber = parseInt(durationSecsString);
        if (
          !Number.isSafeInteger(durationSecsNumber) ||
          durationSecsNumber <= 0
        )
          return new Response(null, {
            status: 400,
          });

        await this.state.storage.put("lock", Date.now());

        return new Response(null, {
          status: 204,
        });
      }
    }
  }

async fetch(request: Request) {
    const url = new URL(request.url);

    switch (url.pathname) {
      case "/unlock": {
        await this.state.storage.delete("lock");
        return new Response(null, {
          status: 204,
        });
      }
      case "/lock": {
        const lockedUntil = await this.state.storage.get<number>("lock");
        if (lockedUntil && lockedUntil > Date.now())
          return new Response(null, {
            status: 409,
          });

        const durationSecsString = url.searchParams.get("durationSecs");
        if (!durationSecsString)
          return new Response(null, {
            status: 400,
          });
        const durationSecsNumber = parseInt(durationSecsString);
        if (
          !Number.isSafeInteger(durationSecsNumber) ||
          durationSecsNumber <= 0
        )
          return new Response(null, {
            status: 400,
          });

        await this.state.storage.put("lock", Date.now());

        return new Response(null, {
          status: 204,
        });
      }
    }
  }

async fetch(request: Request) {
    const url = new URL(request.url);

    switch (url.pathname) {
      case "/unlock": {
        await this.state.storage.delete("lock");
        return new Response(null, {
          status: 204,
        });
      }
      case "/lock": {
        const lockedUntil = await this.state.storage.get<number>("lock");
        if (lockedUntil && lockedUntil > Date.now())
          return new Response(null, {
            status: 409,
          });

        const durationSecsString = url.searchParams.get("durationSecs");
        if (!durationSecsString)
          return new Response(null, {
            status: 400,
          });
        const durationSecsNumber = parseInt(durationSecsString);
        if (
          !Number.isSafeInteger(durationSecsNumber) ||
          durationSecsNumber <= 0
        )
          return new Response(null, {
            status: 400,
          });

        await this.state.storage.put("lock", Date.now());

        return new Response(null, {
          status: 204,
        });
      }
    }
  }

async fetch(request: Request) {
    const url = new URL(request.url);

    switch (url.pathname) {
      case "/unlock": {
        await this.state.storage.delete("lock");
        return new Response(null, {
          status: 204,
        });
      }
      case "/lock": {
        const lockedUntil = await this.state.storage.get<number>("lock");
        if (lockedUntil && lockedUntil > Date.now())
          return new Response(null, {
            status: 409,
          });

        const durationSecsString = url.searchParams.get("durationSecs");
        if (!durationSecsString)
          return new Response(null, {
            status: 400,
          });
        const durationSecsNumber = parseInt(durationSecsString);
        if (
          !Number.isSafeInteger(durationSecsNumber) ||
          durationSecsNumber <= 0
        )
          return new Response(null, {
            status: 400,
          });

        await this.state.storage.put("lock", Date.now());

        return new Response(null, {
          status: 204,
        });
      }
    }
  }

N

neoneyOP•4/17/24, 4:39 PM

If I'm understanding right, I don't need to worry about the lock ID in the actual DO

N

neoneyOP•4/17/24, 4:39 PM

right?

N

neoneyOP•4/17/24, 4:39 PM

it's gonna be a separate object for a different userId

Nneoney ```ts const lockId = env.LOCK.idFromString(`${storeId}-${data.userEmail}`); ...

H

Hello, I’m Allie!•4/17/24, 4:39 PM

That looks fine?

N

neoneyOP•4/17/24, 4:39 PM

Thanks

N

neoneyOP•4/17/24, 4:39 PM

Just checking

N

neoneyOP•4/17/24, 4:39 PM

hope it works in dev mode now..

N

neoneyOP•4/17/24, 4:46 PM

[TypeError: Invalid Durable Object ID: must be 64 hex digits]

N

neoneyOP•4/17/24, 4:46 PM

interesting

N

neoneyOP•4/17/24, 4:46 PM

i guess idFromName is a better choice there

Nneoney [TypeError: Invalid Durable Object ID: must be 64 hex digits]

H

Hello, I’m Allie!•4/17/24, 4:46 PM

Oh yeah, missed that.

idFromString

idFromString

idFromString

idFromString only accepts the result of an

id.toString()

id.toString()

id.toString()

id.toString()

N

neoneyOP•4/17/24, 4:47 PM

Ah okay

N

neoneyOP•4/17/24, 4:47 PM

Welp

N

neoneyOP•4/17/24, 4:47 PM

I be getting a 503 response

N

neoneyOP•4/17/24, 4:47 PM

Might be broken in dev

N

neoneyOP•4/17/24, 4:47 PM

next-on-pages moment

N

neoneyOP•4/17/24, 4:47 PM

not sure if it reads wrangler.toml properly...

N

neoneyOP•4/17/24, 5:41 PM

why cant i add bindings

N

neoneyOP•4/17/24, 5:41 PM

https://developers.cloudflare.com/pages/functions/bindings/#durable-objects says i should be able to

Cloudflare Docs

Bindings · Cloudflare Pages docs

A binding enables your Pages Functions to interact with resources on the Cloudflare developer platform. Use bindings to integrate your Pages Functions …

N

neoneyOP•4/17/24, 5:43 PM

suddenly the button appeared after I redeployed project

N

neoneyOP•4/17/24, 5:43 PM

idk

N

neoneyOP•4/17/24, 6:01 PM

works in prod

N

neoneyOP•4/17/24, 6:01 PM

def can recommend these locks

N

neoneyOP•4/17/24, 6:01 PM

even wrote some nice utils for them

N

neoneyOP•4/17/24, 6:01 PM

export enum LockResult {
  Success,
  AlreadyLocked,
}

export class Lock {
  private lockId: DurableObjectId;
  private stub: DurableObjectStub;

  constructor(name: string, cloudflareEnv: CloudflareEnv) {
    this.lockId = cloudflareEnv.LOCK.idFromName(name);
    this.stub = cloudflareEnv.LOCK.get(this.lockId);
  }

  async unlock() {
    const unlockUrl = new URL("http://0.0.0.0/unlock");
    const response = await this.stub.fetch(unlockUrl.toString());

    if (response.status !== 204) throw new Error(await response.text());
  }

  async lock(durationSecs: number) {
    const lockUrl = new URL("http://0.0.0.0/lock");
    lockUrl.searchParams.set("durationSecs", durationSecs.toFixed(0));
    const response = await this.stub.fetch(lockUrl.toString());

    if (response.status === 204) return LockResult.Success;
    if (response.status === 409) return LockResult.AlreadyLocked;

    throw new Error(await response.text());
  }
}

export class LockError extends Error {
  constructor(msg: string) {
    super(msg);

    // Set the prototype explicitly.
    Object.setPrototypeOf(this, LockError.prototype);
  }
}

export async function withLock<T>(
  name: string,
  cloudflareEnv: CloudflareEnv,
  lockExpirySecs: number,
  fn: () => T,
  unlockOnEnd = true,
): Promise<T> {
  const lock = new Lock(name, cloudflareEnv);

  const lockResult = await lock.lock(lockExpirySecs);

  if (lockResult === LockResult.AlreadyLocked)
    throw new LockError("Lock is already locked.");

  try {
    return fn();
  } finally {
    if (unlockOnEnd) await lock.unlock();
  }
}

export enum LockResult {
  Success,
  AlreadyLocked,
}

export class Lock {
  private lockId: DurableObjectId;
  private stub: DurableObjectStub;

  constructor(name: string, cloudflareEnv: CloudflareEnv) {
    this.lockId = cloudflareEnv.LOCK.idFromName(name);
    this.stub = cloudflareEnv.LOCK.get(this.lockId);
  }

  async unlock() {
    const unlockUrl = new URL("http://0.0.0.0/unlock");
    const response = await this.stub.fetch(unlockUrl.toString());

    if (response.status !== 204) throw new Error(await response.text());
  }

  async lock(durationSecs: number) {
    const lockUrl = new URL("http://0.0.0.0/lock");
    lockUrl.searchParams.set("durationSecs", durationSecs.toFixed(0));
    const response = await this.stub.fetch(lockUrl.toString());

    if (response.status === 204) return LockResult.Success;
    if (response.status === 409) return LockResult.AlreadyLocked;

    throw new Error(await response.text());
  }
}

export class LockError extends Error {
  constructor(msg: string) {
    super(msg);

    // Set the prototype explicitly.
    Object.setPrototypeOf(this, LockError.prototype);
  }
}

export async function withLock<T>(
  name: string,
  cloudflareEnv: CloudflareEnv,
  lockExpirySecs: number,
  fn: () => T,
  unlockOnEnd = true,
): Promise<T> {
  const lock = new Lock(name, cloudflareEnv);

  const lockResult = await lock.lock(lockExpirySecs);

  if (lockResult === LockResult.AlreadyLocked)
    throw new LockError("Lock is already locked.");

  try {
    return fn();
  } finally {
    if (unlockOnEnd) await lock.unlock();
  }
}

export enum LockResult {
  Success,
  AlreadyLocked,
}

export class Lock {
  private lockId: DurableObjectId;
  private stub: DurableObjectStub;

  constructor(name: string, cloudflareEnv: CloudflareEnv) {
    this.lockId = cloudflareEnv.LOCK.idFromName(name);
    this.stub = cloudflareEnv.LOCK.get(this.lockId);
  }

  async unlock() {
    const unlockUrl = new URL("http://0.0.0.0/unlock");
    const response = await this.stub.fetch(unlockUrl.toString());

    if (response.status !== 204) throw new Error(await response.text());
  }

  async lock(durationSecs: number) {
    const lockUrl = new URL("http://0.0.0.0/lock");
    lockUrl.searchParams.set("durationSecs", durationSecs.toFixed(0));
    const response = await this.stub.fetch(lockUrl.toString());

    if (response.status === 204) return LockResult.Success;
    if (response.status === 409) return LockResult.AlreadyLocked;

    throw new Error(await response.text());
  }
}

export class LockError extends Error {
  constructor(msg: string) {
    super(msg);

    // Set the prototype explicitly.
    Object.setPrototypeOf(this, LockError.prototype);
  }
}

export async function withLock<T>(
  name: string,
  cloudflareEnv: CloudflareEnv,
  lockExpirySecs: number,
  fn: () => T,
  unlockOnEnd = true,
): Promise<T> {
  const lock = new Lock(name, cloudflareEnv);

  const lockResult = await lock.lock(lockExpirySecs);

  if (lockResult === LockResult.AlreadyLocked)
    throw new LockError("Lock is already locked.");

  try {
    return fn();
  } finally {
    if (unlockOnEnd) await lock.unlock();
  }
}

export enum LockResult {
  Success,
  AlreadyLocked,
}

export class Lock {
  private lockId: DurableObjectId;
  private stub: DurableObjectStub;

  constructor(name: string, cloudflareEnv: CloudflareEnv) {
    this.lockId = cloudflareEnv.LOCK.idFromName(name);
    this.stub = cloudflareEnv.LOCK.get(this.lockId);
  }

  async unlock() {
    const unlockUrl = new URL("http://0.0.0.0/unlock");
    const response = await this.stub.fetch(unlockUrl.toString());

    if (response.status !== 204) throw new Error(await response.text());
  }

  async lock(durationSecs: number) {
    const lockUrl = new URL("http://0.0.0.0/lock");
    lockUrl.searchParams.set("durationSecs", durationSecs.toFixed(0));
    const response = await this.stub.fetch(lockUrl.toString());

    if (response.status === 204) return LockResult.Success;
    if (response.status === 409) return LockResult.AlreadyLocked;

    throw new Error(await response.text());
  }
}

export class LockError extends Error {
  constructor(msg: string) {
    super(msg);

    // Set the prototype explicitly.
    Object.setPrototypeOf(this, LockError.prototype);
  }
}

export async function withLock<T>(
  name: string,
  cloudflareEnv: CloudflareEnv,
  lockExpirySecs: number,
  fn: () => T,
  unlockOnEnd = true,
): Promise<T> {
  const lock = new Lock(name, cloudflareEnv);

  const lockResult = await lock.lock(lockExpirySecs);

  if (lockResult === LockResult.AlreadyLocked)
    throw new LockError("Lock is already locked.");

  try {
    return fn();
  } finally {
    if (unlockOnEnd) await lock.unlock();
  }
}

N

neoneyOP•4/17/24, 6:32 PM

soooo

N

neoneyOP•4/17/24, 6:32 PM

i was setting a lock for 15s

N

neoneyOP•4/17/24, 6:32 PM

and somehow

N

neoneyOP•4/17/24, 6:32 PM

it all worked fine for me

N

neoneyOP•4/17/24, 6:32 PM

yet my mate was always getting an error that the lock is locked

N

neoneyOP•4/17/24, 6:32 PM

even after waiting 15s

N

neoneyOP•4/17/24, 6:46 PM

thinking maybe the binding didnt deploy globally immediately

N

neoneyOP•4/17/24, 6:46 PM

and he was hitting some worker that didnt have the binding, thus erroring

N

neoneyOP•4/17/24, 6:46 PM

but idk, just speculating

N

neoneyOP•4/17/24, 6:46 PM

for now he made it roll it back and does not want me to push it again even though it worked fine for me and still works fine in dev

N

neoneyOP•4/17/24, 6:48 PM

would be nice if anyone knows what that could have been and could shine a light on it

N

neoneyOP•4/17/24, 7:02 PM

when I deploy my page with wrangler it returns an URL. That URL though, shows the "Nothing is here" page, and the deployments on cloudflare show as being "Queued"?
Queued for what? I uploaded everything locally...

N

neoneyOP•4/17/24, 7:04 PM

➜ wrangler pages deploy apps/page/.vercel/output/static --branch=main --project-name=<project-name>

➜ wrangler pages deploy apps/page/.vercel/output/static --branch=main --project-name=<project-name>

➜ wrangler pages deploy apps/page/.vercel/output/static --branch=main --project-name=<project-name>

➜ wrangler pages deploy apps/page/.vercel/output/static --branch=main --project-name=<project-name> gives that exact result

N

neoneyOP•4/17/24, 7:05 PM

ok, seems like one of the deployments actually worked, just need to set some env vars

1

1.1.1.1APP•4/17/24, 11:08 PM

DNS over Discord: A records

zeroline.dev A @1.1.1.1 +noall +answer

zeroline.dev A @1.1.1.1 +noall +answer

zeroline.dev A @1.1.1.1 +noall +answer

zeroline.dev A @1.1.1.1 +noall +answer

NAME         | TTL  | DATA         
-------------+------+--------------
zeroline.dev | 300s | 104.21.89.219
zeroline.dev | 300s | 172.67.165.53

NAME         | TTL  | DATA         
-------------+------+--------------
zeroline.dev | 300s | 104.21.89.219
zeroline.dev | 300s | 172.67.165.53

NAME         | TTL  | DATA         
-------------+------+--------------
zeroline.dev | 300s | 104.21.89.219
zeroline.dev | 300s | 172.67.165.53

NAME         | TTL  | DATA         
-------------+------+--------------
zeroline.dev | 300s | 104.21.89.219
zeroline.dev | 300s | 172.67.165.53

diggy diggy hole

•

4/17/24, 11:09 PM

1

1.1.1.1APP•4/17/24, 11:09 PM

DNS over Discord: A records

zeroline.dev A @1.1.1.1 +noall +answer

zeroline.dev A @1.1.1.1 +noall +answer

zeroline.dev A @1.1.1.1 +noall +answer

zeroline.dev A @1.1.1.1 +noall +answer

NAME         | TTL  | DATA         
-------------+------+--------------
zeroline.dev | 300s | 172.67.165.53
zeroline.dev | 300s | 104.21.89.219

NAME         | TTL  | DATA         
-------------+------+--------------
zeroline.dev | 300s | 172.67.165.53
zeroline.dev | 300s | 104.21.89.219

NAME         | TTL  | DATA         
-------------+------+--------------
zeroline.dev | 300s | 172.67.165.53
zeroline.dev | 300s | 104.21.89.219

NAME         | TTL  | DATA         
-------------+------+--------------
zeroline.dev | 300s | 172.67.165.53
zeroline.dev | 300s | 104.21.89.219

diggy diggy hole

•

4/17/24, 11:10 PM

D

dave•4/18/24, 2:48 PM

alright , so I'm trying to update to the new build system

does it matter, if I don't check any part of it, only the hostname and query params?

Similar Threads

Similar Threads

Similar Threads