env.ASSETS.fetch doesn't return additional headers

I have a Pages project with a worker (advanced config) that attempts to add a cookie via adding headers to the env.ASSETS.fetch call

return await env.ASSETS.fetch(request, {
  headers: {
    'Set-Cookie': `${cookie}=${jwt}; Secure`
  }
});

return await env.ASSETS.fetch(request, {
  headers: {
    'Set-Cookie': `${cookie}=${jwt}; Secure`
  }
});

return await env.ASSETS.fetch(request, {
  headers: {
    'Set-Cookie': `${cookie}=${jwt}; Secure`
  }
});

return await env.ASSETS.fetch(request, {
  headers: {
    'Set-Cookie': `${cookie}=${jwt}; Secure`
  }
});

the headers are not returned.
to sanity check if i return the following ther are:

return new Response(null, {
  headers: {
    'Set-Cookie': `${cookie}=${jwt}; Secure`
  }
});

return new Response(null, {
  headers: {
    'Set-Cookie': `${cookie}=${jwt}; Secure`
  }
});

return new Response(null, {
  headers: {
    'Set-Cookie': `${cookie}=${jwt}; Secure`
  }
});

return new Response(null, {
  headers: {
    'Set-Cookie': `${cookie}=${jwt}; Secure`
  }
});

to workaround i could either redirect (with the cookies), but what i'm attempting above seems reasonable so i wonder if there's an API bug?

Rrichburdon I have a Pages project with a worker (advanced config) that attempts to add a co...

Hello, I’m Allie!•5/3/24, 5:23 PM

Not quite. Instead of returning a

Response

Response

with a

set-cookie

set-cookie

header, your code is sending the request to the

ASSETS

ASSETS

binding with a

set-cookie

set-cookie

header. You want

let res = await env.ASSETS.fetch(request);
res = new Response(res.body, res);
res.headers.set("set-cookie", `${cookie}=${jwt}; Secure`);
return res;

let res = await env.ASSETS.fetch(request);
res = new Response(res.body, res);
res.headers.set("set-cookie", `${cookie}=${jwt}; Secure`);
return res;

richburdonOP•5/3/24, 5:26 PM

hi thanks for the quick response.

richburdonOP•5/3/24, 5:26 PM

for that i got:

TS2345: Argument of type ReadableStream<any> is not assignable to parameter of type BodyInit

TS2345: Argument of type ReadableStream<any> is not assignable to parameter of type BodyInit

richburdonOP•5/3/24, 5:27 PM

i shouldn't need to await the body?

richburdonOP•5/3/24, 5:29 PM

related (TS issue) @cloudflare/workers-types doesn't export a Response type (it does for Request, etc.) so the native Node Response seems differnet from the one that the worker implements/provides?

Hello, I’m Allie!•5/3/24, 5:29 PM

It should be? https://workers-types.pages.dev/

richburdonOP•5/3/24, 5:31 PM

oh. could it be that that's been updated recently? the code isn't open source right? i'm pretty user the export was missing a couple of days ago. (but you're right it's there now).

richburdonOP•5/3/24, 5:32 PM

well, it still doesn't compile

✘ [ERROR] No matching export in "../../node_modules/.pnpm/@cloudflare+workers-types@4.20240502.0/node_modules/@cloudflare/workers-types/index.ts" for import "Response"

✘ [ERROR] No matching export in "../../node_modules/.pnpm/@cloudflare+workers-types@4.20240502.0/node_modules/@cloudflare/workers-types/index.ts" for import "Response"

Rrichburdon oh. could it be that that's been updated recently? the code isn't open source ri...

Hello, I’m Allie!•5/3/24, 5:32 PM

It is. I don't remember where the generator code lives, but the package is here: https://github.com/cloudflare/workerd/tree/main/npm/workers-types

GitHub

workerd/npm/workers-types at main · cloudflare/workerd

The JavaScript / Wasm runtime that powers Cloudflare Workers - cloudflare/workerd

Rrichburdon well, it still doesn't compile ``` ✘ [ERROR] No matching export in "../../node_...

Hello, I’m Allie!•5/3/24, 5:35 PM

Not sure why it is throwing that. Here's that exact file, and I do see

export declare class Response extends Body {

export declare class Response extends Body {

...
https://cdn.jsdelivr.net/npm/@cloudflare/workers-types@4.20240502.0/index.ts

richburdonOP•5/3/24, 5:39 PM

right. i see that.

richburdonOP•5/3/24, 5:39 PM

wrangler 3.53.0 (update available 3.53.1)

richburdonOP•5/3/24, 5:40 PM

does my tsconfig look okay?

  "compilerOptions": {
    "esModuleInterop": false,
    "allowSyntheticDefaultImports": true,
    "rootDir": ".",
    "outDir": "../../dist",
    "types": [
      "@cloudflare/workers-types",
    ]
  }

  "compilerOptions": {
    "esModuleInterop": false,
    "allowSyntheticDefaultImports": true,
    "rootDir": ".",
    "outDir": "../../dist",
    "types": [
      "@cloudflare/workers-types",
    ]
  }

richburdonOP•5/3/24, 5:41 PM

it's strange -- my IDE was reporting Response as missing last week, so i commented out the import and used casts.

import {
  type ExportedHandlerFetchHandler,
  type Fetcher,
  type Request as WorkerRequest,
  // Response
} from '@cloudflare/workers-types';

import {
  type ExportedHandlerFetchHandler,
  type Fetcher,
  type Request as WorkerRequest,
  // Response
} from '@cloudflare/workers-types';

richburdonOP•5/3/24, 5:41 PM

now the IDE isn't complaing but the build fails, so it feels like something has updated recentely and is out of sync

Rrichburdon it's strange -- my IDE was reporting Response as missing last week, so i comment...

Hello, I’m Allie!•5/3/24, 5:41 PM

If you have the

types

types

in your

tsconfig.json

tsconfig.json

, then you shouldn't need to import any types at all

richburdonOP•5/3/24, 5:42 PM

I've imported the CF Request since i wanted to access the typed cf property

Rrichburdon I've imported the CF Request since i wanted to access the typed cf property

Hello, I’m Allie!•5/3/24, 5:43 PM

request.cf

request.cf

? That should be typed automatically too

richburdonOP•5/3/24, 5:45 PM

src/auth.ts:75:31 - error TS2339: Property 'cf' does not exist on type 'Request'.

Rrichburdon src/auth.ts:75:31 - error TS2339: Property 'cf' does not exist on type 'Request'...

Hello, I’m Allie!•5/3/24, 5:46 PM

Is that a Node/DOM

Request

Request

too?

richburdonOP•5/3/24, 5:47 PM

that's the main request handler.

richburdonOP•5/3/24, 5:47 PM

(request: Request, env: Env, c)

Rrichburdon that's the main request handler.

Hello, I’m Allie!•5/3/24, 5:47 PM

Yeah, I think it is using a DOM/Node Request, rather than the CF Request

Hello, I’m Allie!•5/3/24, 5:48 PM

Per your

tsconfig

tsconfig

it should use the CF request, but iirc some depencies can override your config(for some dumb reason)

richburdonOP•5/3/24, 5:52 PM

ok well my workaround is

(request as any).cf

(request as any).cf

; it's a pity since the CF TS system is really nice.

richburdonOP•5/3/24, 5:52 PM

i'll investigate what might be happening with our tsconfig that might be interfering with this.

richburdonOP•5/3/24, 5:52 PM

thanks very much for your help.

Rrichburdon ok well my workaround is `(request as any).cf`; it's a pity since the CF TS syst...

Hello, I’m Allie!•5/3/24, 5:54 PM

Just as a sanity check, if you start a new project with the following

tsconfig.json

tsconfig.json

{
  "compilerOptions": {
    "target": "esnext",
    "module": "esnext",
    "moduleResolution": "node",
    "lib": ["esnext"],
    "types": ["@cloudflare/workers-types/experimental"],
    "isolatedModules": true,
    "noEmit": true,
    "strict": true,
    "esModuleInterop": true,
  },
  "include": [
    "src",
    "types"
  ]
}

{
  "compilerOptions": {
    "target": "esnext",
    "module": "esnext",
    "moduleResolution": "node",
    "lib": ["esnext"],
    "types": ["@cloudflare/workers-types/experimental"],
    "isolatedModules": true,
    "noEmit": true,
    "strict": true,
    "esModuleInterop": true,
  },
  "include": [
    "src",
    "types"
  ]
}

, and then a

src/index.ts

src/index.ts

with the following, do you see any type errors?

export default {
  async fetch(req: Request): Promise<Response> {
    console.lof(req.cf);
    return new Response("Hello from TS Worker!");
  }
}

export default {
  async fetch(req: Request): Promise<Response> {
    console.lof(req.cf);
    return new Response("Hello from TS Worker!");
  }
}

richburdonOP•5/3/24, 5:58 PM

it'll take me a moment to set that up but i'll try that out -- do you mind if i ping you back on this.

Rrichburdon it'll take me a moment to set that up but i'll try that out -- do you mind if i ...

Hello, I’m Allie!•5/3/24, 5:59 PM

Sounds good

richburdonOP•5/6/24, 8:15 PM

hi @HardlyWorkin' i figured out the issue was that I had

"lib": ["ESNext", "DOM"]

"lib": ["ESNext", "DOM"]

in my tsconfig and the "DOM" lib overrides the CF types (for DOM Request/Response). if i now remove that then

fetch

fetch

is undefined so i'm still tracking that down.

Rrichburdon hi @HardlyWorkin' i figured out the issue was that I had`"lib": ["ESNext", "DOM"...

Hello, I’m Allie!•5/6/24, 8:32 PM

Oh yeah, that’ll do it

richburdonOP•5/6/24, 8:33 PM

the way around is to have a separate tsconfi.spec.json for the tests (e.g., for clients which require fetch). thanks again for the help.

env.ASSETS.fetch doesn't return additional headers

Similar Threads

Similar Threads

Similar Threads