Time fixes everything

F

Hi everyone, I think this is the right place to post this. I'm currently in the process or migrating from Vercel to Pages, and everything has going super smooth so far, apart from Image optimization. I use the /cdn-cgi custom loader from the dev docs:

const normalizeSrc = src => {
  return src.startsWith('/') ? src.slice(1) : src;
};

export default function cloudflareLoader ({ src, width, quality }) {
  const params = [`width=${width}`];
  if (quality) {
    params.push(`quality=${quality}`);
  }
  const paramsString = params.join(',');
  return `/cdn-cgi/image/${paramsString}/${normalizeSrc(src)}`;
};

const normalizeSrc = src => {
  return src.startsWith('/') ? src.slice(1) : src;
};

export default function cloudflareLoader ({ src, width, quality }) {
  const params = [`width=${width}`];
  if (quality) {
    params.push(`quality=${quality}`);
  }
  const paramsString = params.join(',');
  return `/cdn-cgi/image/${paramsString}/${normalizeSrc(src)}`;
};

const normalizeSrc = src => {
  return src.startsWith('/') ? src.slice(1) : src;
};

export default function cloudflareLoader ({ src, width, quality }) {
  const params = [`width=${width}`];
  if (quality) {
    params.push(`quality=${quality}`);
  }
  const paramsString = params.join(',');
  return `/cdn-cgi/image/${paramsString}/${normalizeSrc(src)}`;
};

const normalizeSrc = src => {
  return src.startsWith('/') ? src.slice(1) : src;
};

export default function cloudflareLoader ({ src, width, quality }) {
  const params = [`width=${width}`];
  if (quality) {
    params.push(`quality=${quality}`);
  }
  const paramsString = params.join(',');
  return `/cdn-cgi/image/${paramsString}/${normalizeSrc(src)}`;
};

but all optimized images return a 404 (example below)

source image (works fine):

https://summit7-media.pages.dev/splash.png

https://summit7-media.pages.dev/splash.png

https://summit7-media.pages.dev/splash.png

https://summit7-media.pages.dev/splash.png

optimized image (404 error):

https://summit7-media.pages.dev/cdn-cgi/image/width=96/splash.png

https://summit7-media.pages.dev/cdn-cgi/image/width=96/splash.png

https://summit7-media.pages.dev/cdn-cgi/image/width=96/splash.png

https://summit7-media.pages.dev/cdn-cgi/image/width=96/splash.png

is there anything I am doing wrong here? Any and all help appreciated!

FFrontline Genesis Hi everyone, I think this is the right place to post this. I'm currently in the ...

N

Nob•5/4/24, 12:46 PM

you can't use image optimization with pages.dev pages

N

Nob•5/4/24, 12:47 PM

its only with your domain

NNob you can't use image optimization with pages.dev pages

F

Frontline Genesis•5/4/24, 1:02 PM

Oh right, thanks

Ccj Time fixes everything

M

Matt•5/4/24, 6:27 PM

12 hrs later and my icon has no changed

why has time forsaken me?

MMatt 12 hrs later and my icon has no changed 😦 why has time forsaken me?

F

Frontline Genesis•5/4/24, 7:42 PM

Add ?v=2 to the end for the time being, should get browser's to refetch it. The new path should be /favicon.ico?v=2

B

bun•5/4/24, 9:01 PM

anyone using baselime with next-on-pages? if so, how?

J

James•5/4/24, 9:28 PM

nope

W

whois | API man•5/4/24, 9:45 PM

Hello! Someone told me it would be best to ask over here.

Would Dynamic Routing and Text Animations consume my daily CF Pages requests?

W

whois | API man•5/4/24, 9:46 PM

I could ask about using gifs but I think if I add them to my public directory it won’t affect

J

James•5/4/24, 9:50 PM

i'm not sure i understand what you're asking

J

James•5/4/24, 9:50 PM

it depends on how many requests your site gets

W

Walshy•5/4/24, 9:51 PM

an animation shouldn't use any server-side stuff, sounds like regular css so no, doesn't use any Function requests

W

Walshy•5/4/24, 9:51 PM

Dynamic routing depends on the framework, can be done client-side or server-side

W

Walshy•5/4/24, 9:52 PM

If it's done server-side (so with Functions) then yes it would consume Function requestions

WWalshy Dynamic routing depends on the framework, can be done client-side or server-side

W

whois | API man•5/4/24, 9:52 PM

Well… it would be NextJs lol

J

James•5/4/24, 9:52 PM

They're likely referring to dynamic routes, which would involve hitting the worker

W

Walshy•5/4/24, 9:53 PM

i missed this being the next-on-pages channel

WWalshy i missed this being the next-on-pages channel

W

whois | API man•5/4/24, 9:53 PM

ye lol…

W

Walshy•5/4/24, 9:53 PM

Yeah, I think everything in next-on-pages is classed as server-side

WWalshy Yeah, I think everything in next-on-pages is classed as server-side

W

whois | API man•5/4/24, 9:54 PM

Oh, so then for dynamic routing I must setup workers

J

James•5/4/24, 9:55 PM

@cloudflare/next-on-pages

@cloudflare/next-on-pages

creates the worker that is deployed to your Pages project for you

JJames `@cloudflare/next-on-pages` creates the worker that is deployed to your Pages pr...

W

whois | API man•5/4/24, 9:55 PM

I think I don’t have that yet… somehow my web is deployed without using that…

W

whois | API man•5/4/24, 9:56 PM

I will still know how to use it and implement it

JJames `@cloudflare/next-on-pages` creates the worker that is deployed to your Pages pr...

W

whois | API man•5/4/24, 9:56 PM

So basically I need to add it to my dynamic route file? “file/[id].tsx”?

J

James•5/4/24, 9:57 PM

No, it's a tool that you can use when building your app. It's typically used as part of the build command in your Pages project settings

JJames No, it's a tool that you can use when building your app. It's typically used as ...

W

whois | API man•5/4/24, 9:58 PM

Oh so then I don’t have to add anything?

W

whois | API man•5/4/24, 9:58 PM

It is automatic?

J

James•5/4/24, 9:59 PM

It depends on if you chose the Next.js option when creating your Pages project. You can go to your project -> settings -> build & deployments -> build configuration to check your build command

JJames It depends on if you chose the Next.js option when creating your Pages project. ...

W

whois | API man•5/4/24, 10:06 PM

Well uhh my build command is npx @cloudflare/next-on-pages@1

J

James•5/4/24, 10:06 PM

Then it should be all good

F

florent•5/5/24, 2:20 PM

Do filesystem packages like

fast-glob

fast-glob

fast-glob

fast-glob work on next-on-pages?

J

James•5/5/24, 2:41 PM

the node fs module will not work on workerd

J

James•5/5/24, 2:42 PM

so if it interacts with the filesystem, it wont work

Bbun anyone using baselime with next-on-pages? if so, how?

V

vmg•5/6/24, 4:02 AM

How do i get this github action to deploy to production instead of preview?

name: Deploy
on:
  push:
    branches:
      - 'releases/**'
jobs:
  deploy:
    runs-on: ubuntu-latest
    permissions:
      contents: read
      deployments: write
    steps:
      - name: Checkout code
        uses: actions/checkout@v3
      - uses: pnpm/action-setup@v2
        with:
          version: 8
      - uses: actions/setup-node@v3
        with:
          node-version: 20
          cache: 'pnpm'
      - name: Install dependencies
        run: pnpm install --frozen-lockfile
      #
      # Build web app
      #
      - name: Build web
        run: pnpm run pages:build
      #
      # Deploy to Cloudflare Pages
      #
      - name: Publish
        uses: cloudflare/pages-action@1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          projectName: project-name
          directory: .vercel/output/static
          gitHubToken: ${{ secrets.GITHUB_TOKEN }}

name: Deploy
on:
  push:
    branches:
      - 'releases/**'
jobs:
  deploy:
    runs-on: ubuntu-latest
    permissions:
      contents: read
      deployments: write
    steps:
      - name: Checkout code
        uses: actions/checkout@v3
      - uses: pnpm/action-setup@v2
        with:
          version: 8
      - uses: actions/setup-node@v3
        with:
          node-version: 20
          cache: 'pnpm'
      - name: Install dependencies
        run: pnpm install --frozen-lockfile
      #
      # Build web app
      #
      - name: Build web
        run: pnpm run pages:build
      #
      # Deploy to Cloudflare Pages
      #
      - name: Publish
        uses: cloudflare/pages-action@1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          projectName: project-name
          directory: .vercel/output/static
          gitHubToken: ${{ secrets.GITHUB_TOKEN }}

name: Deploy
on:
  push:
    branches:
      - 'releases/**'
jobs:
  deploy:
    runs-on: ubuntu-latest
    permissions:
      contents: read
      deployments: write
    steps:
      - name: Checkout code
        uses: actions/checkout@v3
      - uses: pnpm/action-setup@v2
        with:
          version: 8
      - uses: actions/setup-node@v3
        with:
          node-version: 20
          cache: 'pnpm'
      - name: Install dependencies
        run: pnpm install --frozen-lockfile
      #
      # Build web app
      #
      - name: Build web
        run: pnpm run pages:build
      #
      # Deploy to Cloudflare Pages
      #
      - name: Publish
        uses: cloudflare/pages-action@1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          projectName: project-name
          directory: .vercel/output/static
          gitHubToken: ${{ secrets.GITHUB_TOKEN }}

name: Deploy
on:
  push:
    branches:
      - 'releases/**'
jobs:
  deploy:
    runs-on: ubuntu-latest
    permissions:
      contents: read
      deployments: write
    steps:
      - name: Checkout code
        uses: actions/checkout@v3
      - uses: pnpm/action-setup@v2
        with:
          version: 8
      - uses: actions/setup-node@v3
        with:
          node-version: 20
          cache: 'pnpm'
      - name: Install dependencies
        run: pnpm install --frozen-lockfile
      #
      # Build web app
      #
      - name: Build web
        run: pnpm run pages:build
      #
      # Deploy to Cloudflare Pages
      #
      - name: Publish
        uses: cloudflare/pages-action@1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          projectName: project-name
          directory: .vercel/output/static
          gitHubToken: ${{ secrets.GITHUB_TOKEN }}

Vvmg How do i get this github action to deploy to production instead of preview? ```...

B

bun•5/6/24, 7:46 AM

First, you swap out pnpm with bun, then idk? Seems to be right

JJames so if it interacts with the filesystem, it wont work

F

florent•5/6/24, 8:52 AM

so anything that uses

fs

fs

fs

fs does not work within cloudflare pages?

Fflorent so anything that uses `fs` does not work within cloudflare pages?

J

James•5/6/24, 10:23 AM

correct, next.js won't actually let you build if you're trying to use fs and using the edge runtime.

JJames correct, next.js won't actually let you build if you're trying to use fs and usi...

F

florent•5/6/24, 10:56 AM

tysm!

W

whois | API man•5/6/24, 7:02 PM

Would it be a problem if I want to deploy a site that uses NextJs and Python?

V

vmg•5/6/24, 8:38 PM

I'm starting a greenfield project and am wondering if it makes sense to use api routes in nextjs when i could just use the functions directory which seems to have better first class support with bindings and cloudflare compatible libraries. Does anyone have an opinion on this?

Vvmg I'm starting a greenfield project and am wondering if it makes sense to use api ...

H

Hello, I’m Allie!•5/6/24, 8:44 PM

next-on-pages disables the Functions directory, so you should go with the API Routes

Wwhois | API man Would it be a problem if I want to deploy a site that uses NextJs and Python?

J

James•5/6/24, 9:07 PM

how would you use python in nextjs?

Original message was deleted

J

James•5/6/24, 9:08 PM

Have you tried creating your table? If this is when deployed, make sure you run your migrations against the remote DB. If this is local, make sure you run your migrations against your local db

JJames how would you use python in nextjs?

W

whois | API man•5/6/24, 9:09 PM

Python as backend

W

whois | API man•5/6/24, 9:09 PM

Well, not the whole backend

W

whois | API man•5/6/24, 9:09 PM

But part of it

J

James•5/6/24, 9:11 PM

But Next.js needs to run in a javascript environment so I'm not sure how that could work if you wanted to deploy them to the same worker. They'd need to be separate

JJames But Next.js needs to run in a javascript environment so I'm not sure how that co...

W

whois | API man•5/6/24, 10:32 PM

alr…

W

whois | API man•5/6/24, 10:32 PM

Well uhh

Similar Threads

Similar Threads

Similar Threads