https://github.com/cloudflare/workers-sdk/issues/5788

B

blindChicken•5/8/24, 9:32 PM

@HardlyWorkin' It appears to have worked. The binding found worker and called the method. I made a mistake in my code, but that will be quickly fixed.

S

Steven•5/8/24, 9:56 PM

Hi all, I have a quick questions, I currently have a Worker that is responsible for putting json's in KV that will be read from a Cloudflare pages project. The idea is to prepopulate the cache in order to get super fast pages. At the moment I created a worker that runs fine locally and can add a few thousand entries into my local wrangler state. However after deploying the worker I hit the limit of 50 subrequests. I think I can rewrite the worker to use a queue and split up the work, thus reducing the number of subrequests. But I'm wondering what the best approach is for my use case?

HHello, I’m Allie!https://github.com/cloudflare/workers-sdk/issues/5788

I

Isaac McFadyen•5/8/24, 10:02 PM

Looks like a duplicate of https://github.com/cloudflare/workers-sdk/issues/5663

GitHub

🐛 BUG: hacky modules detection doesn't work remarkably well in prac...

Which Cloudflare product(s) does this pertain to? Wrangler core What version(s) of the tool(s) are you using? 3.51.2 What version of Node are you using? No response What operating system and versio...

IIsaac McFadyen Looks like a duplicate of https://github.com/cloudflare/workers-sdk/issues/5663

H

Hello, I’m Allie!OP•5/8/24, 10:05 PM

Not quite? As far as I can tell, it is detecting it is a Module Syntax Worker, it just complains that it doesn’t have any handlers

H

Hello, I’m Allie!OP•5/8/24, 10:05 PM

Because I am doing export default

HHello, I’m Allie!Not quite? As far as I can tell, it is detecting it is a Module Syntax Worker, i...

I

Isaac McFadyen•5/8/24, 10:06 PM

Yeah but if you scroll down a while in that Issue Kian discusses needing a

fetch

fetch

fetch

fetch even if you have

export default {}

export default {}

export default {}

export default {}

I

Isaac McFadyen•5/8/24, 10:07 PM

Plus some other people chiming in

I

Isaac McFadyen•5/8/24, 10:07 PM

https://github.com/cloudflare/workers-sdk/issues/5663#issuecomment-2080991838

R

Renegade•5/9/24, 2:29 AM

how can i get the headers when using module-workers

RRenegade how can i get the headers when using module-workers

H

Hello, I’m Allie!OP•5/9/24, 7:42 AM

export default {
  fetch(req: Request) {
    const someHeader = req.headers.get("some-header");
  }
}

export default {
  fetch(req: Request) {
    const someHeader = req.headers.get("some-header");
  }
}

export default {
  fetch(req: Request) {
    const someHeader = req.headers.get("some-header");
  }
}

export default {
  fetch(req: Request) {
    const someHeader = req.headers.get("some-header");
  }
}

BBachMacintosh Can two Custom Domains from different Zones owned by the same Account (eg `api.e...

H

Hello, I’m Allie!OP•5/9/24, 8:38 AM

It should work fine, yeah

K

kelbs•5/9/24, 9:59 AM

Does anyone know if there's a rough timeline for full nodejs compatibility?

I've read docs and blog posts about compatibility, but they never mention

the APIs that still aren't implemented
the timeline for implementing them

Kkelbs Does anyone know if there's a rough timeline for full nodejs compatibility? I'v...

H

Hello, I’m Allie!OP•5/9/24, 10:08 AM

AFAIK, never. Some APIs don’t make sense in a serverless context, or the way Workers works in particular

B

Barry_Based_Benson•5/9/24, 3:07 PM

[vars]
dotenv = ".env"

in wrangler.toml how do import the vars for the cloudflare worker to use from my own .env file? currently it seems cloudflare is interpreting dotenv as its own variable rather than importing the variables

K

kian•5/9/24, 3:08 PM

All that does is set

dotenv

dotenv

dotenv

dotenv to be a string of

.env

.env

.env

.env

K

kian•5/9/24, 3:08 PM

You can't tell Wrangler to read from a

.env

.env

.env

.env file

K

kian•5/9/24, 3:08 PM

Local development will read from

.dev.vars

.dev.vars

.dev.vars

.dev.vars

Kkian Local development will read from `.dev.vars`

B

Barry_Based_Benson•5/9/24, 3:09 PM

wdym by this part?

B

Barry_Based_Benson•5/9/24, 3:09 PM

how do i use them for my own worker from my own .env? or do i just import it manually in my worker script

K

kian•5/9/24, 3:10 PM

https://developers.cloudflare.com/workers/configuration/secrets/#secrets-in-development

BBarry_Based_Benson how do i use them for my own worker from my own .env? or do i just import it man...

K

kian•5/9/24, 3:10 PM

Wrangler doesn't use .env files.

K

kian•5/9/24, 3:10 PM

You define variables in Wrangler.toml as

[vars]

[vars]

[vars]

[vars] and you upload secrets with

wrangler secret put

wrangler secret put

wrangler secret put

wrangler secret put

Kkian <https://developers.cloudflare.com/workers/configuration/secrets/#secrets-in-dev...

B

Barry_Based_Benson•5/9/24, 3:10 PM

thanks for this

HHello, I’m Allie!AFAIK, never. Some APIs don’t make sense in a serverless context, or the way Wor...

U

userzach•5/9/24, 3:15 PM

What about the crypto stuff? https://www.reddit.com/r/nextjs/comments/1ck32et/comment/l2p404o/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

Kkian Local development will read from `.dev.vars`

B

Barry_Based_Benson•5/9/24, 3:20 PM

ok so i set up a .dev.vars file with my env variables and then deployed the worker but i still don't see it showing up on the cloudflare dashboard, nor is my worker using it. Am i misunderstanding how it's meant to be used?

export interface Env {
    BUCKET_URL_AUTH_GENERATION_KEY: string;
    BUCKET_URL_SYMMETRIC_KEY: string;
}

export default {
    async fetch(request: Request, env: Env,): Promise<Response> {
        if (!env.BUCKET_URL_AUTH_GENERATION_KEY || !env.BUCKET_URL_SYMMETRIC_KEY) {
            return new Response("Missing required environment variables", { status: 500 });
        }

export interface Env {
    BUCKET_URL_AUTH_GENERATION_KEY: string;
    BUCKET_URL_SYMMETRIC_KEY: string;
}

export default {
    async fetch(request: Request, env: Env,): Promise<Response> {
        if (!env.BUCKET_URL_AUTH_GENERATION_KEY || !env.BUCKET_URL_SYMMETRIC_KEY) {
            return new Response("Missing required environment variables", { status: 500 });
        }

export interface Env {
    BUCKET_URL_AUTH_GENERATION_KEY: string;
    BUCKET_URL_SYMMETRIC_KEY: string;
}

export default {
    async fetch(request: Request, env: Env,): Promise<Response> {
        if (!env.BUCKET_URL_AUTH_GENERATION_KEY || !env.BUCKET_URL_SYMMETRIC_KEY) {
            return new Response("Missing required environment variables", { status: 500 });
        }

export interface Env {
    BUCKET_URL_AUTH_GENERATION_KEY: string;
    BUCKET_URL_SYMMETRIC_KEY: string;
}

export default {
    async fetch(request: Request, env: Env,): Promise<Response> {
        if (!env.BUCKET_URL_AUTH_GENERATION_KEY || !env.BUCKET_URL_SYMMETRIC_KEY) {
            return new Response("Missing required environment variables", { status: 500 });
        }

am i supposed to somehow use them here? how? do i change the param name or something?

K

kian•5/9/24, 3:24 PM

.dev.vars is just for local development

Kkian You define variables in Wrangler.toml as `[vars]` and you upload secrets with `w...

K

kian•5/9/24, 3:24 PM

You do this for deployed Workers

B

Barry_Based_Benson•5/9/24, 3:25 PM

so is it not possible for me to use my own .env file for production? have to do it through cli or dashboard or [vars]?

K

kian•5/9/24, 3:26 PM

Yes

B

Barry_Based_Benson•5/9/24, 3:27 PM

Thank you for you help, appreciate it

Uuserzach What about the crypto stuff? https://www.reddit.com/r/nextjs/comments/1ck32et/co...

H

Hello, I’m Allie!OP•5/9/24, 3:32 PM

Workers/Pages do have support for some of

node:crypto

node:crypto

node:crypto

node:crypto. Which modules do you need?

HHello, I’m Allie!Workers/Pages do have support for some of `node:crypto`. Which modules do you ne...

U

userzach•5/9/24, 3:43 PM

Thank you. I'm aware. The trouble is getting them to work with all the typical dependencies of a blockchain app which rely on node's crypto.
Case in point:
https://github.com/LIT-Protocol/Issues-and-Reports/issues/14#issue-2248885628

JJames After their platform got hit with security issues. I would recommend avoiding Ma...

J

jason•5/9/24, 4:35 PM

Is anything still problematic with Mailchannels (as of May 2024) given that Mailchannels has lockdown mode now? It didn't exist when the defcon presentation was made

HHello, I’m Allie!AFAIK, never. Some APIs don’t make sense in a serverless context, or the way Wor...

K

kelbs•5/9/24, 4:39 PM

where can I find more information about this?

Jjason Is anything still problematic with Mailchannels (as of May 2024) given that Mail...

J

James•5/9/24, 4:47 PM

I would still strongly recommend you avoid it. If you enable Domain Lockdown, you're protected from all known issues they had, but their responses to the situation have still been awful. They've still yet to inform all of their customers who remain unprotected because they don't do basic stuff like Sender Verification, and their platform is still vulnerable in a similar way if you sign up with any number of hosting providers that use them.

JJames I would still strongly recommend you avoid it. If you enable Domain Lockdown, yo...

I

IEatBeans•5/9/24, 4:59 PM

Yikes, do you know of any better free alternatives? I was just reading about security issues with resend, so looks like lots of them have issues

IIEatBeans Yikes, do you know of any better free alternatives? I was just reading about se...

J

James•5/9/24, 5:00 PM

"Free" and secure/reliable email sending often doesn't go together, sadly. SendGrid has a reasonable free tier at 100/day, and then Postmark is great too, but only 100 free per month.

JJames I would still strongly recommend you avoid it. If you enable Domain Lockdown, yo...

I

IEatBeans•5/9/24, 5:02 PM

Does this mean that currently this issue is still exploitable even with domain lockdown? Or do you mean that users that sign up from other providers are vulnerable, and not that that makes us (CF users) vulnerable?

IIEatBeans Does this mean that currently this issue is still exploitable even with domain l...

J

James•5/9/24, 5:03 PM

If you turn on Domain Lockdown, then it's not exploitable with your domain. But many of their customers don't have this enabled, and if you sign up with another hosting provider that uses MailChannels, you can still send emails from many of their customers that'll pass security checks, yes.

J

James•5/9/24, 5:03 PM

They used to allow self-service for just $80 where you could do this. But they quietly removed that from their site. So now you have to signup via a third-party.

J

James•5/9/24, 5:04 PM

It all just reinforces their terrible communication throughout the process, and is a partnership that I think is irresponsible for Cloudflare to upkeep, personally.

B

Barry_Based_Benson•5/10/24, 2:41 AM

const newRequest = new Request(request);

            const contentType = url.searchParams.get("content-type");
            if (contentType) {
                newRequest.headers.set("Content-Type", contentType);
            }
            
            const contentDisposition = url.searchParams.get("content-disposition");
            if (contentDisposition) {
                newRequest.headers.set("Content-Disposition", contentDisposition);
            }

            return fetch(new URL(url.pathname, `https://${requiredHostname}`), newRequest);

const newRequest = new Request(request);

            const contentType = url.searchParams.get("content-type");
            if (contentType) {
                newRequest.headers.set("Content-Type", contentType);
            }
            
            const contentDisposition = url.searchParams.get("content-disposition");
            if (contentDisposition) {
                newRequest.headers.set("Content-Disposition", contentDisposition);
            }

            return fetch(new URL(url.pathname, `https://${requiredHostname}`), newRequest);

const newRequest = new Request(request);

            const contentType = url.searchParams.get("content-type");
            if (contentType) {
                newRequest.headers.set("Content-Type", contentType);
            }
            
            const contentDisposition = url.searchParams.get("content-disposition");
            if (contentDisposition) {
                newRequest.headers.set("Content-Disposition", contentDisposition);
            }

            return fetch(new URL(url.pathname, `https://${requiredHostname}`), newRequest);

const newRequest = new Request(request);

            const contentType = url.searchParams.get("content-type");
            if (contentType) {
                newRequest.headers.set("Content-Type", contentType);
            }
            
            const contentDisposition = url.searchParams.get("content-disposition");
            if (contentDisposition) {
                newRequest.headers.set("Content-Disposition", contentDisposition);
            }

            return fetch(new URL(url.pathname, `https://${requiredHostname}`), newRequest);

How do i get content-disposition: attachment to cause my custom domain r2 to force a download instead of treating it as inline? Am i doing it wrong? it's appearing correctly in the param as attachment and i'm trying to send it as a header in the fetch request but the file is still being displayed in-browser instead of starting a download

BBarry_Based_Benson ``` const newRequest = new Request(request); const cont...

I

Isaac McFadyen•5/10/24, 4:28 AM

So content-disposition is a response header, not a request header.

I

Isaac McFadyen•5/10/24, 4:28 AM

Your need to reply with the

content-disposition

content-disposition

content-disposition

content-disposition header (it looks like you're making the request with the header, which is different)

I

Isaac McFadyen•5/10/24, 4:29 AM

You probably need to do a (untested but should work):

const res = fetch(new URL(url.pathname, `https://${requiredHostname}`));

// Clone the response because it's immutable by default.
const clonedRes = new Response(res.body, res);
clonedRes.headers.set("Content-Disposition", contentDisposition);
clonedRes.headers.set("Content-Type", contentType);

return clonedRes

const res = fetch(new URL(url.pathname, `https://${requiredHostname}`));

// Clone the response because it's immutable by default.
const clonedRes = new Response(res.body, res);
clonedRes.headers.set("Content-Disposition", contentDisposition);
clonedRes.headers.set("Content-Type", contentType);

return clonedRes

const res = fetch(new URL(url.pathname, `https://${requiredHostname}`));

// Clone the response because it's immutable by default.
const clonedRes = new Response(res.body, res);
clonedRes.headers.set("Content-Disposition", contentDisposition);
clonedRes.headers.set("Content-Type", contentType);

return clonedRes

const res = fetch(new URL(url.pathname, `https://${requiredHostname}`));

// Clone the response because it's immutable by default.
const clonedRes = new Response(res.body, res);
clonedRes.headers.set("Content-Disposition", contentDisposition);
clonedRes.headers.set("Content-Type", contentType);

return clonedRes

I

Isaac McFadyen•5/10/24, 4:30 AM

Just as a side-note, you should probably not be deciding what content-type to return based on what the client asks you to - the content-type is usually decided by what the actual content is, not what the browser wants.

I

Isaac McFadyen•5/10/24, 4:31 AM

So for example, text files should usually be returned as

text/plain

text/plain

text/plain

text/plain, in your example I could do a

contentType

contentType

contentType

contentType query param of

video/webm

video/webm

video/webm

video/webm and the browser would think my text file is a video

https://github.com/cloudflare/workers-sdk/issues/5788

Similar Threads