Just a normal `try/catch` around the subrequest

Kkian Just a normal `try/catch` around the subrequest

J

johtso•5/10/24, 1:54 PM

but how to I check if an error is a "subrequest limit exceeded" exception? is that the exact name of the exception?

e.name === "subrequest limit exceeded"

e.name === "subrequest limit exceeded"

e.name === "subrequest limit exceeded"

e.name === "subrequest limit exceeded"?

SSheng Mailchannels + CF Workers, anyone facing status 500 error, EOF when sending emai...

J

James•5/10/24, 1:57 PM

Sadly not a direct solution to your problem, but I would recommend you avoid MailChannels. Cloudflare's continued partnership with them is very disappointing after their security issues and terrible response. See https://canary.discord.com/channels/595317990191398933/779390076219686943/1226529017763463219 for more details.

Jjohtso but how to I check if an error is a "subrequest limit exceeded" exception? is th...

K

kianOP•5/10/24, 1:58 PM

export default {
  async fetch() {
    try {
      while (true) { await fetch("https://cloudflare.com/cdn-cgi/trace") }
    } catch (e) {
      return new Response(JSON.stringify(e, Object.getOwnPropertyNames(e)))
    }
  },
};

export default {
  async fetch() {
    try {
      while (true) { await fetch("https://cloudflare.com/cdn-cgi/trace") }
    } catch (e) {
      return new Response(JSON.stringify(e, Object.getOwnPropertyNames(e)))
    }
  },
};

export default {
  async fetch() {
    try {
      while (true) { await fetch("https://cloudflare.com/cdn-cgi/trace") }
    } catch (e) {
      return new Response(JSON.stringify(e, Object.getOwnPropertyNames(e)))
    }
  },
};

export default {
  async fetch() {
    try {
      while (true) { await fetch("https://cloudflare.com/cdn-cgi/trace") }
    } catch (e) {
      return new Response(JSON.stringify(e, Object.getOwnPropertyNames(e)))
    }
  },
};

K

kianOP•5/10/24, 1:58 PM

You can test it with that and see what the error is

Kkian ```js export default { async fetch() { try { while (true) { await fe...

J

johtso•5/10/24, 1:59 PM

I'm guessing it's along the lines of this? https://github.com/cloudflare/miniflare/blob/c2ed3afdc1fed9f78d5cb6c50edc793a9a43a850/packages/shared/src/context.ts#L149

J

johtso•5/10/24, 2:00 PM

which doesn't seem very amenable to being handled specifically

J

johtso•5/10/24, 2:01 PM

Is this just the javascript way? generic errors with error text?

J

johtso•5/10/24, 2:01 PM

coming from python I'm used to specific subclasses of errors

J

James•5/10/24, 2:02 PM

You absolutely can create subclasses of errors in JS, and attach things like a

code

code

, etc. but not everything does, sadly

J

johtso•5/10/24, 2:03 PM

would be nice if core cloudflare errors did this :/

J

johtso•5/10/24, 2:10 PM

{"stack":"Error: Too many subrequests.\n    at Object.fetch (worker.js:15:28)","message":"Too many subrequests."}

{"stack":"Error: Too many subrequests.\n    at Object.fetch (worker.js:15:28)","message":"Too many subrequests."}

{"stack":"Error: Too many subrequests.\n    at Object.fetch (worker.js:15:28)","message":"Too many subrequests."}

{"stack":"Error: Too many subrequests.\n    at Object.fetch (worker.js:15:28)","message":"Too many subrequests."}

J

johtso•5/10/24, 2:19 PM

and this is going to behave differently when ran locally?

J

johtso•5/10/24, 2:20 PM

@kian and do you think I can safely run that snippet locally, or will I end up spamming cloudflare?

J

johtso•5/10/24, 2:24 PM

I don't think local wrangler is respecting subrequest limits..

J

johtso•5/10/24, 2:51 PM

should I be able to test locally with the same subrequest limit behaviour? the github issues I'm seeing give the impression that it should "just work"

J

James•5/10/24, 5:34 PM

I don't believe subrequest limits are enforced at all locally

J

James•5/10/24, 5:35 PM

so that'll probably just run forever

J

johtso•5/10/24, 6:29 PM

@James that seems unfortunate? something can seem to run fine locally and then break when deployed

J

James•5/10/24, 6:29 PM

I agree, it's very much not ideal

J

James•5/10/24, 6:29 PM

https://github.com/cloudflare/workers-sdk/issues/4359 seems to be where this is tracked if you want to add your thoughts

J

johtso•5/10/24, 6:30 PM

https://github.com/cloudflare/workerd/blob/a3de83cbbd338bb64f9782f3584ec17ad6995821/src/workerd/io/limit-enforcer.h#L84

J

johtso•5/10/24, 6:30 PM

is this not being used when running locally?

J

johtso•5/10/24, 6:30 PM

oh right, workerd is the production runtime, but also used locally

W

Walshy•5/10/24, 6:31 PM

that is local but the implementation is internal, that's just the header file

W

Walshy•5/10/24, 6:34 PM

how come you're doing 1k subrequests?

C

codebam•5/10/24, 6:53 PM

did cloudflare AI just go down? I didn't change any code and I'm getting

Error: AiError: undefined: ERROR 3040: Unknown internal error

Error: AiError: undefined: ERROR 3040: Unknown internal error

Error: AiError: undefined: ERROR 3040: Unknown internal error

Error: AiError: undefined: ERROR 3040: Unknown internal error

W

Walshy•5/10/24, 6:54 PM

https://canary.discord.com/channels/595317990191398933/895794943182909470/1238495826683101194

WWalshy https://canary.discord.com/channels/595317990191398933/895794943182909470/123849...

C

codebam•5/10/24, 6:55 PM

thanks

WWalshy how come you're doing 1k subrequests?

J

johtso•5/10/24, 7:17 PM

I'm mirroring data to my d1 database from an api that only allows requesting one thing at a time

W

Walshy•5/10/24, 7:18 PM

i'd submit to a queue and process in a queue

WWalshy i'd submit to a queue and process in a queue

J

johtso•5/10/24, 7:25 PM

just seems a bit overkill.. I don't even want parallelism because I don't want to overload my API

J

johtso•5/10/24, 7:26 PM

and I don't really need a concept of a "job" or queue item because anything not already in my database is something that still needs to be fetched

J

johtso•5/10/24, 7:26 PM

alternatively I was thinking I might just run the "backfilling" as a local process on my computer

J

johtso•5/10/24, 7:27 PM

as it's quite different from the work of constantly monitoring for new data (which should only involve a few requests)

L

liam | helius.dev•5/10/24, 10:32 PM

Is anyone using workers to proxy websockets getting 502 errors currently? Suddenly all our websockets, across multiple accounts, stopped working

Lliam | helius.dev Is anyone using workers to proxy websockets getting 502 errors currently? Sudden...

W

Walshy•5/10/24, 10:53 PM

Hey, got a repro URL? and is this fully client <-> Worker or is there an origin involved?

WWalshy Hey, got a repro URL? and is this fully client <-> Worker or is there an origin ...

L

liam | helius.dev•5/10/24, 10:57 PM

Origin, normally connects to a cloudflare LB, but I have now tried arbitrary origins that support wss and it all returns 502. It also swallows our logs so its like something is broken in the upgrade path

You can try making a wss connection to here `atlas-mainnet.helius-rpc.com?

W

Walshy•5/10/24, 10:58 PM

origin is definitely up and working?

L

liam | helius.dev•5/10/24, 10:59 PM

100%, I can connect to it. I also have multiple origins across accounts that all work going to directly

L

liam | helius.dev•5/10/24, 10:59 PM

and also tried putting origins that I don't own that support wss in there and same error

W

Walshy•5/10/24, 11:00 PM

i see you have an escalation open internally already

W

Walshy•5/10/24, 11:00 PM

It's a p1 escalation, I'm tracking it now

W

Walshy•5/10/24, 11:30 PM

We've reverted the release causing this, thanks for the report and sorry for the issues @liam | helius.dev !

WWalshy We've reverted the release causing this, thanks for the report and sorry for the...

L

liam | helius.dev•5/10/24, 11:31 PM

np, ty for the help!

A

alphaβiota | Ekonavi•5/11/24, 2:59 AM

hi. is this still valid?
https://blog.cloudflare.com/sending-email-from-workers-with-mailchannels
Getting:

{"errors":["Failed to send email: 550 5.7.1 This sender is not authorized to send from <mydomain>.com. See https://bit.ly/domain-lockdown. cfid=<myworker>-ca9.workers.dev"]}

{"errors":["Failed to send email: 550 5.7.1 This sender is not authorized to send from <mydomain>.com. See https://bit.ly/domain-lockdown. cfid=<myworker>-ca9.workers.dev"]}

{"errors":["Failed to send email: 550 5.7.1 This sender is not authorized to send from <mydomain>.com. See https://bit.ly/domain-lockdown. cfid=<myworker>-ca9.workers.dev"]}

{"errors":["Failed to send email: 550 5.7.1 This sender is not authorized to send from <mydomain>.com. See https://bit.ly/domain-lockdown. cfid=<myworker>-ca9.workers.dev"]}

Thanks

The Cloudflare Blog

Send email using Workers with MailChannels

MailChannels has created an email sending service specifically for Cloudflare Workers that removes all the friction associated with sending emails.

Aalphaβiota | Ekonavi hi. is this still valid? https://blog.cloudflare.com/sending-email-from-workers-...

U

Unsmart•5/11/24, 3:02 AM

Did you go to the link the error said? Should explain what you need there

C

codebam•5/11/24, 3:05 AM

https://developers.cloudflare.com/workers/testing

what are service workers in this context? can I test regular module workers with vitest pool?

U

Unsmart•5/11/24, 3:08 AM

service workers are the old form of creating workers, module workers are the new form

U

Unsmart•5/11/24, 3:09 AM

https://developers.cloudflare.com/workers/reference/migrate-to-module-workers/#migrate-from-service-workers-to-es-modules is the migration guide and can show the differences from them

Aalphaβiota | Ekonavi hi. is this still valid? https://blog.cloudflare.com/sending-email-from-workers-...

J

James•5/11/24, 3:23 AM

Sadly not a direct solution to your problem, but I would recommend you avoid MailChannels. Cloudflare's continued partnership with them is very disappointing after their security issues and terrible response. See https://canary.discord.com/channels/595317990191398933/779390076219686943/1226529017763463219 for more details.

Just a normal `try/catch` around the subrequest

Similar Threads

Similar Threads

Similar Threads