cus says sttrings interpreted as the url

Nneoney cus says sttrings interpreted as the url

H

Basically anything that can be parsed as a URL. So

https://google.com

https://google.com

https://google.com

https://google.com should work, even though your value isn't actually being returned by Google

N

neoneyOP•6/15/24, 8:41 PM

great

N

neoneyOP•6/15/24, 8:41 PM

thats nice

N

neoneyOP•6/15/24, 8:41 PM

oh and also, to set the actual like ttl of the value

N

neoneyOP•6/15/24, 8:41 PM

i use the response headers?

N

neoneyOP•6/15/24, 8:41 PM

i implemented a "cache" with kv and honestly this looks so portable to the cache api...

Nneoney i use the response headers?

H

Hello, I’m Allie!•6/15/24, 8:45 PM

Yeah

W

Walshy•6/15/24, 9:38 PM

snippets support it but they can only do 1 subrequest per call and the cache api call counts as a subrequest

W

Walshy•6/15/24, 9:38 PM

so, you can do like a cache.match but then you couldn't also do a fetch if it wasn't in cache

W

Walshy•6/15/24, 9:39 PM

has been discussed changing this so snippets can use it but i'm not sure of any actual plans outside of that

W

Walshy•6/15/24, 9:48 PM

agree we should hence why discussions happened for it

W

Walshy•6/15/24, 9:49 PM

not sure if they got actioned and maybe that's why

W

Walshy•6/15/24, 9:49 PM

or if a limit changed

W

Walshy•6/15/24, 9:49 PM

if it works though, awesome

W

Walshy•6/15/24, 10:03 PM

can you not still pass in ctx?

W

Walshy•6/15/24, 10:05 PM

seems not

W

Walshy•6/15/24, 10:06 PM

yeah make a ticket or chat to your CSM, they can file an FR

L

lupin•6/15/24, 10:10 PM

Hi! Quick question, is there anyone else from the community experiencing the same problem lately?:

workers-and-pages-helpDeploying with keep-vars not working anymore

P

pfeffunit•6/16/24, 1:05 AM

hey folks! i'm trying to deploy my worker via the github action:

https://github.com/marketplace/actions/deploy-to-cloudflare-workers-with-wrangler

it deploys fine, but the env vars are never set.

what am i missing? i don't need to specify those names in wrangler.toml, right?

P

pfeffunit•6/16/24, 1:05 AM

just setting them in the worker itself should be fine:

export interface Env {
    DATABASE_HOST: string;
    DATABASE_USERNAME: string;
    DATABASE_PASSWORD: string;

export interface Env {
    DATABASE_HOST: string;
    DATABASE_USERNAME: string;
    DATABASE_PASSWORD: string;

export interface Env {
    DATABASE_HOST: string;
    DATABASE_USERNAME: string;
    DATABASE_PASSWORD: string;

export interface Env {
    DATABASE_HOST: string;
    DATABASE_USERNAME: string;
    DATABASE_PASSWORD: string;

P

pfeffunit•6/16/24, 1:06 AM

the very simple GH action:

P

pfeffunit•6/16/24, 1:06 AM

jobs:
  deploy:
    runs-on: ubuntu-latest
    name: Deploy
    steps:
      - uses: actions/checkout@v4
      - name: Deploy
        uses: cloudflare/wrangler-action@v3.6.1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          environment: production
        env:
          DATABASE_HOST: ${{ secrets.DATABASE_HOST }}
          DATABASE_USERNAME: ${{ secrets.DATABASE_USERNAME }}
          DATABASE_PASSWORD: ${{ secrets.DATABASE_PASSWORD }}

jobs:
  deploy:
    runs-on: ubuntu-latest
    name: Deploy
    steps:
      - uses: actions/checkout@v4
      - name: Deploy
        uses: cloudflare/wrangler-action@v3.6.1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          environment: production
        env:
          DATABASE_HOST: ${{ secrets.DATABASE_HOST }}
          DATABASE_USERNAME: ${{ secrets.DATABASE_USERNAME }}
          DATABASE_PASSWORD: ${{ secrets.DATABASE_PASSWORD }}

jobs:
  deploy:
    runs-on: ubuntu-latest
    name: Deploy
    steps:
      - uses: actions/checkout@v4
      - name: Deploy
        uses: cloudflare/wrangler-action@v3.6.1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          environment: production
        env:
          DATABASE_HOST: ${{ secrets.DATABASE_HOST }}
          DATABASE_USERNAME: ${{ secrets.DATABASE_USERNAME }}
          DATABASE_PASSWORD: ${{ secrets.DATABASE_PASSWORD }}

jobs:
  deploy:
    runs-on: ubuntu-latest
    name: Deploy
    steps:
      - uses: actions/checkout@v4
      - name: Deploy
        uses: cloudflare/wrangler-action@v3.6.1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          environment: production
        env:
          DATABASE_HOST: ${{ secrets.DATABASE_HOST }}
          DATABASE_USERNAME: ${{ secrets.DATABASE_USERNAME }}
          DATABASE_PASSWORD: ${{ secrets.DATABASE_PASSWORD }}

P

pfeffunit•6/16/24, 3:39 AM

alright you need to also specify

secrets

secrets

for some reason? this works:

jobs:
  deploy:
    runs-on: ubuntu-latest
    name: Deploy
    steps:
      - uses: actions/checkout@v4
      - name: Deploy
        uses: cloudflare/wrangler-action@v3.6.1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          environment: production
          secrets: |
            DATABASE_HOST
            DATABASE_USERNAME
            DATABASE_PASSWORD
        env:
          DATABASE_HOST: ${{ secrets.DATABASE_HOST }}
          DATABASE_USERNAME: ${{ secrets.DATABASE_USERNAME }}
          DATABASE_PASSWORD: ${{ secrets.DATABASE_PASSWORD }}

jobs:
  deploy:
    runs-on: ubuntu-latest
    name: Deploy
    steps:
      - uses: actions/checkout@v4
      - name: Deploy
        uses: cloudflare/wrangler-action@v3.6.1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          environment: production
          secrets: |
            DATABASE_HOST
            DATABASE_USERNAME
            DATABASE_PASSWORD
        env:
          DATABASE_HOST: ${{ secrets.DATABASE_HOST }}
          DATABASE_USERNAME: ${{ secrets.DATABASE_USERNAME }}
          DATABASE_PASSWORD: ${{ secrets.DATABASE_PASSWORD }}

jobs:
  deploy:
    runs-on: ubuntu-latest
    name: Deploy
    steps:
      - uses: actions/checkout@v4
      - name: Deploy
        uses: cloudflare/wrangler-action@v3.6.1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          environment: production
          secrets: |
            DATABASE_HOST
            DATABASE_USERNAME
            DATABASE_PASSWORD
        env:
          DATABASE_HOST: ${{ secrets.DATABASE_HOST }}
          DATABASE_USERNAME: ${{ secrets.DATABASE_USERNAME }}
          DATABASE_PASSWORD: ${{ secrets.DATABASE_PASSWORD }}

jobs:
  deploy:
    runs-on: ubuntu-latest
    name: Deploy
    steps:
      - uses: actions/checkout@v4
      - name: Deploy
        uses: cloudflare/wrangler-action@v3.6.1
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          environment: production
          secrets: |
            DATABASE_HOST
            DATABASE_USERNAME
            DATABASE_PASSWORD
        env:
          DATABASE_HOST: ${{ secrets.DATABASE_HOST }}
          DATABASE_USERNAME: ${{ secrets.DATABASE_USERNAME }}
          DATABASE_PASSWORD: ${{ secrets.DATABASE_PASSWORD }}

E

Erisa•6/17/24, 1:21 AM

Yes, if you use a stream you can avoid buffering the file into memory

B

Bernardo•6/17/24, 1:33 AM

Hi everyone, why I can't use mtls_certificates binding without

--remote

--remote

?

I created a brand new cf worker project with the following tutorial: https://developers.cloudflare.com/workers/get-started/guide/#1-create-a-new-worker-project
I added the mtls certificate like the following tutorial: https://developers.cloudflare.com/workers/runtime-apis/bindings/mtls/#client-authentication-with-mtls

When I run the command

wrangler dev

wrangler dev

the binding

environment.MY_CERT

environment.MY_CERT

environment.MY_CERT

environment.MY_CERT is

undefined

undefined

undefined

undefined.

But when I run the command with remote like

wrangler dev --remote

wrangler dev --remote

the binding starts to work.

E

Erisa•6/17/24, 4:08 AM

I mean, you can define ranges in the get from r2 can't you?

E

Erisa•6/17/24, 4:09 AM

Hm but the cache api should handle ranges itself after you cache the full file

E

Erisa•6/17/24, 4:09 AM

This code works fine with ranges https://github.com/kotx/render/blob/master/src/index.ts

E

Erisa•6/17/24, 4:10 AM

I would link to a specific line but the range handling is scattered around

Ppeshakoo i took a look and it looks like they are inserting the range in the get, not fro...

E

Erisa•6/17/24, 4:18 AM

Well the cache just reads the range headers in the request object you passed it and returns the right slice so you don't need any code for it

E

Erisa•6/17/24, 4:19 AM

I think what render doesn't do is insert the full file into cache when asked for a range, but you could do that instead if it suits your case

cus says sttrings interpreted as the url

Similar Threads

Similar Threads

Similar Threads