あIs there a solution?
TResponded in thread
TSame here
AAThe recent postgres.js work did a lot to unblock this, as the nodejs_compat flag works with postgres.js, and also with pages, which was I think one of the last blockers there
MDoes Hyperdrive play nicely with Postgres transactions, or would they conflict in any way? I know Hyperdrive handles pooling, hence the question, whereas PG transactions depend on using a pool client, not on-the-fly, one-off queries.
AIt works well with them but they do impose some costs.
- We don't cache parts of transactions, so you'll always be serving from origin
- The client holds the connection until the transaction completes or rolls back, which limits the amount of scaling available
MGreat, thanks for the info.
✅Suggestion: Support mongodb in hyperdrive
MThis may be more a general PG question, but asking here in case there's any HD implications/angle on it: is it advisable to cache the
do:
Client instance on req, rather than create it for each query? i.e. instead of:do:
INo.
req is new every time and the client will be recycled.IAlso it's fine to recreate clients with Hyperdrive, it holds open connections for you.
HI think they meant if a single Request runs multiple queries across different handlers
IOh I see
IThen yeah, could work. I'd still be wary of mutating request state though... I've always been told not to do that by various frameworks
IIf Workers changes something internally on the request you have no guarantee that
req.client will still be unused (unlikely it will be but possible?)HSome frameworks do provide a "state" store somewhere that will be passed around, so I would use that if possible
IYeah this
IHono calls it context, Fastify calls it state.
IThere's nothing workers-native though I don't think.
HIsn't the "official" one
req.cf?HLike, as in, they don't guarantee that they won't put new stuff on it, but it will be passed around
IYeah but that's even more likely to be overwritten.
II guess if you name your thing something obscure it'll work, but I can imagine a
req.cf.client some day for some service or another.
Mseem to be experiencing an outage again, with hyperdrive connection latency spikes. is there anyone available who can look into it?
ALet me take a look. Same config ID you'd previously sent?
ALooks like the ID you'd sent previously is not seeing traffic. Please post or DM the one you're seeing issues with. I'm not seeing latency spikes globally, but individual configs certainly could be. Happy to take a look.
MInteresting - I've seen frameworks absolutely encourage storing things on
req between middleware. Otherwise you'd have no option but to laboriously pass around manually a ton of data as function arguments.MExactly.
IAbsolutely, but there's usually a property dedicated towards it.
ILike
ctx or similar.
P
ANo, not for Hyperdrive. Not that I've seen or know of.
Podd. I know that they have the same ip pool so i was wondering because for about a minute i had connection timeouts
BSeeing an interesting problem with workers, may or may not be a result of hyperdrive. I have an API implemented in workers with typescript and I'm running React in Pages. Some of my components load 2 different requests simultaneously. Sometimes, works fine, a lot of times, one of the requests receives a connection timeout from the DB. If I disable hyperdrive, the problem goes away. If I stagger the request by a second or two then there is no problem. Is it possible hyperdrive or workers cannot locate a connection in such quick succession? Should I serialize the requests?
Interestingly, I also see the problem locally with wrangler dev. Again, stagger the requests, no issue.
Interestingly, I also see the problem locally with wrangler dev. Again, stagger the requests, no issue.
MIf you’re seeing it in dev - where Hyperdrive’s connection logic isn’t in place - it might be something else. Are you doing something odd with your driver/client code?
BNothing unique and no problems normally. The only issue is if I send off 2 simultaneous connections from react at roughly the same time. I see it in wrangler and I see it in workers production. Using Hono and Kysley. I'll dig a bit more, as of right now, just staggering the requests.
PI think its possible I'm experiencing this as well
Pstarted getting this error a couple days ago
Pthat looks like a bug
Pand i suppose it is
Pbut whats interesting is
PPCONNECT_TIMEOUT?
P its a bug in postgres.js, caused by CONNECTION_TIMEOUTs
PFurthermore, I can corroborate that the issue is solved when hyperdrive is disabled
PI can tell that hyperdrive was properly disabled because requests now take about 200ms longer
