Significant surface features artifacts on DH 2.2

Minecraft version: 1.20.1
Distant Horizons version: 2.2.0-a
Mod loader: Fabric Loader 0.16.2
Installed mods: Lithium, Distant Horizons
Bug: There are large areas with few or no trees, but when you go there it's a forest. And Log file is bloating.
Steps to reproduce the bug: Generate LODs (seed: 3730872696997453204)
Log: https://mclo.gs/HUapFuH

mclo.gs

Vanilla Client Log [#HUapFuH]

25000 lines

AnonOP•8/26/24, 2:52 AM

Too Short; Will Read:
See for how this bug was found → help-meSignificant surface features artifacts on DH 2.2 with modded world gen

AnonOP•8/26/24, 2:58 AM

344mb log file

AnonOP•8/26/24, 2:59 AM

AnonOP•8/26/24, 3:03 AM

I created a GitLab issue: https://gitlab.com/jeseibel/distant-horizons/-/issues/790

GitLab

Significant surface features artifacts on DH 2.2 (#790) · Issues · ...

Check off each item in this list before submitting: Check the...

AnonOP•8/26/24, 3:26 AM

Log is full of this error

Miki_P98•8/26/24, 8:28 AM

Can you give the seed?

MMiki_P98 Can you give the seed?

AnonOP•8/26/24, 9:28 AM

I already gave the seed

AnonOP•8/26/24, 9:29 AM

I would really appreciate it if you can reproduce this bug

Puhpine•8/26/24, 10:13 AM

ill take a look to see if i can reproduce

Puhpine•8/26/24, 10:19 AM

Puhpine•8/26/24, 10:19 AM

imma see if i can reproducce it with less mods

Puhpine•8/26/24, 10:21 AM

does NOT happen without entity culling, ferritecore and lithium

AnonOP•8/26/24, 10:22 AM

Watch out for your log file too man it adds up quick

Puhpine•8/26/24, 10:22 AM

ill delete the instance once im done anyway

Puhpine•8/26/24, 10:24 AM

still happens without sodium and indium

Puhpine•8/26/24, 10:25 AM

lithium is the issue

AnonOP•8/26/24, 10:28 AM

Should i update the issue on installed mods as lithium and distant horizons

Puhpine•8/26/24, 10:29 AM

yes please

AnonOP•8/26/24, 10:30 AM

Thx dude it was really late for me so i just couldn't dig into enough and left as it is

Puhpine•8/26/24, 10:31 AM

np!

PPuhpine lithium is the issue

Puhpine•8/26/24, 10:31 AM

@James Seibel (GMT-6) this may be a significant bug. lots of people use lithium

AnonOP•8/26/24, 10:35 AM

@Puhpine (GMT +2) does log bloating still happens with only lithium

Puhpine•8/26/24, 10:36 AM

not sure because i deleted the instance, but i think it did yea

Miki_P98•8/26/24, 10:57 AM

Here are chunk, world and generation Lithium settings I dag up:

this.addMixinRule("chunk", true);
this.addMixinRule("chunk.block_counting", true);
this.addMixinRule("chunk.entity_class_groups", true);
this.addMixinRule("chunk.no_locking", true);
this.addMixinRule("chunk.no_validation", true);
this.addMixinRule("chunk.palette", true);
this.addMixinRule("chunk.section_update_tracking", true);
this.addMixinRule("chunk.serialization", true);

this.addMixinRule("gen", true);
this.addMixinRule("gen.biome_noise_cache", true);
this.addMixinRule("gen.cached_generator_settings", true);
this.addMixinRule("gen.chunk_region", true);
this.addMixinRule("gen.fast_island_noise", true);
this.addMixinRule("gen.fast_layer_sampling", true);
this.addMixinRule("gen.fast_multi_source_biomes", true);
this.addMixinRule("gen.features", true);
this.addMixinRule("gen.perlin_noise", true);

this.addMixinRule("world", true);
this.addMixinRule("world.block_entity_retrieval", true);
this.addMixinRule("world.block_entity_ticking", true);
this.addMixinRule("world.block_entity_ticking.support_cache", false); //have to check whether the cached state bugfix fixes any detectable vanilla bugs first
this.addMixinRule("world.chunk_access", true);
this.addMixinRule("world.chunk_task_system", true);
this.addMixinRule("world.chunk_tickets", true);
this.addMixinRule("world.chunk_ticking", true);
this.addMixinRule("world.explosions", true);
this.addMixinRule("world.inline_block_access", true);
this.addMixinRule("world.inline_height", true);
this.addMixinRule("world.mob_spawning", true);
this.addMixinRule("world.player_chunk_tick", true);
this.addMixinRule("world.tick_scheduler", true);

this.addMixinRule("worldfixer", true);

this.addMixinRule("chunk", true);
this.addMixinRule("chunk.block_counting", true);
this.addMixinRule("chunk.entity_class_groups", true);
this.addMixinRule("chunk.no_locking", true);
this.addMixinRule("chunk.no_validation", true);
this.addMixinRule("chunk.palette", true);
this.addMixinRule("chunk.section_update_tracking", true);
this.addMixinRule("chunk.serialization", true);

this.addMixinRule("gen", true);
this.addMixinRule("gen.biome_noise_cache", true);
this.addMixinRule("gen.cached_generator_settings", true);
this.addMixinRule("gen.chunk_region", true);
this.addMixinRule("gen.fast_island_noise", true);
this.addMixinRule("gen.fast_layer_sampling", true);
this.addMixinRule("gen.fast_multi_source_biomes", true);
this.addMixinRule("gen.features", true);
this.addMixinRule("gen.perlin_noise", true);

this.addMixinRule("world", true);
this.addMixinRule("world.block_entity_retrieval", true);
this.addMixinRule("world.block_entity_ticking", true);
this.addMixinRule("world.block_entity_ticking.support_cache", false); //have to check whether the cached state bugfix fixes any detectable vanilla bugs first
this.addMixinRule("world.chunk_access", true);
this.addMixinRule("world.chunk_task_system", true);
this.addMixinRule("world.chunk_tickets", true);
this.addMixinRule("world.chunk_ticking", true);
this.addMixinRule("world.explosions", true);
this.addMixinRule("world.inline_block_access", true);
this.addMixinRule("world.inline_height", true);
this.addMixinRule("world.mob_spawning", true);
this.addMixinRule("world.player_chunk_tick", true);
this.addMixinRule("world.tick_scheduler", true);

this.addMixinRule("worldfixer", true);

One (or more) of them is most likely incompatible

Miki_P98•8/26/24, 11:39 AM

Disabling all of

gen

gen

optimizations fix this

Miki_P98•8/26/24, 11:41 AM

It is 1 of the first 4

Miki_P98•8/26/24, 11:45 AM

Found it:

mixin.gen.chunk_region

mixin.gen.chunk_region

Miki_P98•8/26/24, 11:46 AM

There are still holes in the world...

Miki_P98•8/26/24, 11:46 AM

Miki_P98•8/26/24, 11:47 AM

They've got fixed after I've flew over them
.
.

Miki_P98•8/26/24, 11:48 AM

The fix to the OP's problem is disabling

mixin.gen.chunk_region

mixin.gen.chunk_region

Lithium option

Miki_P98•8/26/24, 11:48 AM

The line:

mixin.gen.chunk_region=false

mixin.gen.chunk_region=false

Should be added to

lithium.properties

lithium.properties

config file

Miki_P98•8/26/24, 11:49 AM

.
.
@Puhpine (GMT +2) Can you add this to #faq-mod-support or confirm?

Puhpine•8/26/24, 11:49 AM

i cant, as i cant edit james' messages

PPuhpine i cant, as i cant edit james' messages

Miki_P98•8/26/24, 11:49 AM

You can write a new one

Puhpine•8/26/24, 11:50 AM

dont know if james would want that, and maybe the bug can be fixed, so that you dont need to edit anything

Miki_P98•8/26/24, 11:50 AM

It can always be deleted later, but OK

Puhpine•8/26/24, 11:50 AM

oh and i dont even have permissions to write in #faq-mod-support

Miki_P98•8/26/24, 11:50 AM

MMiki_P98 The line: `mixin.gen.chunk_region=false` Should be added to `lithium.properties`...

Puhpine•8/26/24, 11:55 AM

this also works for me

Miki_P98•8/26/24, 11:58 AM

This is this option description:

mixin.gen.chunk_region
mixin.gen.chunk_region

(boolean, default: true)

If true, an optimized chunk cache will be used for world population features which avoids array indirection and complex logic.

BackSun•8/26/24, 12:03 PM

I'll take a look at the bug when I have time.

Puhpine•8/26/24, 12:03 PM

nice!

MMiki_P98 This is this option description: > `mixin.gen.chunk_region` > (boolean, default:...

AnonOP•8/26/24, 12:14 PM

you are awesome

hardester•8/26/24, 12:17 PM

This bug feels like one of those classic seed-sensitive Minecraft bug where it only occurs on certain seeds. This world seed just so happens to trigger it.

hardester•8/26/24, 12:26 PM

Can't reproduce this on 1.21.1, however, other things I noticed is that there are many features that appears to be sliced at chunk borders. All screenshots are zoomed in with the spyglass. Same setup with OP with the exception of Minecraft version being 1.21.1.

hardester•8/26/24, 12:27 PM

Also, man this speed-up sure helps a lot with getting LODs quickly.

hardester•8/26/24, 12:35 PM

One question, is the button placement messed up in the main menu 1.20.1?

hardester•8/26/24, 12:36 PM

Nevermind, it resets itself once I joined a world.

hardester•8/26/24, 12:37 PM

This is already concerning.

Significant surface features artifacts on DH 2.2

The fix to the OP's problem is disabling
`mixin.gen.chunk_region`
`mixin.gen.chunk_region`
Lithium option

The fix to the OP's problem is disabling
`mixin.gen.chunk_region`
`mixin.gen.chunk_region`
Lithium option

Significant surface features artifacts on DH 2.2

The fix to the OP's problem is disabling mixin.gen.chunk_regionmixin.gen.chunk_region Lithium option

The fix to the OP's problem is disabling mixin.gen.chunk_regionmixin.gen.chunk_region Lithium option

The fix to the OP's problem is disabling
`mixin.gen.chunk_region`
`mixin.gen.chunk_region`
Lithium option

The fix to the OP's problem is disabling
`mixin.gen.chunk_region`
`mixin.gen.chunk_region`
Lithium option