I updated my project and started noticing "Too many subrequests" errors in prod. I made a branch and

I updated my project and started noticing "Too many subrequests" errors in prod. I made a branch and did some testing, and found that this was caused by updating next from 14.1.0 to 14.2.13 - if I go back to 14.1.0 with the same code then this error doesn't happen. is cloudflare aware of any next change that would be causing this?

Walshy•9/26/24, 1:03 AM

cc: @James @Dario

tadhglewis•9/26/24, 4:40 AM

Question for the crowd: what is the expect/your median CPU time? (Workers & Pages > project > Function metrics)

I'm curious if mine is high relatively speaking - it seems higher than Vercel but their usage dashboards are a bit difficult to use.

Also, has anyone managed to get __NEXT_ON_PAGES__KV_SUSPENSE_CACHE__NEXT_ON_PAGES__KV_SUSPENSE_CACHE working?

Aadvaith I updated my project and started noticing "Too many subrequests" errors in prod....

advaithOP•9/26/24, 6:35 AM

ok actually it's weirder than this

advaithOP•9/26/24, 6:36 AM

i noticed that for some queries in my site, it is still getting that error, even on the older next version. (all queries do the same number of subrequests, and it is much lower than 50)

advaithOP•9/26/24, 6:36 AM

I made a new branch at the commit I was at before today and deployed it.

advaithOP•9/26/24, 6:36 AM

and this new deploy, with the identical commit as a deploy from a few months ago, gets this "too many subrequests" error on some queries. the older deploy is fine

advaithOP•9/26/24, 6:37 AM

so something seems to have changed in how cloudflare handles these deploys, breaking my site

advaithOP•9/26/24, 6:41 AM

i rolled it back to the old deploy for now, since that's the only way for it to not error

Ttadhglewis Question for the crowd: what is the expect/your median CPU time? (Workers & Page...

James•9/26/24, 7:12 AM

We added KV because, well, people asked for it, but my personal opinion is that you should be using cache api since it aligns better with the expected behaviour of the fetch cache (e.g. being regional). And I'm also of the opinion that the eventual consistency of KV completely kills the ability for the cache to work properly because every change to the cache manifest takes 60 seconds to propagate which will mean it'll probably change every request when it shouldnt be

Aadvaith so something seems to have changed in how cloudflare handles these deploys, brea...

James•9/26/24, 7:13 AM

are you using the same next-on-pages version in both the old and new deploy?

advaithOP•9/26/24, 7:15 AM

probably not, it isn't a dependency in the project, and the build command is pnpm dlx @cloudflare/next-on-pages@1pnpm dlx @cloudflare/next-on-pages@1

James•9/26/24, 7:16 AM

would you be able to try a deploy with next-on-pages version from when your last deploy worked and see if that makes the difference

advaithOP•9/26/24, 7:18 AM

ok, it was april 5 so i'll try 1.11.0

advaithOP•9/26/24, 7:22 AM

ok it seems to work fine with next-on-pages 1.11.0 @James

James•9/26/24, 7:24 AM

that's irritating - there's been a lot of changes since then...

James•9/26/24, 7:24 AM

can i be really annoying and ask if it's possible to increment the version until you get to the one that introduces the problem?

advaithOP•9/26/24, 7:26 AM

sure

James•9/26/24, 7:27 AM

thanks

advaithOP•9/26/24, 7:37 AM

1.11.3 works fine
1.12.0 has the error

James•9/26/24, 7:42 AM

James•9/26/24, 7:46 AM

do you use the fetch cache?

advaithOP•9/26/24, 7:47 AM

i don't have any code for controlling caching, but data does get cached. so i assume next does?

advaithOP•9/26/24, 7:49 AM

this is an app router project that has about 20 components that each do a fetch request

James•9/26/24, 7:50 AM

i'm thinking it's possibly something along the lines of those fetch requests might have been being cached before but one of these two fetch cache changes resulted in them not being cached either as long or at all and therefore leading to more requests happening

advaithOP•9/26/24, 7:52 AM

whether cached or not, there's no reason why one page would do more than ~20 subrequests

James•9/26/24, 7:55 AM

i agree, but that's the only thing related to those changes that would make sense

ItsWendell•9/26/24, 2:13 PM

Now that cloudflare has joined OpenNext, do we get a seperate channel for that or do we keep discussions around that in next-on-pages / next channel? https://blog.cloudflare.com/builder-day-2024-announcements/#cloudflare-joins-opennext

The Cloudflare Blog

Builder Day 2024: 18 big updates to the Workers platform

To celebrate Builder Day 2024, we’re shipping 18 updates inspired by direct feedback from developers building on Cloudflare. This includes new capabilities, like running evals with AI Gateway, beta products like Queues and Vectorize graduating to GA, massive speed improvements to KV and Workers AI, pricing simplifications, and bringing key featu...

tadhglewis•9/26/24, 2:16 PM

Sounds like OpenNext + Workers Static Assets will replace Pages so probably warrants a separate channel?

we plan to bridge the remaining gaps between Workers and Pages and provide ways to migrate your Pages projects to Workers.

James•9/26/24, 2:25 PM

the blog post says to use the OpenNext Discord, so you should probably head over there for discussion about @opennextjs/cloudflare@opennextjs/cloudflare.

D Trombett•9/26/24, 3:36 PM

imo we need a migration guide from @cloudflare/next-on-pages@cloudflare/next-on-pages to @opennextjs/cloudflare@opennextjs/cloudflare

Baran•9/26/24, 3:59 PM

Is Cloudflare going to drop support for next-on-pages after OpenNext announcement? If so, a migration guide would be useful

simplenotezy•9/27/24, 9:32 AM

Is it correctly understood that ISR is not supported by next-on-pages?

simplenotezy•9/27/24, 9:33 AM

Oh, just saw the above blogpost regarding OpenNext... Interesting!

James•9/27/24, 10:16 PM

you can't

koribot•9/29/24, 1:41 PM

Hello, as far as I know axios does not work on edge function right? but why is this api endpoint of mine working just fine

James•9/29/24, 3:37 PM

magic

Kkoribot Hello, as far as I know axios does not work on edge function right? but why is t...

yuripave•9/30/24, 1:24 AM

https://github.com/axios/axios/pull/6371

GitHub

feat(adapter): add fetch adapter; by DigitalBrainJS · Pull Request ...

The goal of this PR is to add a minimal fetch implementation that provides the same capabilities as the xhr adapter without major changes, allowing it to be released in Axios 1.x.
To avoid breaking...

chof64•9/30/24, 3:39 PM

Hello, trying to learn and try deploying an existing nextjs project to pages, I'm following the ssr guide. But I got a question.

In the docs, a library @cloudflare/next-on-pages@cloudflare/next-on-pages is needed, and when I installed it as dev dependency. I now get 11 vulnerabilities in my project. But before installing the dev dependency these vulnerabilities don't exist. Is there a way to fix these or maybe a resource that talks about these so that I can do further research?

tadhglewis•9/30/24, 4:20 PM

https://snyk.io/advisor/npm-package/@cloudflare/next-on-pages

Snyk Advisor

View @cloudflare/next-on-pa… on Snyk Open Source Advisor

Find the best open-source package for your project with Snyk Open Source Advisor. Explore over 1 million open source packages.

tadhglewis•9/30/24, 4:21 PM

npm audits typically show a lot of stuff due to how many dependencies npm packages have (you'd need to double check the source of the 11 vulerabilities)... Majority of it (esp for dev deps) is not applicable. Most of the time you just need to re-generate the lock file which updates downstream dependencies

Puliczek•10/1/24, 6:43 PM

Are Next.js Workers more expensive than Next.js Pages? Does one HTTP request equal one worker request?

James•10/1/24, 6:50 PM

it's the same

James•10/1/24, 6:50 PM

Pages uses workers

Sevrene•10/1/24, 8:37 PM

Attempting to embed Sanity Studio into a Cloudflare Pages deploy and since it must run on edge it falls into the worker size limit
I am assuming my solution is to just upgrade to a paid plan to fit within the larger size limit and I'm not configuring something incorrectly here?

James•10/1/24, 9:50 PM

correct

JJames it's the same

tadhglewis•10/1/24, 11:01 PM

That's not necessarily true, it's one request but can be more expensive. @Puliczek I replied to you on Open NextJS discord

tadhglewis•10/1/24, 11:01 PM

Tldr: higher CPU and page load but limited testing

Puliczek•10/2/24, 6:32 AM

Thank you so much for your analysis. I will wait longer before migrating. Also, there is no proper tutorial on how to migrate from Pages to Workers.

面

面条•10/2/24, 3:27 PM

Middleware ？

I updated my project and started noticing "Too many subrequests" errors in prod. I made a branch and

Similar Threads

Similar Threads

Similar Threads