That's intentional - `nodejs_compat` implies `nodejs_compat_v2` after that `compatibility_date` & Wr

That's intentional -

nodejs_compat

nodejs_compat

implies

nodejs_compat_v2

nodejs_compat_v2

after that

compatibility_date

compatibility_date

& Wrangler adds polyfills with unenv

DDaniFoldi could you share a little more so I can repro and escalate if it is actually a ru...

berkinovish•10/3/24, 8:55 PM

Yes, this crashes with

"wrangler": "3.78.10"

"wrangler": "3.78.10"

, but works fine with wrangler on

3.78.9

3.78.9

function isNotEmptyObject<T extends Record<string, any>>(val: T | unknown): val is T {
    if (Object.prototype.toString.call(val) !== '[object Object]') return false;
    for (const _ in val as Record<string, any>) {
        return true;
    }
    return false;
}

export default {
    async fetch(request, env, ctx): Promise<Response> {
        if (!isNotEmptyObject(ctx)) throw new Error('ctx');
        return new Response('Hello World!');
    },
} satisfies ExportedHandler<Env>;

function isNotEmptyObject<T extends Record<string, any>>(val: T | unknown): val is T {
    if (Object.prototype.toString.call(val) !== '[object Object]') return false;
    for (const _ in val as Record<string, any>) {
        return true;
    }
    return false;
}

export default {
    async fetch(request, env, ctx): Promise<Response> {
        if (!isNotEmptyObject(ctx)) throw new Error('ctx');
        return new Response('Hello World!');
    },
} satisfies ExportedHandler<Env>;

We think this might be the commit that caused the behaviour change: https://github.com/cloudflare/workerd/pull/2801/files

I assume impact will be low though, pretty niche to do this check on

ctx

ctx

Llouiek22 Has anyone else seen a significant jump in bundle size when using a compatibilit...

DaniFoldi•10/3/24, 8:56 PM

that's because workers with nodejs_compat and a compat date that is newer than your date have some js polyfills added, in addition to the runtime compat mode that it enables

Bberkinovish Yes, this crashes with `"wrangler": "3.78.10"`, but works fine with wrangler on ...

DaniFoldi•10/3/24, 8:56 PM

thanks, I'll forward this info

Kkian That's intentional - `nodejs_compat` implies `nodejs_compat_v2` after that `comp...

louiek22•10/3/24, 8:58 PM

Gotcha, I thought unenv was supposed to be smart about adding polyfills. Thanks for the info!

DDaniFoldi thanks, I'll forward this info

berkinovish•10/3/24, 8:58 PM

Even though we fixed our wrangler at 3.78.6, we were still impacted - it looked like there was a gradual rollout of a newer version throughout the day

Llouiek22 Gotcha, I thought unenv was supposed to be smart about adding polyfills. Thanks ...

DaniFoldi•10/3/24, 8:58 PM

it should only add what you might use

Bberkinovish Even though we fixed our wrangler at 3.78.6, we were still impacted - it looked ...

DaniFoldi•10/3/24, 8:59 PM

correct, that's usually how runtime releases are done, and your version of wrangler only affects your local runtime version

DDaniFoldi correct, that's usually how runtime releases are done, and your version of wrang...

berkinovish•10/3/24, 8:59 PM

makes sense

DDaniFoldi it should only add what you _might_ use

louiek22•10/3/24, 8:59 PM

I'm not using anything in the worker itself, just have it for vitest.

louiek22•10/3/24, 9:01 PM

I'm guessing that extra size is from boilerplate from unenv, or maybe it's coming from my tests?

rufi•10/3/24, 11:59 PM

how many requests can a single worker handle? in AWS, GCloud and al., we see the concept of "quotas" and number of "container instances" spawned over time. We don't have such information on Cloudflare dashboard. Is it using a single worker for each request; or rather a single worker can handle millions or more requests by itself?

Walshy•10/4/24, 12:14 AM

There is no limit, I've done over 100k rps myself from my own laptop and of course we do much more as a whole platform

Each Worker can handle tons and there could many many thousands of worker instances.

Workers are light and so can be created everywhere and handle a lot

Akash•10/4/24, 1:14 AM

does snippets support kv? If not is there any plan to add this support?

Ashish Rawat•10/4/24, 5:28 AM

I wish workers has support for firebase sdk and mongodb. That's the only thing stopping me to deploy to workers. Currently have to use google cloud run for docker instance.

AAshish Rawat I wish workers has support for firebase sdk and mongodb. That's the only thing s...

hfcRed•10/4/24, 5:50 AM

Why not D1 or KV

AAkash does snippets support kv? If not is there any plan to add this support?

Walshy•10/4/24, 8:47 AM

Snippets have no bindings access. They're meant for lightweight use cases

w3bcode•10/4/24, 9:03 AM

Anyone getting error with wrangler deploy command, I am latest version 3.79.0

workers.api.error.unknown [code: 10013]

Ww3bcode Anyone getting error with wrangler deploy command, I am latest version 3.79.0 > ...

Walshy•10/4/24, 9:34 AM

What's your account ID?

w3bcode•10/4/24, 1:31 PM

9c508e2e1d1c6d075d774819cf38176c

I was using it with Cloudflare account token template settings by exposing it to environment but getting api errors, so I logged in with wrangler login and deployed. It worked that way

Focux•10/4/24, 1:35 PM

is there any template for running remix spa mode in workers?

HHello, I’m Allie!Afaik currently you would have to apply headers via a rule(or via the Worker its...

Focux•10/4/24, 1:43 PM

If the _headers file doesn't work anymore, would be good to remove it from the template, otherwise, it's a bit confusing.

FFocux If the _headers file doesn't work anymore, would be good to remove it from the t...

Isaac McFadyen•10/4/24, 1:51 PM

It still works with Pages which is what the template is designed for AFAIK

Ww3bcode 9c508e2e1d1c6d075d774819cf38176c I was using it with Cloudflare account token t...

texan•10/4/24, 1:52 PM

Hey w3b, we discovered a bug related to account owned tokens this morning. The team is looking into it, thanks!

Focux•10/4/24, 1:56 PM

oh, i thought that

pnpm create cloudflare@latest web --framework=remix --experimental

pnpm create cloudflare@latest web --framework=remix --experimental

bootstrapped a workers project

FFocux oh, i thought that `pnpm create cloudflare@latest web --framework=remix --experi...

Isaac McFadyen•10/4/24, 2:23 PM

Apologies - you might be right

Focux•10/4/24, 2:37 PM

haha no problem

kaelys.js•10/4/24, 5:05 PM

Is there a way in a worker (js) to get the current version/deployment id?

Kkaelys.js Is there a way in a worker (js) to get the current version/deployment id?

Chaika•10/4/24, 5:08 PM

https://developers.cloudflare.com/workers/runtime-apis/bindings/version-metadata/

Cloudflare Docs

Version metadata | Cloudflare Workers docs

Exposes Worker version metadata (

versionID

versionID

and

versionTag

versionTag

). These fields can be added to events emitted from the Worker to send to downstream observability systems.

HhfcRed Why not D1 or KV

Ashish Rawat•10/4/24, 5:21 PM

KV not good for everything and can't migrate. D1 is limited, no read replica, no sharding. Firebase I'm using only for firebase auth. And I'm using more node.js features (packages) that is not supported by even latest node_compat.

CChaika https://developers.cloudflare.com/workers/runtime-apis/bindings/version-metadata...

kaelys.js•10/4/24, 6:25 PM

How do I define that in the toml across multiple env? It fails when trying to add the key to separate env and warns when it’s not in separate env. Latest wrangler

Kkaelys.js How do I define that in the toml across multiple env? It fails when trying to ad...

texan•10/4/24, 6:28 PM

Can you share your toml? I set it globally as defined in the docs and not getting any errors or warnings

Ttexan Can you share your toml? I set it globally as defined in the docs and not gettin...

kaelys.js•10/4/24, 6:32 PM

Here you go, redacted some info

wrangler.toml2.17KB

kaelys.js•10/4/24, 6:33 PM

Screenshot_2024-10-04_at_11.33.24_AM.png

Walshy•10/4/24, 6:34 PM

[env.local.version_metadata]

Walshy•10/4/24, 6:34 PM

TOML is great :meowupsidedown:

kaelys.js•10/4/24, 6:35 PM

ah geeze, thanks! That sorted it

Bberkinovish Even though we fixed our wrangler at 3.78.6, we were still impacted - it looked ...

DaniFoldi•10/4/24, 6:45 PM

hey, I think this is being addressed, there's a compatibility flag so if you're using something older than

2024-09-26

2024-09-26

you should see the old behavior
no idea when it will be rolled out to prod, so could be that you're already back to the old functionality, or maybe only next week

Walshy•10/4/24, 7:21 PM

Dani too fast, yes we're working on rolling out a fix gating this change now

tobi•10/4/24, 9:09 PM

hmm, anyone know what the size limit is for workers static assets?

texan•10/4/24, 9:14 PM

Should be 25MiB

texan•10/4/24, 9:14 PM

(Same as pages)

tobi•10/4/24, 9:15 PM

ah, so also built upon kv?

texan•10/4/24, 9:17 PM

Yup!

MMarkR Hi there, I am trying the Worker Builds connect with Github. - Is there a retry...

aniniflare•10/4/24, 9:20 PM

yup, we will be adding that soon
what do you mean by environments? do you mean Workers environments or something else?

Cloudflare Docs

Environments | Cloudflare Workers docs

Deploy the same Worker application with different configuration for each environment.

quiqsilver•10/5/24, 4:07 AM

Does Workers Static Assets have the same 20k file count limit that Pages does?

LordSilver•10/5/24, 7:46 AM

How do you submit feature requests? You can only through a ticket on a business/enterprise plan? I could ask one of my clients, but I'd rather not bother them.

function isNotEmptyObject<T extends Record<string, any>>(val: T | unknown): val is T { if (Object.prototype.toString.call(val) !== '[object Object]') return false; for (const _ in val as Record<string, any>) { return true; } return false; } export default { async fetch(request, env, ctx): Promise<Response> { if (!isNotEmptyObject(ctx)) throw new Error('ctx'); return new Response('Hello World!'); }, } satisfies ExportedHandler<Env>;

That's intentional - `nodejs_compat` implies `nodejs_compat_v2` after that `compatibility_date` & Wr

Similar Threads

Similar Threads

Similar Threads