https://developers.cloudflare.com/workflows/build/workers-api/#nonretryableerror

MMatt Silverlock https://developers.cloudflare.com/workflows/build/workers-api/#nonretryableerror

L

Luca (steebchen)•1/13/25, 1:59 PM

Oh nice thank you

L

Luca (steebchen)•1/13/25, 4:01 PM

I'm getting this error with the cloudflare blank starter repo when I change the index.ts to use workflows (the test passed before0

[vpw:inf] Starting isolated runtimes for vitest.config.mts...
Worker "workflows:telegram-mod-wf"'s binding "USER_WORKFLOW" refers to service "core:user:vitest-pool-workers-runner-" with a named entrypoint "MessageHandler", but "core:user:vitest-pool-workers-runner-" has no such named entrypoint.
WARN - IDE integration: Got finished tests before collecting them
WARN - IDE integration: Cannot finish not started testing

[vpw:inf] Starting isolated runtimes for vitest.config.mts...
Worker "workflows:telegram-mod-wf"'s binding "USER_WORKFLOW" refers to service "core:user:vitest-pool-workers-runner-" with a named entrypoint "MessageHandler", but "core:user:vitest-pool-workers-runner-" has no such named entrypoint.
WARN - IDE integration: Got finished tests before collecting them
WARN - IDE integration: Cannot finish not started testing

[vpw:inf] Starting isolated runtimes for vitest.config.mts...
Worker "workflows:telegram-mod-wf"'s binding "USER_WORKFLOW" refers to service "core:user:vitest-pool-workers-runner-" with a named entrypoint "MessageHandler", but "core:user:vitest-pool-workers-runner-" has no such named entrypoint.
WARN - IDE integration: Got finished tests before collecting them
WARN - IDE integration: Cannot finish not started testing

[vpw:inf] Starting isolated runtimes for vitest.config.mts...
Worker "workflows:telegram-mod-wf"'s binding "USER_WORKFLOW" refers to service "core:user:vitest-pool-workers-runner-" with a named entrypoint "MessageHandler", but "core:user:vitest-pool-workers-runner-" has no such named entrypoint.
WARN - IDE integration: Got finished tests before collecting them
WARN - IDE integration: Cannot finish not started testing

L

Luca (steebchen)•1/13/25, 9:17 PM

can someone help with this one please? not sure if it's an issue on my side or CF. it's just a log and everything else works fine but it seems a bit weird. it has something to do with workflows so should have posted it here I guess workers-and-pages-helpWeird "run" error with workers + CF workflows

J

jordanfinners•1/14/25, 7:19 AM

Hey, I think I've got a bug.

Every so often workflows will fail to find the toISOString method on the WorkflowEvent.

timestamp.toISOString is not a function

timestamp.toISOString is not a function

timestamp.toISOString is not a function

timestamp.toISOString is not a function

Which leads me to belive sometimes it's not parsing the event into a date object or losing that method somewhere.

Its failed 10 workflows for me overnight

J

jordanfinners•1/14/25, 9:18 AM

@Skye yes sure

export class ActionsWorkflow extends WorkflowEntrypoint<Env, StockTakeActionEvent> {
async run(event: WorkflowEvent<StockTakeActionEvent>, step: WorkflowStep) {
// some other code, but doesn't interact with event
const timestamp = event.timestamp.toISOString()
}
}

K

kchro3•1/14/25, 8:14 PM

Hi, folks, would there be a problem with using a for loop over a step.do & a step.sleep?

for example:

const configs = [{ id: 1, delay: "2 hours" }, { ... }]
for config in configs:
  await step.do(`do ${config.id}`, { ... })
  await step.sleep(`sleep ${config.id}`, config["delay"])

const configs = [{ id: 1, delay: "2 hours" }, { ... }]
for config in configs:
  await step.do(`do ${config.id}`, { ... })
  await step.sleep(`sleep ${config.id}`, config["delay"])

const configs = [{ id: 1, delay: "2 hours" }, { ... }]
for config in configs:
  await step.do(`do ${config.id}`, { ... })
  await step.sleep(`sleep ${config.id}`, config["delay"])

const configs = [{ id: 1, delay: "2 hours" }, { ... }]
for config in configs:
  await step.do(`do ${config.id}`, { ... })
  await step.sleep(`sleep ${config.id}`, config["delay"])

i'm not sure how this works behind the scenes, but i read that the step names need to be static so that they will be cached, so i imagine that if the workflow shuts down after the first sleep, it will reiterate over configs but "skip" the steps

do 1

do 1

do 1

do 1 and

sleep 1

sleep 1

sleep 1

sleep 1 and pick up from

do 2

do 2

do 2

do 2. is that correct?

K

kchro3•1/14/25, 8:34 PM

just minor feedback, but it would be helpful if it was spelled out what happens on workflow reboots, especially in this section: https://developers.cloudflare.com/workflows/build/rules-of-workflows/#do-not-rely-on-state-outside-of-a-step

we were confused by the example because a for-loop has dynamic variables, so we weren't sure if we needed to store the index in the workflow state. there were other examples with for-loops but not with sleep calls that could force a hibernation.

Cloudflare Docs

Rules of Workflows · Cloudflare Workflows docs

A Workflow contains one or more steps. Each step is a self-contained, individually retriable component of a Workflow. Steps may emit (optional) state that allows a Workflow to persist and continue from that step, even if a Workflow fails due to a network or infrastructure issue.

Ssmcstewart Hey there, has anyone had any issues with `NonRetryableError()`? it just doesn't...

M

Matt SilverlockOP•1/15/25, 3:26 PM

What version of wrangler are you using? How are you seeing that it is retrying the step?

I can't reproduce this with your exact code:

MMatt Silverlock What version of wrangler are you using? How are you seeing that it is retrying t...

M

Matt SilverlockOP•1/15/25, 3:27 PM

Fails every time, as expected:

Ssmcstewart @Matt Thanks! It's certainly a wrangler dev issue.

M

Matt SilverlockOP•1/15/25, 3:46 PM

You mean - only local dev? What version of wrangler?

L

Luca (steebchen)•1/15/25, 6:59 PM

I have some feedback – it seems that in a step.do() not the full error message may be shown on the dashboard? it just says ZodError; I doubt it's an issue on zod's side?

await step.do("detect spam", async () => {
  return await detectSpam(this.env, opts.payload.message.content);
});

await step.do("detect spam", async () => {
  return await detectSpam(this.env, opts.payload.message.content);
});

check spam basically does this:

    const response = await ai(env).chat.completions.create({
        response_format: zodResponseFormat(schema, "spam_detection"),
        model: "gpt-4o",
        messages: [
            {
                role: "user",
                content: prompt,
            },
        ],
    });

    return schema.parse(JSON.parse(response.choices[0].message.content || "{}"));

    const response = await ai(env).chat.completions.create({
        response_format: zodResponseFormat(schema, "spam_detection"),
        model: "gpt-4o",
        messages: [
            {
                role: "user",
                content: prompt,
            },
        ],
    });

    return schema.parse(JSON.parse(response.choices[0].message.content || "{}"));

    const response = await ai(env).chat.completions.create({
        response_format: zodResponseFormat(schema, "spam_detection"),
        model: "gpt-4o",
        messages: [
            {
                role: "user",
                content: prompt,
            },
        ],
    });

    return schema.parse(JSON.parse(response.choices[0].message.content || "{}"));

    const response = await ai(env).chat.completions.create({
        response_format: zodResponseFormat(schema, "spam_detection"),
        model: "gpt-4o",
        messages: [
            {
                role: "user",
                content: prompt,
            },
        ],
    });

    return schema.parse(JSON.parse(response.choices[0].message.content || "{}"));

LLuca (steebchen)I have some feedback – it seems that in a step.do() not the full error message m...

M

Matt SilverlockOP•1/15/25, 7:31 PM

https://zod.dev/ERROR_HANDLING?id=formatting-errors

GitHub

TypeScript-first schema validation with static type inference

LLuca (steebchen)I have some feedback – it seems that in a step.do() not the full error message m...

M

Matt SilverlockOP•1/15/25, 7:31 PM

If you want to print the error reason, you should catch it and format the

ZodError

ZodError

MMatt Silverlock If you want to print the error reason, you should catch it and format the `ZodEr...

L

Luca (steebchen)•1/15/25, 7:43 PM

thanks a lot for the quick pointer. really appreciate it.

L

Luca (steebchen)•1/15/25, 7:51 PM

there is no error handler with workflows yet, is there? like inFailure with inngest https://www.inngest.com/docs/reference/functions/handling-failures

L

Luca (steebchen)•1/15/25, 7:52 PM

I'd like to catch any failures and send the details to sentry

D

D Trombett•1/15/25, 7:54 PM

iirc they suggested using a try catch

L

Luca (steebchen)•1/15/25, 8:23 PM

fair enough for the beta. would be great to have that though

D

D Trombett•1/15/25, 9:07 PM

Agree :plus1green:

L

Luca (steebchen)•1/15/25, 9:42 PM

@DaveMurphySF you can ignore these, see https://discord.com/channels/595317990191398933/1328145630341894224/1328473979190509669

R

Rakhim•1/16/25, 12:05 PM

I have a growing backlog of pending workflow instances, while there are only a dozen (not 100) currently executing ones. Anyone has this problem? Perhaps I'm doing something wrong or I misunderstood the limits?

RRakhim I have a growing backlog of pending workflow instances, while there are only a d...

M

Matt SilverlockOP•1/16/25, 12:59 PM

Can you share your account ID here? (it’s safe to share publicly)

MMatt Silverlock Can you share your account ID here? (it’s safe to share publicly)

R

Rakhim•1/16/25, 1:17 PM

1ac93aea0842f2d3ef10111b5bf7bb11

1ac93aea0842f2d3ef10111b5bf7bb11

K

kchro3•1/16/25, 11:02 PM

Hi team, can you clarify if "concurrent executions" means any incomplete workflow or if it means any concurrently running steps?

For example, if I have a workflow with delays of multiple days, would they be considered concurrent while they are sleeping?

Kkchro3 Hi team, can you clarify if "concurrent executions" means any incomplete workflo...

T

tadhglewis•1/17/25, 10:25 AM

No, it's only running instances. Sleeping ones aren't counted

M

Mr. Technician•1/17/25, 3:44 PM

can I call workflow steps in a loop?

MMr. Technician can I call workflow steps in a loop?

A

Ashley•1/17/25, 6:43 PM

Yup! It’s just vanilla JS/TS, so you can do loops/conditionals etc

AAshley Yup! It’s just vanilla JS/TS, so you can do loops/conditionals etc

M

Mr. Technician•1/17/25, 6:44 PM

great, I wanted to make sure that wouldn't upset anything in the step architecture

M

Mr. Technician•1/17/25, 6:45 PM

the only thing cloudflare workers is missing is support for puppeteer stealth plugins when using the browser rendering API

M

Mr. Technician•1/18/25, 5:09 PM

is this a reasonable way of making sure this variable remains accessible?

const maxFutureDays = await step.do(`get ${key} max days`, async () => 330);

const maxFutureDays = await step.do(`get ${key} max days`, async () => 330);

const maxFutureDays = await step.do(`get ${key} max days`, async () => 330);

const maxFutureDays = await step.do(`get ${key} max days`, async () => 330);

AAshley Yup! It’s just vanilla JS/TS, so you can do loops/conditionals etc

M

Mr. Technician•1/18/25, 5:12 PM

what I'm not clear on here is what happens if the engine restarts while my loop is running

M

Mr. Technician•1/18/25, 5:13 PM

for example I have a while loop that I will break out of depending on the result of the step called within it

M

Mr. Technician•1/18/25, 5:13 PM

I guess I am safe as long as all of my variables are step returns

M

Mr. Technician•1/18/25, 5:18 PM

also, I'm not sure my question was clear. I want to call steps within a loop, not use loops within a step

M

Mr. Technician•1/18/25, 5:18 PM

for example:

M

Mr. Technician•1/18/25, 5:19 PM

while (somecondition){
    await step.do(`some action `${somekey}`, async () => {});
}

while (somecondition){
    await step.do(`some action `${somekey}`, async () => {});
}

while (somecondition){
    await step.do(`some action `${somekey}`, async () => {});
}

while (somecondition){
    await step.do(`some action `${somekey}`, async () => {});
}

M

Mr. Technician•1/18/25, 5:19 PM

but this seems to violate: https://developers.cloudflare.com/workflows/build/rules-of-workflows/#name-steps-deterministically

Cloudflare Docs

Rules of Workflows · Cloudflare Workflows docs

A Workflow contains one or more steps. Each step is a self-contained, individually retriable component of a Workflow. Steps may emit (optional) state that allows a Workflow to persist and continue from that step, even if a Workflow fails due to a network or infrastructure issue.

M

Mr. Technician•1/18/25, 5:20 PM

the problem is my workflow isn't strictly deterministic, I need to check state in D1, then depending on the result from my upstream API I need to loop another step an unknown number of times

M

Mr. Technician•1/18/25, 5:21 PM

the documentation seems to discourage this

A

Ashley•1/18/25, 5:22 PM

It’s hard without knowing the underlying data, but the step name as you linked is the cache key. So as long as the data points you’re using are determinsticly named, it will just return from cache if that step name has a value. If you’re looping over results in D1, why not use the table’s primary key for example in the step name?

AAshley It’s hard without knowing the underlying data, but the step name as you linked i...

M

Mr. Technician•1/18/25, 5:27 PM

I can provide a little more context. I'm the developer of https://railforless.us/ which scrapes prices for Amtrak's trains. They use a bucket pricing system and I am working on a workflow that will find every current bucket (I know there are 8). I am scraping 14 days of prices per step, so I would loop until I have found all 8 buckets (or give up after x tries). It sounds like I could use the date range as the key and it would correctly cache the state of that step?

RailForLess.us

Taking the train shouldn't be a pain. Make your next Amtrak trip a reality with flexible scheduling and the tools you need to plan the perfect trip.

A

Ashley•1/18/25, 5:39 PM

Yes, I think so, as long as the date is consistent (e.g. not using “now” functions where the time changes etc so make sure it’s just YYYY-MM-DD or something)

M

Mr. Technician•1/18/25, 11:29 PM

it would be, yeah

MMatt Silverlock Can you share your account ID here? (it’s safe to share publicly)

R

Rakhim•1/19/25, 10:28 AM

any updates? I had to reduce the pace of creating new workflow instances in an attempt to reduce the backlog, it works but very slowly. I'm still never seeing anything close to 100 concurrent workflows

MMr. Technician I can provide a little more context. I'm the developer of https://railforless.us...

T

thousandmiles•1/20/25, 5:39 AM

great tool you built. so is your website purely serverless on cf right now?

https://developers.cloudflare.com/workflows/build/workers-api/#nonretryableerror

Similar Threads