Universal Blue•11mo ago•

101 replies

Github Action push failure on bluefin-lts{-dx,-hwe,-dx-hwe}

could someone help me out with the github actions on bluefin-lts?

Ttulip this works, without any issue

tulipOP•2/1/25, 5:14 PM

Ttulip this absolutely does not work

tulipOP•2/1/25, 5:14 PM

Ttulip Click to see attachment

tulipOP•2/1/25, 5:15 PM

i really dont know what to do here

tulipOP•2/1/25, 5:16 PM

this is the last blocker to getting -hwe and -dx working on this

tulipOP•2/1/25, 5:17 PM

@p5 friendly ping since i believe this might be of your interest

tulipOP•2/1/25, 5:20 PM

OH MY GOD I GOT IT

tulipOP•2/1/25, 5:21 PM

its doign

lts-amd64

lts-amd64

without like any reason to do so

tulipOP•2/1/25, 5:21 PM

it should be just :lts

Robert•2/1/25, 5:57 PM

@tulip It needs to push the images to lts-<arch>

Robert•2/1/25, 5:57 PM

The images are pushed first to the registry under that tag, then they are tagged with just lts in the manifest job

RRobert @tulip It needs to push the images to lts-<arch>

tulipOP•2/1/25, 5:58 PM

it doesnt seem to have pushed the images properly :( i think i brome something

tulipOP•2/1/25, 5:58 PM

check this out

tulipOP•2/1/25, 5:58 PM

thats why then!!!

tulipOP•2/1/25, 5:58 PM

tulipOP•2/1/25, 5:58 PM

it got pushed like this

Robert•2/1/25, 5:58 PM

Yeah. That's normal

RRobert @tulip It needs to push the images to lts-<arch>

tulipOP•2/1/25, 6:00 PM

man so this really makes me wonder then, why dont the other ones work...

Robert•2/1/25, 6:01 PM

So to summarise:
1. Create a matrix JSON from the required architectures
2. Build, rechunk and push to lts-<arch> in matrix
3. Collect all outputs from builds and push a single manifest, with the required end-user facing labels and tags

Is something not working?

RRobert So to summarise: 1. Create a matrix JSON from the required architectures 2. Buil...

tulipOP•2/1/25, 6:01 PM

i changed the first step, i just put a matrix directly there

tulipOP•2/1/25, 6:01 PM

pretty sure that broke it.

Robert•2/1/25, 6:01 PM

Oh, main branch is broken? I can take a look

tulipOP•2/1/25, 6:01 PM

yuuup...

tulipOP•2/1/25, 6:01 PM

sorry for the trouble tho

RRobert Oh, main branch is broken? I can take a look

tulipOP•2/1/25, 6:03 PM

you used the

include:

include:

thing to get the matrix going, with the -hwe + -dx suffixes that would mean like 8(?) includes? (+ some weird logic)

tulipOP•2/1/25, 6:03 PM

so i just put the matrix there thinking nothing would break

Robert•2/1/25, 6:04 PM

Nope. At that time, I wasn't aware of plans to use -hwe and -dx.
What I'm going to do is turn it into a reusable workflow, then have separate YAML files that call the reusable build for each

RRobert Nope. At that time, I wasn't aware of plans to use -hwe and -dx. What I'm goi...

tulipOP•2/1/25, 6:04 PM

ooh! why do we do that tho?

tulipOP•2/1/25, 6:04 PM

like, does the matrix thing not work for that?

RRobert Nope. At that time, I wasn't aware of plans to use -hwe and -dx. What I'm goi...

tulipOP•2/1/25, 6:05 PM

tbh, same?

tulipOP•2/1/25, 6:10 PM

@p5 you might want to revert my changes then btw: https://github.com/ublue-os/bluefin-lts/pull/216

GitHub

feat: enable workflows for dx and hwe by tulilirockz · Pull Request...

tulipOP•2/1/25, 6:10 PM

the logic on the

build

build

step is fine tho, fixed it later on a separate commit

tulipOP•2/1/25, 6:11 PM

here: https://github.com/ublue-os/bluefin-lts/blob/02ee360352d2f0033f55a6121ebe3fdbb95970d4/.github/workflows/build-image.yml#L77

GitHub

bluefin-lts/.github/workflows/build-image.yml at 02ee360352d2f0033f...

Bluefin LTS, built on CentOS Stream with bootc. Contribute to ublue-os/bluefin-lts development by creating an account on GitHub.

Robert•2/1/25, 6:20 PM

https://github.com/ublue-os/bluefin-lts/pull/219/files
Does this approach look okay?

like, does the matrix thing not work for that?

Nope. The matrix on the build step itself doesn't work since this will then try and put all 8 images inside a single manifest, which won't work. bluefin:lts would contain hwe, dx, non-dx, non-hwe etc.

We need to call the workflow separately for each image because we need to make a single manifest for each image

GitHub

fix: refactor workflow to support multiple images by p5 · Pull Requ...

Robert•2/1/25, 6:21 PM

Depending on how GITHUB_ENV is handled between different jobs, I may need to do something more

RRobert https://github.com/ublue-os/bluefin-lts/pull/219/files Does this approach look o...

tulipOP•2/1/25, 6:21 PM

looks perfect to me! - the only thing is that like, we need

-hwe-dx

-hwe-dx

too

tulipOP•2/1/25, 6:21 PM

dunno if that handles that

tulipOP•2/1/25, 6:21 PM

its kinda like the current bluefin workflows

RRobert https://github.com/ublue-os/bluefin-lts/pull/219/files Does this approach look o...

tulipOP•2/1/25, 6:21 PM

ooooooooooh thats why oh my god

i would never figure that out

Robert•2/1/25, 6:22 PM

I've not changed your build logic, so that should just be a new file with hwe-dx passed in as an input

tulipOP•2/1/25, 6:22 PM

perfect then!

RRobert I've not changed your build logic, so that should just be a new file with hwe-dx...

tulipOP•2/1/25, 6:23 PM

we can add that as a follow up

tulipOP•2/1/25, 6:23 PM

ill merge this

tulipOP•2/1/25, 6:23 PM

is that ok?

tulipOP•2/1/25, 6:23 PM

LGTM tho

Robert•2/1/25, 6:23 PM

Not yet! I'm researching if I need to handle the IMAGE_NAME logic in the manifest step too

tulipOP•2/1/25, 6:23 PM

ooh okok

Robert•2/1/25, 6:24 PM

Going to change the image name to a test one and try a full build + push

tulipOP•2/1/25, 6:24 PM

the IMAGE_NAME gets changed on the build workflow

Github Action push failure on bluefin-lts{-dx,-hwe,-dx-hwe}

Similar Threads

Similar Threads

Similar Threads