Universal Blue•11mo ago

We didn't need to do any tricking or anything - it "just worked". Perhaps you're changing something

We didn't need to do any tricking or anything - it "just worked".
Perhaps you're changing something we're not?

RRobert We didn't need to do any tricking or anything - it "just worked". Perhaps you'r...

RoyalOughtness•2/2/25, 2:19 AM

if anything we're doing less branding

RoyalOughtness•2/2/25, 2:19 AM

hmm

Ttulip its something in-image, the action doesnt do anything special

RoyalOughtness•2/2/25, 2:19 AM

yeah i thought it was os-release

RoyalOughtness•2/2/25, 2:20 AM

i may have to read the image builder code smh

tulip•2/2/25, 2:20 AM

its kinda crazy we actually made this work LOL

tulip•2/2/25, 2:20 AM

heliumOS also ran into that issue

RoyalOughtness•2/2/25, 2:20 AM

like.. our /etc/os-release modifications were "stolen" directly from bluefin, it should be identical

tulip•2/2/25, 2:20 AM

man i think its /usr/lib/os-release?

RoyalOughtness•2/2/25, 2:20 AM

ID=secureblue
ID_LIKE="fedora"

ID=secureblue
ID_LIKE="fedora"

RRoyalOughtness ``` ID=secureblue ID_LIKE="fedora" ```

tulip•2/2/25, 2:20 AM

that absolutely looks like it

Ttulip man i think its /usr/lib/os-release?

RoyalOughtness•2/2/25, 2:21 AM

they're identical

RoyalOughtness•2/2/25, 2:21 AM

hmm

RRoyalOughtness ``` ID=secureblue ID_LIKE="fedora" ```

tulip•2/2/25, 2:21 AM

nvm we edited that on bluefin:lts too

RoyalOughtness•2/2/25, 2:21 AM

maybe it's because there's no def for fedora 41

RoyalOughtness•2/2/25, 2:21 AM

but there is for centos

RoyalOughtness•2/2/25, 2:21 AM

:thonk:

RobertOP•2/2/25, 2:21 AM

    imageDef, err := distrodef.LoadImageDef(c.DistroDefPaths, c.SourceInfo.OSRelease.ID, c.SourceInfo.OSRelease.VersionID, "anaconda-iso")

    imageDef, err := distrodef.LoadImageDef(c.DistroDefPaths, c.SourceInfo.OSRelease.ID, c.SourceInfo.OSRelease.VersionID, "anaconda-iso")

RobertOP•2/2/25, 2:21 AM

This is where those defs are matched against

RRobert ``` imageDef, err := distrodef.LoadImageDef(c.DistroDefPaths, c.SourceInfo.O...

RoyalOughtness•2/2/25, 2:21 AM

yeah, so bluefin should have the same issue

RoyalOughtness•2/2/25, 2:21 AM

i think

RoyalOughtness•2/2/25, 2:22 AM

since osrelease id is "bluefin" for which there is no def

RoyalOughtness•2/2/25, 2:22 AM

tulip•2/2/25, 2:22 AM

literally that

James•2/2/25, 2:25 AM

I just add a manifest on my fork of image builder lol. Seems crazy to have a list per OS in the public version of bib

JJames I just add a manifest on my fork of image builder lol. Seems crazy to have a lis...

RoyalOughtness•2/2/25, 2:26 AM

I just add a manifest on my fork of image builder lol.

why didn't i think of this lmao

RobertOP•2/2/25, 2:26 AM

I'd open an issue in the osbuild/bootc-image-builder repo. Requiring each distro or image that wants to use BIB to have a file in their repo isn't very scalable

RRobert I'd open an issue in the osbuild/bootc-image-builder repo. Requiring each distr...

James•2/2/25, 2:26 AM

I did? Or maybe commented. They said they are happy to add more

JJames I did? Or maybe commented. They said they are happy to add more

RoyalOughtness•2/2/25, 2:27 AM

is this you? https://github.com/osbuild/bootc-image-builder/pull/771#issuecomment-2572646810

RoyalOughtness•2/2/25, 2:27 AM

small world

RobertOP•2/2/25, 2:30 AM

Created this to remind them and start a discussion
https://github.com/osbuild/bootc-image-builder/issues/816

GitHub

Support changes in /etc/os-release without requiring new OS definit...

Do we want to add manifests for all custom images? I can imageing the list becoming very long. Or should there be some way to pass it in to the build? Probably a bit of both; I see no real necessit...