Keep getting this crash sometimes when I load up.

awake-maroon · 2025-03-12T22:49:34.596Z

Sometimes I would say maybe 1 in 3 times I load up tmodloader I get this crash, its not a huge deal but does anyone have any ideas?

T

tModLoader•3/12/25, 10:49 PM

Automatic Hastebin for realjackk

(client.log)

(client.log)

(client.log)

(client.log): https://hst.sh/ofuyaqatov.cs

A

awake-maroonOP•3/12/25, 10:50 PM

I have no clue what the issue could be as I don't have the understanding to read these error logs, but I would appreciate some help

J

jopojelly•3/12/25, 10:58 PM

We haven't been able to reliably replicate this issue, but it pretty much always involves the HighFPSSupport mod.

A

awake-maroonOP•3/12/25, 10:58 PM

Ahh interesting interesting, I might have some valuable info I just tested

A

awake-maroonOP•3/12/25, 10:58 PM

It seems to happen when I tab out of the game during loading

A

awake-maroonOP•3/12/25, 10:59 PM

Even if I tab out and back in, it normally crashes

A

awake-maroonOP•3/12/25, 10:59 PM

However if I just dont tab out, it doesnt crash

A

awake-maroonOP•3/12/25, 10:59 PM

I guess its probably something to do with that mod, but no worries

J

jopojelly•3/12/25, 11:03 PM

So, you are tabbed out while the game is loading from the start, or are you tabbing out just while mods are loading?

A

awake-maroonOP•3/12/25, 11:04 PM

I tabbed out while the mods are loading, then it continues to load for a few seconds and then crashes.

A

awake-maroonOP•3/12/25, 11:05 PM

I havent experienced the crash if I just tab out

A

awake-maroonOP•3/12/25, 11:05 PM

And it does seem to be HighFPSSupport as if I remove it I can tab out during loading completely fine

J

jopojelly•3/12/25, 11:07 PM

@Chicken Bones Here is some more replication steps for that "Referenced cell no longer exists (Parameter 'cellRef')" issue I pinged you about before. Seems like tabbing out while mods are loading is a key component to replicating.

A

awake-maroonOP•3/12/25, 11:09 PM

It doesnt always seem to happen still, but definitely seems to happen when tabbing out the most

A

awake-maroonOP•3/12/25, 11:09 PM

If I just dont tab out, it doesnt happen

C

Chicken Bones•3/12/25, 11:12 PM

I will have a go at replicating, take a look at the mod, and escalate to MonoMod

C

Chicken Bones•3/13/25, 12:51 AM

Who makes HighFPSSupport?

C

Chicken Bones•3/13/25, 1:01 AM

@jopojelly I think this is the first one with a full

client.log

client.log

client.log

client.log

It looks like it might be happening when you try and add a new

ILHook

ILHook

ILHook

ILHook to a method which already had an

ILHook

ILHook

ILHook

ILHook and is currently executing.

In this log, it happens in

DrawMenu

DrawMenu

DrawMenu

DrawMenu, which is already IL hooked by

InnoVault

InnoVault

InnoVault

InnoVault, but it looks like

HighFPSSupport

HighFPSSupport

HighFPSSupport

HighFPSSupport adds two IL hooks to

DoDraw

DoDraw

DoDraw

DoDraw itself, which is the method I've seen in other stack traces.

C

Chicken Bones•3/13/25, 1:01 AM

[22:47:16.896] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DrawMenu(GameTime) added by InnoVault
...
[22:47:20.803] [.NET TP Worker/DEBUG] [tML]: Hook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
...
[22:47:20.847] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
...
[22:47:20.912] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
[22:47:20.996] [Main Thread/ERROR] [Terraria]: System.ArgumentException: Referenced cell no longer exists (Parameter 'cellRef')
   at MonoMod.Utils.DynamicReferenceManager.GetCell(DynamicReferenceCell cellRef) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 167
   at MonoMod.Utils.DynamicReferenceManager.GetValueRefUnsafe[T](DynamicReferenceCell cellRef) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 219
   at MonoMod.Utils.DynamicReferenceManager.GetValueTUnsafe[T](Int32 index, Int32 hash) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 251
   at DMD<DMD<>?29812957::Terraria.Main::DrawMenu>(Main this, GameTime gameTime)
   at SyncProxy<System.Void Terraria.Main:DrawMenu(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at DMD<DMD<>?47174377::Terraria.Main::DoDraw>(Main this, GameTime gameTime)
   at HighFPSSupport.TickRateModifier.OnDraw(orig_DoDraw orig, Main self, GameTime gameTime) in HighFPSSupport\TickRateModifier.cs:line 77
   at Hook<System.Void HighFPSSupport.TickRateModifier::OnDraw(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at SyncProxy<System.Void Terraria.Main:DoDraw(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at Terraria.Main.Draw_Inner(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53070
   at Terraria.Main.Draw(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53057
[22:47:21.025] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DrawMenu(GameTime) added by HighFPSSupport

[22:47:16.896] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DrawMenu(GameTime) added by InnoVault
...
[22:47:20.803] [.NET TP Worker/DEBUG] [tML]: Hook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
...
[22:47:20.847] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
...
[22:47:20.912] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
[22:47:20.996] [Main Thread/ERROR] [Terraria]: System.ArgumentException: Referenced cell no longer exists (Parameter 'cellRef')
   at MonoMod.Utils.DynamicReferenceManager.GetCell(DynamicReferenceCell cellRef) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 167
   at MonoMod.Utils.DynamicReferenceManager.GetValueRefUnsafe[T](DynamicReferenceCell cellRef) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 219
   at MonoMod.Utils.DynamicReferenceManager.GetValueTUnsafe[T](Int32 index, Int32 hash) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 251
   at DMD<DMD<>?29812957::Terraria.Main::DrawMenu>(Main this, GameTime gameTime)
   at SyncProxy<System.Void Terraria.Main:DrawMenu(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at DMD<DMD<>?47174377::Terraria.Main::DoDraw>(Main this, GameTime gameTime)
   at HighFPSSupport.TickRateModifier.OnDraw(orig_DoDraw orig, Main self, GameTime gameTime) in HighFPSSupport\TickRateModifier.cs:line 77
   at Hook<System.Void HighFPSSupport.TickRateModifier::OnDraw(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at SyncProxy<System.Void Terraria.Main:DoDraw(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at Terraria.Main.Draw_Inner(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53070
   at Terraria.Main.Draw(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53057
[22:47:21.025] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DrawMenu(GameTime) added by HighFPSSupport

[22:47:16.896] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DrawMenu(GameTime) added by InnoVault
...
[22:47:20.803] [.NET TP Worker/DEBUG] [tML]: Hook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
...
[22:47:20.847] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
...
[22:47:20.912] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
[22:47:20.996] [Main Thread/ERROR] [Terraria]: System.ArgumentException: Referenced cell no longer exists (Parameter 'cellRef')
   at MonoMod.Utils.DynamicReferenceManager.GetCell(DynamicReferenceCell cellRef) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 167
   at MonoMod.Utils.DynamicReferenceManager.GetValueRefUnsafe[T](DynamicReferenceCell cellRef) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 219
   at MonoMod.Utils.DynamicReferenceManager.GetValueTUnsafe[T](Int32 index, Int32 hash) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 251
   at DMD<DMD<>?29812957::Terraria.Main::DrawMenu>(Main this, GameTime gameTime)
   at SyncProxy<System.Void Terraria.Main:DrawMenu(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at DMD<DMD<>?47174377::Terraria.Main::DoDraw>(Main this, GameTime gameTime)
   at HighFPSSupport.TickRateModifier.OnDraw(orig_DoDraw orig, Main self, GameTime gameTime) in HighFPSSupport\TickRateModifier.cs:line 77
   at Hook<System.Void HighFPSSupport.TickRateModifier::OnDraw(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at SyncProxy<System.Void Terraria.Main:DoDraw(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at Terraria.Main.Draw_Inner(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53070
   at Terraria.Main.Draw(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53057
[22:47:21.025] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DrawMenu(GameTime) added by HighFPSSupport

[22:47:16.896] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DrawMenu(GameTime) added by InnoVault
...
[22:47:20.803] [.NET TP Worker/DEBUG] [tML]: Hook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
...
[22:47:20.847] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
...
[22:47:20.912] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DoDraw(GameTime) added by HighFPSSupport
[22:47:20.996] [Main Thread/ERROR] [Terraria]: System.ArgumentException: Referenced cell no longer exists (Parameter 'cellRef')
   at MonoMod.Utils.DynamicReferenceManager.GetCell(DynamicReferenceCell cellRef) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 167
   at MonoMod.Utils.DynamicReferenceManager.GetValueRefUnsafe[T](DynamicReferenceCell cellRef) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 219
   at MonoMod.Utils.DynamicReferenceManager.GetValueTUnsafe[T](Int32 index, Int32 hash) in /_/src/MonoMod.Utils/DynamicReferenceManager.cs:line 251
   at DMD<DMD<>?29812957::Terraria.Main::DrawMenu>(Main this, GameTime gameTime)
   at SyncProxy<System.Void Terraria.Main:DrawMenu(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at DMD<DMD<>?47174377::Terraria.Main::DoDraw>(Main this, GameTime gameTime)
   at HighFPSSupport.TickRateModifier.OnDraw(orig_DoDraw orig, Main self, GameTime gameTime) in HighFPSSupport\TickRateModifier.cs:line 77
   at Hook<System.Void HighFPSSupport.TickRateModifier::OnDraw(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at SyncProxy<System.Void Terraria.Main:DoDraw(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
   at Terraria.Main.Draw_Inner(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53070
   at Terraria.Main.Draw(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53057
[22:47:21.025] [.NET TP Worker/DEBUG] [tML]: ILHook Terraria.Main::DrawMenu(GameTime) added by HighFPSSupport

J

jopojelly•3/13/25, 1:03 AM

Makes sense. I do remember thinking it could be something similar to what you mentioned being the root cause

C

Chicken Bones•3/13/25, 1:08 AM

So, while it wouldn't solve this case of

InnoVault

InnoVault

InnoVault

InnoVault and

HighFPSSupport

HighFPSSupport

HighFPSSupport

HighFPSSupport hooking the same method,

HighFPSSupport

HighFPSSupport

HighFPSSupport

HighFPSSupport could temporarily work around this by merging its two IL hooks.

It could also avert this incompatibility by adding this specific hook inside a

QueueMainThreadAction

QueueMainThreadAction

QueueMainThreadAction

QueueMainThreadAction to avoid the race condition

C

Chicken Bones•3/13/25, 1:14 AM

Added https://github.com/MonoMod/MonoMod/issues/220 to track

J

jopojelly•3/13/25, 1:14 AM

I see. So if they are combined, it'll still crash if the other mod is present, but the QueueMainThread should avoid it altogether?

C

Chicken Bones•3/13/25, 1:16 AM

It's only a risk when il-hooking an already il-hooked and executing method. In this log

InnoVault

InnoVault

InnoVault

InnoVault hooks first, so it can't trigger the race, but if another mod was to load before it, or the hook order isn't deterministic, then they would also need to use

QueueMainThreadAction

QueueMainThreadAction

QueueMainThreadAction

QueueMainThreadAction

J

jopojelly•3/13/25, 1:16 AM

I think our only option is the steam workshop comments to contact them. Others say he's Chinese and not here.

C

Chicken Bones•3/13/25, 1:16 AM

Ultimately we should fix the issue in MonoMod, but I don't have a timeframe for that

J

jopojelly•3/13/25, 1:17 AM

Yeah.

T

then-purple•3/13/25, 2:03 AM

Yeah I couldn't reproduce this crash myself (assuming it's caused by tabbing out while loading mods). It has been reported several times though
I can merge those two hooks if we're confident that would be a workaround

T

then-purple•3/13/25, 2:04 AM

Will anyone be able to test after I update the mod?

J

jopojelly•3/13/25, 2:07 AM

You should also put the hook registration in a QueueMainThreadAction method. Merging the 2 will help, but the QueueMainThreadAction part is most likely to fix the issue

J

jopojelly•3/13/25, 2:10 AM

like this, I think

J

jopojelly•3/13/25, 2:13 AM

            Main.QueueMainThreadAction(() => {
                IL_Main.DoUpdate += PatchDoUpdate;
            });

            Main.QueueMainThreadAction(() => {
                IL_Main.DoUpdate += PatchDoUpdate;
            });

            Main.QueueMainThreadAction(() => {
                IL_Main.DoUpdate += PatchDoUpdate;
            });

            Main.QueueMainThreadAction(() => {
                IL_Main.DoUpdate += PatchDoUpdate;
            });

J

jopojelly•3/13/25, 2:13 AM

If you want to post the .tmod for testing, maybe Jack or chicken bones can do that, I don't have a high fps monitor myself.

SStellar Will anyone be able to test after I update the mod?

C

Chicken Bones•3/13/25, 2:31 AM

because it's a race condition, it's difficult to consistently reproduce. Your best bet is to just make sure the hook is still applying and release and see if issues go away. (Please let us know the version of the new release so we can keep an eye out for old versions in support tickets)

T

then-purple•3/13/25, 3:02 AM

Alright, new version (0.6.6.3) is up where I merged the two hooks into one and wrapped it in a

Main.QueueMainThreadAction()

Main.QueueMainThreadAction()

Main.QueueMainThreadAction()

Main.QueueMainThreadAction(). Hopefully that works

T

then-purple•3/13/25, 3:05 AM

Also fwiw it kinda feels like mod loading shouldn't be triggered by a widget draw function.

Load()

Load()

Load()

Load() seems like a reasonable place for mods to apply IL hooks that affect drawing/UI. Obviously fixing the MonoMod bug itself is ideal, but deferring mod loading to not happen while the game is drawing would have also avoided this

C

Chicken Bones•3/13/25, 3:17 AM

Preventing drawing while mods are loading would mean a UI freeze for basically the entire duration of mod loading

C

Chicken Bones•3/13/25, 3:18 AM

We execute the bare minimum of draw code while loading mods, just the menu UI

T

then-purple•3/13/25, 3:19 AM

Ah so it's an async thing, that makes sense

C

Chicken Bones•3/13/25, 4:18 AM

Yeah,

QueueMainThreadAction

QueueMainThreadAction

QueueMainThreadAction

QueueMainThreadAction lets you apply your hook at a time when there is no drawing or updating happening

Keep getting this crash sometimes when I load up.

Similar Threads

Similar Threads

Similar Threads