gnome-shell logo-menu

Original message was deleted

bsherman•5/30/25, 3:55 PM

@Lorbus I'm looking for eyes on why this build failed

https://github.com/ublue-os/packages/pull/526

I think it may be the patch doesn't apply cleanly

GitHub

chore: Revert "chore(logo-menu): bump to 89e0e4d84b97e65f0787e19566...

Reverts #516

Lorbus•5/30/25, 3:58 PM

yup looks like the patch can't be applied

bsherman•5/30/25, 3:59 PM

that IS in fact the problem and i see why now

Lorbus•5/30/25, 3:59 PM

I detest hacking on patch files directly. Imo it's better to generate them from a forked branch carrying those changes

bsherman•5/30/25, 3:59 PM

yeah, i think that may be the reason Kyle originally did this via a fork

bsherman•5/30/25, 4:00 PM

it's more automated that the changes we maintain in the fork would be auto-applied when we update from upstream

Lorbus•5/30/25, 4:01 PM

yeah, auto rebasing also doesn't always work :/ either way is annoying

bsherman•5/30/25, 4:03 PM

related, but not exactly about this particular package...

since you were commenting on how package version/release should work

i wonder what your thoughts are about this...

Lorbus•5/30/25, 4:03 PM

did the 0.1.0-1 package get build and added to the repo?

bsherman•5/30/25, 4:03 PM

we have some packages which use version/release like this

Version:       {{{ git_dir_version }}}
Release:       1%{?dist}

Version:       {{{ git_dir_version }}}
Release:       1%{?dist}

Lorbus•5/30/25, 4:03 PM

if yes, the new build should get 0.1.0-2 or so, otherwise it won't get picked up

Lorbus•5/30/25, 4:04 PM

We should probably use %autorelease - see https://fedora-infra.github.io/rpmautospec-docs/autorelease.html

bsherman•5/30/25, 4:05 PM

when logo-menu was moved from fork to patch, it was changed to:

# renovate: datasource=git-refs depName=https://github.com/Aryan20/Logomenu versioning=loose currentValue=main
%global commit 89e0e4d84b97e65f0787e195663090f157dd82ae
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global gitrel      .git%{shortcommit}

Version:       0.0.0
Release:       4%{gitrel}%{?dist}

# renovate: datasource=git-refs depName=https://github.com/Aryan20/Logomenu versioning=loose currentValue=main
%global commit 89e0e4d84b97e65f0787e195663090f157dd82ae
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global gitrel      .git%{shortcommit}

Version:       0.0.0
Release:       4%{gitrel}%{?dist}

LLorbus if yes, the new build should get 0.1.0-2 or so, otherwise it won't get picked up

bsherman•5/30/25, 4:07 PM

it's not THAT important since we don't do dnf updates of this package... and I am happy to purge the known bad package from the COPR repo

Lorbus•5/30/25, 4:08 PM

0.1.0-1 never landed it seems, so 0.0.0-4 should be fine (https://copr.fedorainfracloud.org/coprs/ublue-os/staging/package/gnome-shell-extension-logo-menu/)

LLorbus We should probably use %autorelease - see https://fedora-infra.github.io/rpmauto...

bsherman•5/30/25, 4:12 PM

ok so what i read here is %autorelease%autorelease should be good for us...

and we'd use the same version as upstream, if they have a version...
but for packages where we create the spec (eg, this gnome-shell logo-menu package doesn't have an upstream RPM spec), then we could still use the git sha (probably of the upstream repo)

bsherman•5/30/25, 4:12 PM

i'm trying to come up with a consistent way to do this... our specs seem to be all over the place

Lorbus•5/30/25, 4:15 PM

should I just package logo-menu in Fedora then?

Lorbus•5/30/25, 4:15 PM

gnome-shell will hopefully go away soon when the switcheroo stuff lands

Lorbus•5/30/25, 4:16 PM

but I agree, it's gonna be difficult to find a solution that fits all

LLorbus should I just package logo-menu in Fedora then? 😄

bsherman•5/30/25, 4:20 PM

we'll always need a fork... because the maintainer won't include non-FOSS logos, so and we want to ship Ampere and Framework logos (and you want Windows LOL)

Lorbus•5/30/25, 4:23 PM

it shouldn't be too hard to setup a fork with a renovate bot or so trying to rebase on upstream change. On success, a patch file could then be generated and a PR to packages opened

Lorbus•5/30/25, 4:24 PM

but someone needs to set that up first ofc

bsherman•5/30/25, 4:35 PM

maintaining patches and forks is annoying

bsherman•5/30/25, 4:48 PM

that's purely a lament, not arguing against

Lorbus•5/30/25, 4:48 PM

it's an unfortunate necessity

bsherman•5/30/25, 4:48 PM

yep

# renovate: datasource=git-refs depName=https://github.com/Aryan20/Logomenu versioning=loose currentValue=main %global commit 89e0e4d84b97e65f0787e195663090f157dd82ae %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global gitrel .git%{shortcommit} Version: 0.0.0 Release: 4%{gitrel}%{?dist}

gnome-shell logo-menu

Similar Threads

Similar Threads

Similar Threads