League of Extraordinary FoundryVTT Developers•5y ago

I do wonder. Did .8 break more things than .7? I'm curious if this ritual is normal for each milesto

I do wonder. Did .8 break more things than .7? I'm curious if this ritual is normal for each milestone release.

0.8 involved a large refactor of how Entities worked. It's probably one of the more fundamentally breaking things (though a lot of effort has been put into deprecation paths). Mostly, updates only tend to break in the things that touch the specific features being improved (e.g. 0.7 broke a lot of lighting stuff, and 0.8 will break a chunk of audio stuff - because those are getting an overhaul). It's just that one of the "things being improved" in 0.8 was "the entire backend, the way the code is organised, and how data structures are handled".

n0qOP•5/7/21, 7:03 PM

That makes sense.

Nn0q I do wonder. Did .8 break more things than .7? I'm curious if this ritual is nor...

Calego•5/7/21, 7:15 PM

Major core changes do usually have this kind of ripple effect. I've only lived through 07 and now 08, but its usually a matter of "how much wierd do you do" in your codebase, combined with "how much do you put your fingers into things at a low level" which determines how much the big hits affect you.

Calego•5/7/21, 8:03 PM

Is there a way to update compendium entries without affecting the ID?

Calego•5/7/21, 8:04 PM

merge by name or something?

PPhoenix Anyone seen this with async rolls turned on? Some reason I am getting duplicate ...

arcanistzed•5/7/21, 9:12 PM

What code are you using?

FloRadical•5/7/21, 9:25 PM

is anybody here familiar on how to use the ContextMenuContextMenu class?

FFloRadical is anybody here familiar on how to use the `ContextMenu` class?

arcanistzed•5/7/21, 9:31 PM

I recently made a module that uses it, so I'm slightly familiar

BadIdeasBureau•5/7/21, 9:31 PM

I've poked it in a different context with a module so I'm confused in appropriately specific ways

FloRadical•5/7/21, 9:32 PM

do I just instantiate the class somewhere? Is it possible to open on a click instead of a right-click?

FFloRadical do I just instantiate the class somewhere? Is it possible to open on a click ins...

arcanistzed•5/7/21, 9:34 PM

What I did was hook into the getXXXXDirectoryEntryContextgetXXXXDirectoryEntryContext hook and then modify the contextEntries argument. I don't think it would be easy to use a click instead. That would probably require making your own hook or something

FloRadical•5/7/21, 9:35 PM

ah, right. I want to make my own contextmenu in my own Formapp

arcanistzed•5/7/21, 9:35 PM

Hooks.on('getJournalDirectoryEntryContext', (_html, contextEntries) => {
    contextEntries.push({
        name: "myFormApp",
        icon: `<i class="fas fa-code"></i>`,
        condition: {},
        callback: data => {            
            new myFormApp().render(true);
        }
    })
});

Hooks.on('getJournalDirectoryEntryContext', (_html, contextEntries) => {
    contextEntries.push({
        name: "myFormApp",
        icon: `<i class="fas fa-code"></i>`,
        condition: {},
        callback: data => {            
            new myFormApp().render(true);
        }
    })
});

BadIdeasBureau•5/7/21, 9:36 PM

As far as I can tell, yes you just instantiate it (passing the HTML of the thing you want them to right click on), and I can't see a way to bind it to click instead.

BadIdeasBureau•5/7/21, 9:36 PM

(I have to override the function that generates it for scene-viewer since that one doesn't get a hook for the options, and it just takes in some html and then passes that html right to the constructor, with a set of options - nothing that looks like it could change what it's listening for)

BadIdeasBureau•5/7/21, 9:38 PM

new ContextMenu(html, ".directory-item", menuItems);new ContextMenu(html, ".directory-item", menuItems); is the only bit of the code that actually deals with creating the contextMenu (which then promptly vanishes into the abyss, never to be usefully referenceable again)

FloRadical•5/7/21, 9:42 PM

well you can assign it to a variable and return it

FloRadical•5/7/21, 9:42 PM

but I see

FFloRadical well you can assign it to a variable and return it

BadIdeasBureau•5/7/21, 9:42 PM

Yeah, but a bunch of the ones in core don't do that

I need to do some digging at some point and make an issue for it, tbh.

FloRadical•5/7/21, 9:43 PM

FloRadical•5/7/21, 9:45 PM

almost. It keeps vanishing xD

FloRadical•5/7/21, 9:45 PM

maybe because Iassigned it the click event?

FloRadical•5/7/21, 9:45 PM

on a button?

BadIdeasBureau•5/7/21, 9:46 PM

Yeah, I think it just gets assigned to an element and sets up its own event. Honestly not entirely sure, but that's a reasonable theory.

FloRadical•5/8/21, 10:51 AM

It works perfectly fine when using the contextmenu event. I talked to Atro about it and he was quite bewildered

FloRadical•5/8/21, 10:56 AM

Indeed

corporat•5/8/21, 2:54 PM

do the render hooks not trigger on a refresh for some reason?

corporat•5/8/21, 2:56 PM

That sounds silly, I know. What's the best way to debug confirm something didn't go wrong with registering my hook? Or maybe the hook code isn't loaded before the render? Is that even possible?

Ccorporat That sounds silly, I know. What's the best way to debug confirm something didn't...

Calego•5/8/21, 3:00 PM

You can usually do something like add in a console log or debugger in your hook callback to see if it's being fired.

Core will log which hooks should be fired even if there are no registered callbacks when you have the hooks debugging on

corporat•5/8/21, 3:00 PM

yeah I tried that and got nothing

Calego•5/8/21, 3:01 PM

First thing to check is spelling, after that, where are you registering the hook?

Hooks.on('getJournalDirectoryEntryContext', (_html, contextEntries) => { contextEntries.push({ name: "myFormApp", icon: `<i class="fas fa-code"></i>`, condition: {}, callback: data => { new myFormApp().render(true); } }) });