League of Extraordinary FoundryVTT Developers•5y ago

Yeah may not need to be an explicit hook for the first one tbh, could just be an object containing n

Yeah may not need to be an explicit hook for the first one tbh, could just be an object containing name/func/condition to trigger that's set at the system level

WHITESPINE•7/14/21, 4:58 PM

Including the roll info/total, who by, what with, upon whom

GGrygon Yeah may not need to be an explicit hook for the first one tbh, could just be an...

WHITESPINE•7/14/21, 4:58 PM

I mean that's basically what hooks are

WHITESPINE•7/14/21, 4:58 PM

Making a hook isn't like, a really formal process

GrygonOP•7/14/21, 4:58 PM

One issue with hooks is they're difficult for non-modules/systems to work with though

GrygonOP•7/14/21, 4:59 PM

I'm imagining more of a system setting thing for this use case

WHITESPINE•7/14/21, 4:59 PM

I don't think we should try to handle this ourselves tbh

WHITESPINE•7/14/21, 4:59 PM

I think dnd system kinda does it right

WHITESPINE•7/14/21, 4:59 PM

There's a robust module ecosystem for handling different levels of people's preferred automation

WHITESPINE•7/14/21, 5:00 PM

Not making it hook based gates functionality entirely to us, basically

GrygonOP•7/14/21, 5:00 PM

Fair, a hook can't hurt at least

WHITESPINE•7/14/21, 5:00 PM

not to mention there's modules that let users set hooks to run macros

WHITESPINE•7/14/21, 5:02 PM

I fully expect the community to want to go ham on this stuff

WHITESPINE•7/14/21, 5:03 PM

Automagically apply status effects, bonus damage workflows, damage application, etc

WHITESPINE•7/14/21, 5:06 PM

And my personal dream: automating brutal 3. I hate that talent! So much!

WHITESPINE•7/14/21, 5:18 PM

Yeah sorry lol

WHITESPINE•7/14/21, 5:18 PM

That's long term dreams

WHITESPINE•7/14/21, 7:14 PM

I think targets gives actors doesn't it?

WHITESPINE•7/14/21, 7:14 PM

Or might be token vs tokendocument

WHITESPINE•7/14/21, 7:15 PM

recall that you can do x.constructor.name

WHITESPINE•7/14/21, 7:15 PM

Cool

GrygonOP•7/14/21, 9:17 PM

Yeah that'd be my recommendation, helper that's a function that returns the renderTemplate result

GrygonOP•7/14/21, 9:17 PM

The macros do something similar iirc

GrygonOP•7/14/21, 9:19 PM

I think it may take an extra ms or two

WHITESPINE•7/14/21, 9:24 PM

Are you sure you aren't just describing a partial

GrygonOP•7/14/21, 9:25 PM

I always get the two mixed up

WHITESPINE•7/15/21, 1:15 AM

oh i just noticed the mech sheet grids look diff between firefox and chrome