My boss is trying to convince us that we should be caching the oauth requests in KV for x amount of

My boss is trying to convince us that we should be caching the oauth requests in KV for x amount of time, because making an extra 'fetch' each request would be expensive. Could someone say if this would actually matter

CCоle My boss is trying to convince us that we should be caching the oauth requests in...

James•11/18/21, 9:05 PM

I think the only "expensive" part about that will be any Discord API rate limits you may hit over time

CоleOP•11/18/21, 9:07 PM

Base is 50 a sec, which isn't bad

CCоle My boss is trying to convince us that we should be caching the oauth requests in...

simpson•11/18/21, 9:17 PM

you should definitely cache even for a small amount of time, unless you have a very low traffic site

CоleOP•11/18/21, 9:25 PM

it is pretty low traffic now, but of course scalability is important. trying to hit the balance of "secure" and "scalable"

CоleOP•11/18/21, 9:26 PM

with the cache having no user-end "log out" button

CоleOP•11/18/21, 10:52 PM

on topic this time, when I try to deploy, I get this:

16:39:48.894    Finished
16:39:49.042    Compiling worker to "/opt/pages/functions/user-worker.js"
16:39:49.102    Finished in 115ms.
16:39:49.108    Validating asset output directory
16:39:49.517    Deploying your site to Cloudflare's global network...
16:39:54.138    Failed: an internal error occurred

16:39:48.894    Finished
16:39:49.042    Compiling worker to "/opt/pages/functions/user-worker.js"
16:39:49.102    Finished in 115ms.
16:39:49.108    Validating asset output directory
16:39:49.517    Deploying your site to Cloudflare's global network...
16:39:54.138    Failed: an internal error occurred

any ideas? can't deploy with wrangler dev *rn cuz of the windows bug

Walshy•11/18/21, 10:53 PM

Looks like the Worker was fine

CCоle on topic this time, when I try to deploy, I get this: ``` 16:39:48.894 Finish...

Isaac McFadyen•11/18/21, 10:53 PM

~~I'm getting the same error, actually. My build was working until it was not (no changes).~~ EDIT: Fixed, working now.

Walshy•11/18/21, 10:53 PM

Can you retry the deployment?

CоleOP•11/18/21, 10:54 PM

I'm retrying it rn

CоleOP•11/18/21, 10:56 PM

almost there

CоleOP•11/18/21, 10:57 PM

yea same thing

CоleOP•11/18/21, 10:57 PM

it was doing it last night as well.

CоleOP•11/18/21, 11:03 PM

I read from cf support threads that stuff like filesize limits and filenames can mess it up, but I don't see anything weird in my project

CCоle I read from cf support threads that stuff like filesize limits and filenames can...

Walshy•11/18/21, 11:04 PM

These were fixed and give an actual error

Walshy•11/18/21, 11:05 PM

Let me report this, we've been seeing increased build failures lately.

CоleOP•11/18/21, 11:05 PM

cool

Walshy•11/18/21, 11:06 PM

Can you send me your pages.dev domain in DMs please?

IIsaac McFadyen ~~I'm getting the same error, actually. My build was working until it was not (n...

Walshy•11/18/21, 11:06 PM

What fixed it for you? Did you make any change?

CоleOP•11/18/21, 11:06 PM

I think it should be this guy here https://pvp-legacy-api.pages.dev/

Walshy•11/18/21, 11:07 PM

Walshy•11/18/21, 11:09 PM

Could you try to rename your functions folder to like functions-disabledfunctions-disabled and push? Wondering if it is the function maybe causing this failure

Walshy•11/18/21, 11:09 PM

It shouldn't be... but worth a shot

CоleOP•11/18/21, 11:09 PM

I'll give it a shot

WWalshy What fixed it for you? Did you make any change?

Isaac McFadyen•11/18/21, 11:13 PM

Not really sure... if it helps, I had to rename my functions folder to _functions because it was causing issues originally.

CоleOP•11/18/21, 11:13 PM

@walshydev it did deploy

Walshy•11/18/21, 11:13 PM

Right so it seems it was the function..

Walshy•11/18/21, 11:13 PM

hmm

CоleOP•11/18/21, 11:13 PM

I'm gonna rename it back and try, just as a sanity check

CоleOP•11/18/21, 11:34 PM

._. I think I fixed it

CоleOP•11/18/21, 11:34 PM

I'm gonna see if I can undo it and break it again

CоleOP•11/18/21, 11:43 PM

nope, no idea

CоleOP•11/18/21, 11:43 PM

very cool

GregBrimble•11/19/21, 9:53 AM

Single Worker scripts only support a single compiled file at the moment, so you'll need to bundle that yourself.

GregBrimble•11/19/21, 9:54 AM

esbuild src/index.ts --bundle --outfile=dist/_worker.js --format=esm --minifyesbuild src/index.ts --bundle --outfile=dist/_worker.js --format=esm --minify

GregBrimble•11/19/21, 9:55 AM

(Assuming build directory is

dist

dist

and you have index.tsindex.ts and app.tsapp.ts in srcsrc)

GregBrimble•11/19/21, 10:09 AM

Yup. I made one with Toucan (https://github.com/robertcepa/toucan-js) yesterday to pass to Sentry. Took about 10 minutes to set up.

GregBrimble•11/19/21, 10:11 AM

https://github.com/robertcepa/toucan-js#equivalent-of-above-as-a-module-mjs

ickerio•11/19/21, 10:54 AM

Are you able to define DOs in your pages app? Or does that have to be done separately with wrangler?

Bboojum I'm trying to implement CORS proxy (copy of https://developers.cloudflare.com/wo...

GregBrimble•11/19/21, 10:56 AM

That repo is private.

Iickerio Are you able to define DOs in your pages app? Or does that have to be done separ...

GregBrimble•11/19/21, 10:57 AM

Separately, and with wrangler v1, for now. We're working on bridging this gap and making it a more seamless experience, but haven't quite figured out what that looks like yet.

ickerio•11/19/21, 10:57 AM

Thanks Greg!

My boss is trying to convince us that we should be caching the oauth requests in KV for x amount of

Similar Threads

Similar Threads

Similar Threads