Silk.NET•4y ago

well we can do what we did for vulkan and have a TryGetPlatformExtension

PerkseyOP•4/19/22, 8:13 PM

anyways, i want to curl up in a ball in bed now, so putting the laptop away for this evening

PPerksey well we can do what we did for vulkan and have a TryGetPlatformExtension

Alexx999•4/19/22, 8:13 PM

yeah, that's what has to be done

Alexx999•4/19/22, 8:14 PM

and a different NativeLoader impl

Alexx999•4/19/22, 10:27 PM

I've even tried on Linux machine and it's the same - extension entrypoints aren't exported
soooo breaking changes to extensions are 100% fine - no one complained about this so no one is using them anyway

PerkseyOP•4/20/22, 11:09 AM

@kaijellinghaus what do you feel about the above

Kai•4/20/22, 11:09 AM

If it 100% didn't work before no reason to ensure that it stays that way

PerkseyOP•4/20/22, 11:10 AM

@alexx999_ ok cool, you've won us over on the struct package refactoring

Alexx999•4/20/22, 11:10 AM

LOL

PerkseyOP•4/20/22, 11:10 AM

but i think on the enums front we'd probably want to generate overloads on top of the naked uintuint types

PerkseyOP•4/20/22, 11:11 AM

whereas rn they just get mapped directly to the enum type

PPerksey but i think on the enums front we'd probably want to generate overloads _on top_...

PerkseyOP•4/20/22, 11:11 AM

with the only exception being cases where the enums are not 32-bit, we can just map those willy nilly

PPerksey but i think on the enums front we'd probably want to generate overloads _on top_...

Alexx999•4/20/22, 11:11 AM

we circle back to the problem that not all enums are uints, and having CLEnum64 sounds a bit... over the top

PerkseyOP•4/20/22, 11:12 AM

yep, i agree. i want to phase out CLEnum tbh in favour of new overloads/completely refactoring the signature where it's just broken so far

Alexx999•4/20/22, 11:12 AM

and having some one way and some the other is... very inconsistent?...

PerkseyOP•4/20/22, 11:12 AM

it's about not breaking where we're not already broken

Alexx999•4/20/22, 11:13 AM

the extensions are transparent, and having uint CLenum extension overload over ulong native enum is fine for the most part

PerkseyOP•4/20/22, 11:14 AM

tbh rn i'm leaning towards just merging as is and then adding overloads for bits where we don't want to break.

PerkseyOP•4/20/22, 11:14 AM

the struct stuff is pretty much good to go as i see it

Alexx999•4/20/22, 11:23 AM

btw, I have one more idea (breaking)

Alexx999•4/20/22, 11:24 AM

which is, have typed, ugh, "object handles"?

Alexx999•4/20/22, 11:25 AM

would be handy to have "Device" struct that will be only accepted by "clDevice...()" methods

Alexx999•4/20/22, 11:26 AM

now it's nint which is nice and all but not helpful, I had a bug where I passed wrong nint to the method and it... partially misbehaved? Like, no error just wrong result, very "fun" to debug

Kai•4/20/22, 3:25 PM

I think done with struct layouts (pending review) and will start working on the Scraper now

PPerksey just not that we had a RID for it

frenzibyte•4/20/22, 8:55 PM

not sure if you're aware of this by now, but osxosx should be a valid runtime identifier for fat libs (x86_64+arm64)

Ffrenzibyte not sure if you're aware of this by now, but `osx` should be a valid runtime ide...

PerkseyOP•4/20/22, 9:16 PM

see also help-and-questions

Volte•4/20/22, 9:16 PM

roeyskoe#4938

I just tested with my M1, and actually I need to fix my pr a bit. For some reason the osxosx folder only works with an Intel Mac, on M1 you need to use osx-arm64osx-arm64.

Original Message

Click here

Quoted by Perksey#6579

TechPizza•4/20/22, 9:20 PM

just look at how SkiaSharp does it

PerkseyOP•4/20/22, 9:21 PM

no thanks

PerkseyOP•4/20/22, 9:21 PM

this isn’t even my code/library

PerkseyOP•4/20/22, 9:21 PM

I don’t know why I’m hearing about it haha

frenzibyte•4/20/22, 9:22 PM

interesting... can someone link the PR? we've used osxosx and managed to publish and have a working native-library nupkg using it so far

PerkseyOP•4/20/22, 9:23 PM

I suppose our loader could just not account for it, but that’s unlikely

PerkseyOP•4/20/22, 9:23 PM

we have to do a lot of hand holding for the runtime when it pokes in NuGet packages

Ffrenzibyte interesting... can someone link the PR? we've used `osx` and managed to publish ...

roeyskoe•4/21/22, 5:18 AM

https://github.com/mellinoe/ImGui.NET/pull/318

frenzibyte•4/21/22, 5:20 AM

yeah I'm in the middle of commenting to that rn

frenzibyte•4/21/22, 5:52 AM

@roeyskoe so I've created a local package and tested against a fresh project similar to what I did in https://github.com/mellinoe/veldrid-spirv/pull/24

frenzibyte•4/21/22, 5:52 AM

and it's working for me here on macOS m1

frenzibyte•4/21/22, 5:52 AM

I believe you mentioned macOS m1 still requires osx-arm64osx-arm64?

roeyskoe•4/21/22, 5:57 AM

I already replied in github, but osxosx did not work on my M1 when I tested.

frenzibyte•4/21/22, 6:00 AM

let's keep discussing in github, better visibility there