MI'll take a look!
AI was wondering if turning on the new(ish) Incremental Garbage Collector might be a good idea. Anyone got much experience of using it?
M(there's a new incremental garbage collector?)
AWell - 3 years old new: https://docs.unity3d.com/Manual/performance-incremental-garbage-collection.html
A2019.4
Mwhich OpenXR runtime, Oculus or Steam?
Aoculus i think. i rarely change it
Amust be - otherwise steamvr would open
Myeah, okay i'll charge my Q1 up, Rosie's in London with the Q2 
Ai'm off to the beach now it's cooled down but i'm back later
Moh also, have you got the malarkey enabled or is it just pure openxr?
Msure thing! The beach is a bit far for me haha
MFound it, this is certainly an odd one esp as other buttons work but not that one, and the accounts one too
esp as other buttons work but not that one, and the accounts one tooMThere's a bug in the new input system. 
MWasPressedThisFrame only fires when the button or axis is greater than 0.5, despite me changing the default to 0.15. this is a bit of a blocker for lazy input/pressure strokes, as it only works for values above 0.5 now
AIs the bug in C# or in compiled code?
Ai.e. can we just fork it for now?
MI'm not sure yet, this code is confusing as heck 
Will take a look after lunch and fork if needed, we're already running on a forked localization package
Will take a look after lunch and fork if needed, we're already running on a forked localization package
MSo, a local localization? 
A@mikesky Is there any magic way to handle structs that contain lists so that the lists are cloned when the struct is reassigned? I'm finding myself littering the code with lines specifically to break the reference and clone when i pass the struct around.
AI can see extension methods to do deep copies but wondered if there was a neater way to handle this scenario.
AIt feels like a code smell - like I shouldn't be solving this as much as avoiding it in the first place
MCan't say I have a good idea here, sorry
Blist copying in C# is absolute garbage
Bas far as I know there isn't any easy way to prevent shallow copies but I might be wrong
ANot sure if it's a "fix" or an "enhancement" but previously layers and images/video/imported models didn't play together nicely. Only brush strokes worked properly with layers and everything else assumed it was on the main layer.
AJust fixed this. Is it worth backporting to the current beta? It will need some testing and affects the save format. @mikesky ?
MThat would be awesome, yes please!
Aokey doke. that probably nixes any chance of slipping out a 1.1 release though - it really does need some testing!
MWe are due a big test as it is
AIn which case I should probably only bother backporting it to xr_v2 
Alike - adding this to beta means beta will need to be delayed. which means xr_v2 will probably be ready. so why bother with the beta?
Moh, good point
Mthe part where it's not currently broken, just unexpected, tripped me up heh
Myeah go xr_v2 then
Acool.
AThere's another issue with layers that probably counts as "confusing UX" but I've found it to be more confusing than I originally thought
AIt's the fact that:
- Drawing on (say) layer 2
- Selecting your strokes
- Switching to (say) layer 1
- Deselecting
AThis was intentional as it provides a way to move strokes to a different layer. But it's very easy to do my mistake
AI keep doing it and I wrote the damn feature!
AI can't decide how best to handle this.
AMaybe block switching layers when there's an active selection and make it an explicit action to move stuff?
Moh yeah, I accidentally did that, thought it was intentional but cool
Mit made sense at least to me, but perhaps not to others
AOptions:
- Disallow switching layers when there's an active selection.
- Deselect automatically when switching layers
- Objects remember their original layer (more work - how do you move things to a new layer?)
A- Ask the user what they want when switching layers?
Mif we were to block it, 2 would be my natural choice
M4 sounds clunky
AA variant of 2 might be "deselect when switching layers but recall that selection when you switch back"
Ai.e. each layer remembers it's selection