Open Brush, Open Blocks, Icosa Gallery•4y ago

WasPressedThisFrame only fires when the button or axis is greater than 0.5, despite me changing the

WasPressedThisFrame only fires when the button or axis is greater than 0.5, despite me changing the default to 0.15. this is a bit of a blocker for lazy input/pressure strokes, as it only works for values above 0.5 now

Mmikesky WasPressedThisFrame only fires when the button or axis is greater than 0.5, desp...

andybak•8/16/22, 12:08 PM

Is the bug in C# or in compiled code?

andybak•8/16/22, 12:08 PM

i.e. can we just fork it for now?

mikeskyOP•8/16/22, 12:12 PM

I'm not sure yet, this code is confusing as heck

Will take a look after lunch and fork if needed, we're already running on a forked localization package

mikeage•8/16/22, 12:15 PM

So, a local localization?

andybak•8/17/22, 2:06 PM

@mikesky Is there any magic way to handle structs that contain lists so that the lists are cloned when the struct is reassigned? I'm finding myself littering the code with lines specifically to break the reference and clone when i pass the struct around.

andybak•8/17/22, 2:13 PM

I can see extension methods to do deep copies but wondered if there was a neater way to handle this scenario.

andybak•8/17/22, 2:13 PM

It feels like a code smell - like I shouldn't be solving this as much as avoiding it in the first place

mikeskyOP•8/17/22, 2:17 PM

Can't say I have a good idea here, sorry

Bootleg•8/17/22, 2:23 PM

list copying in C# is absolute garbage

Bootleg•8/17/22, 2:24 PM

as far as I know there isn't any easy way to prevent shallow copies but I might be wrong

andybak•8/19/22, 8:55 AM

Not sure if it's a "fix" or an "enhancement" but previously layers and images/video/imported models didn't play together nicely. Only brush strokes worked properly with layers and everything else assumed it was on the main layer.

andybak•8/19/22, 8:55 AM

Just fixed this. Is it worth backporting to the current beta? It will need some testing and affects the save format. @mikesky ?

Aandybak Just fixed this. Is it worth backporting to the current beta? It will need some ...

mikeskyOP•8/19/22, 8:56 AM

That would be awesome, yes please!

Mmikesky That would be awesome, yes please!

andybak•8/19/22, 8:57 AM

okey doke. that probably nixes any chance of slipping out a 1.1 release though - it really does need some testing!

mikeskyOP•8/19/22, 8:57 AM

We are due a big test as it is

andybak•8/19/22, 8:57 AM

In which case I should probably only bother backporting it to xr_v2

andybak•8/19/22, 8:58 AM

like - adding this to beta means beta will need to be delayed. which means xr_v2 will probably be ready. so why bother with the beta?

mikeskyOP•8/19/22, 8:58 AM

oh, good point

mikeskyOP•8/19/22, 8:58 AM

the part where it's not currently broken, just unexpected, tripped me up heh

mikeskyOP•8/19/22, 8:58 AM

yeah go xr_v2 then

andybak•8/19/22, 8:59 AM

cool.

andybak•8/19/22, 9:01 AM

There's another issue with layers that probably counts as "confusing UX" but I've found it to be more confusing than I originally thought

andybak•8/19/22, 9:02 AM

It's the fact that:

Drawing on (say) layer 2
Selecting your strokes
Switching to (say) layer 1
Deselecting

results in the strokes being moved to layer 1

andybak•8/19/22, 9:03 AM

This was intentional as it provides a way to move strokes to a different layer. But it's very easy to do my mistake

andybak•8/19/22, 9:03 AM

I keep doing it and I wrote the damn feature!

andybak•8/19/22, 9:03 AM

I can't decide how best to handle this.

andybak•8/19/22, 9:04 AM

Maybe block switching layers when there's an active selection and make it an explicit action to move stuff?

mikeskyOP•8/19/22, 9:04 AM

oh yeah, I accidentally did that, thought it was intentional but cool

mikeskyOP•8/19/22, 9:04 AM

it made sense at least to me, but perhaps not to others

andybak•8/19/22, 9:07 AM

Options:

Disallow switching layers when there's an active selection.
Deselect automatically when switching layers
Objects remember their original layer (more work - how do you move things to a new layer?)

andybak•8/19/22, 9:08 AM

Ask the user what they want when switching layers?

mikeskyOP•8/19/22, 9:08 AM

if we were to block it, 2 would be my natural choice

mikeskyOP•8/19/22, 9:08 AM

4 sounds clunky

andybak•8/19/22, 9:09 AM

A variant of 2 might be "deselect when switching layers but recall that selection when you switch back"

andybak•8/19/22, 9:09 AM

i.e. each layer remembers it's selection

andybak•8/19/22, 9:10 AM

but 2 still leaves open "how do you move objects to a new layer?" - this is best as an explicit user action. It's just "where does it live and what do we call it?"

andybak•8/19/22, 9:11 AM

I've been thinking about expanding "selection" with a new panel. Stuff like "saved selections list", "select all objects with same x (color, brush, type etc)"

andybak•8/19/22, 9:11 AM

or just another button on the layers palette.

andybak•8/19/22, 9:12 AM

@ancientworlds or anyone who's used layers - would be good to get input from artists?

andybak•8/19/22, 9:20 AM

Also @dangerdano - have you got any thoughts?

Bootleg•8/19/22, 10:57 AM

I would say layer switching should deselect strokes (so option 2)

Bootleg•8/19/22, 11:02 AM

As for moving strokes between layers, I have 2 ideas:

Reworking the duplication, where copying and pasting don't happen at the same time anymore. You press a button to store a selection in the clipboard, and then paste it around with a different button (can also be the same button but differ by being pressed and held)
Not touching the original duplication and instead just having some sort of storage "pocket" where you can store a selection and then extract it in a different layer