like i already done it in

LLyris the Kitori im terrible with algorithms lmao

F

Furball•10/24/22, 4:02 AM

i usually just bash my head against stuff until it works

F

Furball•10/24/22, 4:02 AM

hasnt failed me yet

LLyris the Kitori like i already done it in

H

Hanprogramer•10/24/22, 4:50 AM

oh actually yeah :v

H

Hanprogramer•10/24/22, 7:51 AM

Window window = new MainWindow("Title",800,600, "logo.png");
new Thread(() =>
{

    window._initialize();
    // Initiate win32 APIs
    new WinFormNativeWindow(window);

    while (true)
    {
        //if (IWindow.API.API == ContextAPI.OpenGL || IWindow.API.API == ContextAPI.OpenGLES)
        {
            try
            {
                window._window.MakeCurrent();
                window._window.DoUpdate();
                window._window.DoRender();
            }
            catch (GlfwException e)
            {
                Console.WriteLine($"GlfwException[handle: {window._window.Handle}]: {e.Message}");
                //continue;
            }
        }

        if (window._window.IsClosing)
            break;
    }
}).Start();

while (true)
{
    if (window._window != null)
    {
        window._window.DoEvents();
        if (window._window.IsClosing)
            break;
    }
}

Window window = new MainWindow("Title",800,600, "logo.png");
new Thread(() =>
{

    window._initialize();
    // Initiate win32 APIs
    new WinFormNativeWindow(window);

    while (true)
    {
        //if (IWindow.API.API == ContextAPI.OpenGL || IWindow.API.API == ContextAPI.OpenGLES)
        {
            try
            {
                window._window.MakeCurrent();
                window._window.DoUpdate();
                window._window.DoRender();
            }
            catch (GlfwException e)
            {
                Console.WriteLine($"GlfwException[handle: {window._window.Handle}]: {e.Message}");
                //continue;
            }
        }

        if (window._window.IsClosing)
            break;
    }
}).Start();

while (true)
{
    if (window._window != null)
    {
        window._window.DoEvents();
        if (window._window.IsClosing)
            break;
    }
}

Window window = new MainWindow("Title",800,600, "logo.png");
new Thread(() =>
{

    window._initialize();
    // Initiate win32 APIs
    new WinFormNativeWindow(window);

    while (true)
    {
        //if (IWindow.API.API == ContextAPI.OpenGL || IWindow.API.API == ContextAPI.OpenGLES)
        {
            try
            {
                window._window.MakeCurrent();
                window._window.DoUpdate();
                window._window.DoRender();
            }
            catch (GlfwException e)
            {
                Console.WriteLine($"GlfwException[handle: {window._window.Handle}]: {e.Message}");
                //continue;
            }
        }

        if (window._window.IsClosing)
            break;
    }
}).Start();

while (true)
{
    if (window._window != null)
    {
        window._window.DoEvents();
        if (window._window.IsClosing)
            break;
    }
}

Window window = new MainWindow("Title",800,600, "logo.png");
new Thread(() =>
{

    window._initialize();
    // Initiate win32 APIs
    new WinFormNativeWindow(window);

    while (true)
    {
        //if (IWindow.API.API == ContextAPI.OpenGL || IWindow.API.API == ContextAPI.OpenGLES)
        {
            try
            {
                window._window.MakeCurrent();
                window._window.DoUpdate();
                window._window.DoRender();
            }
            catch (GlfwException e)
            {
                Console.WriteLine($"GlfwException[handle: {window._window.Handle}]: {e.Message}");
                //continue;
            }
        }

        if (window._window.IsClosing)
            break;
    }
}).Start();

while (true)
{
    if (window._window != null)
    {
        window._window.DoEvents();
        if (window._window.IsClosing)
            break;
    }
}

For some reasons, i can only do

DoEvents

DoEvents

DoEvents

DoEvents on the 2nd thread

H

Hanprogramer•10/24/22, 7:51 AM

the

_window

_window

_window

_window here is the Silk.NET window

H

Hanprogramer•10/24/22, 7:52 AM

if i did it on the main thread then the window just doesn't respond

H

Hanprogramer•10/24/22, 7:55 AM

reading through Beyley's code, why is these options used?

H

Hanprogramer•10/24/22, 8:11 AM

unfortunately Beyley's program also broken on my device

LLyris the Kitori i have a super barebones codebase for doing nearly this in Silk, if it may be of...

H

Hanprogramer•10/24/22, 8:30 AM

this is the code i run ^

H

Hanprogramer•10/24/22, 8:43 AM

i am so confused now

P

Perksey•10/24/22, 10:43 AM

once again I’d like to reiterate that using any window function other than DoRender and Invoke on any thread other than the main thread is entirely undefined behaviour

P

Perksey•10/24/22, 10:44 AM

and should be assumed never to work

H

Hanprogramer•10/24/22, 12:49 PM

Yeah im confused what's wrong

NewThread({
  while:
    DoRender();
})
MainThread{
  while:
    DoUpdate();
    DoEvents();
}

NewThread({
  while:
    DoRender();
})
MainThread{
  while:
    DoUpdate();
    DoEvents();
}

NewThread({
  while:
    DoRender();
})
MainThread{
  while:
    DoUpdate();
    DoEvents();
}

NewThread({
  while:
    DoRender();
})
MainThread{
  while:
    DoUpdate();
    DoEvents();
}

this only works when i put the DoEvents on the NewThread too

H

Hanprogramer•10/24/22, 12:49 PM

which is what you say i shouldn't do

P

Perksey•10/24/22, 1:26 PM

generally if you're doing multithreading i recommend just keeping the window completely on one thread, and having rendering completely on one thread

P

Perksey•10/24/22, 1:31 PM

i.e.

bool isRunning = true;
IGLContext context;
void RenderLoop()
{
    context.MakeCurrent();
    context.SwapInterval(1); // for vsync
    var sw = new Stopwatch();
    while (isRunning)
    {
        var delta = sw.Elapsed.TotalSeconds;
        sw.Reset();
        // do rendering code
        context.SwapBuffers();
    }
}

void MainLoop()
{
    var window = Window.Create(WindowOptions.Default with { IsContextControlDisabled = true });
    window.Closing += () => isRunning = false;
    window.Load += () =>
    {
        context = window.GLContext;
        new Thread(RenderLoop).Start();
    }
    window.Run();
}

bool isRunning = true;
IGLContext context;
void RenderLoop()
{
    context.MakeCurrent();
    context.SwapInterval(1); // for vsync
    var sw = new Stopwatch();
    while (isRunning)
    {
        var delta = sw.Elapsed.TotalSeconds;
        sw.Reset();
        // do rendering code
        context.SwapBuffers();
    }
}

void MainLoop()
{
    var window = Window.Create(WindowOptions.Default with { IsContextControlDisabled = true });
    window.Closing += () => isRunning = false;
    window.Load += () =>
    {
        context = window.GLContext;
        new Thread(RenderLoop).Start();
    }
    window.Run();
}

bool isRunning = true;
IGLContext context;
void RenderLoop()
{
    context.MakeCurrent();
    context.SwapInterval(1); // for vsync
    var sw = new Stopwatch();
    while (isRunning)
    {
        var delta = sw.Elapsed.TotalSeconds;
        sw.Reset();
        // do rendering code
        context.SwapBuffers();
    }
}

void MainLoop()
{
    var window = Window.Create(WindowOptions.Default with { IsContextControlDisabled = true });
    window.Closing += () => isRunning = false;
    window.Load += () =>
    {
        context = window.GLContext;
        new Thread(RenderLoop).Start();
    }
    window.Run();
}

bool isRunning = true;
IGLContext context;
void RenderLoop()
{
    context.MakeCurrent();
    context.SwapInterval(1); // for vsync
    var sw = new Stopwatch();
    while (isRunning)
    {
        var delta = sw.Elapsed.TotalSeconds;
        sw.Reset();
        // do rendering code
        context.SwapBuffers();
    }
}

void MainLoop()
{
    var window = Window.Create(WindowOptions.Default with { IsContextControlDisabled = true });
    window.Closing += () => isRunning = false;
    window.Load += () =>
    {
        context = window.GLContext;
        new Thread(RenderLoop).Start();
    }
    window.Run();
}

H

Hanprogramer•10/24/22, 1:33 PM

ohhh i see

H

Hanprogramer•10/24/22, 1:33 PM

i started the thread before the window even loads

P

Perksey•10/24/22, 1:34 PM

IsContextControlDisabled

IsContextControlDisabled

IsContextControlDisabled

IsContextControlDisabled is important as well, the window system will keep trying to move your context back otherwise

P

Perksey•10/24/22, 1:36 PM

one day i did intend to abstract all of this into a separate

GameLoop

GameLoop

GameLoop

GameLoop class that can be configured to automatically multithread, but sadly just a pipe dream now

PPerksey `IsContextControlDisabled` is important as well, the window system will keep try...

H

Hanprogramer•10/24/22, 1:37 PM

Speaking of this one, i did this and do
context.MakeCurrent()
and
SwapBuffers()
Manually and it did increase the performance about 2x

H

Hanprogramer•10/24/22, 1:38 PM

basically i skipped this part?

P

Perksey•10/24/22, 1:40 PM

hrmfffff SwapInterval has given me so much grief over these 3 years

HHanprogramer basically i skipped this part?

P

Perksey•10/24/22, 1:43 PM

i think it's actually the IsCurrent that'd be causing the perf hit

P

Perksey•10/24/22, 1:43 PM

i mean do run it through dotTrace if you can, would be interesting to compare

H

Hanprogramer•10/24/22, 1:44 PM

I see

H

Hanprogramer•10/24/22, 1:47 PM

im still hit with the same errors as before

LLyris the Kitori i have a super barebones codebase for doing nearly this in Silk, if it may be of...

H

Hanprogramer•10/24/22, 1:47 PM

same as when i run this repo

PPerksey one day i did intend to abstract all of this into a separate `GameLoop` class th...

R

Redhacker2•10/24/22, 1:49 PM

GameLoop is too specific, I think something like ApplicationLoop would be better

P

Perksey•10/24/22, 1:50 PM

doesn't matter, it's not happening anyway

R

Redhacker2•10/24/22, 1:50 PM

fair nuff

HHanprogramer im still hit with the same errors as before

P

Perksey•10/24/22, 1:50 PM

i may have missed a

ClearContext

ClearContext

ClearContext

ClearContext in

Load

Load

Load

Load

H

Hanprogramer•10/24/22, 1:51 PM

is it inside or outside the render thread?

P

Perksey•10/24/22, 1:52 PM

    window.Load += () =>
    {
        context = window.GLContext;
+       context.Clear();
        new Thread(RenderLoop).Start();
    }

    window.Load += () =>
    {
        context = window.GLContext;
+       context.Clear();
        new Thread(RenderLoop).Start();
    }

    window.Load += () =>
    {
        context = window.GLContext;
+       context.Clear();
        new Thread(RenderLoop).Start();
    }

    window.Load += () =>
    {
        context = window.GLContext;
+       context.Clear();
        new Thread(RenderLoop).Start();
    }

R

Redhacker2•10/24/22, 1:53 PM

Why do you guys make the context current automatically? Was there a specific reason?

P

Perksey•10/24/22, 1:54 PM

like a lot of things in windowing it is designed for ease of use and to prevent confusion

P

Perksey•10/24/22, 1:54 PM

imagine how a beginner would react if they couldn't issue any GL commands on their fresh window

R

Redhacker2•10/24/22, 1:54 PM

fair enough...

H

Hanprogramer•10/24/22, 1:55 PM

It no longer crashes, but it doesn't do anything now

H

Hanprogramer•10/24/22, 1:56 PM

Here's my window options

P

Perksey•10/24/22, 1:56 PM

you probably want to move SwapBuffers into your Render callback

H

Hanprogramer•10/24/22, 1:56 PM

this is what i had

P

Perksey•10/24/22, 1:57 PM

you're probably double swapping somewhere

H

Hanprogramer•10/24/22, 1:59 PM

i dont think so?

H

Hanprogramer•10/24/22, 2:00 PM

hmmmm

P

Perksey•10/24/22, 2:01 PM

heh

P

Perksey•10/24/22, 2:02 PM

i have a feeling your render callback could be called on both threads

H

Hanprogramer•10/24/22, 2:02 PM

oh yea let me check

H

Hanprogramer•10/24/22, 2:05 PM

ok yeah it's my code

H

Hanprogramer•10/24/22, 2:07 PM

It worked!

like i already done it in

Similar Threads