Blet me know when you make the changes
J
Jok, this looks like it also means no one has to change their COPY lines, which is a double bonus
Jor just do the
--from /ublue-os-udev-rules right?JYeah
JThat way you don't even have to remove the *.rpm
JSo we end up with
COPY --from=ghcr.io/ublue-os/udev-rules /ublue-os-udev-rules/* /etc/udev/rules.dJYou can always run the RPM through cpio if you have a system that doesn't use rpm directly, but these changes skip that step for you
Jyes please, remember I am old, learning a new packaging system will break me
JI think more like
/ublue-os-udev-rules/usr/lib/udev/rules.d/*Joh goodness lol
BThis change looks good to me
J@Bigpod put the review in github so we can start practicing to do it
Jand then I'll add mine
Jand then update the readme
Bi dont have review permission
Jhuh, I set them all to have that on yesterday
Bmaybe some setting is wrong becuase it says reviewers with write access, and it also could be since i do not have any contributions anywhere in ublue-os org
Joh, good opportuntiy to test the docs, one sec!
JBahh yea been a while since i have done reviews in github or reviews at all
Jyeah, because I ran into this too
Jyou can review but you don't know it unless you start at the bottom link
JThis seems to be all you'd need to copy:
Joh, duh, of course
Jthat makes sense, just use the root
Jlol how obviously simple
Badded a approval review
JIt basically gives you
rpm -ivh -like powersJ@Bigpod I'll fix the docs as a PR, and then if you can review the 3 PRs that are left we'd be done with this bad boy
Jand then I'll post an update in the forum like how jstone did for the nvidia one
Jok, pushed, if you'd do the honors!
JI forgot to add the release-action to this repo
B
Joh nice catch!
Bapproved both yubikey and docs one
Bbut docs one could use better name
Jwhich part? (also, there's a little widget in github where you can click on the exact part and leave a comment right next to it)
Jlike if you click the + on the left hand side of the code block
Badd openrgb to docs is a bit missleading since you do add more to docs then just openrgb information, its not realy a problem since its a simple change
JI left a review
Joh, yeah, I should specify, it's only the udev rules, not "auto set up openrgb", is that what you mean?
Byea
Bwith such small changes it isnt a problem but with big changes sometimes reviewers need to rely on title
Jyeah
Jhuh I can't seem to find it?
Ball pull request in udev-rules approved from my side
Bcant find it either
JAh, I didn't submit
JShould be able to see it now
