Wow I didn't even realize that was a thing. I'll raise it internally to see what the plans are for t

KKevH Is it recommended to just use the api directly for now?

C

Cyb3r-Jak3•3/14/23, 6:54 PM

Yeah. The go api is the most update if you know go

Bbeelzabub Wow I didn't even realize that was a thing. I'll raise it internally to see what...

C

Cyb3r-Jak3•3/14/23, 6:55 PM

IIRC, there is a plan to auto generate clients once the shift to openapi is done. The node, python, and PHP libraries don’t receive a lot of love otherwise

M

meyer•3/14/23, 10:04 PM

can bulk KV write operations occur simultaneously? i'm writing around 128K items to a KV store in batches of 2000 over a period of about a minute and i'm noticing that some values aren't getting written.

M

meyer•3/14/23, 10:04 PM

at the moment i'm doing some further debugging to make sure that it's not me doing something dumb, but i figured i'd check here as well.

Mmeyer can bulk KV write operations occur simultaneously? i'm writing around 128K items...

M

meyer•3/15/23, 12:14 AM

mystery solved: 429 Too Many Requests

M

meyer•3/15/23, 12:15 AM

is rate limiting per IP or per API key?

J

James•3/15/23, 12:21 AM

Account ID in general, I believe

J

James•3/15/23, 12:22 AM

429s are pretty common when doing bulk stuff with KV

C

Cyb3r-Jak3•3/15/23, 12:22 AM

Yeah API rate limit is per account

M

meyer•3/15/23, 12:34 AM

ty

M

meyer•3/15/23, 12:35 AM

is rate limit info posted anywhere? googling for anything cloudflare-related + 429 gives me a whole lot of useless results

E

Erisa•3/15/23, 12:36 AM

Theres this which says 1200 req per 5 minutes, but I dont think thats the one youre running into? https://developers.cloudflare.com/fundamentals/api/reference/limits/

EErisa Theres this which says 1200 req per 5 minutes, but I dont think thats the one yo...

M

meyer•3/15/23, 12:41 AM

yeah i don’t think that’s the one i’m getting

C

Cyb3r-Jak3•3/15/23, 12:45 AM

I thought it would be. Wrangler just uses the normal API when uploading in bulk

M

meyer•3/15/23, 12:52 AM

innteresting… maybe it is? i’m definitely not sending 1200 requests in five minutes tho. 64 calls containing 2000 items each.

J

James•3/15/23, 1:06 AM

It's not uncommon for KV to throw 429s with bulk data unfortunately, even outside of the API req limits

M

meyer•3/15/23, 1:29 AM

oh dear. good to know, thank you. i’ll add some extra handling on my end.

Mmeyer oh dear. good to know, thank you. i’ll add some extra handling on my end.

B

beelzabubOP•3/15/23, 1:53 AM

64 concurrent calls with 2k items each? Yeah, that’s >100k writes/s if my math is right. That’s too high right now. I wouldn’t recommend going higher than 10k/s right now. KV2 will give us more breathing room. I do want to get to much higher later this year but it’ll depend on internal arch stuff.

Bbeelzabub 64 concurrent calls with 2k items each? Yeah, that’s >100k writes/s if my math i...

M

meyer•3/15/23, 2:04 AM

ahhhhhhh that makes sense, i wasn’t thinking of writes, just requests

O

Oleg Isonen•3/15/23, 4:04 PM

Hey folks, I am seeing something (strange?) - KV has much higher latency than R2, is that normal?

To back it up, here is what I am looking at.

For static JS, we are using workers for platforms and we use kv-asset-handler
For fonts, we use fetch from R2

Fonts are waiting for response under 50ms consistently
Scripts are waiting for response from 150ms to 500ms

We tried multiple regions, I am personally Berlin.

B

beelzabubOP•3/15/23, 4:08 PM

KV should not have higher latency than R2 generally. R2 can have better latency if you happen to be in the same region you placed the bucket (which is generally the default if the machine you created the bucket is the same machine making these requests). Even still, for an asset you fetch repeatedly KV should still be faster.

B

beelzabubOP•3/15/23, 4:10 PM

If you're changing the UUID of the script frequently, that would trigger a cold read every time. So this is very dependent on your test experiment environment.

Bbeelzabub KV should not have higher latency than R2 generally. R2 can have better latency ...

O

Oleg Isonen•3/15/23, 4:20 PM

We are not changing the UUID of the script during the tests, so its really static. https://webstudio.is

B

beelzabubOP•3/15/23, 4:35 PM

Ok. Let me take a look

B

beelzabubOP•3/15/23, 4:38 PM

So just so I'm clear, for example https://webstudio.is/build/entry.client-QHBMJZIF.js is taking 137ms in your screenshot and that's served from KV?

Bbeelzabub So just so I'm clear, for example https://webstudio.is/build/entry.client-QHBMJZ...

O

Oleg Isonen•3/15/23, 4:49 PM

yes!

B

beelzabubOP•3/15/23, 5:02 PM

So looking at our backend, it looks like there's no KV asset for that file. It looks like you might be trying to put cache in front of KV but then forgetting to update KV on a miss?

I

Ivan Starkov•3/15/23, 5:13 PM

Its worker for platform, it has following code.

      // @todo the whole logic looks strange, add test, write what it solves
      if (asset) {
        finalRequest = new Request(
          url.origin + "/" + asset,
          request as RequestInit
        );
      }

      const response = await getAssetFromKV(
        {
          request: finalRequest,
          waitUntil(promise) {
            return ctx.waitUntil(promise);
          },
        },
        {
          ASSET_NAMESPACE: env.__STATIC_CONTENT,
          ASSET_MANIFEST: assetManifest,
          cacheControl: {
            browserTTL: ttl,
            edgeTTL: ttl,
          },
        }
      );

      return response;

      // @todo the whole logic looks strange, add test, write what it solves
      if (asset) {
        finalRequest = new Request(
          url.origin + "/" + asset,
          request as RequestInit
        );
      }

      const response = await getAssetFromKV(
        {
          request: finalRequest,
          waitUntil(promise) {
            return ctx.waitUntil(promise);
          },
        },
        {
          ASSET_NAMESPACE: env.__STATIC_CONTENT,
          ASSET_MANIFEST: assetManifest,
          cacheControl: {
            browserTTL: ttl,
            edgeTTL: ttl,
          },
        }
      );

      return response;

      // @todo the whole logic looks strange, add test, write what it solves
      if (asset) {
        finalRequest = new Request(
          url.origin + "/" + asset,
          request as RequestInit
        );
      }

      const response = await getAssetFromKV(
        {
          request: finalRequest,
          waitUntil(promise) {
            return ctx.waitUntil(promise);
          },
        },
        {
          ASSET_NAMESPACE: env.__STATIC_CONTENT,
          ASSET_MANIFEST: assetManifest,
          cacheControl: {
            browserTTL: ttl,
            edgeTTL: ttl,
          },
        }
      );

      return response;

      // @todo the whole logic looks strange, add test, write what it solves
      if (asset) {
        finalRequest = new Request(
          url.origin + "/" + asset,
          request as RequestInit
        );
      }

      const response = await getAssetFromKV(
        {
          request: finalRequest,
          waitUntil(promise) {
            return ctx.waitUntil(promise);
          },
        },
        {
          ASSET_NAMESPACE: env.__STATIC_CONTENT,
          ASSET_MANIFEST: assetManifest,
          cacheControl: {
            browserTTL: ttl,
            edgeTTL: ttl,
          },
        }
      );

      return response;

KV is created by using

[site]
bucket = "./public"

[site]
bucket = "./public"

[site]
bucket = "./public"

[site]
bucket = "./public"

section in toml file
and exists and filled

4453161ad26e32a617c6c6d4b837c9d9/workers/kv/namespaces/989796259c334124b2e868bd9a0c3849

4453161ad26e32a617c6c6d4b837c9d9/workers/kv/namespaces/989796259c334124b2e868bd9a0c3849

4453161ad26e32a617c6c6d4b837c9d9/workers/kv/namespaces/989796259c334124b2e868bd9a0c3849

4453161ad26e32a617c6c6d4b837c9d9/workers/kv/namespaces/989796259c334124b2e868bd9a0c3849

I

Ivan Starkov•3/15/23, 5:15 PM

This library https://github.com/cloudflare/kv-asset-handler std code is used for static assets hosting

I

Ivan Starkov•3/15/23, 5:17 PM

timings are very unstable and sometimes can be very good

I

Ivan Starkov•3/15/23, 5:17 PM

But next reload

I

Ivan Starkov•3/15/23, 5:17 PM

I

Ivan Starkov•3/15/23, 5:17 PM

Font timing (r2 with cache rule) is independent

B

beelzabubOP•3/15/23, 5:18 PM

That library seems to have a lot of magic and I've never looked at it before

O

Oleg Isonen•3/15/23, 5:20 PM

The weird thing is that R2 has consistently good timing. Should we put everything in R2 then?

B

beelzabubOP•3/15/23, 5:20 PM

No. I'd recommend using KV properly

I

Ivan Starkov•3/15/23, 5:21 PM

Can it be because of worker is blocked by some heavy script, like first request is coming and cause some heavy job on worker - really 100-200ms computation, and consequent requests are waiting for worker finish that task?

B

beelzabubOP•3/15/23, 5:21 PM

No

B

beelzabubOP•3/15/23, 5:21 PM

The problem is that that kv-asset-handler is doing a lot of complicated things more than just hitting KV

B

beelzabubOP•3/15/23, 5:21 PM

It's using cache in front of KV and trying to honor caching headers from the origin afaict.

B

beelzabubOP•3/15/23, 5:22 PM

Any one of those things could be tripping you up in theory

B

beelzabubOP•3/15/23, 5:22 PM

Try disabling

shouldEdgeCache

shouldEdgeCache

shouldEdgeCache

shouldEdgeCache in your options and see if that fixes it

I

Ivan Starkov•3/15/23, 5:23 PM

Trying

B

beelzabubOP•3/15/23, 5:23 PM

I think you do that by eliding ASSET_MANIFEST

B

beelzabubOP•3/15/23, 5:24 PM

(i.e. setting it to undefined)

I

Ivan Starkov•3/15/23, 5:27 PM

Seems like this https://github.com/cloudflare/kv-asset-handler/blob/c198236dc7444f99acad1f8ccffa2532b8fda879/src/index.ts#L227 i.e. bypassCache also set shouldEdgeCache=false

B

beelzabubOP•3/15/23, 5:28 PM

Yeah maybe

B

beelzabubOP•3/15/23, 5:30 PM

@cherryjimbo might know more about the specifics of this library as he seems to be the primary maintainer.

Wow I didn't even realize that was a thing. I'll raise it internally to see what the plans are for t

Similar Threads