yeah I'm not picky on implementation because I just want to see if the model works. if it's a great

Jj0rge yeah I'm not picky on implementation because I just want to see if the model wor...

B

Bigpod•5/16/23, 12:41 AM

me too

A

akdev•5/16/23, 1:33 AM

ime all web-based terminals add more latency than they should tbh but I've been using code-server at work as my main shell and it is mostly ok

A

akdev•5/16/23, 1:34 AM

but vs code doesn't support ligatures and it is still a less responsive than iterm2

A

akdev•5/16/23, 1:34 AM

Konsole is the best all around terminal I've found

Ppythoner6 Also I think I had the adw gtk3 flatpak install automatically once I was using t...

A

Arcitec•5/16/23, 1:42 AM

I just found the exact mechanism: It's not on app launch. Instead,

flatpak update

flatpak update

installs the active system theme if found at Flathub:

$ flatpak update
Looking for updates…


        ID                           Branch  Op  Remote   Download
 1.     org.gtk.Gtk3theme.adw-gtk3   3.22    i   flathub  < 152.6 kB

Proceed with these changes to the system installation? [Y/n]:

$ flatpak update
Looking for updates…


        ID                           Branch  Op  Remote   Download
 1.     org.gtk.Gtk3theme.adw-gtk3   3.22    i   flathub  < 152.6 kB

Proceed with these changes to the system installation? [Y/n]:

$ flatpak update
Looking for updates…


        ID                           Branch  Op  Remote   Download
 1.     org.gtk.Gtk3theme.adw-gtk3   3.22    i   flathub  < 152.6 kB

Proceed with these changes to the system installation? [Y/n]:

$ flatpak update
Looking for updates…


        ID                           Branch  Op  Remote   Download
 1.     org.gtk.Gtk3theme.adw-gtk3   3.22    i   flathub  < 152.6 kB

Proceed with these changes to the system installation? [Y/n]:

So if you wanna be sure a user has it for Flatpaks before updates, you can ensure that your yafti first boot runs:

flatpak install ---system org.gtk.Gtk3theme.adw-gtk3 org.gtk.Gtk3theme.adw-gtk3-dark

flatpak install ---system org.gtk.Gtk3theme.adw-gtk3 org.gtk.Gtk3theme.adw-gtk3-dark

flatpak install ---system org.gtk.Gtk3theme.adw-gtk3 org.gtk.Gtk3theme.adw-gtk3-dark

flatpak install ---system org.gtk.Gtk3theme.adw-gtk3 org.gtk.Gtk3theme.adw-gtk3-dark

P

pythoner6•5/16/23, 1:43 AM

Yeah, it'll also install it when you install a gnome flatpak (which is how I discovered it) with the system theme set.

Ppythoner6 Yeah, it'll also install it when you install a gnome flatpak (which is how I dis...

A

Arcitec•5/16/23, 1:46 AM

Surprisingly not.

[johnny@fedora ~]$ flatpak install --system  org.gnome.Music
Looking for matches…

org.gnome.Music permissions:
    ipc                network                  fallback-x11   pulseaudio
    wayland            x11                      dri            file access [1]
    dbus access [2]    system dbus access [3]

    [1] xdg-music
    [2] org.freedesktop.Tracker3.Writeback, org.gnome.ControlCenter,
        org.gnome.OnlineAccounts, org.gnome.Settings
    [3] org.freedesktop.login1


        ID                        Branch   Op   Remote    Download
 1.     org.gnome.Music.Locale    stable   i    flathub   < 1.7 MB (partial)
 2.     org.gnome.Music           stable   i    flathub   < 2.5 MB

Proceed with these changes to the system installation? [Y/n]: n

[johnny@fedora ~]$ flatpak install --system  org.gnome.Music
Looking for matches…

org.gnome.Music permissions:
    ipc                network                  fallback-x11   pulseaudio
    wayland            x11                      dri            file access [1]
    dbus access [2]    system dbus access [3]

    [1] xdg-music
    [2] org.freedesktop.Tracker3.Writeback, org.gnome.ControlCenter,
        org.gnome.OnlineAccounts, org.gnome.Settings
    [3] org.freedesktop.login1


        ID                        Branch   Op   Remote    Download
 1.     org.gnome.Music.Locale    stable   i    flathub   < 1.7 MB (partial)
 2.     org.gnome.Music           stable   i    flathub   < 2.5 MB

Proceed with these changes to the system installation? [Y/n]: n

[johnny@fedora ~]$ flatpak install --system  org.gnome.Music
Looking for matches…

org.gnome.Music permissions:
    ipc                network                  fallback-x11   pulseaudio
    wayland            x11                      dri            file access [1]
    dbus access [2]    system dbus access [3]

    [1] xdg-music
    [2] org.freedesktop.Tracker3.Writeback, org.gnome.ControlCenter,
        org.gnome.OnlineAccounts, org.gnome.Settings
    [3] org.freedesktop.login1


        ID                        Branch   Op   Remote    Download
 1.     org.gnome.Music.Locale    stable   i    flathub   < 1.7 MB (partial)
 2.     org.gnome.Music           stable   i    flathub   < 2.5 MB

Proceed with these changes to the system installation? [Y/n]: n

[johnny@fedora ~]$ flatpak install --system  org.gnome.Music
Looking for matches…

org.gnome.Music permissions:
    ipc                network                  fallback-x11   pulseaudio
    wayland            x11                      dri            file access [1]
    dbus access [2]    system dbus access [3]

    [1] xdg-music
    [2] org.freedesktop.Tracker3.Writeback, org.gnome.ControlCenter,
        org.gnome.OnlineAccounts, org.gnome.Settings
    [3] org.freedesktop.login1


        ID                        Branch   Op   Remote    Download
 1.     org.gnome.Music.Locale    stable   i    flathub   < 1.7 MB (partial)
 2.     org.gnome.Music           stable   i    flathub   < 2.5 MB

Proceed with these changes to the system installation? [Y/n]: n

A

Arcitec•5/16/23, 1:46 AM

So it seems to behave the same as nvidia/amd drivers: Installed on

flatpak update

flatpak update

.

P

pythoner6•5/16/23, 1:46 AM

Oh maybe it's because you're installing things as system flatpaks? I definitely had it auto install the theme flatpak when I installed another flatpak

A

Arcitec•5/16/23, 1:47 AM

Exact same result if I do --user instead. No theme.

A

Arcitec•5/16/23, 1:49 AM

Actually, wow, even though I said "no" to installing it during

flatpak update

flatpak update

it has still installed itself, and if I try to remove it, it's saying that every Flatpak depends on it now, so they would uninstall too.

So I can't test the thing you're saying. ^^ It's glued in there now. So there's a good chance that you're right that it installs itself during

flatpak install <something else>

flatpak install <something else>

flatpak install <something else>

flatpak install <something else> too.

A

Arcitec•5/16/23, 2:42 AM

Yikes, dconf-editor as Flatpak was totally unusable. It was showing the wrong data (Flatpak environment's rather than the host's) and was unable to see the host environment at all. RIP to anyone who was using it:

https://github.com/flathub/ca.desrt.dconf-editor/pull/24

https://github.com/flathub/ca.desrt.dconf-editor/pull/26

Pretty amazing how those bugs escaped notice for 2111 days (first Flatpak release was on Aug 4, 2017).

A

Arcitec•5/16/23, 2:43 AM

Kind of an important tool for everyone building new defaults for immutable distros!

A

Arcitec•5/16/23, 3:26 PM

@hermmm and I are trying to figure out an appropriate name for a special branch on the

startingpoint

startingpoint

startingpoint

startingpoint repo:

The layout will be:

-

template

template

template

template: Untouched template branch, which comes from the startingpoint repo itself. People don't modify it. It's used for easy fast-forwarding / syncing of repos to update their local copy of the template.
-

<something>

<something>

<something>

<something>: The ONLY branch that gets deployed (published) to GHCR. All other branches will merely build but won't deploy. This ensures total control over GHCR publishing.

We need a name for

<something>

<something>

<something>

<something>.

Names that have been considered and rejected:

-

deploy

deploy

deploy

deploy or

deployment

deployment

deployment

deployment: Very accurate names but also very ugly word.
-

public

public

: I thought about it but all branches are public, so it makes no sense.
-

release

release

: Too confusing since Releases are a GitHub feature.
-

production

production

production

production: Strange name.

Uncertain names:

-

custom

custom

custom

custom: Decent but doesn't make it clear to anybody that this is the ONLY branch that gets published to live GHCR.

Leading names (clearest names so far):

-

publish

publish

publish

publish: The only branch that is published to GHCR.
-

live

live

live

live: The branch that goes live (deploys).

X

xyny•5/16/23, 3:27 PM

I like live, it's a noun but implies the same thing

A

Arcitec•5/16/23, 3:27 PM

I agree, it's a neat name.

X

xyny•5/16/23, 3:27 PM

Other one could be

prod

prod

being short for production

A

Arcitec•5/16/23, 3:28 PM

Maybe, but still unclear. I definitely think

live

live

live

live is the clearest name so far.

X

xyny•5/16/23, 3:28 PM

Agreed

A

Arcitec•5/16/23, 3:29 PM

I would love to hear some other opinions to decide if we should settle on that name, think you'll be on in like 1-2 hours when we'll hopefully have heard someone else? Or should I just go for it and force-push new commits that switch to

live

live

live

live? It's a good name, could get used to it quickly.

A

Arcitec•5/16/23, 3:30 PM

It's a clear name, purpose is obvious, and it's not a verb so it doesn't sound weird in that way.

A

Arcitec•5/16/23, 3:31 PM

So depending on how you feel about it, I could have updated commits ready in 5 minutes.

X

xyny•5/16/23, 3:31 PM

Sure, but maybe read my other comment first. And excuse me for maybe not getting it.

A

Arcitec•5/16/23, 3:32 PM

Didn't see it, reading now.

Edit: I'll reply there to keep that discussion there.

A

Arcitec•5/16/23, 3:45 PM

@hermmm Okay the PR is updated and ready. Thanks for a good discussion, I really like the new name we came up with.

A

Arcitec•5/16/23, 3:55 PM

@hermmm Sorry I didn't mean to click "disable auto-merge". Mistake. Let's re-enable it.

AArcitec @hermmm Sorry I didn't mean to click "disable auto-merge". Mistake. Let's re-ena...

X

xyny•5/16/23, 3:56 PM

Read my comment. Auto-merge is a new thing I think jorge turned on, and it requires the workflows to run. There's no other ways to merge.

Xxyny Read my comment. Auto-merge is a new thing I think jorge turned on, and it requi...

A

Arcitec•5/16/23, 4:00 PM

I am not sure. The repo's own existing workflow file should be the one that runs. It would be a literal exploit if I could submit a pull request where I change teh workflow to submit code to GHCR. I could literally make a PR to ublue-os/main that installs a virus if that were the case.

So I dunno why it's not running the old workflow on the current PR! It should be running the old

main

main

workflow, not my edits!

Anyway, the changes are two things:

1. The publish to GHCR only happens if the branch is named

live

live

live

live. That part is simple and is taken care of at the bottom of the workflow. No issues there.
2. The auto-trigger workflows are changed to the following:

https://i.imgur.com/7EW7t9D.png

Imgur

X

xyny•5/16/23, 4:01 PM

The repo's own existing workflow file should be the one that runs. It would be a literal exploit if I could submit a pull request where I change teh workflow to submit code to GHCR.

Hmm I wonder how PRs with changes to workflows are handled then...

A

Arcitec•5/16/23, 4:02 PM

What this means is:

- Pull requests will only run builds when they target

live

live

live

live.
- Cron schedule will run every branch every day.
- Pushes to branches will only run automatic builds if they target

live

live

live

live.
- Any branch can manually trigger the workflow (that's

workflow_dispatch:

workflow_dispatch:

workflow_dispatch:

workflow_dispatch:).

X

xyny•5/16/23, 4:02 PM

I actually think that, since it's a PR coming from a branch outside the repo, it doesn't have the secrets and access, and thus can't push to GHCR.

X

xyny•5/16/23, 4:03 PM

So this PR might be running your workflow, actually.

A

Arcitec•5/16/23, 4:03 PM

I dunno, it still makes no sense. The workflow inside the repo itself is the "action" that triggers.

X

xyny•5/16/23, 4:03 PM

- Pull requests will only run builds when they target live.

And this PR doesn't target live.

A

Arcitec•5/16/23, 4:03 PM

Hmm yeah it might be running MY local copy of the workflow instead of the upstream one i nstartingpoint.

X

xyny•5/16/23, 4:03 PM

Yeah the workflows and everything are in your repo.

A

Arcitec•5/16/23, 4:04 PM

Okay that is good, that settles how workflows work in PRs. So they run in my local repo, not yours. Good security, phew.

X

xyny•5/16/23, 4:04 PM

Do you even have the GHA enabled?

A

Arcitec•5/16/23, 4:05 PM

No. But I have some ideas how to fix this. We're gonna need some changes.

X

xyny•5/16/23, 4:05 PM

I can't see the action here https://github.com/Arcitec/os/actions

A

Arcitec•5/16/23, 4:05 PM

Ah, yeah it's not visible there.

A

Arcitec•5/16/23, 4:06 PM

I'm thinking atm, and will try to add

main

main

and

template

template

template

template to the auto-build targets.

A

Arcitec•5/16/23, 4:06 PM

Alternatively...

AArcitec I'm thinking atm, and will try to add `main` and `template` to the auto-build ta...

X

xyny•5/16/23, 4:06 PM

Was just about to comment that.

X

xyny•5/16/23, 4:06 PM

Then we'll just remove

main

main

ones it's renamed

A

Arcitec•5/16/23, 4:06 PM

We could also just remove the list of branches to make every branch build no matter its name. Only

live

live

live

live gets published to GHCR. So that may be the most desirable?

A

Arcitec•5/16/23, 4:07 PM

I am pretty sure this https://i.imgur.com/7EW7t9D.png list of

branches:

branches:

branches:

branches: was the old-school "protect against push to GHCR" idea before I changed it to only push

live

live

live

live.

AArcitec We could also just remove the list of branches to make every branch build no mat...

X

xyny•5/16/23, 4:08 PM

Well, I don't know. If there's some in-repo development on a custom branch. I guess I should start making my PRs from a custom repo too to not pollute the template?

Xxyny Well, I don't know. If there's some in-repo development on a custom branch. I gu...

A

Arcitec•5/16/23, 4:08 PM

I think removing

branches:

branches:

branches:

branches: filtering for the auto-build triggers would solve that. So that way every branch gets built no matter its name. We're exactly as safe as before, since the deploy/sign steps only run for

live

live

live

live.

A

Arcitec•5/16/23, 4:09 PM

And the builds seem to happen in the PR sender's own home.

yeah I'm not picky on implementation because I just want to see if the model works. if it's a great

Similar Threads

Similar Threads

Similar Threads