that will break as soon as there's accidentally 1000 concurrent requests though 😛

Ddave that will break as soon as there's accidentally 1000 concurrent requests though ...

H

Hello, I’m Allie!•5/27/23, 5:20 PM

Then cache the mapping in KV?

A

AA•5/27/23, 6:38 PM

this does not list the 2023-05-15 compatibility date. https://developers.cloudflare.com/workers/platform/compatibility-dates/

Compatibility dates · Cloudflare Workers docs

Cloudflare regularly updates the Workers runtime. These updates apply to all Workers globally and should never cause a Worker that is already deployed …

A

AA•5/27/23, 6:41 PM

cursor has some interesting things to say

I

IdkWhatever69•5/27/23, 6:49 PM

what happened? [cron triggers]
no i didn't change the code

Screenshot_2023-05-28_at_12.18.51_AM.png

W

Walshy•5/27/23, 6:51 PM

¯\_(ツ)_/¯

W

Walshy•5/27/23, 6:51 PM

you'd need to check logs

WWalshy you'd need to check logs

I

IdkWhatever69•5/27/23, 6:51 PM

from where?

W

Walshy•5/27/23, 6:52 PM

tail or if you have logpush enabled then they'll be in your storage

WWalshy tail or if you have logpush enabled then they'll be in your storage

I

IdkWhatever69•5/27/23, 6:52 PM

logpushs are paid right?

W

Walshy•5/27/23, 6:53 PM

it requires a paid plan iirc but the feature itself isn't paid

I

IdkWhatever69•5/27/23, 6:54 PM

this project is for public service
i cant put any money into this :{

Screenshot_2023-05-28_at_12.23.54_AM.png

W

Walshy•5/27/23, 6:54 PM

https://developers.cloudflare.com/workers/platform/pricing/#workers-trace-events-logpush

oh nevermind but it's very cheap 10 mil included then only $0.05/mil (after filtering)

W

Walshy•5/27/23, 6:54 PM

best you'd get is tail then

W

Walshy•5/27/23, 6:55 PM

it'll fire again in 6 mins so start tailing now and wait 6 mins

WWalshy it'll fire again in 6 mins so start tailing now and wait 6 mins

I

IdkWhatever69•5/27/23, 6:55 PM

so just

wrangler tail

wrangler tail

wrangler tail

wrangler tail right?

W

Walshy•5/27/23, 6:56 PM

yep

WWalshy it'll fire again in 6 mins so start tailing now and wait 6 mins

I

IdkWhatever69•5/27/23, 7:05 PM

this time it worked.
its the exact static code... what kinda blackmagic fookery is this

W

Walshy•5/27/23, 7:06 PM

what's the code doing?

W

Walshy•5/27/23, 7:06 PM

do you make a request to a service or anything?

WWalshy do you make a request to a service or anything?

I

IdkWhatever69•5/27/23, 7:06 PM

yes actually

W

Walshy•5/27/23, 7:06 PM

so probably that service returned something unexpectedly

WWalshy so probably that service returned something unexpectedly

I

IdkWhatever69•5/27/23, 7:06 PM

its open source so here you go: https://github.com/DaBigBlob/FIT-Weather-Chan/blob/main/src/bot.ts

GitHub

FIT-Weather-Chan/bot.ts at main · DaBigBlob/FIT-Weather-Chan

Hourly weather updates for Florida Institute of Technology campus - FIT-Weather-Chan/bot.ts at main · DaBigBlob/FIT-Weather-Chan

WWalshy so probably that service returned something unexpectedly

I

IdkWhatever69•5/27/23, 7:07 PM

the requests are these:

//get hourly weather
    const wthr: Result<Period> = await (async () => {
        const proto_res = (await (await fetch(`${WeatherAPIEndpoint}/hourly`, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

        const result = proto_res.properties.periods.filter(p => (dateIsoToUnixSec(p.startTime)*1000 > now))[0];
        if (exists(result)) return new Ok(result);

        return new Err("Data too old");
    })();
    if (!wthr.isOk()) return;

    //get overall day dorcast
    const day_forcase = await (async () => {
        const proto_res = (await (await fetch(WeatherAPIEndpoint, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}`);

        const result = proto_res.properties.periods.find(p => (p.number == 1));
        if (exists(result)) return new Ok(result);

        return new Err("Today's data not found");
    })();

//get hourly weather
    const wthr: Result<Period> = await (async () => {
        const proto_res = (await (await fetch(`${WeatherAPIEndpoint}/hourly`, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

        const result = proto_res.properties.periods.filter(p => (dateIsoToUnixSec(p.startTime)*1000 > now))[0];
        if (exists(result)) return new Ok(result);

        return new Err("Data too old");
    })();
    if (!wthr.isOk()) return;

    //get overall day dorcast
    const day_forcase = await (async () => {
        const proto_res = (await (await fetch(WeatherAPIEndpoint, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}`);

        const result = proto_res.properties.periods.find(p => (p.number == 1));
        if (exists(result)) return new Ok(result);

        return new Err("Today's data not found");
    })();

//get hourly weather
    const wthr: Result<Period> = await (async () => {
        const proto_res = (await (await fetch(`${WeatherAPIEndpoint}/hourly`, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

        const result = proto_res.properties.periods.filter(p => (dateIsoToUnixSec(p.startTime)*1000 > now))[0];
        if (exists(result)) return new Ok(result);

        return new Err("Data too old");
    })();
    if (!wthr.isOk()) return;

    //get overall day dorcast
    const day_forcase = await (async () => {
        const proto_res = (await (await fetch(WeatherAPIEndpoint, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}`);

        const result = proto_res.properties.periods.find(p => (p.number == 1));
        if (exists(result)) return new Ok(result);

        return new Err("Today's data not found");
    })();

//get hourly weather
    const wthr: Result<Period> = await (async () => {
        const proto_res = (await (await fetch(`${WeatherAPIEndpoint}/hourly`, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

        const result = proto_res.properties.periods.filter(p => (dateIsoToUnixSec(p.startTime)*1000 > now))[0];
        if (exists(result)) return new Ok(result);

        return new Err("Data too old");
    })();
    if (!wthr.isOk()) return;

    //get overall day dorcast
    const day_forcase = await (async () => {
        const proto_res = (await (await fetch(WeatherAPIEndpoint, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}`);

        const result = proto_res.properties.periods.find(p => (p.number == 1));
        if (exists(result)) return new Ok(result);

        return new Err("Today's data not found");
    })();

I

IdkWhatever69•5/27/23, 7:07 PM

my god that looks ugly

I

IdkWhatever69•5/27/23, 7:08 PM

(excuse my spelling mistakes)

J

James•5/27/23, 7:10 PM

Yeah you're making a lot of assumptions about those requests always returning a 200, and always returning valid JSON

J

James•5/27/23, 7:10 PM

I'd guess one of them had a hiccup

J

James•5/27/23, 7:11 PM

If you wanted to make it more resilient,, make the request, check if OK, check if JSON, and then call

.json()

.json()

.json()

.json()

J

James•5/27/23, 7:11 PM

Depending on the service, I might also check the data is returns, in case there's a chance

properties.periods

properties.periods

properties.periods

properties.periods doesn't exist, for example.

F

F0rce•5/27/23, 7:12 PM

is

[placement]
mode = "smart"

[placement]
mode = "smart"

[placement]
mode = "smart"

[placement]
mode = "smart"

inheritable ? The docs page does not seem to have it listed.

JJames If you wanted to make it more resilient,, make the request, check if OK, check i...

I

IdkWhatever69•5/27/23, 7:16 PM

right i should check .ok before .json()-ing

JJames Depending on the service, I might also check the data is returns, in case there'...

I

IdkWhatever69•5/27/23, 7:17 PM

if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

i do check that

J

James•5/27/23, 7:17 PM

yep I'd check

.ok

.ok

.ok

.ok and also check if the

content-type

content-type

content-type

content-type includes

application/json

application/json

application/json

application/json. You'd be surprised at how many APIs are wonky sometimes and return a 200 but an HTML error page or something

IIdkWhatever69 ```ts if (!exists(proto_res) || !exists(proto_res.properties.periods)) return ne...

J

James•5/27/23, 7:18 PM

if

.properties

.properties

.properties

.properties doesn't exist there, you'll get a

TypeError

TypeError

. I'd check

proto_res.properties

proto_res.properties

proto_res.properties

proto_res.properties exists too

JJames yep I'd check `.ok` and also check if the `content-type` includes `application/j...

I

IdkWhatever69•5/27/23, 7:18 PM

but this is in the geaders tho

const fetch_headers = {
    'User-Agent': `${fitweather_credentials.name}/1.0 (Florida Institute of Technology Weather Discord Bot (Student Run), https://github.com/DaBigBlob/FIT-Weather-Chan)`,
    'Accept': "application/geo+json"
};

const fetch_headers = {
    'User-Agent': `${fitweather_credentials.name}/1.0 (Florida Institute of Technology Weather Discord Bot (Student Run), https://github.com/DaBigBlob/FIT-Weather-Chan)`,
    'Accept': "application/geo+json"
};

const fetch_headers = {
    'User-Agent': `${fitweather_credentials.name}/1.0 (Florida Institute of Technology Weather Discord Bot (Student Run), https://github.com/DaBigBlob/FIT-Weather-Chan)`,
    'Accept': "application/geo+json"
};

const fetch_headers = {
    'User-Agent': `${fitweather_credentials.name}/1.0 (Florida Institute of Technology Weather Discord Bot (Student Run), https://github.com/DaBigBlob/FIT-Weather-Chan)`,
    'Accept': "application/geo+json"
};

J

James•5/27/23, 7:18 PM

Or just

if(!proto_res?.properties?.periods)

if(!proto_res?.properties?.periods)

with optional chaining

IIdkWhatever69 but this is in the geaders tho ```ts const fetch_headers = { 'User-Agent': `...

J

James•5/27/23, 7:19 PM

are you 100% certain that API is perfect and only ever returns JSON when asked?

When working with external APIs, it's always better to add resilience by checking what's actually returned

FF0rce is ```toml [placement] mode = "smart" ``` inheritable ? The docs page does not s...

K

kian•5/27/23, 7:19 PM

Nope

JJames are you 100% certain that API is perfect and only ever returns JSON when asked? ...

I

IdkWhatever69•5/27/23, 7:19 PM

true true; i'll do that

K

kian•5/27/23, 7:19 PM

Oh no, it is

K

kian•5/27/23, 7:19 PM

It's the very last inheritable property

F

F0rce•5/27/23, 7:19 PM

perfect. thanks a lot

JJames if `.properties` doesn't exist there, you'll get a `TypeError`. I'd check `proto...

I

IdkWhatever69•5/27/23, 7:20 PM

if .properties dont exist shouldn't .properties.periods be undefined?
and if it is, i do check that

export function exists<T>(data: T|null|undefined): data is T {
  if (
      (data === null) ||
      (data === undefined)
  ) return false;
  return true;
}

export function exists<T>(data: T|null|undefined): data is T {
  if (
      (data === null) ||
      (data === undefined)
  ) return false;
  return true;
}

export function exists<T>(data: T|null|undefined): data is T {
  if (
      (data === null) ||
      (data === undefined)
  ) return false;
  return true;
}

export function exists<T>(data: T|null|undefined): data is T {
  if (
      (data === null) ||
      (data === undefined)
  ) return false;
  return true;
}

IIdkWhatever69 if .properties dont exist shouldn't .properties.periods be undefined? and if it ...

J

James•5/27/23, 7:22 PM

.properties.periods

.properties.periods

would throw a

TypeError

TypeError

if

properties

properties

doesn't exist. For example:

const obj = {foo: 'bar'}
console.log(obj.foo) // bar
console.log(obj.bar) // undefined
console.log(obj.bar.baz) // TypeError

const obj = {foo: 'bar'}
console.log(obj.foo) // bar
console.log(obj.bar) // undefined
console.log(obj.bar.baz) // TypeError

const obj = {foo: 'bar'}
console.log(obj.foo) // bar
console.log(obj.bar) // undefined
console.log(obj.bar.baz) // TypeError

const obj = {foo: 'bar'}
console.log(obj.foo) // bar
console.log(obj.bar) // undefined
console.log(obj.bar.baz) // TypeError

A

AA•5/27/23, 7:23 PM

I want to create a single git repo, with lots of workers (mostly webhooks, so stripe/ses/etc) this seems smarter than 1 big project since i can update/change them 1 at a time.. anyone have a good example of how to structure this? just 1 directory per worker, with its own wrangler? or?

that will break as soon as there's accidentally 1000 concurrent requests though 😛

Similar Threads

Similar Threads

Similar Threads