hey there! I'm new to wrangler pull requests and such. I followed the 'contributing.md' instructio

hey there! I'm new to wrangler pull requests and such. I followed the 'contributing.md' instructions within the workers-sdk project root folder, which points towards creation of pull requests. But, I've seen no activity in relation to my pull request thus far. Is there supposed to also be some kind of related Issue that needs to be created?

PPeter Belbin hey there! I'm new to wrangler pull requests and such. I followed the 'contrib...

Max (@rozenmd)•6/1/23, 2:26 PM

most of the team is out at a conference atm, but i can ping some folks to take a look

MMax (@rozenmd)most of the team is out at a conference atm, but i can ping some folks to take a...

Peter BelbinOP•6/1/23, 2:29 PM

Ah. I see! Thank you! Here is the PR I'm referring to: https://github.com/cloudflare/workers-sdk/pull/3384
Any idea when people will be 'business as usual'?

GitHub

[wrangler] Add deploy --old-asset-ttl option by Peter-Sparksuite · ...

Fixes # [none].
What this PR solves / how to test:
When a wrangler deploy happens, the old assets are immediately deleted, causing users of previously obtained web applications that expect to find ...

PPeter Belbin Ah. I see! Thank you! Here is the PR I'm referring to: https://github.com/clou...

Max (@rozenmd)•6/1/23, 2:31 PM

They should be back next Monday

PPeter Belbin hey there! I'm new to wrangler pull requests and such. I followed the 'contrib...

Max (@rozenmd)•6/1/23, 2:33 PM

but yeah typically I'd open a GitHub issue explaining what you're looking to fix before proceeding with a PR - I'll update the contributing.md

MMax (@rozenmd)but yeah typically I'd open a GitHub issue explaining what you're looking to fix...

Peter BelbinOP•6/1/23, 2:35 PM

Ah. So, should I open an issue, and connect it to the PR?

Original message was deleted

Peter BelbinOP•6/1/23, 2:39 PM

Well, I wasn't really expecting it to be totally resolved by now, but, I was kinda expecting something to have happened by now, but, since people appear to be at a conference, well, it's understandable. But also, perhaps it needs an issue being created too?

Original message was deleted

Peter BelbinOP•6/1/23, 2:42 PM

Thank you for some expectation-setting. Like I said, I wasn't expecting everything to be resolved in a day, but rather, that there would have been some kind of action on it, but perhaps even that is expecting too much.

PPeter Belbin Thank you for some expectation-setting. Like I said, I wasn't expecting everyth...

DaniFoldi•6/1/23, 2:43 PM

if you look at the backlog (open issues + PRs), those alone would take weeks to catch up with notlikemeowcry

DDaniFoldi if you look at the backlog (open issues + PRs), those alone would take weeks to ...

Peter BelbinOP•6/1/23, 2:46 PM

Yes, totally agree, but, there are also often PRs and issues on larger projects that just never get beyond the point of being an issue or PR, so that's not always an indicator of how things are moving..... but, I get your point. ie: looking at some recently closed PRs would give some idea of how long it takes for PRs to make their way through.

Peter BelbinOP•6/1/23, 3:42 PM

Ok, so, I have created an issue for my pull request, and have updated the pull request to identify the new issue that it fixes. https://github.com/cloudflare/workers-sdk/issues/3385

GitHub

🚀 Feature Request: Allow Wrangler deployments to opt-in to expirati...

Background The place where I work has been using Wrangler 1.x, and likes having the old assets not immediately being removed from the KV storage when a new deploy happens. Reason: users that alread...

PPeter Belbin Ok, so, I have created an issue for my pull request, and have updated the pull r...

Max (@rozenmd)•6/1/23, 3:45 PM

Thanks Peter, much appreciated.

Noil•6/1/23, 5:52 PM

When is the wrangler-action github actions getting a update to Wrangler 3.0.0?

NNoil When is the wrangler-action github actions getting a update to Wrangler 3.0.0?

James•6/1/23, 10:13 PM

I don't think there's a timeline, but you can follow https://github.com/cloudflare/wrangler-action/issues/107

AAlexander Any plans to support older macs as in 11.7?

James•6/1/23, 10:14 PM

Unfortunately OS support for workerdworkerd (what's used for

wrangler dev

wrangler dev

now in v3) is VERY limited. I know the team want to expand this, but I would recommend sticking with wrangler v2 for now if you want to run it on older operating systems - it should work fine.

James•6/1/23, 10:15 PM

Wrangler v3 was released a little hastily and seemingly without much testing, but hopefully we'll see this improve in the near future

JJames I don't think there's a timeline, but you can follow https://github.com/cloudfla...

Walshy•6/1/23, 10:21 PM

note @_noil you can add wranglerVersion: 3wranglerVersion: 3 to use 3.x today

AAlexander I understand that, I just wanted to now if it was planned or not, I subscribed, ...

James•6/1/23, 10:24 PM

Yep the issue was in response to noil

Issues like https://github.com/cloudflare/workerd/issues/46 and https://github.com/cloudflare/workerd/issues/174 and https://github.com/cloudflare/workers-sdk/issues/3262 and https://github.com/cloudflare/workers-sdk/issues/3301 are more relevant to your issue.

James•6/1/23, 10:24 PM

I believe it'll come, but I'd stick with v2 for now.

LeftSpace•6/2/23, 6:32 PM

is there any fix for this?

LeftSpace•6/2/23, 6:32 PM

https://github.com/cloudflare/workers-sdk/issues/3292
exact same

GitHub

🐛 BUG: Wrangler fails to reload Rust · Issue #3292 · cloudflare/wor...

Which Cloudflare product(s) does this pertain to? Workers/Other, Wrangler What version of Wrangler are you using? 3.0.0 What operating system are you using? Linux, Mac Describe the Bug I can boot t...

LeftSpace•6/2/23, 6:32 PM

wrangler 3.0.1

LLeftSpace https://github.com/cloudflare/workers-sdk/issues/3292 exact same

kian•6/2/23, 6:34 PM

LeftSpace•6/2/23, 6:35 PM

no solution yet

LeftSpace•6/2/23, 6:35 PM

fair

LeftSpace•6/2/23, 6:35 PM

kian•6/2/23, 6:36 PM

If you don't necessarily need functionality that's only in Wrangler 3 then I'd recommend downgrading to Wrangler 2, 3 is in a rough spot right now.

LeftSpace•6/2/23, 6:50 PM

just figured out my way
nodemon --watch src --exec npm run devnodemon --watch src --exec npm run dev
nodemon.json

{
    "watch": ["lib.rs", "src/"],
    "ext": "rs"
}

{
    "watch": ["lib.rs", "src/"],
    "ext": "rs"
}

package.json

{
    "name": "worker1",
    "version": "0.0.0",
    "private": true,
    "scripts": {
        "deploy": "wrangler deploy",
        "dev": "wrangler dev"
    },
    "dependencies": {
        "wrangler": "^3.0.1"
    }
}

{
    "name": "worker1",
    "version": "0.0.0",
    "private": true,
    "scripts": {
        "deploy": "wrangler deploy",
        "dev": "wrangler dev"
    },
    "dependencies": {
        "wrangler": "^3.0.1"
    }
}

it restarts the wrangler if detects a changed file.

lokiwind•6/2/23, 7:09 PM

Hello, I have a worker that I created with dashboard without using wrangler.
How can I run this worker with wrangler.
I mean: How can I edit an employee created with Dashboard::I want to edit this worker with wrangler

Llokiwind Hello, I have a worker that **I created with dashboard** **without using wrangle...

Adam•6/2/23, 7:25 PM

You can run wrangler init --from-dash <WORKER NAME>wrangler init --from-dash <WORKER NAME> to pull it down locally and develop with Wrangler. https://developers.cloudflare.com/workers/wrangler/commands/#init

AAdam You can run `wrangler init --from-dash <WORKER NAME>` to pull it down locally an...

lokiwind•6/2/23, 7:28 PM

What it means: Therefore, it is recommended that you continue using the CLI.Therefore, it is recommended that you continue using the CLI.

Llokiwind What it means: `Therefore, it is recommended that you continue using the CLI.`

Adam•6/2/23, 7:33 PM

There are currently some differences between the way Wrangler builds and bundles Worker code and the way it's handled via the dashboard. For that reason, we recommend that users that start deploying via Wrangler continue doing that. Eventually, we'd like to get parity so that you can develop your Worker interchangeably with Wrangler or the dashboard, but that's a ways off.

AAdam There are currently some differences between the way Wrangler builds and bundles...

lokiwind•6/2/23, 7:35 PM

Thank you, I understand, it is healthier to edit in the field in which I created it

AAdam There are currently some differences between the way Wrangler builds and bundles...

Unsmart•6/2/23, 7:36 PM

Does this also mean potentially that you can have direct github integration with the quick edit in the future that would be really cool create a branch in quick edit it be running there for testing while coding then push that to the branch go to github open pr and merge

UUnsmart Does this also mean potentially that you can have direct github integration with...

Adam•6/2/23, 8:07 PM

Yes! That would be great.

kian•6/4/23, 12:45 AM

that was fixed 2 days ago in workerd so I'd expect it to be fixed in the next release

kian•6/4/23, 12:45 AM

as for how to workaround it right now, I'm not too sure

JacobMGEvans•6/4/23, 3:02 PM

The team will be back in full force starting tomorrow, appreciate the community as usual.

Some really cool stuff talked about this last week.

I also have the TurboRepo + Monorepo standardization PR which is getting wrapped up. This will enable a lot of other improvements, and even feature work!!

Thanks again everyone!

JJacobMGEvans The team will be back in full force starting tomorrow, appreciate the community ...

Ashley•6/4/23, 5:17 PM

That made me curious, are there issues currently operating a Monorepo with Wrangler? (e.g. a project that has 2 Workers, as a random example)

AAshley That made me curious, are there issues currently operating a Monorepo with Wrang...

JacobMGEvans•6/4/23, 5:18 PM

This is about turning Workers-SDK into a standardized monorepo

Ashley•6/4/23, 5:19 PM

Ah okay cool thanks, as I had just recently started a project using a Monorepo so wanted to make sure I wasn’t about to hit pain

AAshley Ah okay cool thanks, as I had just recently started a project using a Monorepo s...

JacobMGEvans•6/4/23, 5:21 PM

Shouldn't be but if you do hit us up (I would be interested)

AAshley Ah okay cool thanks, as I had just recently started a project using a Monorepo s...

rodrigo•6/4/23, 9:18 PM

Is there any tutorial/guide about how to deploy a monorepo/turborepo (Remix/Expo) on Cloudflare?

hey there! I'm new to wrangler pull requests and such. I followed the 'contributing.md' instructio

Similar Threads