well random negative checks i probably didnt bother documenting, nor did i probably even understand

well random negative checks i probably didnt bother documenting, nor did i probably even understand at the time, most of this code is reworked from examples/other codebases

SQDev•6/14/23, 7:40 AM

me in the mean time

Lyris the KitoriOP•6/14/23, 7:41 AM

theres very little documentation for FFmpeg, so a lot of what i wrote is things sussed out from other projects

LLyris the Kitori theres very little documentation for FFmpeg, so a lot of what i wrote is things ...

SQDev•6/14/23, 7:41 AM

i agree

SQDev•6/14/23, 7:41 AM

such a big project having almost no useful documentation feels weird

SQDev•6/14/23, 7:41 AM

all those big companies just internally care for their projects i guess

LLyris the Kitori well random negative checks i probably didnt bother documenting, nor did i proba...

King•6/14/23, 7:43 AM

Ah, pretty much my exact experience trying to do imgui things lol

King•6/14/23, 7:44 AM

"I don't know why this is important but apparently everything explodes if you don't do it... ??? oh well"

Lyris the KitoriOP•6/14/23, 7:45 AM

i've found imgui to be well documented and easy to use, theres nothing in my imgui code id describe like that

King•6/14/23, 7:46 AM

All I remember from my past attempt was I tried doing it on my own instead of copypasting an example, and everything just went maximum bork, and I couldn't figure out why until I realized I wasn't doing a boolean check on something or the other, which seemed completely pointless and redundant, but not doing it just broke everything horribly

King•6/14/23, 7:47 AM

I think I spent a whole day trying to figure out why it was necessary... but neither stack overflow, reddit or the official examples/documentation made so much as a mention of it

SQDev•6/14/23, 7:47 AM

that happened to me multiple times in the past

SQDev•6/14/23, 7:49 AM

especially if i work on something very big, multiple source files thousands of lines of codes, if i just stand up to somewhere for a sec without finishing, i always end up writing incorrect code when i am back to finish it

SQDev•6/14/23, 7:49 AM

missing something thanks to

King•6/14/23, 7:49 AM

Oh yeah... the whole "train of code" thing

King•6/14/23, 7:50 AM

If you take a break and come back, and everything just feels like mystery heiroglyphs and you have no idea why the heck you did it that way

King•6/14/23, 7:50 AM

Until you starts from the beginning and sort of get the train of thought rolling on the same track again

King•6/14/23, 7:50 AM

Horribly annoying D:

SQDev•6/14/23, 7:52 AM

exactly xd

SQDev•6/14/23, 7:52 AM

wait wasnt xgui c#

SQDev•6/14/23, 7:52 AM

EXTERN_C DLLENTRY void DLLCALL conv_yuv444_to_rgb_sse_thr(const int threadcount, size_t length, byte* Y, byte* U, byte* V, vec4u8* rgba)
{
    _CSR_SAVE();

    _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_ON);
    _MM_SET_FLUSH_ZERO_MODE(_MM_FLUSH_ZERO_ON);
#pragma omp parallel for num_threads(threadcount)
    for (__int64 i = 0; i < length; i++)
    {
        __m128 frgba = { 0,0,0,0 };
        __m128 yuv0 = __m128{Y[i] * inv255, U[i] * inv255, V[i] * inv255, 1};
        yuv0 =_mm_add_ps(yuv0, offset);
        frgba = _mm_add_ps(frgba, _mm_dp_ps(yuv0, Rcoeff, 0x71)); // or reverse???
        frgba = _mm_add_ps(frgba, _mm_dp_ps(yuv0, Gcoeff, 0x72)); // or reverse???
        frgba = _mm_add_ps(frgba, _mm_dp_ps(yuv0, Bcoeff, 0x74)); // or reverse???
        frgba = _mm_min_ps(frgba, one);
        frgba = _mm_max_ps(frgba, zero);

        rgba[i] = vec4u8{
            byte(frgba.m128_f32[0] * 255),
            byte(frgba.m128_f32[1] * 255),
            byte(frgba.m128_f32[2] * 255),
            255
        };

    }
    _CSR_RESTORE();
}

EXTERN_C DLLENTRY void DLLCALL conv_yuv444_to_rgb_sse_thr(const int threadcount, size_t length, byte* Y, byte* U, byte* V, vec4u8* rgba)
{
    _CSR_SAVE();

    _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_ON);
    _MM_SET_FLUSH_ZERO_MODE(_MM_FLUSH_ZERO_ON);
#pragma omp parallel for num_threads(threadcount)
    for (__int64 i = 0; i < length; i++)
    {
        __m128 frgba = { 0,0,0,0 };
        __m128 yuv0 = __m128{Y[i] * inv255, U[i] * inv255, V[i] * inv255, 1};
        yuv0 =_mm_add_ps(yuv0, offset);
        frgba = _mm_add_ps(frgba, _mm_dp_ps(yuv0, Rcoeff, 0x71)); // or reverse???
        frgba = _mm_add_ps(frgba, _mm_dp_ps(yuv0, Gcoeff, 0x72)); // or reverse???
        frgba = _mm_add_ps(frgba, _mm_dp_ps(yuv0, Bcoeff, 0x74)); // or reverse???
        frgba = _mm_min_ps(frgba, one);
        frgba = _mm_max_ps(frgba, zero);

        rgba[i] = vec4u8{
            byte(frgba.m128_f32[0] * 255),
            byte(frgba.m128_f32[1] * 255),
            byte(frgba.m128_f32[2] * 255),
            255
        };

    }
    _CSR_RESTORE();
}

SQDev•6/14/23, 7:52 AM

the hell is this lol

Lyris the KitoriOP•6/14/23, 7:53 AM

whats wrong with it

SQDev•6/14/23, 7:53 AM

i couldnt understand what it is, "conv yuv444" conversion but convert what

SQDev•6/14/23, 7:53 AM

colors?

King•6/14/23, 7:53 AM

yuv444 is a color format iirc

Lyris the KitoriOP•6/14/23, 7:54 AM

google can probably fill in the details

King•6/14/23, 7:54 AM

you have rgb but you also have like... yuv444 and 442 and 422?

King•6/14/23, 7:54 AM

lots of fours and twos anyway

King•6/14/23, 7:55 AM

which I think relates to how you compress colors in a video stream?

SQDev•6/14/23, 7:55 AM

yes

KKing which I think relates to how you compress colors in a video stream?

SQDev•6/14/23, 7:55 AM

i just found it in theora player thingy

King•6/14/23, 7:55 AM

I remember having to mess with it on the PC I used with our livingroom TV, because it didn't like RGB very much on AMD drivers

SQDev•6/14/23, 7:56 AM

oh lol

LLyris the Kitori google can probably fill in the details

SQDev•6/14/23, 7:57 AM

what details?

King•6/14/23, 7:57 AM

But yeah that whole code thing looks incredibly just... C++ code in the wrong place

King•6/14/23, 7:58 AM

but I guess it's just a bunch of weirdly named classes and structs and whatnot

KKing But yeah that whole code thing looks incredibly just... C++ code in the wrong pl...

Lyris the KitoriOP•6/14/23, 7:58 AM

i dont think thats even C++

King•6/14/23, 7:59 AM

Maybe it's just me but the all-uppercase method names and EXTERN_C just screams C++ lol

SQDev•6/14/23, 7:59 AM

its c++ yes

SQDev•6/14/23, 8:00 AM

intrinsics

_mm_add_ps

_mm_add_ps

thats not how it is used in c#

KKing Maybe it's just me but the all-uppercase method names and EXTERN_C just screams ...

Lyris the KitoriOP•6/14/23, 8:00 AM

most of that is just SIMD code

SQDev•6/14/23, 8:00 AM

thats why at first i was thinking it looks weird

LLyris the Kitori i dont think thats even C++

SQDev•6/14/23, 8:01 AM

#pragma omp parallel for num_threads(threadcount)

Lyris the KitoriOP•6/14/23, 8:03 AM

that is the only thing there that is really C++

SQDev•6/14/23, 8:04 AM

probably yes

SQDev•6/14/23, 8:05 AM

i am not sure if _mm_add_ps or _MM_SET_DENORMALS_ZERO_MODE/_MM_SET_FLUSH_ZERO_MODE available in C tho

Lyris the KitoriOP•6/14/23, 8:05 AM

why wouldnt they be?

SQDev•6/14/23, 8:06 AM

cause checked google and someone seem to have asked this

SQDev•6/14/23, 8:06 AM

so thats why i said it might not be, but im not sure

Lyris the KitoriOP•6/14/23, 8:07 AM

that means C code implementations of the intrinsics

EXTERN_C DLLENTRY void DLLCALL conv_yuv444_to_rgb_sse_thr(const int threadcount, size_t length, byte* Y, byte* U, byte* V, vec4u8* rgba) { _CSR_SAVE(); _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_ON); _MM_SET_FLUSH_ZERO_MODE(_MM_FLUSH_ZERO_ON); #pragma omp parallel for num_threads(threadcount) for (__int64 i = 0; i < length; i++) { __m128 frgba = { 0,0,0,0 }; __m128 yuv0 = __m128{Y[i] * inv255, U[i] * inv255, V[i] * inv255, 1}; yuv0 =_mm_add_ps(yuv0, offset); frgba = _mm_add_ps(frgba, _mm_dp_ps(yuv0, Rcoeff, 0x71)); // or reverse??? frgba = _mm_add_ps(frgba, _mm_dp_ps(yuv0, Gcoeff, 0x72)); // or reverse??? frgba = _mm_add_ps(frgba, _mm_dp_ps(yuv0, Bcoeff, 0x74)); // or reverse??? frgba = _mm_min_ps(frgba, one); frgba = _mm_max_ps(frgba, zero); rgba[i] = vec4u8{ byte(frgba.m128_f32[0] * 255), byte(frgba.m128_f32[1] * 255), byte(frgba.m128_f32[2] * 255), 255 }; } _CSR_RESTORE(); }