dev mode can often have inconsistencies between actual production builds. If it is not working with

Original message was deleted

K

Kuririn•6/15/23, 11:01 AM

but on prerender I can't read it

platform.env is not available

Original message was deleted

K

Kuririn•6/15/23, 12:57 PM

Thanks!

I will check it out

K

Kuririn•6/15/23, 1:08 PM

static worked

K

Kuririn•6/15/23, 1:09 PM

I thought I was trying static yesterday but supposedly not

A

Ashley•6/15/23, 5:29 PM

Are there docs somewhere for what can be passed for

preview_deployment_setting

preview_deployment_setting

preview_deployment_setting

preview_deployment_setting in the Cloudflare Pages Terraform module? It notes

all

all

all

all is default, and I can see based on the example

custom

custom

is also allowed... are there others?

tl;dr I want to deploy branches that contain

preview

preview

preview

preview, so I have:

preview_deployment_setting    = "custom"
preview_branch_includes       = ["preview"]
preview_branch_excludes       = ["master""]

preview_deployment_setting    = "custom"
preview_branch_includes       = ["preview"]
preview_branch_excludes       = ["master""]

preview_deployment_setting    = "custom"
preview_branch_includes       = ["preview"]
preview_branch_excludes       = ["master""]

preview_deployment_setting    = "custom"
preview_branch_includes       = ["preview"]
preview_branch_excludes       = ["master""]

But it's skipping (shown in the UI) a branch named

preview-add-text

preview-add-text

preview-add-text

preview-add-text, so a little confused why

A

Ashley•6/15/23, 5:29 PM

(the docs aren't super clear on the values for

preview_deployment_setting

preview_deployment_setting

preview_deployment_setting

preview_deployment_setting)

AAshley 👋 Are there docs somewhere for what can be passed for `preview_deployment_setti...

W

Walshy•6/15/23, 5:37 PM

"all" "custom" and "none"

W

Walshy•6/15/23, 5:38 PM

But it's skipping (shown in the UI) a branch named preview-add-text, so a little confused why

You're only including "preview"

W

Walshy•6/15/23, 5:38 PM

you want

preview*

preview*

preview*

preview* to include "preview" and

"preview-*"

"preview-*"

"preview-*"

"preview-*" or just

preview-*

preview-*

preview-*

preview-* for only

"preview-*

"preview-*

"preview-*

"preview-*

A

Ashley•6/15/23, 5:58 PM

Ahhh thank you, didn’t realise you needed wildcards as the name implies it’s sort of a wildcard (due to “includes”)

C

Cyb3r-Jak3•6/15/23, 6:10 PM

We need to make those docs better

C

Cyb3r-Jak3•6/15/23, 6:10 PM

Well Washly needs to

W

Walshy•6/15/23, 7:43 PM

wait waht

W

Walshy•6/15/23, 7:43 PM

me

W

Walshy•6/15/23, 7:44 PM

I made the dev docs: https://developers.cloudflare.com/pages/platform/branch-build-controls/#preview-branch-control

WWalshy I made the dev docs: <https://developers.cloudflare.com/pages/platform/branch-bu...

C

Cyb3r-Jak3•6/15/23, 7:48 PM

Yeah so you can copy and paste

W

Walshy•6/15/23, 7:49 PM

nah wouldn't copy-paste

W

Walshy•6/15/23, 7:49 PM

docs should be source of truth

C

Cyb3r-Jak3•6/15/23, 7:51 PM

Hyperlinks it is

JJames dev mode can often have inconsistencies between actual production builds. If it ...

K

kev-ac•6/15/23, 8:40 PM

Possible. Just wanted to ask here first because it only happens using the edge runtime. Maybe its totally obvious but I just didn't get it.

J

JamesOP•6/15/23, 8:45 PM

i would guess it probably depends on reading something in the filesystem that is only a part of nodejs builds to work properly

J

JamesOP•6/15/23, 8:45 PM

¯\_(ツ)_/¯

K

kian•6/16/23, 12:28 AM

Not currently, no

WWalshy docs should be source of truth

A

Ashley•6/16/23, 5:09 PM

Sorry didn't see the responses - agreed there should be a source of truth, but the Terraform docs could link to the ones on dev.cloudflare as I did try to look for values for things and couldn't find it easily

S

simpson•6/16/23, 8:03 PM

what is the best place to look for historical product updates for Pages?

S

simpson•6/16/23, 8:05 PM

I've looked at that before, it just feels like there is a lot more than what is documented there

A

Ashley•6/16/23, 8:24 PM

For

pages dev

pages dev

with Wrangler, I can see you can pass KV/R2 etc. but what about service bindings?

In essence, I have a worker that's implementing an API, and a pages project that's using the API, and the API itself will remain private. Currently, I am just hard-coding the URL and making a

fetch

fetch

(server-side, using SvelteKit) but naturally in production I need to use a service binding, any ideas?

A

Ashley•6/16/23, 8:26 PM

I feared that might be the case, any tips on how to handle? I'd like to avoid conditionals that are effectively "if local do this else do that" but guessing that's probably the only way?

A

Ashley•6/16/23, 8:26 PM

I can wrap it in some module that encapsulates this for all service binding calls so it's mostly centered in one place but still

A

Ashley•6/16/23, 8:27 PM

Oh that's pretty neat

A

Ashley•6/16/23, 8:28 PM

Thank you!

A

Ashley•6/16/23, 8:29 PM

I wonder if a little more complex version of that would help with the

platform

platform

being empty locally in SvelteKit problem

A

Ashley•6/16/23, 8:35 PM

And if you passed

--kv=FOO

--kv=FOO

--kv=FOO

--kv=FOO when starting

pages dev

pages dev

it'd be set in

platform

platform

?

A

Ashley•6/16/23, 8:35 PM

ty!

A

Ashley•6/16/23, 8:39 PM

Yeah I don't think it's awful with the suggestion above, and just going to set platform and steal your polyfill and set it for my service binding locally

Or that's the hope, anyway

AAshley Yeah I don't think it's awful with the suggestion above, and just going to set p...

A

Ashley•6/16/23, 8:52 PM

For anyone curious, this works in SvelteKit:

// /src/hooks.server.ts
import { dev } from '$app/environment';

export const handle = ({ event, resolve }) => {
    if (dev) {
        // We fake the platform for local development.
        event.platform ??= {
            env: {
                PHOTO_SERVICE: {
                    fetch(input, init) {
                        const req = new Request(input, init);
                        return fetch(input, req)
                    }
                } 
            },
        };
    }
    return resolve(event);
};

// /src/hooks.server.ts
import { dev } from '$app/environment';

export const handle = ({ event, resolve }) => {
    if (dev) {
        // We fake the platform for local development.
        event.platform ??= {
            env: {
                PHOTO_SERVICE: {
                    fetch(input, init) {
                        const req = new Request(input, init);
                        return fetch(input, req)
                    }
                } 
            },
        };
    }
    return resolve(event);
};

// /src/hooks.server.ts
import { dev } from '$app/environment';

export const handle = ({ event, resolve }) => {
    if (dev) {
        // We fake the platform for local development.
        event.platform ??= {
            env: {
                PHOTO_SERVICE: {
                    fetch(input, init) {
                        const req = new Request(input, init);
                        return fetch(input, req)
                    }
                } 
            },
        };
    }
    return resolve(event);
};

// /src/hooks.server.ts
import { dev } from '$app/environment';

export const handle = ({ event, resolve }) => {
    if (dev) {
        // We fake the platform for local development.
        event.platform ??= {
            env: {
                PHOTO_SERVICE: {
                    fetch(input, init) {
                        const req = new Request(input, init);
                        return fetch(input, req)
                    }
                } 
            },
        };
    }
    return resolve(event);
};

Naturally if you're mixing Service Bindings and KV for example, you'd lose your KV, but for my case I'm only using Service Bindings atm

A

Ashley•6/16/23, 8:53 PM

And you can use https://github.com/sveltejs/kit/issues/4292#issuecomment-1550596497 to add other deps if you wish from Miniflare

A

Ashley•6/16/23, 9:31 PM

I feel like I am going to facepalm, but in production, using a real service binding, what on earth do you pass as the URL in the request?

All the examples are simply passing or cloning the original request like in a middleware, but in this case, my Pages Function needs to basically make an API call to a Worker.

e.g. my website might get hit on the root domain, triggering a request to a Pages Function that will SSR the page, and in doing so I want to make an API call to my worker (e.g. to

/foo

/foo

/foo

/foo as I'm using IttyRouter to route API requests in the worker). Is that... possible? I find it weird it wouldn't be as you wouldn't be able to have composable "microservices" otherwise

AAshley I feel like I am going to facepalm, but in production, using a real service bind...

H

Hello, I’m Allie!•6/16/23, 9:39 PM

Pass any hostname, along with the path you want, ie

https://rawr.co/foo

https://rawr.co/foo

https://rawr.co/foo

https://rawr.co/foo. The hostname doesn’t matter, unless your Service does something with it

A

Ashley•6/16/23, 9:40 PM

Thanks for confirmation, I er... realised I er... hadn't bound my worker to the pages project

R

Ricardo Viteri•6/17/23, 1:35 AM

is it possible to assign a domain to the preview environment?

dev mode can often have inconsistencies between actual production builds. If it is not working with

Similar Threads

Similar Threads

Similar Threads