A create-react-app?

H

Hello, I’m Allie!OP•6/17/23, 12:54 PM

What do you mean, "default"?

HHello, I’m Allie!A create-react-app?

H

Hasi•6/17/23, 12:54 PM

yep

HHello, I’m Allie!What do you mean, "default"?

H

Hasi•6/17/23, 12:54 PM

Default: The one created with the cloudflare-create

H

Hasi•6/17/23, 12:58 PM

soo what's the solution?

H

Hello, I’m Allie!OP•6/17/23, 1:03 PM

Huh, that one is kind of borked... Let me see if I can get it working...

HHello, I’m Allie!Huh, that one is kind of borked... Let me see if I can get it working...

H

Hasi•6/17/23, 1:04 PM

Welp, just deploy a react app

H

Hello, I’m Allie!OP•6/17/23, 1:07 PM

Yeah, looks like something the React dev server is returning breaks GZip...

HHello, I’m Allie!Yeah, looks like something the React dev server is returning breaks GZip...

H

Hasi•6/17/23, 1:08 PM

yep, I see it

S

Steved•6/18/23, 9:53 PM

I've just created a new svelte project with C3, and run

npm run pages:dev

npm run pages:dev

npm run pages:dev

npm run pages:dev which in turn runs

wrangler pages dev --compatibility-date=2023-06-18 --proxy 5173 -- npm run dev

wrangler pages dev --compatibility-date=2023-06-18 --proxy 5173 -- npm run dev

wrangler pages dev --compatibility-date=2023-06-18 --proxy 5173 -- npm run dev

wrangler pages dev --compatibility-date=2023-06-18 --proxy 5173 -- npm run dev. This triggers an oauth login to cloudflare in the browser. Out of interest, why? Given it's running locally with Wranger v3.

K

kian•6/19/23, 4:21 PM

Local development that uses

workerd

workerd

doesn't support that architecture, correct

K

kian•6/19/23, 9:27 PM

Pass it to

deploy

deploy

like

wrangler deploy --var GOVEE_API_KEY:$WRANGLER_GOVEE_API_KEY

wrangler deploy --var GOVEE_API_KEY:$WRANGLER_GOVEE_API_KEY

wrangler deploy --var GOVEE_API_KEY:$WRANGLER_GOVEE_API_KEY

wrangler deploy --var GOVEE_API_KEY:$WRANGLER_GOVEE_API_KEY but those are plain-text in the dashboard & whatnot so ideally you'd use secrets.

K

kian•6/19/23, 9:27 PM

KV has no CLI arg unfortunately

D

DaniFoldi•6/19/23, 9:37 PM

wrangler-action also has a secrets: section where you can provide secrets it will upload every time

K

kian•6/19/23, 9:55 PM

Have you done

npm i

npm i

(or the equivalent in the package manager you're using) in CI already?

K

kian•6/19/23, 9:58 PM

preCommands: npm install

preCommands: npm install

preCommands: npm install

preCommands: npm install should be all you need I suppose

K

kian•6/19/23, 9:58 PM

It'll go in the

with

with

with

with block - put it before

command

command

command

command (just aesthetics)

J

James•6/19/23, 9:59 PM

I'd heavily encourage using

npm ci

npm ci

npm ci

npm ci over

npm install

npm install

if you have a lockfile, for stable and reproducible builds, but yep,

preCommands

preCommands

preCommands

preCommands is great for that

J

James•6/19/23, 10:01 PM

devDependencies

devDependencies

devDependencies

devDependencies is fine and what I'd recommend for something like this. But it won't matter here

K

kian•6/19/23, 10:01 PM

@cloudflare/workers-types

@cloudflare/workers-types

@cloudflare/workers-types

@cloudflare/workers-types and

typescript

typescript

typescript

typescript could probably be devDependencies I guess

J

James•6/19/23, 10:02 PM

My mentality:

dependencies

dependencies

are for runtime things, if you've got an app that runs and uses

express

express

express

express for example.

devDependencies

devDependencies

devDependencies

devDependencies for dev tooling, or anything that's only used to build, like everything here, since it's all bundled into a single output worker.

D

DaniFoldi•6/19/23, 10:02 PM

I keep dependencies required in the main build step in regular, everything else in dev, so the main build step only needs to install non-dev stuff

JJames My mentality: `dependencies` are for _runtime_ things, if you've got an app that...

J

James•6/19/23, 10:02 PM

But I know people have differing opinions on that

D

DaniFoldi•6/19/23, 10:03 PM

Yup

J

James•6/19/23, 10:03 PM

Yeah, in your case I would personally throw it all in

devDependencies

devDependencies

devDependencies

devDependencies, but you're not publishing to npm... so it doesn't overly matter.

J

James•6/19/23, 10:04 PM

perfect haha

K

kian•6/19/23, 10:04 PM

that's a James move

Similar Threads

Similar Threads

Similar Threads