Cloudflare Developers•3y ago

If Astro uses something like node_modules/.cache then we could totally cache that

EErisa (ok ideally pages would allow custom cache folders, im just being cheeky)

JacobOP•9/1/23, 3:12 PM

One day

JJacob If Astro uses something like node_modules/.cache then we could totally cache tha...

itsmatteomanf•9/1/23, 4:42 PM

It’s actually .astro, but yes

itsmatteomanf•9/1/23, 4:42 PM

(In node_modules)

itsmatteomanf•9/1/23, 5:20 PM

I just filled the form again, I want to try it on Astro with a lot of images

itsmatteomanf•9/4/23, 12:10 PM

@Vero any chance to get the form looked at?

Iitsmatteomanf <@1052249953570918430> any chance to get the form looked at? 🙂

Vero•9/4/23, 12:11 PM

Today is a holiday in the US, so expect delays

itsmatteomanf•9/4/23, 12:11 PM

Oh... didn't know that NotLikeThis

itsmatteomanf•9/4/23, 12:11 PM

No prob

Vero•9/4/23, 12:11 PM

haha don't worry

Vero•9/4/23, 12:13 PM

but let me ask someone internally if they can enable it

itsmatteomanf•9/4/23, 12:13 PM

Don't worry too much

Iitsmatteomanf Don't worry too much 🙂

Vero•9/4/23, 12:16 PM

enabled

VVero enabled

itsmatteomanf•9/4/23, 12:16 PM

That was fast, thanks!

VVero enabled

itsmatteomanf•9/4/23, 12:22 PM

I'm not seeing that trying to fetch anything from cache... is it just production or preview, too?

Iitsmatteomanf I'm not seeing that trying to fetch anything from cache... is it just production...

Vero•9/4/23, 12:26 PM

it's for prod and preview too, he enabled both envs

VVero it's for prod and preview too, he enabled both envs

itsmatteomanf•9/4/23, 12:27 PM

Let me retry... but it's not showing anything regarding cache NotLikeThis

itsmatteomanf•9/4/23, 12:27 PM

I have retried a deployment, maybe it requires a new commit...?

itsmatteomanf•9/4/23, 12:31 PM

Nope, nothing

itsmatteomanf•9/4/23, 12:31 PM

Next attempt is new commit...

Vero•9/4/23, 12:38 PM

Hmm weird, I've asked internally but no response yet

Iitsmatteomanf Next attempt is new commit...

itsmatteomanf•9/4/23, 1:02 PM

Nope, this didn't seem to work either. I hoped when it took 30+ seconds initialize the environment lul

Iitsmatteomanf Nope, this didn't seem to work either. I hoped when it took 30+ seconds initiali...

Vero•9/4/23, 1:15 PM

well, let's wait for John and Jacob to get back to work

Vero•9/4/23, 1:35 PM

@itsmatteomanf Walshy just found the issue, is it working now?

VVero <@487247657736339456> Walshy just found the issue, is it working now?

itsmatteomanf•9/4/23, 1:35 PM

Retrying

Walshy, the savior lul

itsmatteomanf•9/4/23, 1:36 PM

Yes, shows the attempt to restore from cache!

Vero•9/4/23, 1:39 PM

yaay

itsmatteomanf•9/4/23, 1:49 PM

Questions for the team, once they actually get back, no rush:

Are there size limits for the cache?
I am not actually seeing the cache in node_modulesnode_modules being used, so is every folder saved? Are .[folder].[folder] excluded?

Iitsmatteomanf Questions for the team, once they actually get back, no rush: - Are there size l...

Isaac McFadyen•9/4/23, 8:17 PM

AFAIK node_modules isn't cached.

Isaac McFadyen•9/4/23, 8:17 PM

Only ~/.npm is cached.

Isaac McFadyen•9/4/23, 8:17 PM

See James' comments above.

IIsaac McFadyen AFAIK node_modules isn't cached.

itsmatteomanf•9/4/23, 8:18 PM

I think it’s currently the opposite.

JJames How is the cache key determined, and how could I use caching successfully with m...

Isaac McFadyen•9/4/23, 8:18 PM

@itsmatteomanf

JJacob We're going to switch to caching npm/yarn global caches. Thanks!

Isaac McFadyen•9/4/23, 8:18 PM

Oh OK, yeah Jacob mentioned they were going to do it here but didn't say if that was current or not.

itsmatteomanf•9/4/23, 8:19 PM

Yeah, it’s planned for this week afaik, but we’ll see tomorrow

IIsaac McFadyen Only ~/.npm is cached.

JacobOP•9/5/23, 5:48 PM

Working on making this change this week. Current beta still caches node_modules

Luke•9/5/23, 6:20 PM

Hello! I see only Next.js and Gatsby are supported so far. I have a few Vite projects and Nuxt projects I could test with once they're supported

JJacob Working on making this change this week. Current beta still caches node_modules

James•9/6/23, 11:02 AM

Are y’all planning on landing this before adding more folks to the beta? Excited to see this rolling out!

simpson•9/6/23, 7:16 PM

how do we tell if caching is enabled on our account?

Ssimpson how do we tell if caching is enabled on our account?

itsmatteomanf•9/6/23, 7:17 PM

There should be a message pretty soon after the build starts, in the logs, that is fetching the cache, and one at the end that is saving it (or skipping it for some reason)

JJames Are y’all planning on landing this before adding more folks to the beta? Excited...

JacobOP•9/7/23, 3:37 PM

Adding more users shortly - expecting dependency cache changes by EOW!
Edit: Probably more like early next week. Possibly Astro support soon too

JacobOP•9/8/23, 6:56 PM

Just pushed an update - dependency caching now caches global npm/yarn caches. Thanks again for the feedback @James

JacobOP•9/8/23, 6:56 PM

Users who have submitted projects the last few days will be enabled in a bit

JJacob Just pushed an update - dependency caching now caches global npm/yarn caches. Th...

James•9/8/23, 7:22 PM

Amazing, thank you for the update and being so receptive to feedback! MeowHeartCloudflare

JJacob Just pushed an update - dependency caching now caches global npm/yarn caches. Th...

JohnDotAwesome•9/8/23, 7:49 PM

Do note that with the change in cache strategy, your previous caches will no longer match

JacobOP•9/8/23, 9:27 PM

Astro support is now live party_blob

JJacob Astro support is now live <a:party_blob:818919990635266079>

itsmatteomanf•9/8/23, 9:47 PM

And... it works?

JacobOP•9/8/23, 9:56 PM

should now!

itsmatteomanf•9/8/23, 9:56 PM

Let me retry!

itsmatteomanf•9/8/23, 9:57 PM

Looks like it does!

JacobOP•9/8/23, 9:59 PM

All users that submitted projects now has build caching enabled for the submitted project. You will need to click Enable build cacheEnable build cache in the Builds and deploymentsBuilds and deployments settings.
For the first few users, the build cache toggle is currently ignored. But please enable it, as we will remove the override in the next week or two so that you can turn it on/off as desired.

NOTE: The "Enable build cache" options will show up in all projects, but it will ONLY have any affect on the project(s) you submitted.
Also: The Clear cacheClear cache button won't work until early next week.

Thanks!

If Astro uses something like node_modules/.cache then we could totally cache that

Similar Threads

Similar Threads

Similar Threads