Also seems like `success: true` is forced in the typings, so presumably it's not even useful?

Also seems like

success: true

success: true

is forced in the typings, so presumably it's not even useful?

CretezyOP•10/6/23, 6:03 AM

Also, are

batch

batch

ran sequencially? Would it work if I read a row in the 1st batched statement, but delete the same row in the 2nd statement?

CCretezy Also seems like `success: true` is forced in the typings, so presumably it's not...

Max (@rozenmd)•10/6/23, 8:16 AM

  success: boolean, // true if the operation was successful, false otherwise

  success: boolean, // true if the operation was successful, false otherwise

MMatt Silverlock Yes, if you are using `—remote` mode in wrangler

Adi//•10/6/23, 9:24 AM

is this solved now?

AAdi//is this solved now?

Matt Silverlock•10/6/23, 9:40 AM

Yes, the incident you were asking about has been closed since yesterday

MMatt Silverlock Yes, the incident you were asking about has been closed since yesterday

Adi//•10/6/23, 9:44 AM

ok ok, lol i was trying to work on a cron worker at the same time and --remote kept failing

good to know there was no mistake on my end

SSPS | Shootmail https://github.com/cloudflare/workerd/pull/1279 Is this being merged today to fi...

Matt Silverlock•10/6/23, 10:02 AM

To be transparent: no. Also merging is not the same as releasing. Hold tight.

SSPS | Shootmail Any expected date, so that i can decide my next steps. I cannot move forward wit...

Matt Silverlock•10/6/23, 10:15 AM

Our goal is within the next week. I strongly suggest you refactor how you are performing your joins in the meantime if you need to unblock yourself. The current limit isn’t high but we’ve rarely had folks run into it so directly.

VVikash The database is for testing, feel free to takeover if you want to test? Or shoul...

Vikash•10/6/23, 10:20 AM

@rozenmd Any suggestion on 1 second slowness in all queries?

VVikash @rozenmd Any suggestion on 1 second slowness in all queries?

Matt Silverlock•10/6/23, 11:37 AM

You should not expect D1 to be outright faster than a hot (cached) KV read. How are you measuring query performance? What is the duration of the query itself, as reported in

result.meta.duration

result.meta.duration

and then the time for the D1 API call without your application code?

MMatt Silverlock You should not expect D1 to be outright faster than a hot (cached) KV read. How ...

Vikash•10/6/23, 11:46 AM

Yes, I am not considering that. Here is response on a worker where duration is : 0.689.
I guess that's more half second.

"success":true,"meta":{"served_by":"v3-prod","duration":0.689,"changes":0,"last_row_id":0,"changed_db":false,"size_after":81920,"rows_read":43,"rows_written":0},"results": [....]

"success":true,"meta":{"served_by":"v3-prod","duration":0.689,"changes":0,"last_row_id":0,"changed_db":false,"size_after":81920,"rows_read":43,"rows_written":0},"results": [....]

https://development.pricetree-angular.pages.dev/api/products

Vikash•10/6/23, 11:48 AM

And some time even more than 1 second -

Kuririn•10/6/23, 12:01 PM

I have query like this:

const response = await env.DB.prepare(`
                UPDATE Promotions 
                SET content = ?, last_update_time = ?
                WHERE promo_id = ?
            `).bind(JSON.stringify(page), currentTimeInSeconds, page.id).run();

const response = await env.DB.prepare(`
                UPDATE Promotions 
                SET content = ?, last_update_time = ?
                WHERE promo_id = ?
            `).bind(JSON.stringify(page), currentTimeInSeconds, page.id).run();

but it doesn't update the record and doesn’t return anything or throw an error.

My only idea is that page is too big, but something similar works for insert.
But it would be weird that I can't update big values (article).

VVikash And some time even more than 1 second -

Matt Silverlock•10/6/23, 12:19 PM

Duration is in milliseconds

KKuririn I have query like this: ```const response = await env.DB.prepare(` ...

Matt Silverlock•10/6/23, 12:19 PM

Try it without calling stringify, and just pass in a plain value first

MMatt Silverlock Try it without calling stringify, and just pass in a plain value first

Vikash•10/6/23, 12:21 PM

I am using Hono

.json()

.json()

, I will test without that -

products.get('/', async (c) => {
const { offset = 0, limit = 1000 } = c.req.query();
const results = await getProducts(c, Number(offset), Number(limit));
return c.json(results as Product[]);
});

VVikash I am using Hono `.json()`, I will test without that - products.get('/', async...

Matt Silverlock•10/6/23, 12:25 PM

I replied to the other user

MMatt Silverlock I replied to the other user 🙂

Vikash•10/6/23, 12:26 PM

MMatt Silverlock Try it without calling stringify, and just pass in a plain value first

Kuririn•10/6/23, 12:55 PM

It doesn’t work without stringify, but I noticed it worked once finally (after many trials). It was probably cloudflare issue (didn't execute code and didn't return the promise). I will test it again.

KKuririn It doesn’t work without stringify, but I noticed it worked once finally (after m...

Matt Silverlock•10/6/23, 12:57 PM

And you changed nothing at all?

Kuririn•10/6/23, 1:01 PM

let me check again, I'm trying so many different things that I'm confused

Kuririn•10/6/23, 1:06 PM

Sorry man! It worked without stringify. I got some D1 error about object when testing before but it worked nevertheless. And now it works without the object error.

Kuririn•10/6/23, 1:06 PM

I'm using insert with strinigify and it works, when I should use it and when not?

Ttouhidurrr 🇵🇸Is there any way to use D1 directly from my app without using workers?

Kuririn•10/6/23, 1:09 PM

I don't think so. I use worker to provide an api for my app.

KKuririn Sorry man! It worked without stringify. I got some D1 error about object when te...

Kuririn•10/6/23, 1:12 PM

I got the error again:
for value "D1_TYPE_ERROR: Type 'object' not supported [Object object]''

Kuririn•10/6/23, 1:13 PM

I'm totally confused now, because it worked once, then without changing the code it throw this error

Kuririn•10/6/23, 1:15 PM

orr diffrent versions are running, I will check without stringify once again

KKuririn I'm using insert with strinigify and it works, when I should use it and when not...

Matt Silverlock•10/6/23, 1:18 PM

Your JSON.stringify call is likely returning an object that isn’t what your query can bind. You should prep the bound variable before you pass it to your query.

KKuririn I got the error again: for value "D1_TYPE_ERROR: Type 'object' not supported [Ob...

Matt Silverlock•10/6/23, 1:18 PM

If you stringify and then log that result I guarantee it is not what you are expecting

Kuririn•10/6/23, 1:37 PM

I finally figured it out, this call was in async foreach loop and script ended too soon without waiting for the response , I changed it to for of loop and it seems to work now

EvanPiro•10/6/23, 3:28 PM

Is it possible to easily pull a remote database copy into local using wrangler?

MMax (@rozenmd)? ` success: boolean, // true if the operation was successful, false otherwise`

CretezyOP•10/6/23, 3:44 PM

CretezyOP•10/6/23, 3:44 PM

success

success

can only be

true

true

in the TypeScript typings

CretezyOP•10/6/23, 3:44 PM

node_modules/@cloudflare/workers-types/index.d.tsnode_modules/@cloudflare/workers-types/index.d.ts

CCretezy `success` can only be `true` in the TypeScript typings

Max (@rozenmd)•10/6/23, 3:51 PM

success

success

can only be

true

true

in the D1Result type, see D1UpstreamFailure:

interface D1UpstreamFailure {
  results?: never
  error: string
  success: false
  meta: Record<string, unknown>
}

interface D1UpstreamFailure {
  results?: never
  error: string
  success: false
  meta: Record<string, unknown>
}

CretezyOP•10/6/23, 3:52 PM

I don't see D1UpstreamFailureD1UpstreamFailure is this file. I'm using "@cloudflare/workers-types": "^4.20230814.0""@cloudflare/workers-types": "^4.20230814.0", will update

CretezyOP•10/6/23, 3:53 PM

Still nothing in 4.20231002.04.20231002.0. @rozenmd Can you link me to this file?

kian•10/6/23, 3:54 PM

D1UpstreamFailureD1UpstreamFailure is in the binding rather than the types so the users don't see it

Max (@rozenmd)•10/6/23, 3:54 PM

ahhh

Max (@rozenmd)•10/6/23, 3:54 PM

Yeah we should probably export it

CretezyOP•10/6/23, 3:54 PM

Either way, I think it would be good to mark in the documentation what happens if

success

success

false

false

for methods which don't return it

CretezyOP•10/6/23, 3:54 PM

E.g., what happens if

success

success

false

false

for

first

first

. Does it throw an error, return null, etc

CretezyOP•10/6/23, 3:55 PM

Also, should we be checking if

success

success

true

true

on every call that returns it? I've been assuming if there's an upstream error it will throw

CretezyOP•10/6/23, 3:59 PM

Another note: https://developers.cloudflare.com/workers/wrangler/commands/#execute should likely mention

--local

--local

Commands - Wrangler · Cloudflare Workers docs

Wrangler offers a number of commands to manage your Cloudflare Workers.

Matt Silverlock•10/6/23, 4:13 PM

Just landed: every D1 account (on a paid plan) can create up to 50,000 databases, no changes needed: https://developers.cloudflare.com/d1/changelog/#create-up-to-50000-d1-databases

Changelog · Cloudflare D1 docs

Developers using D1 on a Workers Paid plan can now create up to 50,000 databases as part of ongoing increases to D1’s limits.

Also seems like `success: true` is forced in the typings, so presumably it's not even useful?

Similar Threads