was more the libsilk side of things

P

PerkseyOP•10/17/23, 4:06 PM

@khitiara maths is in the repo now ready for your hacking

K

khitiara•10/17/23, 4:06 PM

cool, thanks!

P

PerkseyOP•10/17/23, 4:06 PM

71 new commits

K

khitiara•10/17/23, 4:10 PM

lmao

K

khitiara•10/17/23, 5:22 PM

so the thing causing potential issues here

K

khitiara•10/17/23, 5:24 PM

public void Thing<T>(T x) where T : notnull {
  if(x is ISomeMathInterface<T>) {
    Func<T>(x);
  }
  void Func<T1>(T1 x) where T1 : ISomeMathInterface<T> {
    // ...
  }
}

public void Thing<T>(T x) where T : notnull {
  if(x is ISomeMathInterface<T>) {
    Func<T>(x);
  }
  void Func<T1>(T1 x) where T1 : ISomeMathInterface<T> {
    // ...
  }
}

public void Thing<T>(T x) where T : notnull {
  if(x is ISomeMathInterface<T>) {
    Func<T>(x);
  }
  void Func<T1>(T1 x) where T1 : ISomeMathInterface<T> {
    // ...
  }
}

public void Thing<T>(T x) where T : notnull {
  if(x is ISomeMathInterface<T>) {
    Func<T>(x);
  }
  void Func<T1>(T1 x) where T1 : ISomeMathInterface<T> {
    // ...
  }
}

K

khitiara•10/17/23, 5:24 PM

this isnt legal

K

khitiara•10/17/23, 5:24 PM

and that makes it hard to use generic math without losing potential generic arguments

K

khitiara•10/17/23, 5:24 PM

it is doable! but only with reflection afaik

K

khitiara•10/17/23, 5:25 PM

any ideas for how to work around this?

P

PerkseyOP•10/17/23, 5:29 PM

to some extent we may have to still do our generic specialisation thing...

public void Thing<T>(T x) where T : notnull {
  return x switch
  {
    float x => (T) (object) Func(x),
    double x => (T) (object) Func(x),
    // ... 
  };
  void Func<T1>(T1 x) where T1 : ISomeMathInterface<T> {
    // ...
  }
}

public void Thing<T>(T x) where T : notnull {
  return x switch
  {
    float x => (T) (object) Func(x),
    double x => (T) (object) Func(x),
    // ... 
  };
  void Func<T1>(T1 x) where T1 : ISomeMathInterface<T> {
    // ...
  }
}

public void Thing<T>(T x) where T : notnull {
  return x switch
  {
    float x => (T) (object) Func(x),
    double x => (T) (object) Func(x),
    // ... 
  };
  void Func<T1>(T1 x) where T1 : ISomeMathInterface<T> {
    // ...
  }
}

public void Thing<T>(T x) where T : notnull {
  return x switch
  {
    float x => (T) (object) Func(x),
    double x => (T) (object) Func(x),
    // ... 
  };
  void Func<T1>(T1 x) where T1 : ISomeMathInterface<T> {
    // ...
  }
}

K

khitiara•10/17/23, 5:30 PM

fortunately this only affects float specific things generally

K

khitiara•10/17/23, 5:31 PM

most things can just be a single generic constraint which everything satisfies

K

khitiara•10/17/23, 5:31 PM

but float specific ops cause issues

PPerksey was more the libsilk side of things

A

Aqua•10/17/23, 5:31 PM

SDL style event handling would be quite nice. i always thought glfw's event processing was terrible
i just like to do

SDL_Event event;
while (SDL_PollEvent(&event)) {
  switch (event.type) { .... }
}

SDL_Event event;
while (SDL_PollEvent(&event)) {
  switch (event.type) { .... }
}

SDL_Event event;
while (SDL_PollEvent(&event)) {
  switch (event.type) { .... }
}

SDL_Event event;
while (SDL_PollEvent(&event)) {
  switch (event.type) { .... }
}

K

khitiara•10/17/23, 5:31 PM

that ill agree with

K

Kai•10/17/23, 5:32 PM

perksey having fun with CI

AAqua SDL style event handling would be quite nice. i always thought glfw's event proc...

P

PerkseyOP•10/17/23, 5:32 PM

this will probably still be heavily abstracted away

P

PerkseyOP•10/17/23, 5:32 PM

e.g. you'd still have to call

Run

Run

the "root" surface and that'll pump the events to the relevant windows

A

Aqua•10/17/23, 5:33 PM

ah you're talking about high level silk windowing? i've only used it a handful of times so I don't have too much input on it

A

Aqua•10/17/23, 5:33 PM

since the days of when I was using opentk i've been ignoring the built in windowing systems and just rolling my own

P

PerkseyOP•10/17/23, 5:34 PM

yeah, essentially

libsilk

libsilk

is just going to be a native counterpart to the HLU that basically implements an almost identical API, but in C (+COM?)

P

PerkseyOP•10/17/23, 5:34 PM

@tannergooding i don't suppose over the years you've come up with some smart ideas for Vector2<T>? we're looking into moving to generic maths, and obviously there's loads of cases that Silk.NET supports today that would be silly in a generic maths world (e.g. you can do

Sin

Sin

on a

byte

byte

).

we can go with use case parity with 2.X, even if it doesn't make sense, but i figured given you'll have to be tackling this problem eventually maybe you have some loose thoughts knocking about in that noggin.

P

PerkseyOP•10/17/23, 5:35 PM

oh i didn't reply to the message, this is the relevant link team-talk

A

Aqua•10/17/23, 5:35 PM

currently .net generic math requires you to specifically implement

ITrigonometricFunctions

ITrigonometricFunctions

etc to get the sin and cos functions

A

Aqua•10/17/23, 5:35 PM

so you can't use those on integers for example

K

Kai•10/17/23, 5:35 PM

I think with the new generic API you can solve this with extension types no?

A

Aqua•10/17/23, 5:35 PM

as only float + double support it

A

Aqua•10/17/23, 5:35 PM

and yeah you can use extensions to fix some issues

K

Kai•10/17/23, 5:35 PM

I mean we hardly ever want to support VectorN<T> : any_of_the_interfaces

A

Aqua•10/17/23, 5:35 PM

as they will only show up on types that support it

K

Kai•10/17/23, 5:36 PM

so Vector2<T>.Sin can just be defined as an extension method on Vector2<T> where T : ITrigonometricFunctions

A

Aqua•10/17/23, 5:36 PM

https://github.com/piegfx/Warp/tree/main/src/Warp.Math here's my current generic math implementations if its of any use

K

Kai•10/17/23, 5:36 PM

(not mentioning the horrible IDE support for this pattern but...)

K

khitiara•10/17/23, 5:36 PM

yeah that works just means things like Length cant be properties

P

PerkseyOP•10/17/23, 5:36 PM

yeah I think maybe we should just have a bunch of generic static methods that conditionally enable. a weird consequence of Silk.NET.Maths implementing a proxy over the base ops itself is that all ops were defined in terms of that proxy, allowing strange things like

Sin<byte>

Sin<byte>

AAqua <https://github.com/piegfx/Warp/tree/main/src/Warp.Math> here's my current gener...

A

Aqua•10/17/23, 5:36 PM

note the use of extension methods for things like

Length()

Length()

Kkhitiara yeah that works just means things like Length cant be properties

K

Kai•10/17/23, 5:37 PM

no reason length isn't well defined on integers?

Kkhitiara yeah that works just means things like Length cant be properties

P

PerkseyOP•10/17/23, 5:37 PM

I can live with that, we already have static functions like

Vector2.Length

Vector2.Length

in a lot of places anyway

KKai no reason length isn't well defined on integers?

K

khitiara•10/17/23, 5:37 PM

sqrt

K

Kai•10/17/23, 5:37 PM

how is that not well defined on integers?

K

Kai•10/17/23, 5:37 PM

sqrt(4) = 2?

A

Aqua•10/17/23, 5:37 PM

the square root of 2 is like 1.4whatever

AAqua <https://github.com/piegfx/Warp/tree/main/src/Warp.Math> here's my current gener...

P

PerkseyOP•10/17/23, 5:37 PM

this is a bad suggestion, we can't have silk contributors looking at this due to the license. they'd become radioactive and we won't be able to take any of their contributions for legal reasons.

A

Aqua•10/17/23, 5:37 PM

it only works for some integers

PPerksey this is a bad suggestion, we can't have silk contributors looking at this due to...

A

Aqua•10/17/23, 5:38 PM

while this code is technically gpl license its so generic (haha im unfunny) that i don't care if it gets copied verbatim

A

Aqua•10/17/23, 5:38 PM

given that i just copied stuff from other people anyway

K

khitiara•10/17/23, 5:38 PM

and choosing a floating type to coerce to for sqrt-ing ints is always a choice being made

A

Aqua•10/17/23, 5:38 PM

(system.numerics mainly)

P

PerkseyOP•10/17/23, 5:38 PM

that's irrelevant, we have to respect the license. DNF can't accept that liability.

was more the libsilk side of things

Similar Threads

Similar Threads

Similar Threads