technically you don't even have to write the type specs which is something i'm abusing in the SilkTo

technically you don't even have to write the type specs which is something i'm abusing in the SilkTouchX proposal to leave things open for the team to change

KKai TFloat = sbyte?

Maxine•10/21/23, 8:55 PM

that would be a not very useful length method

Maxine•10/21/23, 8:55 PM

does sbyte implement IRootFunctions

Maxine•10/21/23, 8:55 PM

if not, not possible

Kai•10/21/23, 8:56 PM

Fair, Length squared is totally possible though?

PPerksey technically you don't even have to write the type specs which is something i'm a...

Maxine•10/21/23, 8:56 PM

i wrote them because you asked!

KKai Fair, Length squared is totally possible though?

Maxine•10/21/23, 8:56 PM

lengthsquared is not constrained

Kai•10/21/23, 8:56 PM

Yes it'll likely overflow and isn't super common, but eh

Maxine•10/21/23, 8:56 PM

it's just INumber

PerkseyOP•10/21/23, 8:56 PM

oh yeah, and for maths we definitely want them

PerkseyOP•10/21/23, 8:56 PM

but you don't need to do one for every type

PerkseyOP•10/21/23, 8:56 PM

like for a typespec for Vector4 you can do

// everything from vector3, as well as:
// everything from vector3, except:

// everything from vector3, as well as:
// everything from vector3, except:

PerkseyOP•10/21/23, 8:57 PM

as long as your intent is clear, it can be approved

Maxine•10/21/23, 8:57 PM

so yes you can do LengthSquared<sbyte>

PPerksey this stance does fundamentally change the proposal, and as much as i have agreed...

Kai•10/21/23, 8:57 PM

Don't want to bother you about it given I haven't read the proposal but then I don't understand what perksey is saying here

KKai Don't want to bother you about it given I haven't read the proposal but then I d...

Maxine•10/21/23, 8:57 PM

me neither

MMaxine so yes you can do LengthSquared<sbyte>

Maxine•10/21/23, 8:57 PM

you monster /j

khitiara•10/21/23, 8:57 PM

@shrimpcat in the utf8 formatting bit, why not also check the output from the .Append bits to return early? unless im misremembering those method's return values

Kkhitiara @shrimpcat in the utf8 formatting bit, why not also check the output from the .A...

Maxine•10/21/23, 8:57 PM

they return false

Maxine•10/21/23, 8:57 PM

tahts why the &&

khitiara•10/21/23, 8:58 PM

yeah but why discarding the whole is i guess my question

khitiara•10/21/23, 8:58 PM

im probably just being slow to process this whole setup though

Maxine•10/21/23, 8:58 PM

because you can't have a bunch of && as a statement

PerkseyOP•10/21/23, 8:58 PM

if we can implement something in terms of the generic maths interfaces without implementing the functions exposed by any of the generic maths interfaces ourselves (a la Scalar.BaseOps) then i'm happy with it being in Silk.NET.Maths

Maxine•10/21/23, 8:58 PM

and Utf8.TryWrite checks itself

Maxine•10/21/23, 8:58 PM

if i added a check there, it would be a duplicate

Maxine•10/21/23, 8:58 PM

PPerksey if we can implement something in terms of the generic maths interfaces without i...

Maxine•10/21/23, 8:59 PM

this is definitely going way over my head

PerkseyOP•10/21/23, 8:59 PM

that's about as clear as i can make it

MMaxine if i added a check there, it would be a duplicate

khitiara•10/21/23, 9:00 PM

ah ok cool

Maxine•10/21/23, 9:00 PM

kai if you understand what he means, please explain it to me in baby words

MMaxine so yes you can do LengthSquared<sbyte>

Kai•10/21/23, 9:00 PM

static T LengthSquared<T>(this Vector3<T> vec) where T : INumber<T>, IFloatingPoint<T>;
???

KKai static T LengthSquared<T>(this Vector3<T> vec) where T : INumber<T>, IFloatingPo...

Maxine•10/21/23, 9:00 PM

there is more than one of those!

Maxine•10/21/23, 9:01 PM

check Vector3<T>

Maxine•10/21/23, 9:01 PM

public readonly TReturn LengthSquared<TReturn>() where TReturn : INumber<TReturn>public readonly TReturn LengthSquared<TReturn>() where TReturn : INumber<TReturn>

khitiara•10/21/23, 9:01 PM

yeah

Maxine•10/21/23, 9:01 PM

this is an instance method (but it can be an extension method)

khitiara•10/21/23, 9:01 PM

its a shortcut where TReturn and T are the same

MMaxine this is definitely going way over my head

PerkseyOP•10/21/23, 9:02 PM

basically if ever we find ourselves constrained by the generic maths constraints, then we probably shouldn't be working to allow whatever you're trying to do

Maxine•10/21/23, 9:02 PM

hm.

Maxine•10/21/23, 9:02 PM

what is that comment about, though?

Kai•10/21/23, 9:03 PM

I don't really get why there's two?
Why is the one without a return arg restricted to floating point? Seems like extra typing for user for nothing?

KKai I don't really get why there's two? Why is the one without a return arg restrict...

Maxine•10/21/23, 9:03 PM

because there is no use of calling Length<T> if the result is not a decimal

khitiara•10/21/23, 9:04 PM

the one without a result is a shortcut if T is already floating

khitiara•10/21/23, 9:04 PM

and you just want to use that

Maxine•10/21/23, 9:04 PM

and because there is no square root for integers

MMaxine what is that comment about, though?

PerkseyOP•10/21/23, 9:04 PM

basically no rules were defined for generic maths when Silk.NET.Maths when it was created, and we made no attempt to define them, instead allowing everything in the absence of rules set by an ecosystem authority (a la .NET API Review).
this led to us defining our own Add, Subtract, etc in Scalar.BaseOps, and implementing every algorithm under the sun in terms of those fully generalised BaseOps regardless of whether its correct, makes sense, or would yield the correct results for a given type.

Kai•10/21/23, 9:04 PM

On length I understand the roots interface, but on that and on square I don't get the floating point arg

khitiara•10/21/23, 9:04 PM

the one with a result could be like Vector3<int>.Length<float>()Vector3<int>.Length<float>()

khitiara•10/21/23, 9:04 PM

oh yeah the static lengthsquared has the float bit

khitiara•10/21/23, 9:04 PM

idk why

technically you don't even have to write the type specs which is something i'm abusing in the SilkTo

Similar Threads