Fair, Length squared is totally possible though?
Fair, Length squared is totally possible though?
Mi wrote them because you asked!
Mlengthsquared is not constrained
KYes it'll likely overflow and isn't super common, but eh
Mit's just INumber
Poh yeah, and for maths we definitely want them
Pbut you don't need to do one for every type
Plike for a typespec for Vector4 you can do
Pas long as your intent is clear, it can be approved
Mso yes you can do LengthSquared<sbyte>
KDon't want to bother you about it given I haven't read the proposal but then I don't understand what perksey is saying here
Mme neither
Myou monster /j
K@shrimpcat in the utf8 formatting bit, why not also check the output from the .Append bits to return early? unless im misremembering those method's return values
Mthey return false
Mtahts why the &&
Kyeah but why discarding the whole is i guess my question
Kim probably just being slow to process this whole setup though
Mbecause you can't have a bunch of && as a statement
Pif we can implement something in terms of the generic maths interfaces without implementing the functions exposed by any of the generic maths interfaces ourselves (a la Scalar.BaseOps) then i'm happy with it being in Silk.NET.Maths
Mand Utf8.TryWrite checks itself
Mif i added a check there, it would be a duplicate
M
Mthis is definitely going way over my head
Pthat's about as clear as i can make it
Kah ok cool
Mkai if you understand what he means, please explain it to me in baby words
Kstatic T LengthSquared<T>(this Vector3<T> vec) where T : INumber<T>, IFloatingPoint<T>;
???
???
Mthere is more than one of those!
Mcheck Vector3<T>
Mpublic readonly TReturn LengthSquared<TReturn>() where TReturn : INumber<TReturn>yeah
Mthis is an instance method (but it can be an extension method)
Kits a shortcut where TReturn and T are the same
Pbasically if ever we find ourselves constrained by the generic maths constraints, then we probably shouldn't be working to allow whatever you're trying to do
Mhm.
Mwhat is that comment about, though?
KI don't really get why there's two?
Why is the one without a return arg restricted to floating point? Seems like extra typing for user for nothing?
Why is the one without a return arg restricted to floating point? Seems like extra typing for user for nothing?
Mbecause there is no use of calling Length<T> if the result is not a decimal
Kthe one without a result is a shortcut if T is already floating
Kand you just want to use that
Mand because there is no square root for integers
Pbasically no rules were defined for generic maths when Silk.NET.Maths when it was created, and we made no attempt to define them, instead allowing everything in the absence of rules set by an ecosystem authority (a la .NET API Review).
this led to us defining our own Add, Subtract, etc in Scalar.BaseOps, and implementing every algorithm under the sun in terms of those fully generalised BaseOps regardless of whether its correct, makes sense, or would yield the correct results for a given type.
this led to us defining our own Add, Subtract, etc in Scalar.BaseOps, and implementing every algorithm under the sun in terms of those fully generalised BaseOps regardless of whether its correct, makes sense, or would yield the correct results for a given type.
KOn length I understand the roots interface, but on that and on square I don't get the floating point arg
Kthe one with a result could be like
Vector3<int>.Length<float>()oh yeah the static lengthsquared has the float bit
Kidk why
Kmight be a mistake
Malright
so are you for or against Vector3<int>?
so are you for or against Vector3<int>?
Pi am against not looking at it at an individual operation level
KLike imo we need a really good argument for restricting T beyond what's required for the implementation
