Hey lovely CF people.. I am having a proper challenge building the Open Telemetry library and auto-i

Hey lovely CF people.. I am having a proper challenge building the Open Telemetry library and auto-instrumenting it, because you are implementing exactly the same interface as say a service binding (a

fetch

fetch

method), but at least in your documentation you instruct people to invoke that in a way that is not spec compliant.

This leads to two problems:
1) I can't (easily) distinguish between a ServiceBinding and a BrowserRendering Binding
2) When I try to create a

Request

Request

out of the parameters you specify (

/v1/acquire

/v1/acquire

) it (obviously) fails because

/v1/acquire

/v1/acquire

is not a valid URL.

Now #2 can probably be easily solved by passing in a proper URL, but that would just prevent things from crashing.

Technically I could solve #1 by instrumenting any

fetch

fetch

function with a generic wrapper and then decide which instrumentation implementation to use based on the parameters passed into the

fetch

fetch

function, but that would be pretty brittle, because I would have to hardcode exactly what you would pass into the first request.

EErwin Hey lovely CF people.. I am having a proper challenge building the Open Telemetr...

ItsWendell•10/24/23, 7:25 AM

It's probably ideal to auto instrument any browser binding, regardless of clients used, but out of interest, have you tried auto-intstrumenting

@cloudflare/puppeteer

@cloudflare/puppeteer

IItsWendell It's probably ideal to auto instrument any browser binding, regardless of client...

ErwinOP•10/24/23, 7:55 AM

The puppeteer library can easily add support for instrumentation by just using the OTel API functions. That will be picked up by this library and be automatically added.

ErwinOP•10/24/23, 7:56 AM

And I can write the code for the instrumenting of the binding, but I would love a proper way to identify what binding am looking at when I enumerate “Env”

Kuririn•10/24/23, 10:50 AM

is there a way to see my current usage of browser rendering api?

Original message was deleted

ErwinOP•10/24/23, 10:53 AM

Oh I knew that, but I wasn’t planning on adding that myself..

But I just forked the repository to see what it would take

Niek•10/24/23, 5:55 PM

i would also love to get access to browser rendering beta:

3e38dc7049f501248503b981bf442450

3e38dc7049f501248503b981bf442450

NNiek i would also love to get access to browser rendering beta: `3e38dc7049f501248503...

zegevlier•10/24/23, 8:47 PM

Put the ID in here: browser-rendering-apiBrowser Rendering API Beta Access

Original message was deleted

ErwinOP•10/25/23, 1:01 AM

I just took a look at adding instrumentation to the

@cloudflare/puppeteer

@cloudflare/puppeteer

package, I realised that while adding the spans is going to be very straightforward, it would be quite a bunch of work figuring out what to instrument. So if someone else wants to do that, I would be more than happy to help that. But I am going to focus on the core library in the copious spare time that I have

charl.dev•10/26/23, 9:51 AM

on our ent account, im getting

workers.api.error.no_access_to_browser_worker

workers.api.error.no_access_to_browser_worker

, do we need to enable it?

getting the error when trying to run

dev

dev

deploy

deploy

. Role is worker admin. Can dm the acc id

730283•10/26/23, 9:57 AM

Can develop do something

Ccharl.dev on our ent account, im getting `workers.api.error.no_access_to_browser_worker`, ...

charl.dev•10/26/23, 10:03 AM

dm'd the PO the be added

zegevlier•10/26/23, 10:07 AM

It's not enabled by default for any accounts currently. I assume your contact at CF will be able to add it for you, but otherwise you can also put the account ID in here: browser-rendering-apiBrowser Rendering API Beta Access

charl.dev•10/26/23, 10:17 AM

thanks, dont want to post the account id publically, messaged vero

zegevlier•10/26/23, 10:18 AM

Alright. Just FYI: The account ID is considered safe to be public.

Zzegevlier Alright. Just FYI: The account ID is considered safe to be public.

charl.dev•10/27/23, 7:14 AM

okta was considered safe

Ccharl.dev okta was considered safe 🙂

Hello, I’m Allie!•10/27/23, 7:29 AM

I mean, yes, your account ID can be used to in an attack. But, to perform said attack, the attacker needs access to your account. If they have access to your account, they can find your account ID anyway

Hello, I’m Allie!•10/27/23, 7:29 AM

It's like a Discord User ID. Here's mine:

459755459117711362

459755459117711362

. It can be used in a attack, but it is by no means what determines whether you are vulnerable or not

Hello, I’m Allie!•10/27/23, 7:30 AM

Same thing with your domain

charl.dev•10/27/23, 7:31 AM

Its more around our audit guys, I'm just playing with the okta thing.

I trust cf over any provider

I have browser rendering on my personal account, so can build on that till its enabled on the ent acc

Avocadio•10/28/23, 2:55 PM

hey, in this code it returns empty json

Avocadio•10/28/23, 2:55 PM

but i just want to get the inner text of selector's

Avocadio•10/28/23, 2:55 PM

can you guys help

Avocadio•10/28/23, 10:25 PM

i got this. in case anyone wonders visit my repo :https://github.com/cahmetcan/iuc-yemekhane-scrape

GitHub

GitHub - cahmetcan/iuc-yemekhane-scrape: Scraping Food List of Ista...

Scraping Food List of Istanbul University for goodwill - GitHub - cahmetcan/iuc-yemekhane-scrape: Scraping Food List of Istanbul University for goodwill

windymelt•10/30/23, 1:06 PM

I used this feature to generate OG:Image generation. My server serves html, then worker renders.

Wwindymelt I used this feature to generate OG:Image generation. My server serves html, then...

Tom•10/31/23, 1:49 PM

Check out https://github.com/vercel/satori#documentation

it's probably faster than spinning up a whole browser to render an image

GitHub

GitHub - vercel/satori: Enlightened library to convert HTML and CSS...

Enlightened library to convert HTML and CSS to SVG - GitHub - vercel/satori: Enlightened library to convert HTML and CSS to SVG

jason•11/3/23, 9:30 PM

Hello. I'm taking a screenshot of websites with the

screenshot()

screenshot()

method, and even with

fullPage: false

fullPage: false

i'm getting the full site instead of just the view port. When I also pass

captureBeyondViewport: false

captureBeyondViewport: false

i am getting only the viewport, however, I also get the scrollbar - which I don't want. Is there a reason I'm getting the full page even when setting it to false. I'm manaully setting the viewport as well.

Andy•11/7/23, 1:54 AM

Hello people!

Andy•11/7/23, 1:55 AM

I was told I can request for the beta access over here!

Andy•11/7/23, 1:56 AM

Can I get access for this Account ID: 6413bfbe023fbf879350a20fe7a2245b?

AAndy Hello people!

Chaika•11/7/23, 2:46 AM

Put your ID in the thread for access here: Browser Rendering API Beta Access (can also be found via pins)

CChaika 👋 Put your ID in the thread for access here: https://discord.com/channels/5953...

Andy•11/7/23, 3:20 AM

alright!

jason•11/7/23, 2:39 PM

Hello, I'm trying to understand the proposed pricing structure and how to optimize it. Based on the proposed pricing in this blog post[1], you get 500 sessions per month for free and then 10 cents per session after that. A session, as I understand it, is an active running browser. The naive approach, at any sort of scale, quickly becomes expensive. So the blog says to use a durable object to keep the browser alive and re-use the existing session instead of starting a new one. The example code uses an alarm to keep the browser alive while idle for 1 minute before shutting it down. Using this structure, If I'm understanding it right. Worst case scenario, if I had a job that triggered every 61 seconds, I'd end up starting about 1440 sessions per day. Which is $144/day or over $4k/mon. That's expensive. So, the solution would be the extend the life of the durable object to, say 2 minutes, which would reduce the $4k to $0, for the browser cost.

However, the durable objects aren't free, but I'm having a much harder time understanding how expensive they will be. For example, why do I need to shut down the browser at all? How much does it cost for the browser to sit idle in a Durable Object? Is that documented anywhere? And what if it's not idle? If my worker is handling 1 request per sec, so the browser is in active use all of the time, what sort of costs is that going to yield for the DO?

Any information would be appericiated.

[1] https://blog.cloudflare.com/running-serverless-puppeteer-workers-durable-objects/

Jjason Hello, I'm trying to understand the proposed pricing structure and how to optimi...

Mackenly•11/7/23, 4:28 PM

It costs about $4 to keep a DO alive an entrie month but I'm not sure if that's somehow against terms for browser rendering or if there's unintended consequences.
browser-rendering-api

As far as understanding the pricing I've got no clue and there hasn't been any real clarification on that. Not a single use case makes sense to pay $4000 per month for a single browser instance. You could hire a human for that.

MMackenly It costs about $4 to keep a DO alive an entrie month but I'm not sure if that's...

jason•11/7/23, 4:33 PM

Thanks for the reference to those previous messages. I'm glad that I'm not the only one who is confused by all of this.

jason•11/7/23, 4:34 PM

Some people were mentioning that having one session open, means one request at a time, but that's not true. You can use

newPage()

newPage()

to use the same browser to process request async - but there's got to be some limit to that. I can't imagine one browser would do 100s of request simulateously. But again, those limits don't seem documented either.

MMackenly It costs about $4 to keep a DO alive an entrie month but I'm not sure if that's...

Unsmart•11/7/23, 4:42 PM

Seeing as the blog post about browser rendering showed how to keep sessions alive with a durable object I would find it highly unlikely to be against TOS LUL

UUnsmart Seeing as the blog post about browser rendering showed how to keep sessions aliv...

jason•11/7/23, 4:56 PM

The question is whether keeping the browser open indefinitely is against the TOS. The blog shows how to shut it down with an alarm after a certain amout of time.

Unsmart•11/7/23, 4:57 PM

If you dont do a request to the session in 60 seconds it shuts down thats why they destroyed it after 60 seconds so you dont get billed for the DO being alive if the session isnt even active anymore

Unsmart•11/7/23, 4:58 PM

If you do a call every 60 seconds their example would live forever

UUnsmart If you dont do a request to the session in 60 seconds it shuts down thats why th...

jason•11/7/23, 5:10 PM

Where is it documented that the session shuts down automatically after 60 seconds?

Jjason Where is it documented that the session shuts down automatically after 60 second...

Unsmart•11/7/23, 5:11 PM

https://developers.cloudflare.com/browser-rendering/platform/limits/#limits

A browser instance gets killed if it does not get any command for 60 seconds, freeing one instance.

Limits · Browser Rendering docs

The Workers Browser Rendering API is currently in beta. Add yourself to the waitlist to reserve your spot, and as we expand availability, we will …

jason•11/7/23, 5:12 PM

@Unsmart | Tech debt Ah, okay. That's not good at all then.

jason•11/7/23, 5:12 PM

So if you have, in my example a service that gets a request every minute in a half, you'll have to start a new session for each request.

jason•11/7/23, 5:13 PM

Which will end up with a $4k bill each month.

jason•11/7/23, 5:13 PM

You'd want to add a heartbeat request every <60s in order to keep the browser alive to avoid starting new ones. Crazy.

Jjason You'd want to add a heartbeat request every <60s in order to keep the browser al...

Mackenly•11/7/23, 7:18 PM

Yep. The problem isn't keeping it alive for a minute but if it's okay to keep it alive for forever. And if so why is that the best practice, seems hacky.

It doesn't make sense that CF needs to charge $0.10 to spin up/spin down a browser rendering instance for 60 seconds but will let you keep it up all month for $0.10 as long as you interact with it once every 60 seconds. The economics just don't make sense.

MMackenly Yep. The problem isn't keeping it alive for a minute but if it's okay to keep it...

jason•11/7/23, 7:25 PM

Agreed. Unless it's basically free for them to have it sit idle... but if that's the case, why automatically turn them off after 1 minute?

Jjason Agreed. Unless it's basically free for them to have it sit idle... but if that's...

Mackenly•11/7/23, 7:26 PM

Yeah or just make the session pricing low enough so that it makes sense to spin up/spin down as needed rather than relying on hacks to avoid a $4k bill.

jason•11/7/23, 7:32 PM

Do CF devs monitor this channel? Or is it only community members speculating?

andrew•11/8/23, 1:56 AM

It's a very puzzling situation. I'm basically waiting until it's sorted out before I implement anything with the Browser Rendering API

Hey lovely CF people.. I am having a proper challenge building the Open Telemetry library and auto-i

Similar Threads

Similar Threads

Similar Threads