Greetings and salutations. I have a question about moving a Workers project in TypeScript over to Fu

Greetings and salutations. I have a question about moving a Workers project in TypeScript over to Functions using advanced mode (with a _worker.js). I've written my application in the module syntax (as the docs instructed), but when I compile my TypeScript into _worker.js with tsc, in the output directory (which should be /build, as far as I can tell), the Pages project fails to deploy. I've tried using different options for "module" in the tsconfig.json as well, such as "amd" and "system", because "esnext" doesn't let me use the "outFile" option.

My question is: does all the code for a Function need to be compiled into a single _worker.js, or can each TypeScript file be compiled separately, and then the _worker.js will know to import from the other JavaScript files? Or would it be better to just give up on trying to migrate the Worker, and rebuild the application in the /functions folder instead?

PPoot Greetings and salutations. I have a question about moving a Workers project in T...

Hello, I’m Allie!•11/13/23, 12:02 PM

You can have a _worker.js_worker.js that just reexports your Worker. wranglerwrangler should autobundle for you anyway

Hello, I’m Allie!•11/13/23, 12:02 PM

You don't need to run tsctsc at all

PootOP•11/13/23, 12:07 PM

Thank you for answering. So it would be as simple as copying over the /src folder and just adding a _worker.js with some minimal code that somehow exposes the Worker?
I'm not sure where I can find these steps in the docs, but the article about Advanced Mode said to compile all the TypeScript into a _worker.js, so I'm a little confused.

PPoot Thank you for answering. So it would be as simple as copying over the /src folde...

Hello, I’m Allie!•11/13/23, 12:18 PM

They added support a little while ago for _worker.js_worker.js bundling, so you could keep the same structure, and just have _worker.js_worker.js be

import worker from "../src";
export default worker;

import worker from "../src";
export default worker;

PootOP•11/13/23, 12:41 PM

Oh, wow. Thank you! Going to give this a try.

Panda•11/14/23, 12:35 AM

@Isaac McFadyen | YYZ01 basically I just want the worker to check if the user is allowed to be on the site or not

Panda•11/14/23, 12:36 AM

if yes, allow them to load into it, if not, don't

Panda•11/14/23, 12:36 AM

the reason I want to do it with workers is because I don't want any site data/load to be sent before the user is verified

PPanda the reason I want to do it with workers is because I don't want any site data/lo...

Isaac McFadyen•11/14/23, 12:36 AM

What do you mean by sent?

Isaac McFadyen•11/14/23, 12:37 AM

Oh, as in, you want it to immediately block them without serving an HTML page?

Panda•11/14/23, 12:37 AM

yes

Isaac McFadyen•11/14/23, 12:37 AM

You should use SvelteKit middleware in this case, not _worker.js. SvelteKit already uses a _worker.js so you can't add your own.

Isaac McFadyen•11/14/23, 12:37 AM

Sorry, SvelteKit calls it Hooks not Middleware

Isaac McFadyen•11/14/23, 12:37 AM

You want the handlehandle hook: https://kit.svelte.dev/docs/hooks#server-hooks-handle

Panda•11/14/23, 12:38 AM

Oh. But I mostly wanted to make it using a worker since I want to use this in other projects as well, guess this will work though

Isaac McFadyen•11/14/23, 12:38 AM

Basically, check their auth (cookie or header or whatever) and if it's invalid just don't call resolveresolve, return an error instead.

alex (he/him)•11/14/23, 4:24 PM

Would love to get some insights here: https://canary.discord.com/channels/595317990191398933/1174021841023664288
I'm currently trying to fix _routes.json_routes.json generation in Astro's cloudflare adapter

David Charles•11/15/23, 8:04 AM

I have question need your help: How to run local for pages project (example run react app and have function in it)

David Charles•11/15/23, 8:05 AM

When I deploy by command npm run pages: deploy, it work well,

David Charles•11/15/23, 8:06 AM

But still not run app in locally

Bbillybidley Does pages support scheduled functions?

Hello, I’m Allie!•11/15/23, 9:02 PM

zegevlier•11/15/23, 10:12 PM

I would be very surprised if it isn't planned. This is an often-requested feature. It seems like there are just other features that are prioritised over it

zegevlier•11/15/23, 10:13 PM

You can always deploy a worker with a cron trigger or use DO alarms.

Zzegevlier I would be very surprised if it isn't planned. This is an often-requested featur...

Hello, I’m Allie!•11/15/23, 10:41 PM

I’m guessing this is a why bother, it will work in convergence situation

Dfodor•11/16/23, 7:32 AM

So, is there a good way to prevent CSRF attacks on pages with forms? I figured that I could have javascript request a form from a worker after the webpage has been loaded, but I'm uncertain that would work.

Jeroen•11/16/23, 9:21 PM

Does the workers-rs library also work for Pages Functions?

kian•11/17/23, 12:40 AM

It'd probably work with https://developers.cloudflare.com/pages/platform/functions/advanced-mode/

Kkian It'd probably work with <https://developers.cloudflare.com/pages/platform/functi...

Jeroen•11/17/23, 4:01 AM

I would have to put the build step in the dashboard then? Can it do a cargo build?

Kkian It'd probably work with <https://developers.cloudflare.com/pages/platform/functi...

Jeroen•11/19/23, 3:06 PM

I looked into this, but I do not think this will work. The wasm-pack wrapper is hard-coded to always put the worker in the /build/worker/shim.mjs/build/worker/shim.mjs file, instead of the expected /functions/_worker.js/functions/_worker.js.

kian•11/19/23, 3:07 PM

I’d probably just && mv&& mv it in my build command

Jeroen•11/19/23, 3:09 PM

Unlucky me, I thought I had tried everything. I need to know whether this'll do it now.

Kkian I’d probably just `&& mv` it in my build command

Jeroen•11/19/23, 3:20 PM

Ah, I found the issue. This doesn't work with wrangler2 pages devwrangler2 pages dev

JJeroen Ah, I found the issue. This doesn't work with `wrangler2 pages dev`

Hello, I’m Allie!•11/19/23, 3:23 PM

You could import shim from _worker.js

Jeroen•11/19/23, 3:23 PM

These are all great ideas, I am experimenting

Jeroen•11/19/23, 3:48 PM

I am getting the wildest behaviour. I right now have the following build command:

command = "( cd backend && cargo install -q worker-build && worker-build --release ) && ( cd frontend && yarn run build )"

command = "( cd backend && cargo install -q worker-build && worker-build --release ) && ( cd frontend && yarn run build )"

When doing wrangler2 pages dev frontend/distwrangler2 pages dev frontend/dist, I get an error:

✘ [ERROR] Could not validate _routes.json at /home/jeroen/project/frontend/dist: Error: ENOENT: no such file or directory, open '/home/jeroen/project/frontend/dist/_routes.json'

However, this error occurs while yarn is still building the frontend, as in, it'll be in the middle of the build logs. Not sure what is going on there. I get a similar error from the worker:

✘ [ERROR] 1 error(s) and 0 warning(s) when compiling Worker.

▲ [WARNING] Failed to bundle _worker.js. Error: Build failed with 1 error:

../../.wrangler/tmp/bundle-sGxLQ0/middleware-insertion-facade.js:1:43: ERROR: Could not resolve
"/home/jeroen/project/frontend/dist/_worker.js"
at failureErrorWithLog
(/usr/lib/node_modules/wrangler/node_modules/esbuild/lib/main.js:1636:15)
at /usr/lib/node_modules/wrangler/node_modules/esbuild/lib/main.js:1048:25
at /usr/lib/node_modules/wrangler/node_modules/esbuild/lib/main.js:1512:9
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
errors: [
{
detail: undefined,
id: '',
location: [Object],
notes: [],
pluginName: '',
text: 'Could not resolve
"/home/jeroen/project/frontend/dist/_worker.js"'
}
],
warnings: []
}

Compiled Worker successfully

As you can see, despite CloudFlare alleging the worker doesn't exist, it compiles successfully and actually runs. All of this output is produced while the build command is still running.

Jeroen•11/19/23, 3:50 PM

Even more wildly, if I delete the frontend/distfrontend/dist directory, my worker will not work. It won't even be detected. So CloudFlare seems to insist my worker already exists before the build command is ran, and then compiles it while the build command runs.

Jeroen•11/19/23, 4:34 PM

I believe this is caused by some form of live-reloading that cannot be disabled. If I replace my build command with a sleep 60sleep 60, at no point does CloudFlare try to build the worker until the sleep is over. However, if I add a && sleep 60&& sleep 60 to my build command, cloudflare will try to build my worker before the sleep has even started.

Jeroen•11/19/23, 4:34 PM

Basically, cloudflare is trying to bundle my worker while it is being built, which causes errors

JJeroen I am getting the wildest behaviour. I right now have the following build command...

Hello, I’m Allie!•11/19/23, 4:35 PM

Is this in your wrangler.tomlwrangler.toml?

Jeroen•11/19/23, 4:35 PM

yep

Jeroen•11/19/23, 4:36 PM

basically the only way I can get it to work is:

Comment out command = in my wrangler.toml.
Run the command manually
Run wrangler pages dev frontend/dist

Jeroen•11/19/23, 4:37 PM

Any other way wrangler will try to bundle my worker and routes while the files are being produced still

JJeroen yep

Hello, I’m Allie!•11/19/23, 4:37 PM

That might be the issue. It is a bug that wranglerwrangler reads your config when using Pages

Jeroen•11/19/23, 4:38 PM

I see, I was under the impression it was intended behaviour so tried to get it to work nicely. That also explains why some values in the wrangler.toml are seemingly ignored such as the compatibility date

JJeroen I see, I was under the impression it was intended behaviour so tried to get it t...

Hello, I’m Allie!•11/19/23, 4:39 PM

IIRC it is because it shares a good bit of its code with wrangler devwrangler dev, so it unintentionally reads the config, even though it shouldn't

Greetings and salutations. I have a question about moving a Workers project in TypeScript over to Fu

Similar Threads

Similar Threads

Similar Threads